- 10 Dec, 2016 40 commits
-
-
sadrul authored
BUG=643746, 604369 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2555693005 Cr-Commit-Position: refs/heads/master@{#437771}
-
blink-w3c-test-autoroller authored
Using update-w3c-deps in Chromium a229e828. Build: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7824 TBR=qyearsley@chromium.org NOEXPORT=true Review-Url: https://codereview.chromium.org/2565143003 Cr-Commit-Position: refs/heads/master@{#437770}
-
jschuh authored
Removes a number of branches from the calculations. Also now exporting SafeUnsignedAbs as a public API. NOTRY=true Review-Url: https://codereview.chromium.org/2566733002 Cr-Commit-Position: refs/heads/master@{#437769}
-
peria authored
Now we have format_blink_cpp_source_code filter, and continuous new lines are merged. So we don't need such hacks to avoid duplicated empty lines. BUG=None Review-Url: https://codereview.chromium.org/2558383003 Cr-Commit-Position: refs/heads/master@{#437768}
-
fs authored
Spend some cycles examining the difference between the old and new local-to-border-box transforms, and only signal scale-factor changes if that part of the transform changed. This also means that we now detect changes scale that we previously didn't (like [1].) [1] paint/invalidation/svg/absolute-sized-content-with-resources.xhtml BUG=603956,664961 Review-Url: https://codereview.chromium.org/2559123003 Cr-Commit-Position: refs/heads/master@{#437767}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0a12a619..921d884f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2564173003 Cr-Commit-Position: refs/heads/master@{#437766}
-
olivierrobin authored
BUG=577659 Review-Url: https://codereview.chromium.org/2562643003 Cr-Commit-Position: refs/heads/master@{#437765}
-
primiano authored
Revert of Improve EAT_STREAM_PARAMETERS for Windows x86 (patchset #10 id:240001 of https://codereview.chromium.org/2559323007/ ) Reason for revert: Broke D*LOG on a bunch of bots building non-official builds. See https://codereview.chromium.org/2559323007/#msg60 and https://codereview.chromium.org/2559323007/#msg61 for more context. Original issue's description: > Improve EAT_STREAM_PARAMETERS for Windows x86 > > Dumps of check_example.exe > > Current: > > ?DoBlinkReleaseAssert@@YAX_N@Z: > 00404EDC: 55 push ebp > 00404EDD: 8B EC mov ebp,esp > 00404EDF: 80 7D 08 00 cmp byte ptr [ebp+8],0 > 00404EE3: 75 07 jne 00404EEC > 00404EE5: C6 05 00 00 00 00 mov byte ptr ds:[0],0 > 00 > 00404EEC: 5D pop ebp > 00404EED: C3 ret > ?DoCheck@@YAX_N@Z: > 00404EEE: 55 push ebp > 00404EEF: 8B EC mov ebp,esp > 00404EF1: 51 push ecx > 00404EF2: 83 65 FC 00 and dword ptr [ebp-4],0 > 00404EF6: 80 7D 08 00 cmp byte ptr [ebp+8],0 > 00404EFA: 75 07 jne 00404F03 > 00404EFC: C6 05 00 00 00 00 mov byte ptr ds:[0],0 > 00 > 00404F03: 8B E5 mov esp,ebp > 00404F05: 5D pop ebp > 00404F06: C3 ret > _main: > 00404F07: 55 push ebp > 00404F08: 8B EC mov ebp,esp > 00404F0A: 83 7D 08 02 cmp dword ptr [ebp+8],2 > 00404F0E: 53 push ebx > 00404F0F: 0F 9F C3 setg bl > 00404F12: 53 push ebx > 00404F13: E8 D6 FF FF FF call ?DoCheck@@YAX_N@Z > 00404F18: 53 push ebx > 00404F19: E8 BE FF FF FF call ?DoBlinkReleaseAssert@@YAX_N@Z > 00404F1E: 59 pop ecx > 00404F1F: 59 pop ecx > 00404F20: 33 C0 xor eax,eax > 00404F22: 5B pop ebx > 00404F23: 5D pop ebp > 00404F24: C3 ret > > > > After this CL: > > ?DoBlinkReleaseAssert@@YAX_N@Z: > 00404EAC: 55 push ebp > 00404EAD: 8B EC mov ebp,esp > 00404EAF: 80 7D 08 00 cmp byte ptr [ebp+8],0 > 00404EB3: 75 07 jne 00404EBC > 00404EB5: C6 05 00 00 00 00 mov byte ptr ds:[0],0 > 00 > 00404EBC: 5D pop ebp > 00404EBD: C3 ret > _main: > 00404EBE: 55 push ebp > 00404EBF: 8B EC mov ebp,esp > 00404EC1: 83 7D 08 02 cmp dword ptr [ebp+8],2 > 00404EC5: 53 push ebx > 00404EC6: 0F 9F C3 setg bl > 00404EC9: 53 push ebx > 00404ECA: E8 DD FF FF FF call ?DoBlinkReleaseAssert@@YAX_N@Z > 00404ECF: 53 push ebx > 00404ED0: E8 D7 FF FF FF call ?DoBlinkReleaseAssert@@YAX_N@Z > 00404ED5: 59 pop ecx > 00404ED6: 59 pop ecx > 00404ED7: 33 C0 xor eax,eax > 00404ED9: 5B pop ebx > 00404EDA: 5D pop ebp > 00404EDB: C3 ret > > > Amusingly, I was confused because I thought I was going crazy when > DoCheck wasn't showing up in the /disasm. But of course, it's because it > got COMDAT'd with the Blink one, as we want. :) > > R=primiano@chromium.org > BUG=672699 > > Review-Url: https://codereview.chromium.org/2559323007 TBR=dcheng@chromium.org,scottmg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=672699 Review-Url: https://codereview.chromium.org/2569583002 Cr-Commit-Position: refs/heads/master@{#437764}
-
scottmg authored
Dumps of check_example.exe Current: ?DoBlinkReleaseAssert@@YAX_N@Z: 00404EDC: 55 push ebp 00404EDD: 8B EC mov ebp,esp 00404EDF: 80 7D 08 00 cmp byte ptr [ebp+8],0 00404EE3: 75 07 jne 00404EEC 00404EE5: C6 05 00 00 00 00 mov byte ptr ds:[0],0 00 00404EEC: 5D pop ebp 00404EED: C3 ret ?DoCheck@@YAX_N@Z: 00404EEE: 55 push ebp 00404EEF: 8B EC mov ebp,esp 00404EF1: 51 push ecx 00404EF2: 83 65 FC 00 and dword ptr [ebp-4],0 00404EF6: 80 7D 08 00 cmp byte ptr [ebp+8],0 00404EFA: 75 07 jne 00404F03 00404EFC: C6 05 00 00 00 00 mov byte ptr ds:[0],0 00 00404F03: 8B E5 mov esp,ebp 00404F05: 5D pop ebp 00404F06: C3 ret _main: 00404F07: 55 push ebp 00404F08: 8B EC mov ebp,esp 00404F0A: 83 7D 08 02 cmp dword ptr [ebp+8],2 00404F0E: 53 push ebx 00404F0F: 0F 9F C3 setg bl 00404F12: 53 push ebx 00404F13: E8 D6 FF FF FF call ?DoCheck@@YAX_N@Z 00404F18: 53 push ebx 00404F19: E8 BE FF FF FF call ?DoBlinkReleaseAssert@@YAX_N@Z 00404F1E: 59 pop ecx 00404F1F: 59 pop ecx 00404F20: 33 C0 xor eax,eax 00404F22: 5B pop ebx 00404F23: 5D pop ebp 00404F24: C3 ret After this CL: ?DoBlinkReleaseAssert@@YAX_N@Z: 00404EAC: 55 push ebp 00404EAD: 8B EC mov ebp,esp 00404EAF: 80 7D 08 00 cmp byte ptr [ebp+8],0 00404EB3: 75 07 jne 00404EBC 00404EB5: C6 05 00 00 00 00 mov byte ptr ds:[0],0 00 00404EBC: 5D pop ebp 00404EBD: C3 ret _main: 00404EBE: 55 push ebp 00404EBF: 8B EC mov ebp,esp 00404EC1: 83 7D 08 02 cmp dword ptr [ebp+8],2 00404EC5: 53 push ebx 00404EC6: 0F 9F C3 setg bl 00404EC9: 53 push ebx 00404ECA: E8 DD FF FF FF call ?DoBlinkReleaseAssert@@YAX_N@Z 00404ECF: 53 push ebx 00404ED0: E8 D7 FF FF FF call ?DoBlinkReleaseAssert@@YAX_N@Z 00404ED5: 59 pop ecx 00404ED6: 59 pop ecx 00404ED7: 33 C0 xor eax,eax 00404ED9: 5B pop ebx 00404EDA: 5D pop ebp 00404EDB: C3 ret Amusingly, I was confused because I thought I was going crazy when DoCheck wasn't showing up in the /disasm. But of course, it's because it got COMDAT'd with the Blink one, as we want. :) R=primiano@chromium.org BUG=672699 Review-Url: https://codereview.chromium.org/2559323007 Cr-Commit-Position: refs/heads/master@{#437763} -
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#437762} -
lushnikov authored
This patch ensures that persistence binding is not established if working copy of network UISourceCode does not match with the working copy of filesystem UISourceCode. This validation is done proactively: whenever automapping reports a binding, we fetch contents of both network and filesystem UISourceCodes and compare them. For this to work fast, we do *not* validate the following types of bindings: - bindings of source map sources. These could be slow to fetch, and they don't break us in any way. - bindings of binary files (e.g. images). These are never going to be edited, and thus can't deal any harm. To sum up, we request contents only of those text resources which were already succesfully loaded by the website itself, which means they are of manageble size. However, to be on the safe side, this change is guarded by on-by-default experiment. BUG=649837 R=dgozman Review-Url: https://codereview.chromium.org/2542073002 Cr-Commit-Position: refs/heads/master@{#437761}
-
sadrul authored
Fixes WindowServerTest.OnWindowHierarchyChangedIncludesTransientParent(). BUG=none TBR=sky@ to fix tree. Review-Url: https://codereview.chromium.org/2558043008 Cr-Commit-Position: refs/heads/master@{#437760}
-
brettw authored
This build flag is always set for non-iOS platforms. The flag is not overridable in the build and we never test other settings of it. The policy code is stable and doesn't change. This patch removes the flag and replaces it with !ios conditionals. BUG=671706 Review-Url: https://codereview.chromium.org/2558043004 Cr-Commit-Position: refs/heads/master@{#437759}
-
thomasanderson authored
This is a simple src-side dependency required by https://codereview.webrtc.org/2563203002 BUG=668446 Review-Url: https://codereview.chromium.org/2565063002 Cr-Commit-Position: refs/heads/master@{#437758}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/1951f3ddbddc..2790c52e36dd $ git log 1951f3ddb..2790c52e3 --date=short --no-merges --format='%ad %ae %s' 2016-12-09 bsalomon Make *OpList::recordOp functions take sk_sp<GrOp> not GrOp* Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=herb@google.com Review-Url: https://codereview.chromium.org/2563243002 Cr-Commit-Position: refs/heads/master@{#437757}
-
chengx authored
JumpListIcons(Old) folders are getting unexpectively huge for some users. This may be caused by file operation failures. After analyzing those folders' problematic move operation metric by landing crrev.com/2522163003/, we find that it is necessary to dig into every major step in base::move() operation for better understanding the root cause. Added code to record more detailed JumpListIcons folder's move operation status to UMA. Will revert this CL after gathering user data for further analysis. BUG=179576 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Review-Url: https://codereview.chromium.org/2563483004 Cr-Commit-Position: refs/heads/master@{#437756}
-
rockot authored
Use ThreadTaskRunnerHandle instead of BrowserThread::GetTaskRunnerForThread. This avoids a data race in shutdown due to the fact that RendererScheduler (used on a BrowserThread in this test) tramples the MessageLoop's TaskRunner in a manner BrowserThreadImpl's TaskRunner facade does not anticipate. Also opportunistically corrects some non-const ref arguments in RenderThreadImpl. BUG=672812 Review-Url: https://codereview.chromium.org/2568543002 Cr-Commit-Position: refs/heads/master@{#437755}
-
sadrul authored
The gpu message-pump is no longer ncessary. It is not used in chrome-gpu either. BUG=671397 Review-Url: https://codereview.chromium.org/2560303002 Cr-Commit-Position: refs/heads/master@{#437754}
-
sadrul authored
Revert of Change exo::SurfaceFactoryOwner to exo::ExoCompositorFrameSink (patchset #54 id:1050001 of https://codereview.chromium.org/2493223002/ ) Reason for revert: Breaks test (DesktopMediaListAshTest.ScreenOnly) in chromeos-ozone builds. Original issue's description: > Moved exo::SurfaceFactoryOwner to its own file and renamed it to exo::CompositorFrameSink. > > CompositorFrameSink implements cc::mojom::MojoCompositorFrameSink. > > CompositorFrameSink is no longer a friend class of exo::Surface. > > Added exo::CompositorFrameSinkHolder class that implements cc::mojom::MojoCompositorFrameSinkClient. > > BUG=659601 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2493223002 TBR=reveman@chromium.org,fsamuel@chromium.org,jbauman@chromium.org,sky@chromium.org,staraz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=659601 Review-Url: https://codereview.chromium.org/2566813002 Cr-Commit-Position: refs/heads/master@{#437753}
-
rockot authored
Revert of Build services as standalone executables (patchset #14 id:260001 of https://codereview.chromium.org/2557213002/ ) Reason for revert: Lots of test failures - ICU data not being found in service processes. Original issue's description: > Build services as standalone executables > > Cleans up a bunch of service manager details which exist to support > the currently untenable goal of dynamically loading service binaries > in a common host executable. > > Changes services to instead build as standalone executables, and > teaches the service manager how to launch them. > > BUG=642879 > > Review-Url: https://codereview.chromium.org/2557213002 TBR=ben@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=642879 Review-Url: https://codereview.chromium.org/2566663004 Cr-Commit-Position: refs/heads/master@{#437752}
-
birenroy authored
Most of this changelist is just fixing up SpdyFramer constructor call sites and tests. This CL lands server change 141335728 by birenroy. BUG=488484 Review-Url: https://codereview.chromium.org/2566513004 Cr-Commit-Position: refs/heads/master@{#437751}
-
yhanada authored
This CL allows us to notify keyboard type changes to a client through zcr_keyboard_device_configuration_v1 interface. BUG=670247 Review-Url: https://codereview.chromium.org/2506263002 Cr-Commit-Position: refs/heads/master@{#437750}
-
lushnikov authored
BUG=612493 R=dgozman Review-Url: https://codereview.chromium.org/2569563002 Cr-Commit-Position: refs/heads/master@{#437749}
-
chrome-cron authored
Cr-Commit-Position: refs/heads/master@{#437748} -
sergeyu authored
Previously the frame scheduler was setting target bitrate whenever bandwidth estimate changes. VP8 encoder doesn't handle this very well: every time bitrate is update quality drops significanlty for the following frames. It happens because every time biutrate is updated the codec needs to be reconfigured, resulting in encoder state reset. Fixed it by adding a filter that calculates average BW estimate over last second and updates target bitrate only when the average BW estimate differs from the current target bitrate by more than 33%. Also fixed WebrtcConnectionToHost::Connect() to avoid crash when running perftests. Review-Url: https://codereview.chromium.org/2562893003 Cr-Commit-Position: refs/heads/master@{#437747}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/707aaac64b3c..19565fdb148a $ git log 707aaac64..19565fdb1 --date=short --no-merges --format='%ad %ae %s' 2016-12-09 nednguyen Revert of re-enabled netlog viewer dev server tests (patchset #2 id:20001 of https://codereview.chromium.org/2553213002/ ) 2016-12-09 charliea Roll battor_agent_bin to include new init retry logic BUG=672631 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2567543003 Cr-Commit-Position: refs/heads/master@{#437746}
-
alemate authored
This CL implements Timezone Selection screen for material design ChromeOS OOBE. BUG=604119 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2564563004 Cr-Commit-Position: refs/heads/master@{#437745}
-
qiankun.miao authored
If the extension isn't available, we cannot read from fbo attaching float texture attachment. This CL adds error message when the extension is not available. BUG=369849, 624436 Review-Url: https://codereview.chromium.org/2565703002 Cr-Commit-Position: refs/heads/master@{#437744}
-
jianli authored
BUG=672593 Review-Url: https://codereview.chromium.org/2560823005 Cr-Commit-Position: refs/heads/master@{#437743}
-
phulce authored
Reduces the number of layouts performed. Moves update to be run in a requestAnimationFrame callback. Cleans up the code a bit to move pieces of the massive update functions into their own methods for a clearer breakdown of where time is spent. BUG=657141 R=lushnikov,paulirish Review-Url: https://codereview.chromium.org/2551403002 Cr-Commit-Position: refs/heads/master@{#437742}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/0e8fc8b9e6a1..1951f3ddbddc $ git log 0e8fc8b9e..1951f3ddb --date=short --no-merges --format='%ad %ae %s' 2016-12-09 bsalomon Rename testingOnly_drawBatch to testingOnly_addDrawOp and sk_sp 2016-12-09 mtklein bicubic, attempt gazillion 2016-12-09 bsalomon Make GrRenderTargetOpList::addDrawOp use sk_sp 2016-12-09 bsalomon Fix comment formatting for GrRenderTargetContext::drawArc 2016-12-09 halcanary tools and docs: clean up gyp-specific things Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=herb@google.com Review-Url: https://codereview.chromium.org/2565433005 Cr-Commit-Position: refs/heads/master@{#437741}
-
scottchen authored
BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2561953003 Cr-Commit-Position: refs/heads/master@{#437740}
-
lukasza authored
BUG=666858 Review-Url: https://codereview.chromium.org/2549023003 Cr-Commit-Position: refs/heads/master@{#437739}
-
lushnikov authored
This patch migrates the "left thick blue" icon, which points to the inspected node, onto UI.Icon. As a result, the icon is now sharp on retina! This patch also introduces icon support for treeoutline: every TreeElement now has TreeElement.setTrailingIcons(icons) method. Users might call it to add icons after the treeelement's title. In future, a symmetrical method TreeElement.setLeadingIcons(icons) method, which will be used to migrate navigator icons over to the UI.Icon. BUG=669323 Review-Url: https://codereview.chromium.org/2564433004 Cr-Commit-Position: refs/heads/master@{#437738}
-
rockot authored
This corrects how the ServiceManager clears out identity mappings to singleton services, preventing it from indefinitely holding a raw Instance* to any singleton it starts. BUG=None Review-Url: https://codereview.chromium.org/2566663003 Cr-Commit-Position: refs/heads/master@{#437737}
-
pfeldman authored
Review-Url: https://codereview.chromium.org/2560353002 Cr-Commit-Position: refs/heads/master@{#437736}
-
wolenetz authored
All new tests repro prior to their fix, and no longer repro on trunk. Added 257c076e3e8866554529d495440b606e321d9e39 to internal repo. R=dalecurtis@chromium.org BUG=668346,640912,640889,639961,637428,635422 Review-Url: https://codereview.chromium.org/2569543002 Cr-Commit-Position: refs/heads/master@{#437735}
-
fayang authored
Merge internal change: 141451848 Review-Url: https://codereview.chromium.org/2561913003 Cr-Commit-Position: refs/heads/master@{#437734}
-
smut authored
BUG=661612 Review-Url: https://codereview.chromium.org/2550063003 Cr-Commit-Position: refs/heads/master@{#437733}
-
lawrencewu authored
The Breadcrumbs project dumps system state to a persistent file so that it can be analyzed after a crash. We want to include in that the complete set of field trials. That means saving them to the file when the browser starts and being able to retrieve them from the file on a future run; they will be loaded into a protobuf and uploaded. BUG=663414 Review-Url: https://codereview.chromium.org/2560723004 Cr-Commit-Position: refs/heads/master@{#437732}
-