GitLab

Starts refactoring the tracing specific code from MemoryDumpManager
into a new class MemoryTracingObserver. This shouldn't change the
behaviour of the MemoryDumpManager.

BUG=703184

Review-Url: https://codereview.chromium.org/2820433005
Cr-Commit-Position: refs/heads/master@{#466936}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/af28cbe9..deeaeb8f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2837163003
Cr-Commit-Position: refs/heads/master@{#466935}

In the case the block has relative height and width is auto and
it has an image which should keep the aspect ratio,
it needs preferred width recalculation if the parent changes the height.
To cover this, add NeedsPreferredWidthsRecalculation() for LayoutBlock.

BUG=707151, 514663, 709233

Review-Url: https://codereview.chromium.org/2828453002
Cr-Commit-Position: refs/heads/master@{#466934}

LayoutSelection::SelectionStartEnd(int& start_pos, int& end_pos);
=> std::pair<int, int> LayoutSelection::SelectionStartEnd();

TEST=No change in behavior.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2833343002
Cr-Commit-Position: refs/heads/master@{#466933}

Added recording of user actions for all context menu actions:
 - open context menu
 - open item in new tab
 - open item in new window
 - open item in an incognito tab
 - download item
 - remove item
 - undo removal of item

BUG=713145

Review-Url: https://codereview.chromium.org/2831113002
Cr-Commit-Position: refs/heads/master@{#466932}

This CL moves

 if (is_static_data)
   return kUse;

section down in DetermineRevalidationPolicy as a preparation to factor out some
|return kReload;| statements.

BUG=652228, 714574
R=hiroshige@chromium.org

Review-Url: https://codereview.chromium.org/2829043002
Cr-Commit-Position: refs/heads/master@{#466931}

Remove WEBKIT_KEYFRAMES_RULE and WEBKIT_KEYFRAME_RULE
from CSSRule interface.

Intent to Remove thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/mW1njtgDPHA

BUG=689681
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2795223002
Cr-Commit-Position: refs/heads/master@{#466930}

BUG=621756

Review-Url: https://codereview.chromium.org/2836263002
Cr-Commit-Position: refs/heads/master@{#466929}

The blocking pool is being deprecated in favor of TaskScheduler.

BUG=667892
R=droger@chromium.org

Review-Url: https://codereview.chromium.org/2843573002
Cr-Commit-Position: refs/heads/master@{#466928}

This fixes a regression since Google Chrome 58. New behavior is compatible with
WebKit and Edge. Firefox doesn't have 'type' attribute.

Implementation:
SelectionTemplate<T>::IsCaret() and IsRange() should take care of granularity.

BUG=712579

Review-Url: https://codereview.chromium.org/2835063002
Cr-Commit-Position: refs/heads/master@{#466927}

If sync has been disabled manually or by policy it was not resuming
in local sync mode afterwards because there is no external event to
trigger that.

BUG=707181
TEST=components_unittests

Review-Url: https://codereview.chromium.org/2810943007
Cr-Commit-Position: refs/heads/master@{#466926}

This patch marks |AbsoluteRectsForRange()| and |AbsoluteQuadsForRange()| in
|LayoutText| as const member function since these function don't modify
member variables and don't call non-const member functions.

This patch is a preparation of patch[1].

[1] http://crrev.com/2839633002: Introduce ComputeTextBounds template in Range.cpp

BUG=691198
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2837273002
Cr-Commit-Position: refs/heads/master@{#466925}

Review-Url: https://codereview.chromium.org/2835223003
Cr-Commit-Position: refs/heads/master@{#466924}

The new ComputedStyle::HasBorderColorReferencingCurrentColor() is also
useful for fixing crbug.com/713680.

BUG=713680

Review-Url: https://codereview.chromium.org/2836143003
Cr-Commit-Position: refs/heads/master@{#466923}

Allow a LocatedEvent to be passed to MenuButton, so the ink drop animation is centered on the click location.

The new constructor overload is used in https://codereview.chromium.org/2832823002/

BUG=635699

Review-Url: https://codereview.chromium.org/2831353002
Cr-Commit-Position: refs/heads/master@{#466922}

Destructing floating_control_button_widget_ eventually calls
UpdateControlButtonsVisibility so only create it there if |item_| is
non-null.

Add additional null checks to ShouldUpdateControlButtonsColor.

BUG=712773
BUG=714032

Review-Url: https://codereview.chromium.org/2834763003
Cr-Commit-Position: refs/heads/master@{#466921}

This CL flips use_once_callback flag in //content/common/BUILD.gn, and
fixes all compile failure after that. After this CL, mojo-generated code
starts using OnceCallback instead of Callback for asynchronous result handling.

BUG=554299
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2824193002
Cr-Commit-Position: refs/heads/master@{#466920}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/568edc40..af28cbe9

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2840523004
Cr-Commit-Position: refs/heads/master@{#466919}

The associated Skia roll is now in Chromium so this change can now be
enabled and rebaselined. The related Skia change is
https://skia.googlesource.com/skia.git/+/42a2a20b9114c904ce73d66d0105b81f19d93914

Change plus baselines, original CL and Skia change by Ben Wagner.

TBR'ing since change itself has been reviewed and baseline changes
have been discussed in:
https://skia-review.googlesource.com/c/13863#message-ceea26f848500376b2730668359ea3679778dbe3

BUG=chromium:713942
TBR=bungeman

Review-Url: https://codereview.chromium.org/2835393002
Cr-Commit-Position: refs/heads/master@{#466918}

Add options for controlling whether pre- and post-context should be used
and pack it together with the other bool/enum options to preserve space.

BUG=636993
R=kojii@chromium.org

Review-Url: https://codereview.chromium.org/2838823002
Cr-Commit-Position: refs/heads/master@{#466917}

This is not a pure refactor. Changes:

* SVG local to border box transforms are always present, not just if the
LocalToBorderBoxTransform+PaintOffset is non-identity.
* ObjectPaintProperty objects are cleared from the PaintRareData if not needed.

This is step 1 for SPv2 multicol.

BUG=648274
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2831683003
Cr-Commit-Position: refs/heads/master@{#466916}

This patch prunes the deprecated function from both overloads of
FrameSelection::Modify to improve code health.

BUG=698633
TEST=n/a; no behaviorial change

Review-Url: https://codereview.chromium.org/2829043004
Cr-Commit-Position: refs/heads/master@{#466915}

Calling ResetRepositionSession during UpdateNotificationSize can end up
deleting notification items. This caused two crashes. One in
AddNotification, which calls onItemUpdated, which, without this change,
can set item_ to null. The other is a crash in
ShouldUpdateControlButtonsColor which does not check if item_ is null
since it is called from a context where item_ should not be null.

BUG=714493
BUG=714032

Review-Url: https://codereview.chromium.org/2833403002
Cr-Commit-Position: refs/heads/master@{#466914}

|HostDescriptionNode.name| identifies the node and should not be shared by two
different nodes. If multiple nodes are passed to SerializeHostDescriptions with
the same name, currently SerializeHostDescriptions ends up using
DictionaryValue after performing std::move on it, because of mixing nodes with
the same name.

This CL replaces some internal use of std::vector with std::unordered_set to
discard duplicities.

The CL also improves the unit test to be less dependent on the resulting order
of the serialized descriptions.

The CL also fixes the test name to match its filename and the name of the tested
function.

BUG=714368

Review-Url: https://codereview.chromium.org/2835823002
Cr-Commit-Position: refs/heads/master@{#466913}

Also, use shorter timeout for SignalSenderVerificationTest.TestSignalRejected
which was disabled because of its slowness.

BUG=407063,643537
TEST=dbus_unittests

Review-Url: https://codereview.chromium.org/2837943004
Cr-Commit-Position: refs/heads/master@{#466912}

After recent changes, proxy_policy_handler.cc no longer needs to include
base/memory/ptr_util.h. This has been pointed in
https://codereview.chromium.org/2785883003/diff/80001/components/policy/core/browser/proxy_policy_handler.cc#newcode11.
Because that comment happened after landing of the original CL, that follow-up
is done here.

R=bartfab@chromium.org
BUG=697817

Review-Url: https://codereview.chromium.org/2793093003
Cr-Commit-Position: refs/heads/master@{#466911}

This patch postpones r462778[1] that enabled CSS line-height-step on
stable.

While we do not see web-compat risks, we heard that enabling on stable
gives a pressure to discussions, and that delaying can make it easier.

We expect this feature to grow only slowly. The previous similar feature
was at 0.007% UMA. I hope this property will be used more widely by East
Asians, but it will still take time to grow. Delaying by a few months
will not make much differences in the value of the feature.

[1] https://codereview.chromium.org/2797973005

BUG=714956

Review-Url: https://codereview.chromium.org/2833323002
Cr-Commit-Position: refs/heads/master@{#466910}

Reland of Introduce ModulePendingScript (patchset #1 id:1 of https://codereview.chromium.org/2816043005/ )

This CL doesn't change the behavior, because ModulePendingScript is not
used at this time.

Reason for revert:
Issue 711703 is fixed on
https://codereview.chromium.org/2653923008/.

Original issue's description:
> Revert of Introduce ModulePendingScript (patchset #6 id:100001 of https://codereview.chromium.org/2815453006/ )
>
> Reason for revert:
> Reason for revert:
> https://codereview.chromium.org/2653923008/ is
> suspected to cause CHECK() failure (crbug.com/711703)
> inside PendingScript's prefinalizer.
>
> BUG=711703
>
> Original issue's description:
> > Introduce ModulePendingScript
> >
> > BUG=594639
> >
> > Review-Url: https://codereview.chromium.org/2815453006
> > Cr-Commit-Position: refs/heads/master@{#464627}
> > Committed: https://chromium.googlesource.com/chromium/src/+/2e5a5b8efccf655f183cc7ce0c59a88f77bb50f5
>
> TBR=kouhei@chromium.org,yhirano@chromium.org,sigbjornf@opera.com,japhet@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=594639
>
> Review-Url: https://codereview.chromium.org/2816043005
> Cr-Commit-Position: refs/heads/master@{#464765}
> Committed: https://chromium.googlesource.com/chromium/src/+/80f482b929e1a00817069b15e78cc4473eb50c6f

TBR=kouhei@chromium.org,yhirano@chromium.org,sigbjornf@opera.com,japhet@chromium.org
BUG=594639, 711703

Review-Url: https://codereview.chromium.org/2820703003
Cr-Commit-Position: refs/heads/master@{#466909}

That's because marking LayoutObject::SelectionState doesn't affect hit test.

BUG=708453

Review-Url: https://codereview.chromium.org/2836843002
Cr-Commit-Position: refs/heads/master@{#466908}

The only changes are in comments.

BUG=704911
TBR=bmcquade@chromium.org

Review-Url: https://codereview.chromium.org/2782503004
Cr-Commit-Position: refs/heads/master@{#466907}

Reland of name PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://codereview.chromium.org/2822763002/ )

This CL doesn't change the behavior, because this is renaming only.

Reason for revert:
Issue 711703 is fixed on
https://codereview.chromium.org/2653923008/.

Original issue's description:
> Revert of Rename PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://codereview.chromium.org/2815163005/ )
>
> Reason for revert:
> https://codereview.chromium.org/2653923008/ is
> suspected to cause CHECK() failure (crbug.com/711703)
> inside PendingScript's prefinalizer.
>
> BUG=711703
>
> Original issue's description:
> > Rename PendingScript::Url() to UrlForClassicScript()
> >
> > Because it is/can be used only for classic scripts.
> >
> > BUG=686281
> >
> > Review-Url: https://codereview.chromium.org/2815163005
> > Cr-Commit-Position: refs/heads/master@{#464613}
> > Committed: https://chromium.googlesource.com/chromium/src/+/06fcf4b92be26a28fde65c743e6a0d40bbc53dc0
>
> TBR=kouhei@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=686281
>
> Review-Url: https://codereview.chromium.org/2822763002
> Cr-Commit-Position: refs/heads/master@{#464766}
> Committed: https://chromium.googlesource.com/chromium/src/+/476b2ca298bce5eae94e680ce84ef56c08e28a2e

TBR=kouhei@chromium.org
BUG=686281, 711703

Review-Url: https://codereview.chromium.org/2819043002
Cr-Commit-Position: refs/heads/master@{#466906}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/1a3548e..b5a7da7

$ git log 1a3548e..b5a7da7 --date=short --no-merges --format=%ad %ae %s
2017-04-24 zstein@webrtc.org Move ready to send logic from BaseChannel to RtpTransport.

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2843603003
Cr-Commit-Position: refs/heads/master@{#466905}

The new backend supporting dynamic instantiation on Windows was rolled
out to the stable channel via a field trial flag.
This new backend solves some long-living problems, e.g., grabbing
devices forever, battery concerns, and stability.

Since the feature was enabled by default, and have worked well,
I want to remove the old backend now.

Another change that renames new backend will follow.

BUG=672793

Review-Url: https://codereview.chromium.org/2841493003
Cr-Commit-Position: refs/heads/master@{#466904}

BUG=711703

Review-Url: https://codereview.chromium.org/2828973002
Cr-Commit-Position: refs/heads/master@{#466903}

This CL uses MockScriptElementBase instead of nullptr to create
ClassicPendingScript, in order to remove
ClassicPendingScript::CreateForTesting() and make |PendingScript::element_|
always non-null when used.

BUG=686281, 694702

Review-Url: https://codereview.chromium.org/2827163003
Cr-Commit-Position: refs/heads/master@{#466902}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/5592ae343004..b367d46487c3

$ git log 5592ae343..b367d4648 --date=short --no-merges --format='%ad %ae %s'
2017-04-24 kainino Mac: download numpy and cv2 from Cloud Storage
2017-04-24 kainino Mac/Linux: disable formerly-skipped tests that fail when numpy/cv2 exist
2017-04-24 kainino Delete stale dependency zips

Created with:
  roll-dep src/third_party/catapult
BUG=711307,711307,711307


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ic2e84060eba2d7507e32549da2b8565d4d7ad8a3
Reviewed-on: https://chromium-review.googlesource.com/486063
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#466901}

Process the output of 'ninja' live through the pipe rather than waiting
for it to finish.

Before:
20.74user 16.36system 0:24.57elapsed 151%CPU

After:
16.63user 9.24system 0:13.94elapsed 185%CPU

BUG=661774

Review-Url: https://codereview.chromium.org/2842513003
Cr-Commit-Position: refs/heads/master@{#466900}

This is preparation for introducing ModulePendingScript.

This CL shouldn't change the behavior.

This has been reverted due to crashing (Issue 711703) because
ResourceOwner's prefinalizer is called before PendingScript's prefinalizer,
causing CheckState() assertion failure.
This reland fixes this issue by registering PendingScript::Dispose() also
as the prefinalizer of ClassicPendingScript, which is called before
ResourceOwner's prefinalizer.

A unit test for the crash will be added by
https://codereview.chromium.org/2828973002/.

BUG=594639, 686281, 711703

Review-Url: https://codereview.chromium.org/2653923008
Cr-Original-Commit-Position: refs/heads/master@{#464494}
Committed: https://chromium.googlesource.com/chromium/src/+/d512803299c01324b92ffd8c962da97e3bc8ccff
Review-Url: https://codereview.chromium.org/2653923008
Cr-Commit-Position: refs/heads/master@{#466899}

This is required (and documented by a comment in the header file), so the DCHECKs are motivated.

BUG=711400
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2828233002
Cr-Commit-Position: refs/heads/master@{#466898}

BUG=714831

Review-Url: https://codereview.chromium.org/2838753003
Cr-Commit-Position: refs/heads/master@{#466897}