- 16 Apr, 2018 40 commits
-
-
Owen Min authored
Set the timestamp of last fetch time of MachineLevelUserCloudPolicy if it's enabled. Bug: 832907 Change-Id: I80084e82932479b7e2ee29474f069c685d96f063 Reviewed-on: https://chromium-review.googlesource.com/1013044Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Marc-André Decoste <mad@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550993}
-
Fabio Tirelo authored
This reverts commit c3991fe1. Reason for revert: Several tests became flaky on ChromeOS - crbug.com/c/833176 - crbug.com/c/833237 - crbug.com/c/833219 - crbug.com/c/833127 - crbug.com/c/833030 This is not the first time a test becomes flaky on ChromeOS for the same reason: it hangs while waiting in SendKeyToPopupAndWait(). Giving such an issue has been there for a long time, I think it may be time to investigate what's going on and trying to come up with an explanation. Original change's description: > [af] Run AutofillInteractiveTest with AutofillExpandedPopupViews enabled > > This parameterizes AutofillInteractiveTest and subclasses to run with > the feature either enabled or disabled. The goal is to help us > ensure it's to enable the feature for Canary/Dev. > > I'm investigating if there are other tests that should be affected by > the feature, and will update them in follow up CLs. > > Bug: 768881 > Change-Id: I13b0bf654374728749ce7c5b3829bc02ff386cd3 > Reviewed-on: https://chromium-review.googlesource.com/1005888 > Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550759} TBR=rogerm@chromium.org,estade@chromium.org,tmartino@chromium.org,ftirelo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 768881 Change-Id: I157dcf789abfa57ad924a24967ab3ed83e48145c Reviewed-on: https://chromium-review.googlesource.com/1014141Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#550992}
-
Emily Hanley authored
Bug: 779634 Change-Id: Iba3bed868177e7caa31714573c10eaae1a0571c1 Reviewed-on: https://chromium-review.googlesource.com/1012200Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#550991}
-
Charlie Harrison authored
Bug: 833419 Change-Id: I9b1d6f3b7b5c9229443b71f41d422d78be40ba8d Reviewed-on: https://chromium-review.googlesource.com/1014026Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#550990}
-
https://chromium.googlesource.com/angle/angle.git/+log/152152618edf..20fa8d5cfe9e $ git log 152152618..20fa8d5cf --date=short --no-merges --format='%ad %ae %s' 2018-04-15 jmadill Vulkan: Implement cube map texture sampling. 2018-04-12 jiawei.shao Store shader information in ShaderMap in class Program and Compiler 2018-03-19 oetuaho Store invariant declarations in variable metadata Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ided9c2c111013257fe41c34a7d74455f8c511a10 Reviewed-on: https://chromium-review.googlesource.com/1014007Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550989}
-
Sigurdur Asgeirsson authored
The GetHandle function of RenderProcessHost returned a base::ProcessHandle, which cannot be passed around to other threads because the caller does not have ownership. This lead to handle abuse problems on Windows if the RPH goes away as the handle is being bounced around. This CL replaces the GetHandle function of RPH with a GetProcess function, which returns a const base::Process&. This in turn allows callers to duplicate the underlying base::Process, and the duplicate can then be safely bounced around to other threads. Bug: 821453 Change-Id: I7d9956c3ab92352d99ccea70fde3f2013aa66d33 Reviewed-on: https://chromium-review.googlesource.com/998213 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#550988}
-
Rouslan Solomakhin authored
Before this patch, a payment handler page could be unsecure. This patch checks for the following conditions: - Unsecure origin. - Non-cryptographic scheme. - Invalid certificate. - Flagged in safe browsing database. If any of these conditions are hit, Chrome aborts payment by closing the payment handler page and showing an error message. After this patch, if a payment handler page is detected to be unsecure, Chrome closes the payment handler page and shows an error message. Bug: 828431 Change-Id: Ifdc5a3e3ebf9c511f21aa03dee2d8d3230ac8b88 Reviewed-on: https://chromium-review.googlesource.com/1012451Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#550987}
-
Finnur Thorarinsson authored
Bug: 734095 Change-Id: I3a7e869ca908e53436ff3e78f43f13af1dccedce Reviewed-on: https://chromium-review.googlesource.com/998032 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Xi Cheng <chengx@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#550986}
-
Friedrich Horschig authored
Please note that this move changes ownership of the accessory which is intended but not absolutely necessary. This move/rename serves several purposes beyond that: 1) The accessory becomes an own component living in a separate package. 2) All currently public functions should be accessed through the controller of the component and therefore be package-visible soon. 3) It reduces size and confusion of the CL that wires the old view to the new controller. 4) The name maps to its new role in go/android-accessory-for-manual-ui Bug: 828832 Change-Id: Id54ce3db25c7e37bd6572e28aa8625b0e6868b9d Reviewed-on: https://chromium-review.googlesource.com/1012062 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#550985}
-
Tim Schumann authored
Cause for breakage: Side effect in DCHECK() which wasn't exercised on trybots (apparently they have all DCHECKs enabled) Without persisting them, server-side provided intervals are less efficient on platforms with relatively short app lifetime. This also allows lower poll intervals for latency-sensitive use cases in cases when our notifications are not reliable enough (yet). Bug: 832019 Change-Id: Ifcd55edcbb9fb17583caac847f6c110024a83e19 Reviewed-on: https://chromium-review.googlesource.com/1013457Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#550984}
-
Lutz Justen authored
Removes unnecessary SetVariable method (can use constructor). Documents usage. BUG=chromium:829279 TEST=Tryjobs Change-Id: I44ac2f93cd65fcd2e36814c659956fbdb0dc8277 Reviewed-on: https://chromium-review.googlesource.com/1013937Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#550983}
-
Devlin Cronin authored
Setting a background page is a pretty common operation in test extensions. Bake it into ExtensionBuilder. Use it in a small smattering of places, and add a unittest. Bug: 832958 Change-Id: Iaa3464dfa183f990fb579d289f99271983344983 Reviewed-on: https://chromium-review.googlesource.com/1013128Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550982}
-
Jeremy Roman authored
[extensions] Make ManifestHandler::Keys return a span into static data instead of allocating a vector. Shows up as a signficant fraction of time in content::ContentMainRunnerImpl::Initialize. Change-Id: I56308465e0bd8c1e58018d21263f8e9710ca66dc Reviewed-on: https://chromium-review.googlesource.com/1011367Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#550981}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/05254515..a7328562 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I1caae9638c8b92541ef86cb9a619f760ebbf0b39 Reviewed-on: https://chromium-review.googlesource.com/1013752Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#550980}
-
Justin Novosad authored
This change fixes a regression that was introduced in https://chromium-review.googlesource.com/c/chromium/src/+/780279 Fixing the issue by switching sensitive use cases back to using SkImage::readPixels for safely performing the unpremul conversion BUG=826878 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie4bc9ced4d7175ab308529f7dd7119f93378e34c Reviewed-on: https://chromium-review.googlesource.com/1003320 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#550979}
-
Lei Zhang authored
Mac builds have been 64-bit only for years now. Change-Id: Id11a687ef54488239afcbfa6d44e415d5d2f7528 Reviewed-on: https://chromium-review.googlesource.com/1013082Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#550978}
-
David Tseng authored
This reverts commit fe043a76. Reason for revert: re-enabling for m68 Original change's description: > Revert "Enable ChromeVox ARC support for all apps" > > This reverts commit bea32252. > > Reason for revert: various apps breaking e.g. scrolling > > Original change's description: > > Enable ChromeVox ARC support for all apps > > > > Change-Id: I130db573fcc2ccbda3ce58c9d2bac845218ab1d9 > > Reviewed-on: https://chromium-review.googlesource.com/961549 > > Commit-Queue: David Tseng <dtseng@chromium.org> > > Reviewed-by: Yuki Awano <yawano@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#544283} > > TBR=dtseng@chromium.org,yawano@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: I6a3c80ac74b3101a3ab756f4e0c5e74980019980 > Reviewed-on: https://chromium-review.googlesource.com/989053 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547379} TBR=dtseng@chromium.org,yawano@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I8f7ba6cfe4d59df80309a49499c754768645d453 Reviewed-on: https://chromium-review.googlesource.com/1014016Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#550977}
-
Mikel Astiz authored
The callback must be called at most once, so let's migrate away from deprecated APIs and adopt base::OnceCallback. Bug: 681921 Change-Id: I2cc0fb6b75771b4a203584154178a1a897a305b8 Reviewed-on: https://chromium-review.googlesource.com/1012063Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#550976}
-
Roman Sorokin authored
BUG=chromium:810167 Change-Id: I030f296e0cf1379d65f9dfba759163896f4319b5 Reviewed-on: https://chromium-review.googlesource.com/928721Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550975}
-
Roman Sorokin authored
Checks that correct error card is shown (Active Directory one). Also checks that hitting retry shows Active Directory screen again. BUG=chromium:829361,chromium:809914 TEST=EnterpriseEnrollmentTest.TestActiveDirectoryEnrollment_ErrorCard Change-Id: I5eb6aa289828954c5837934ab34fb119f15bcdc6 Reviewed-on: https://chromium-review.googlesource.com/998272Reviewed-by:
-
Francois Doray authored
TaskPriority::BACKGROUND tasks can take "an arbitrarily long time to complete". https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h?l=26&rcl=19a69a1389844f51c474efa446e3f22dd1fb36a8 We have plan to restrict more aggressively when they can run. To make sure that this doesn't introduce unwanted performance regressions, we need to make sure that there is no need to run TaskPriority::BACKGROUND tasks to respond to user actions. This CL adds a browser test to verify that the first non-empty paint can happen when no TaskPriority::BACKGROUND tasks are allowed to run. Bug: 831835 Change-Id: I4c5d4f1056d823a6c36aa1504e2508d1bc1c58b6 Reviewed-on: https://chromium-review.googlesource.com/1008640Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#550973}
-
Roman Sorokin authored
We will use for Active Directory machine names. Admins would be able to set regex that machine names should match. BUG=chromium:829361 TEST=manual Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie51ec988639ebcb2bee2dad5a117babe5f2bda84 Reviewed-on: https://chromium-review.googlesource.com/1004588Reviewed-by:
-
Maxim Kolosovskiy authored
The masks will be used for better credentials filling and password generation classifiers Before this CL, properties mask were uploading only in Dev and Canary. Bug: 552420 Change-Id: Ia382ef21146b2aeb22ccd15859700f9b74a91602 Reviewed-on: https://chromium-review.googlesource.com/1012072Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#550971}
-
Boris Sazonov authored
This CL updates the animation that is shown at the top of the sign-in screen: 1. The drawable is no longer scaled to match the screen width. 2. All clouds are animated now. 3. Existing animations have been changed to have a shorter time period. 4. android:strokeLineJoin and android:strokeLineCap are removed from most paths. 5. Background fill is removed from the vector drawable and specified as background color for the ImageView that displays the drawable. Bug: 814728 Change-Id: I893fae85c81c024fee44eb850813306af754886d Reviewed-on: https://chromium-review.googlesource.com/1012107Reviewed-by:
-
Julian Pastarmov authored
BUG=808359 Change-Id: Ia95a6f90086f0aa8ea62e81838f1ae95c7c6496c Reviewed-on: https://chromium-review.googlesource.com/1012065Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#550969}
-
Ramin Halavati authored
Bug: 833185 Change-Id: Ic8afceca1239bc3b6f696765dcb0b93b806973da TBR: kenrb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1013565Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#550968}
-
Ramin Halavati authored
Bug: 819696 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I155d56db5f80d08ab15e836ef08d08b5ead0932e TBR: dtseng@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1014084Reviewed-by:
-
Ramin Halavati authored
BUG=775534 NOTRY=true TBR=steimel@chromium.org Change-Id: I394ae0de8d4701e34baac9b4e643558935bd6efb Reviewed-on: https://chromium-review.googlesource.com/1014104 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
Ramin Halavati authored
TBR=aboxhall@chromium.org Bug: 833318 Change-Id: Ib29dc8185241c394bb6e7f6f4dea7d0f9f7beea9 Reviewed-on: https://chromium-review.googlesource.com/1014080Reviewed-by:
-
Andrew Grieve authored
"Address" column was changed to VMA / LMA. TBR=huangs NOTRY=true NOPRESUBMIT=true Bug: 833343 Change-Id: I2bacc49626794ae07fd9d02258e87a5620618cb1 Reviewed-on: https://chromium-review.googlesource.com/1014001 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#550964}
-
Ramin Halavati authored
Bug: 833028 Change-Id: Ie4d60d122f5403f735d8f5a0d9fe45f35f1e13c5 TBR: chrisha@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1014100Reviewed-by:
-
yoshiki iguchi authored
Bug: 826612 Change-Id: Ie2c5cf4266cf38fcfa12c3cb6ec432fc73a841e2 Reviewed-on: https://chromium-review.googlesource.com/992254 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#550962}
-
Marc Treib authored
This removes features::kSupervisedUserCreation and a bunch of now-dead code. There's lots more, but this is plenty for one CL. Bug: 828890 Change-Id: I2793654046a71104b153e5808fe97a2c4151ad12 Reviewed-on: https://chromium-review.googlesource.com/996072 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
-
Marc Treib authored
- Use BindOnce/BindRepeating instead of plain Bind - Remove unused enum entries - Use range-based for loops Bug: none Change-Id: Ife423c425d2c6f3fff05869536af67042b9c8809 Reviewed-on: https://chromium-review.googlesource.com/998353 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#550960}
-
Andrew Grieve authored
This allows the optimization to be enabled when using custom proguard versions. With our current version of ProGuard (5.2.1), it can cause VerifyErrors at runtime (see PS1 trybot failures). Note that when the pass is enabled, I'm seeing: Shrinks monochrome_apk dex by 53kb uncompressed, 17kb compressed. Shrinks method_count by 1400. Bug: 620323, 825995 Change-Id: I08146a8a84d4f466ed91834728914aa116bca7a5 Reviewed-on: https://chromium-review.googlesource.com/986532Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#550959}
-
Matt Falkenhagen authored
SharedWorkerHost was calling WorkedDestroyed at three callsites using two flags to determine when to do so. Use a RAII helper class to manage the state instead. One motiviation is fixing 830288 which is going to add more state to SharedWorkerHost (creating a host before calling start), so when to call WorkerDestroyed would get more complicated. Bug: 830288 Change-Id: Ie3f135d925091518b172a4afcd8c475656aa9db4 Reviewed-on: https://chromium-review.googlesource.com/1013360Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#550958}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ddfc6de6..05254515 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I428a80d5d01a39be3356c01d28bf1f3ba8f9925a Reviewed-on: https://chromium-review.googlesource.com/1013744Reviewed-by:
-
Christopher Lam authored
See go/closure-compile-gn for details. This CL converts the Closure Compilation from GYP to GN for the following: - cryptotoken - download_internals - md_downloads - md_extensions - md_history - md_user_manager - offline_pages - signin - webapks - welcome A local closure compile can be run by setting closure_compile = true in args.gn, and then running ninja -C out/Default webui_closure_compile. Individual projects can be compiled via, for example, ninja -C out/Default chrome/browser/resources/md_extensions:closure_compile Bug: 632206 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I401fc54ee6c5202bd27855ba28d886677e52210e Reviewed-on: https://chromium-review.googlesource.com/954772 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#550956}
-
Friedrich Horschig authored
Right now, clicking the X button in the search will close it. To start a new search, you have to open a new search. That experience isn't very discoverable, so UX developed an improved workflow - details in the bug. The new flow needs these changes: - the X button _only_ clears the query text field now - the X button is _only_ available when a query was entered - closing the search happens only via the "navigate up" button in the action bar. - the three-dots overflow menu is hidden while a search is active (already the case on small screens - now large screens do the same) Tests cover all of these cases. Bug: 821755 Change-Id: Ieb2e16c096750d66874aa4c4999759629332491b Reviewed-on: https://chromium-review.googlesource.com/966070Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#550955}
-
jdoerrie authored
This change fixes a subtle bug in TestCallbackReceiver, renames StatusCallbackReceiver to ValueCallbackReceiver and adds usages where appropriate. Bug: 785955, 799044 Change-Id: Iac686ec59c48e33d75155e67d615a6bdb4c042a0 Reviewed-on: https://chromium-review.googlesource.com/1009744 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#550954}
-
