- 10 Aug, 2018 40 commits
-
-
A Olsen authored
Using type 'list' seems like a good idea if the policy is indeed a list. However, it is not a good idea if it is a list of objects, and so will need to be parsed as JSON - in that case, 'dict' is a better fit. Added some documentation explaining why. Bug: 872765 Change-Id: I5185f515d7bc82048bfb1eaab5d6d9ae61848eea Reviewed-on: https://chromium-review.googlesource.com/1169469Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#582214}
-
Tommy C. Li authored
This is a reland of eb0754126c4ea3ef3aa55b65e607fe8204b6e197 Original change's description: > Omnibox UI: Trivial refactor of redundant logic. > > Bug: NONE > Change-Id: I081af3892dc52f73d7d92aed9b417defa862f8be > Reviewed-on: https://chromium-review.googlesource.com/1168512 > Reviewed-by: Kevin Bailey <krb@chromium.org> TBR=krb@chromium.org Bug: NONE Change-Id: Ie94842ac68a918714e3ddd258ee61b885ec371b5 Reviewed-on: https://chromium-review.googlesource.com/1169930 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#582213}
-
Nico Weber authored
Looks like my new bot is only found without this requirement: https://chromium-swarm.appspot.com/botlist?c=id&c=os&c=task&c=status&f=cores%3A32&f=builder%3Awin-asan&f=os%3AWindows-10&f=cpu%3Ax86-64&f=pool%3Aluci.chromium.ci&l=100&s=id%3Aasc https://chromium-swarm.appspot.com/botlist?c=id&c=os&c=task&c=status&f=builder%3Awin-asan&f=os%3AWindows-10&f=cpu%3Ax86-64&f=pool%3Aluci.chromium.ci&l=100&s=id%3Aasc Bug: 869973,871764 Change-Id: I9f6f6e8bdfb0f62553266ad9eac4a12fcfdedd9f Reviewed-on: https://chromium-review.googlesource.com/1171023Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#582212}
-
Kevin Marshall authored
This adds new CIPD package definitions and supporting GN targets for Chrome Fuchsia prebuilts, for inclusion into the Fuchsia build. Adds a Blink override to licenses.py SPECIAL_CASES. Bug: 869197, 729194 Change-Id: Ibe609cd96fef91358e37c2bc440dd10d5c4cac32 Reviewed-on: https://chromium-review.googlesource.com/1155831 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
-
Weidong Guo authored
1. To add an icon shadow without affecting its bounds, create a new image view for the shadow and hide it behind the icon. In this case, dragged icon does not have shadow, UX is fine with this. 2. Add shadow for app title. 3. Change folder bubble color 4. Change app list background shield color. Demo: https://screenshot.googleplex.com/EWBDpOrpUTa Bug: 872012 Change-Id: I8e2f1ab5cb3bd6ac980ebee0b549e0a7c86f96d2 Reviewed-on: https://chromium-review.googlesource.com/1168583 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582210}
-
Xi Cheng authored
This change removes the current execution profile _mojo_ representation in favor of directly writing the data in the protocol buffer format used for UMA upload. The reasons for using this format are: 1. it's the format that we ultimately need the data in; 2. it's the most memory-efficient representation available to us, because of the protocol buffer varint encoding; 3. the serialized protocol buffers are trivially compressible. We generate execution profiles in non-browser processes, so this means writing the protocol buffer representation in those processes and sending over mojo to the browser process, where the UMA upload takes place. We're making this change as part of a refactoring to expand the profiling scenarios supported by the UMA Sampling Profiler. A key aspect of this refactoring is reducing memory consumption of the execution profile representation. See http://crbug.com/850148 for examples of memory usage problems with this representation. Bug: 851163, 804942 Change-Id: Ied88d6fd932587707c1f5a4c79acd77d5911f6ee Reviewed-on: https://chromium-review.googlesource.com/1157547 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#582209}
-
Alexander Hendrich authored
This CL adds policy value validation to policy validators. For now, we only collect value validation errors/warnings and report them back to the DM server. In the future, the policy value validation can also reject entire policy blobs, if the value validation fails for a single policy. Right now only the values of ONC policies are validated and can generate warnings and errors. Bug: 794848 Test: unit_tests / components_unittests Change-Id: If4569075f698afd49e951794e78d53c0de73eeb2 Reviewed-on: https://chromium-review.googlesource.com/1127164Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#582208}
-
Jan Krcal authored
This CL creates the framework for running autofill wallet integration tests on both implementations. Bug: 869526 Change-Id: Ifb44357fa8be5e2e49f099abb53b69c7be1b53d7 Reviewed-on: https://chromium-review.googlesource.com/1170836 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#582207}
-
Kevin McNee authored
Currently, when we create a RenderWidgetHostViewAndroid, we attach its corresponding native view to the hierarchy. However, RWHVAs may be created for a speculative RenderFrameHost for a cross-site navigation, and would not replace the old RWHVA until the navigation commits. This gives us two RWHVAs in the hierarchy. In this state, input events are targeted to the speculative RWHVA. Moreover, if the cross-site navigation is canceled before it commits, then we stay in this state where input events are sent to the unused RWHVA, causing the page to be seemingly unresponsive to input. We now move new RWHVAs behind any existing ones in the view hierarchy. Bug: 867932 Change-Id: I845d99ecbde7f721f6fa4b6e1b0243abb89a97fc Reviewed-on: https://chromium-review.googlesource.com/1165482Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#582206}
-
Tessa Nijssen authored
When the text surrounding the current selection gets too long, only part of it is received by TextSuggestionsTouchBarController. The location of the received text within the total block of text is denoted by an offset. Previously, TextSuggestionsTouchBarController did not take this offset into account, causing crashes when the selection range was past the end of the received text. The offset is passed along with the text and selection range. The selection range within the received text is calculated using the offset and received selection range. The editing word range is stored both as the range within the received text and the range within the total text for checking when to ignore text selection updates. RenderWidgetHostView::GetOffsetForSurroundingText() was added to retrieve the offset on WebContents update. Browser tests were modified to account for the new offset parameter. A new browser test, TextSuggestionsTouchBarController.Offset, was added to test that the controller properly handles offsets. Bug: 717553 Change-Id: I6dce1405fd5c115ca6ddfdbe4157faf75ccc3a6c Reviewed-on: https://chromium-review.googlesource.com/1169597 Commit-Queue: Tessa Nijssen <tnijssen@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582205}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9b6a3f926032..04c084dd3cf4 git log 9b6a3f926032..04c084dd3cf4 --date=short --no-merges --format='%ad %ae %s' 2018-08-10 jmadill@chromium.org Extend MultiviewDrawValidationTest. Created with: gclient setdep -r src/third_party/angle@04c084dd3cf4 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Iefd268bdcd058300ae57892d2bfe2058bd6998fc Reviewed-on: https://chromium-review.googlesource.com/1169704Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582204}
-
Antoine Labour authored
SharedImageInterface is a minimal interface to allocate and destroy mailbox resources. It is independent of GL, stateless, thread-safe and expresses direct ownership of the resources. SharedImageInterfaceProxy and SharedImageStub implement SharedImageInterface over IPC. Note: currently SharedImageInterfaceProxy sends an IPC for creating and destroying shared images, but this will be merged into the multi-flush IPC in a follow-up. Bug: 870116 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8f0b86957fab34a1a93f0b2ada8590a048e81724 Reviewed-on: https://chromium-review.googlesource.com/1164168 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#582203}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ce9fa204b82d..615ae9b6f35a git log ce9fa204b82d..615ae9b6f35a --date=short --no-merges --format='%ad %ae %s' 2018-08-10 amyqiu@google.com Add tool for visualizing metrics times Created with: gclient setdep -r src/third_party/catapult@615ae9b6f35a The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I4e00e0ef35c9e5c240f472fb11900156873aafd3 Reviewed-on: https://chromium-review.googlesource.com/1170942Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582202}
-
James Cook authored
This reverts commit 2e6f9474f58ddcd3f72f425d5af6a8dd77cab614. Reason for revert: Relanding now that gerrit outage is over. Original change's description: > Revert "Add shelf owners to //ash/public/cpp/OWNERS" > > This reverts commit e7591612da4c080af86c964d14b25c4061f5b51b. > > Reason for revert: Due to Gerrit outage http://crbug.com/872722, we are reverting this CL. Please, re-land it after all clear is given. If you have questions, please ask on the bug. Sorry for the inconvenience. > Original change's description: > > Add shelf owners to //ash/public/cpp/OWNERS > > > > Bug: none > > Change-Id: Ib1fbca291732828c5b7feeaf853ed84a41970999 > > Reviewed-on: https://chromium-review.googlesource.com/1168646 > > Commit-Queue: James Cook <jamescook@chromium.org> > > Reviewed-by: Michael Wasserman <msw@chromium.org> > > TBR=jamescook@chromium.org,msw@chromium.org > > Change-Id: I8b26db1fca95f8ff6b9b01c62911fb904570c50f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: none > Reviewed-on: https://chromium-review.googlesource.com/1169853 > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> TBR=jamescook@chromium.org,msw@chromium.org,tandrii@chromium.org Change-Id: I9ea7352dd60261d0dd604854f8cc76686562f1d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/1171063 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#582201}
-
Peter Beverloo authored
This is currently done on the thread that invokes fetch(), i.e. either the main or the worker thread. Especially now that we're going to resize the image to the desired size too, let's move that to the background. Per this CL we also resize the icon to the display size indicated by the browser process. Change-Id: Iee082c67f9c6b4903b931f95c40142cd5f77b853 Reviewed-on: https://chromium-review.googlesource.com/1166965 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#582200}
-
Maja Kabus authored
Change 1152336 may generate TraceWrapperMember<..> instances but does not include the header. (In test dictionary it is implicitly included e.g. via element.h include) Bug: 867875 Change-Id: I2e627826624c391d3b993b81ca6ed04f477139f6 Reviewed-on: https://chromium-review.googlesource.com/1170684Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Maja Kabus <kabusm@google.com> Cr-Commit-Position: refs/heads/master@{#582199}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/93ce79dba4d9..6ed63968a391 git log 93ce79dba4d9..6ed63968a391 --date=short --no-merges --format='%ad %ae %s' 2018-08-10 timliang@google.com implemented GrMtlPipelineState for metal gpu backend 2018-08-10 timliang@google.com implemented SK_CLOCKWISE_BUILTIN for Metal SkSLC 2018-08-10 egdaniel@google.com Make sure GrResourceCache frees resources waiting on messages during destruction. Created with: gclient setdep -r src/third_party/skia@6ed63968a391 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: I62fa0889abc2e48f9d33832a1e5e276c6f3bc83e Reviewed-on: https://chromium-review.googlesource.com/1169705Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582198}
-
Lei Zhang authored
Change-Id: Id31a0a4d443c19da2be8b47a1074b14faa548794 Reviewed-on: https://chromium-review.googlesource.com/1170566Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#582197}
-
Ryan Daum authored
- Adds detection and dispatch of screen entry/exit events. - Adds detection of a finger press and hold in the corner. - Better handling of multiple-finger events on the screen. Bug: internal b/112073644 Bug: internal b/112314035 Test: unit test and manual Change-Id: Id2155f8e432428ee63f3457274f1507ce1edee53 Reviewed-on: https://chromium-review.googlesource.com/1165795Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#582196}
-
Matthew Cary authored
When generating orderfiles manually, output the sizes symbols in each phase. Also removes obsolete stability calculation. Bug: 758566 Change-Id: Ie836061e93683884d631c2f7d3daab7fb6602c9f Reviewed-on: https://chromium-review.googlesource.com/1156305 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#582195}
-
sczs authored
Bug: 870150 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Idfed72db1f82009e002fb5ed1a6c76427eb0b697 Reviewed-on: https://chromium-review.googlesource.com/1170185Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#582194}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/74182d1df594..c500e36711d5 git log 74182d1df594..c500e36711d5 --date=short --no-merges --format='%ad %ae %s' 2018-08-10 treehugger-gerrit@google.com Merge "Unify and bump kMaxCpus" 2018-08-10 treehugger-gerrit@google.com Merge "Fix Chromium build" 2018-08-10 primiano@google.com UI: several minor fixes (time and queries) 2018-08-10 primiano@google.com UI: Reduce queries and move height computation to the frontend 2018-08-10 primiano@google.com Add chrome slices track 2018-08-09 primiano@google.com Merge "perfetto-ui: Remove ui/src/panels" 2018-08-09 primiano@google.com Merge "perfetto-ui: Update deploy script to deploy test version by default" 2018-08-09 primiano@google.com Merge "perfetto-ui: Copying directories is right out" 2018-08-09 michaschwab@google.com Overview timeline vis shows load per process 2018-08-09 hjd@google.com Merge "perfetto-ui: Add permalinks" 2018-08-09 hjd@google.com Merge "TraceProcessor: expose string table" 2018-08-09 dproy@google.com [perfetto-ui] Add a fake flamegraph 2018-08-09 dproy@google.com Merge "Refactor Scrolling and Tracks using Panels" 2018-08-09 primiano@google.com Merge "perfetto-ui: Remove old CSS" 2018-08-09 hjd@google.com trace_processor: Add integration tests Created with: gclient setdep -r src/third_party/perfetto@c500e36711d5 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I79d9945012d989d5150c78e2487f08b3c065f427 Reviewed-on: https://chromium-review.googlesource.com/1169940Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582193}
-
Peter Beverloo authored
We're not using this code in production. It's hardly tested, has an odd sequencing order and brings a lot of complication that we can remove for now. It's also the cause of a number of crashes. Bug: 850512 Change-Id: I33050f54dfbafa9192390d1ad5f3ed34cce91aca Reviewed-on: https://chromium-review.googlesource.com/1165554 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#582192}
-
Becky Zhou authored
Bug: 687010 Change-Id: I304d68c8ade4e6cddb2017881b80b9300d0e512d Reviewed-on: https://chromium-review.googlesource.com/1170188Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
John Abd-El-Malek authored
Bug: 769401 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ie6dff50674507ec518d5c8043cba7e3202b6f2ff Reviewed-on: https://chromium-review.googlesource.com/1168736Reviewed-by:
Doug Turner <dougt@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#582190}
-
Peter Boström authored
This function is being removed and currently always returns true. Bug: chromium:867557 Change-Id: I6e683990e42a6ad9abb7fe5d9b8cce2f51867c37 Reviewed-on: https://chromium-review.googlesource.com/1166189Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#582189}
-
Matt Menke authored
Previously, they were initialized on first use, however, now that initialization sets up NetworkContexts when the network service is disabled, relying on the first use of the class through the ChromeURLRequestContextGetter API before setting up the NetworkContext could cause problems. Bug: 847555 Change-Id: I2aaac7e717e64fb41ba2fb9141506bb7512b73fa Reviewed-on: https://chromium-review.googlesource.com/1169319Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#582188}
-
Calder Kitagawa authored
Adds a Snackbar to disclose when an unbound WebAPK or TWA is running in Chrome. This is designed such that users see the disclosure under the following conditions: - The webapp is a TWA or WebAPK - If it is a WebAPK it was not installed from Chrome. Until the user presses "OK, got it" the snackbar will persist and remains during navigation. If a session is ended without pressing "OK, got it" then the message will appear the next time the app is opened or resumed. This appears once per app installation with the caveat that if a user clears their Chrome data the app will show this message again. This change is implemented to only start showing the disclosure when the storage is null. This happens only when an app is opened for the first time. As such all deployed and launched unbound WebAPKs will not see this message. To facilitate this we set a boolean flag to show the message when we launch with null storage. The reason this is necessary that the default value for a key is false so for existing unbound WebAPKs we would try to show the message regardless of state if we didn't use a set, check, clear approach. Known issues: It appears that there is a finch trial for chrome modern that isn't properly initialized if the WebAPK is launched cold (i.e. Chrome hasn't been started) and Chrome's data has been wiped. As a result, the old black snackbar is shown instead of the white one. This is remedied if the app is relaunched and won't occur if Chrome is launched before the WebAPK. Bug: 862401 Change-Id: Ieb09b7b628d5718908f8841b06b469c54ed59472 Reviewed-on: https://chromium-review.googlesource.com/1142224 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#582187}
-
Melissa Galonsky authored
Per crbug.com/860229, removes the Android build number from the Android user agent, but creates a Finch experiment that allows the change to be re-enabled. Does not apply the change to Android Web View as mandated by the Android Compatibility Definition Document. Bug: 860229 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I57c24994958d840c80600356f12b2ce20c8a9f74 Reviewed-on: https://chromium-review.googlesource.com/1157225 Commit-Queue: Melissa Galonsky <mgalonsky@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#582186}
-
Matthew Jones authored
This patch reduces the padding above the logo on the NTP to reduce the unneeded whitespace and adds padding to the bottom so that the footer is not obscured by the bottom toolbar. Bug: 870748,869612 Change-Id: I9e003149d32d54b2652e20e1a45524724985abff Reviewed-on: https://chromium-review.googlesource.com/1169587Reviewed-by:
-
Ken Rockot authored
Changes this test to properly wait for the first synthetic click event to fire before proceeding with the rest of the test and validating its expectations. Bug: 872081 Change-Id: I0954ef7deff8415600effbc79cca7402a1b51583 Reviewed-on: https://chromium-review.googlesource.com/1170173 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#582184}
-
Sujie Zhu authored
[Autofill local card migration settings page] Add migration experimental flag api for settings page(#1). This is the start CL of triggering migration from settings page. We modify the original Boolean experimental flag to multi-state experimental flag in order to use one flag to control the normal submit form and settings page separately. The following CLs will be: 1. We will use loadTimeData to get the experimental flag in the JS code. We will use this flag to protect and isolate the new changes. 2. Add new attribute of CreditCardEntry to check the migration requirements. 3. Display the migration button to the user when requirements meet. 4. Trigger migration when user click on the button with new API call. Please refer to the design doc for more details: https://docs.google.com/document/d/1J7YyBeKZZaBhjAHnMEezvuBa5x1pk_XCh_yZvV_HMmc/edit#heading=h.1wm3blr98d8i Bug: 852904 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I5fbf0acc32853b5d2d86cfcd24f109f04341dddd Reviewed-on: https://chromium-review.googlesource.com/1163067Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Sujie Zhu <sujiezhu@google.com> Cr-Commit-Position: refs/heads/master@{#582183}
-
Ryan Daum authored
Does not discard the first tap event, but tries to issue a cancel for it instead. Had to do this because the replaying of the stashed events weren't making it through to later event rewriters in the chain (including side swipe detection, and the forthcoming fullscreen magnifier). Has the side-effect that many applications will still receive a touch press event. However touch latency also improves. Also adds tap slop detection to avoid accidental triple taps. Bug: internal b/110532452 Test: manual and unit test Change-Id: Icc9d3b558940348e98c88eb1c29697cd7d59065a Reviewed-on: https://chromium-review.googlesource.com/1170588Reviewed-by:
-
Michael Lippautz authored
Implement early write barrier bailout similar to incremental marking. This allows bailing out without looking up data structures in TLS or Isolate-specifics maps. Bug: chromium:843903 Change-Id: Iac5afa2ee375b5bb192ef91543f9aa9a54a70385 Reviewed-on: https://chromium-review.googlesource.com/1170834Reviewed-by:
-
Mirko Bonadei authored
This is a reland of 6f1c521d6e0587818817fa55981663ed7d0527ed Original change's description: > Fix gtest missing dependencies on absl. > > If GTEST_HAS_ABSL=1 gtest now also depends on: > * absl/debugging:failure_signal_handler > * absl/debugging:stacktrace > * absl/debugging:symbolize > > More info: https://cs.chromium.org/chromium/src/third_party/googletest/src/BUILD.bazel?l=106-113&rcl=82670da613af6b5a427e7cc9980ba8977afcab8a. > > Bug: None > Change-Id: If1a42dca4b97ea000eb10b178d1abc6a50a5f0e9 > Reviewed-on: https://chromium-review.googlesource.com/1169056 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Bug: None Change-Id: I9a225b9ad4d9d40b2f76b1f074234c190f4681c3 Reviewed-on: https://chromium-review.googlesource.com/1170602 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#582180}
-
Valeriya Sinevich authored
This will be used later inside GaiaCookieManagerService::SetAccountsInCookies(). Change-Id: I210fb940ce397c608e66bbc8067ff5e75164513b Reviewed-on: https://chromium-review.googlesource.com/1169176Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Valeriya Sinevich <valeriyas@google.com> Cr-Commit-Position: refs/heads/master@{#582179}
-
Ramya Nagarajan authored
This is a reland of 94558b66 Original change's description: > [NTP] Adds an experiment for M69 NTP features. > > Only the first experiment entry gets covered by perf waterfall, so adding > this item ensures better test coverage. Also, the existing experiment, > NewTabPageAllBirthday_Enabled, could not be re-used since > go/revising-finch-configs recommends creating a new experiment when > changing size or behavior of existing groups. > > Bug: 831910 > Change-Id: I95ebc6f2768fe25d34993c05c71e35c22e2bdcc5 > Reviewed-on: https://chromium-review.googlesource.com/1160925 > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580314} Bug: 831910 Change-Id: Ie8788f8ee24a146f9854fb9b4abb35cfb55664a2 Reviewed-on: https://chromium-review.googlesource.com/1167562Reviewed-by:
-
Matthew Cary authored
Uses the new WritableUnalignedMapping class, which changes the ownership semantics. See the bug for details on the overall plan. This is a reland of crrev.com/c/1117696, now that mojo is initialized for the unittests is fixed, and also removes a double-close for the shared memory handles. Bug: 849207 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib065caedfed8a33fd0f112ce22a72bda4b9bf99e Reviewed-on: https://chromium-review.googlesource.com/1158567Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#582177}
-
Maks Orlovich authored
... Rather than relying on them to be sufficiently close to each other that there isn't much event loop activity. This is needed for upcoming port of GaiaOauthClient to Network Service (and hence mojo), which requires tests to spin the event loop in a lot more places than before to deliver fetch results, making it hard to ensure that HandleOnAccessTokenRequested and WaitForAccessTokenRequestIfNecessary get delivered in right order. Bug: 865018 Change-Id: I7acf6427be7be5b00c8e003dd687169c4b8a7577 Reviewed-on: https://chromium-review.googlesource.com/1167904Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#582176}
-
Sahel Sharify authored
Bug: 865755 Change-Id: Ic24c1405392ba42810f516f375a3d304a81a88ed Reviewed-on: https://chromium-review.googlesource.com/1169779 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#582175}
-
