- 18 Nov, 2019 40 commits
-
-
Luca Hunkeler authored
Android version and device model are not expected to change within the same interaction. Therefore we can simply get them when the service is initialized and keep them cached. (in the same way we are currently handling the rest of the ClientContext) Bug: b/143519300 Change-Id: I66aa7aeb6d26774fedb2f37f77a221571f70c4bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910084Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#716153}
-
Andrew Grieve authored
Bug: 693079 Change-Id: Ie50b217c572ff63b6a8b1db233e2ede0d7741b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921547 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#716152}
-
Hans Wennborg authored
This reverts commit 29c801b5. Reason for revert: The official/chrome/chrome_android recipe (which does not show up on internal code search) uses this, and that recipe also builds the M78 and M79 branches , so can't be migrated to use the new update.py flag yet. We'll have to keep this around until all builds are targeting M80 or later. Original change's description: > Remove tools/clang/scripts/download_objdump.py > > All uses have been replaced by calls to update.py --package=objdump. > > Bug: 884608 > Change-Id: Icb820782786a256c0a3586e8a23f62d463689afb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917517 > Auto-Submit: Hans Wennborg <hans@chromium.org> > Commit-Queue: Reid Kleckner <rnk@chromium.org> > Reviewed-by: Reid Kleckner <rnk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715750} TBR=hans@chromium.org,rnk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 884608, 1025703 Change-Id: Ib048dfcbd91f4f5201a6b77525189e6185dc7e80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921977Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#716151}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fd0e32a87a4e..4186603902fc git log fd0e32a87a4e..4186603902fc --date=short --no-merges --format='%ad %ae %s' 2019-11-18 handellm@webrtc.org Always record timestamp of keyframe request. 2019-11-18 mbonadei@webrtc.org Reland "Force Chromium deps on the WebRTC component." 2019-11-18 yvesg@google.com Revert "Add AV1 RtpDepacketizer class" 2019-11-18 danilchap@webrtc.org Add AV1 RtpDepacketizer class 2019-11-18 mbonadei@webrtc.org Revert "Force Chromium deps on the WebRTC component." 2019-11-18 jonaso@webrtc.org p2p_transport_channel_unittest : put frequently used checks into functions. 2019-11-17 jerome.humbert@microsoft.com Add missing assert.h for win no-test build 2019-11-16 hta@webrtc.org Make SCTPtransport enter "closed" state when DTLStransport does. 2019-11-16 handellm@webrtc.org VideoFrame: Store a reference to an encoded frame 2019-11-15 thaloun@chromium.org Use GetDefaultAudioEndpoint for the default communications device as well as the vanilla default device 2019-11-15 qingsi@webrtc.org Make ICE transports injectable. 2019-11-15 mbonadei@webrtc.org Force Chromium deps on the WebRTC component. 2019-11-15 peah@webrtc.org Correct the upmixing of mono to stereo in ACM2 Created with: gclient setdep -r src/third_party/webrtc@4186603902fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:1013590,chromium:None,chromium:1013590,chromium:b/144524502,chromium:1024965,chromium:b/144458371 Change-Id: Ib258985c0cc41c04dbdba7aeba67644656f2dcb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921556Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716150}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/be605ce3..6c6d66df Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id18e17215397d47fe01407d3565ef102b8885064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921417 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716149}
-
Yoichi Osato authored
As we got to send WebSocketHandshakeResponse, selected_protocol and extensions at the same time ([1]), let's merge it on mojo. This reduces redundant member declarations in WebRequestProxyingWebSocket. [1] "[WebSocket] Do not send response headers for failed handshake.": https://chromium-review.googlesource.com/c/chromium/src/+/1847592 Change-Id: Ib109f2342e85216e7702a51c136f3f940fa8759c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903236Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#716148}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/aba1020d3914..8df0aaf24931 git log aba1020d3914..8df0aaf24931 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 swiftshader.regress@gmail.com Regres: Update test lists @ aba1020d Created with: gclient setdep -r src/third_party/swiftshader@8df0aaf24931 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I1edaeaa7f6ab8de2933c18ab8e5667f69b7c6507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921866Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716147}
-
Greg Thompson authored
This reverts commit 11936b31. Reason for revert: Crashy. Original change's description: > Browser shutdown cleanups (no functional changes). > > - Make ShutdownType an enum class. > - Introduce browser_shutdown::HasShutdownStarted as a convenience. > - Move some Win-specific relaunch code from AttemptRestart, which runs > fairly early in a restart that may never actually happen, into > upgrade_util::RelaunchChromeBrowserImpl, which performs the actual > restart. > - Switch from UMA macros to functions for one-shot metrics. > > BUG=958865 > > Change-Id: I75cd08c712d8bb7c674b4b5e413d79abc874bc39 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910098 > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Greg Thompson <grt@chromium.org> > Auto-Submit: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715730} TBR=treib@chromium.org,bcwhite@chromium.org,holte@chromium.org,grt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 958865,1025638,1025634 Change-Id: Ia97829abe61fcfb362720ce74741a5d375bb811e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921973Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#716146}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8d735c19a560..b2ac8dce6358 Created with: gclient setdep -r src-internal@b2ac8dce6358 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I1953c437ac4b9eaa68de4595a5ddcd523ea39caa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921208Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716145}
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /components/omnibox This CL was uploaded by git cl split. R=mpearson@chromium.org Bug: 1018667 Change-Id: Idb0b248873001282c98db87a6dfc6381d45bbbc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917229 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#716144}
-
Findit authored
This reverts commit aeec2ba1. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 716101 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYWVlYzJiYTE3NWI5Y2JlZmRhNWQ3ZDQxNmVkZmY2ODRmMmRiOTdlZgw Sample Failed Build: https://ci.chromium.org/b/8896451843858020336 Sample Failed Step: webkit_layout_tests (experimental) Sample Flaky Test: virtual/legacy-client-hints/external/wpt/client-hints/accept-ch-feature-policy-navigation.https.html Original change's description: > [client-hints] Allow 3P legacy Client-Hints to work with Feature Policy > > Currently there are two different flags that control sending Client Hints > to cross-origin resources: Feature Policy delegation (off-by-default) and > a build flag that sends legacy hints on Android. > > This CL makes sure that these two flags play nice together, and adds > virtual test suites to exercise them. > > BUG: 1022366 > Change-Id: I00ed4e9ed5a64e378def3d90227f238b9b3eb374 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893196 > Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#716101} Change-Id: I4974dd0e5342a90f97734fddfb9ddaa6fd4fdb22 No-Presubmit: true No-Tree-Checks: true No-Try: true BUG: 1022366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920472 Cr-Commit-Position: refs/heads/master@{#716143}
-
David Roger authored
This is a fix for the following scenario: - user signs in or opens Chrome - image starts downloading - user signs out - image download completes - pill is shown while signed out The fix is to check that the user is still signed in when the download completes. Fixed: 1025674 Change-Id: I780731d23b6e89beba343c27c947c284172584ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919920Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#716142}
-
Oriol Brufau authored
The test fails because the baseline of an empty cell is the top content edge instead of the bottom one. Bug: 1024207, 799016 Change-Id: Iaffac133eee62a2f8f330fbcfe7a2b738837f6e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921971Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#716141}
-
Carlos Caballero authored
navigation_handle->IsErrorPage() will always be false in DidStartNavigation as the error state is set upon commiting the navigation. Change-Id: Ib8bd7e49a49b87e26a795080a45038f255295c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895348 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#716140}
-
Daniel Vogelheim authored
Bug: 951536 Change-Id: Ia2f65ff3318ac71debba16d6d50e19d28ac5b071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917532Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#716139}
-
Mathias Carlen authored
Before this patch we locally modified the Bundle to forward the actionId of a dynamic action. That implicit behavior is confusing and led to a bug when an extras Bundle passed to performDirectAction from a calling assist app was null, the map here would be immutable. This patch just plainly passes along the actionId as a function argument. R=szermatt@chromium.org Bug: b/138833619 Change-Id: I4a884a5ad288533f55b13937433d8f6ba3d18418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919353Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#716138}
-
Greg Thompson authored
This reverts commit 2c98cab9. Reason for revert: Parent change causing crashes. Original change's description: > Suppress beforeunload and in-progress download prompts for forced restarts. > > This change introduces RelaunchIgnoreUnloadHandlers and uses it in > RelaunchNotificationController when the deadline for a forced relaunch > is reached. This new function is to AttemptRelaunch as > ExitIgnoreUnloadHandlers is to AttemptExit. > > This also introduces browser_shutdown::ShouldIgnoreUnloadHandlers(), > which is a convenience for code that needs to know whether or not an > in-progress shutdown should ignore unload handlers. > > BUG=958865 > > Change-Id: I91a9832d745e95b7436b176d78f5e39ed14addd2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914380 > Commit-Queue: Greg Thompson <grt@chromium.org> > Auto-Submit: Greg Thompson <grt@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715901} TBR=treib@chromium.org,grt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 958865,1025638,1025634 Change-Id: I0584904da38d150481e8450aacaff0f909a53d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919356Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#716137}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/14e51ec7bc7a..f66be5a8dcf8 git log 14e51ec7bc7a..f66be5a8dcf8 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 lalitm@google.com Merge "trace_processor: remove ts/dur DCHECK on span join" Created with: gclient setdep -r src/third_party/perfetto@f66be5a8dcf8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ia0f2089decdf8d32e2000c010332253847993e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921860Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716136}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bbdabb3b9b0a..954888135395 git log bbdabb3b9b0a..954888135395 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src f8ea20adee82..e2441190bb0c (42 commits) Created with: gclient setdep -r src/third_party/angle@954888135395 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=courtneygo@google.com Bug: chromium:None Change-Id: I7abb86fbac18e4193551c3f2da8719883c461153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921861Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716135}
-
Greg Thompson authored
BUG=980487 Change-Id: Idfeaacd4f5d1e295cc26301eedfee33c1d733ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920045 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#716134}
-
Dominique Fauteux-Chapleau authored
Move BrowserDMToken from browser/ to DMToken in components/ in order to be able to use DMToken in components/. Also makes the Create*Token BrowserDMToken functions private to avoid misuses by callers and instead expose *TokenForTesting functions to make their intended usage more explicit. This CL is mostly restructuring the new DM token classes and doesn't change functionality. Bug: 1020296 Change-Id: Ied05c56807352c0bddc4d8ecb11e148d05608e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906901 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#716133}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/295649fd..be605ce3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib2fc9b9fec3a765ec3d9a0bcc6d430d20f165be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921535 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716132}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8ff52d37c080..8d735c19a560 Created with: gclient setdep -r src-internal@8d735c19a560 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I4002199f5f112a1d87cc115f18b4392a8e089191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921859Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716131}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/473984fca427..9c2e77d9113f git log 473984fca427..9c2e77d9113f --date=short --no-merges --format='%ad %ae %s' 2019-11-18 perezju@chromium.org [Telemetry] Write results after each test Created with: gclient setdep -r src/third_party/catapult@9c2e77d9113f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:973837 Change-Id: I4cf948b994378827d0f91e301ca4b0c1bc14c4bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921857Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716130}
-
David Roger authored
Change-Id: Ic7de9065ae3a093c208bb1b8631751986b2a60ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917283Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#716129}
-
Morten Stenshorne authored
Most importantly, it can be a static method. Change-Id: I010faeb002108999b1e4d6ac66d6781cfcdb9f23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910230Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#716128}
-
Victor-Gabriel Savu authored
Used to extend DeviceRebootOnUserSignout to virtual machines. Used by: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1840695 Design Document: https://docs.google.com/document/d/1cIZsPD6rwm6ca5r8GCXUqr2gT1axsoGe0S0Hl2-OgCE Bug: 986755 Change-Id: Ice437dd7efe605c85675bf52fe0f5c9e6603f718 Cq-Depend: chromium:1840693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840891Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Cr-Commit-Position: refs/heads/master@{#716127}
-
Guido Urdaneta authored
All p2p files except this one are in renderer/platform. The reason was issues caused by the lack of support for component builds in libwerbrtc. Now that libwebrtc supports component builds, all files can be in the same directory and modules/p2p no longer exists. Bug: 787254 Change-Id: I91e023ef03029a6b740d709cea3735804846099f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919921Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#716126}
-
Andreas Haas authored
There was an in-between creation of an ArrayBuffer which is not necessary. Bug: chromium:1008840 Change-Id: I003b7a95170ea6fa2e6f308f02b532f51c190c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911213Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#716125}
-
Juan Antonio Navarro Perez authored
Expose the '/list_tests' API from the dashboard. This function will be handy to find wrongly stored story names from the linked bug. Bug: 1022380 Change-Id: Ib8e87549feebb127df6c4c35d735761ccc45e2f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917773Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#716124}
-
Yifan Luo authored
TBR=alexmos@chromium.org Bug: 1012190 Change-Id: Ie0baad25c88fd5552cc7e440d438d26606ec9be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917778 Commit-Queue: Yifan Luo <lyf@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#716123}
-
Kuo Jen Wei authored
Bug: b/141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and validate all function of CCA on HALv1/v3 device works correctly. Change-Id: Id278c309e505336282c70a2cdb0425dc84b4d27f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913229Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#716122}
-
Mike West authored
We're currently enforcing strict MIME type checks for `importScripts()` and nested workers. Firefox would like to enforce them for the top-level worker script as well. We should follow suit. This patch also excludes `blob:`, `filesystem:`, and `data:` from scripty MIME type checks. This is the behavior Firefox is shipping, and seems reasonable, given that the risk of sniffing scripts is highest when dealing with resources delivered from a server, rather than resources which are already accessible to the page causing their execution. https://github.com/whatwg/html/issues/3255 https://bugzilla.mozilla.org/show_bug.cgi?id=1583657 Bug: 794548 Change-Id: Ia55621243b8e279a30f457c6a3a20b9fa13cd3d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917528 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#716121}
-
François Beaufort authored
Change-Id: I64b768922a16decf60df57006cbd93a6f9a677b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920669 Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#716120}
-
Renato Silva authored
This is a reland of 5fd0e6ed Original change's description: > Fix browser test EulaTest.LoadOffline > > This commit improves the reliability of the EULA browser test > EulaTest.LoadOffline. This test was disabled due to its flakiness > in the past and is now enabled again. > > Tested locally. Ran 100 tests under stress without any errors. > > Bug: 1015948 > Change-Id: I59bc8612da9f5be526a2aa28d13ee70400dbb01e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892775 > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Commit-Queue: Renato Silva <rrsilva@google.com> > Cr-Commit-Position: refs/heads/master@{#712516} Bug: 1015948 Change-Id: I47bd386c589344f011b03bd6e24f50f08c3b42a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899862Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#716119}
-
Jinho Bang authored
According to the spec change[1], the attribute byte offset is no longer optional. [1] https://github.com/gpuweb/gpuweb/pull/469 Bug: 852089 Change-Id: I5c29652a56531273a9205151cee0598c6911268f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919532 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#716118}
-
Victor-Gabriel Savu authored
Extending DeviceRebootOnUserSignout to virtual machines requires checks for Crostini, PluginVM and vmc in LockToSingleUserManager. Design Document: https://docs.google.com/document/d/1cIZsPD6rwm6ca5r8GCXUqr2gT1axsoGe0S0Hl2-OgCE Bug: 986755 Change-Id: I54c82a293b9db22158b05ded590b9463c3528668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840892 Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#716117}
-
Jinho Bang authored
In an effort to support multi-queue with WebGPU, the shape of the API has changed in the spec side[1]. [1] https://github.com/gpuweb/gpuweb/pull/490 Bug: 852089 Change-Id: I6971ef859f4af1b94663589039009d416f1bc9a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919531Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#716116}
-
Vasilii Sukhanov authored
- rewrite WaitForElementValue for the UI test. The existing implementation uses onchange event. It's problematic for the real keystroke because the event is triggered on focus change only. oninput is the right choice here. - use WaitForElementValue in FillElementWithValue to enforce that the right input handles the keystrokes. Bug: 1024902 Change-Id: Ib7752e39b62d20c73ed06ff85f4fdea641d0955d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919154 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#716115}
-
Emily Stark authored
These overrides are necessary for keyboard focus to work properly when the dialog is shown. Bug: 1025343 Change-Id: I1a63c6a5e9233bd972cf1a07ad89670bf05a8a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919947 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#716114}
-