GitLab

Add support for [Global] / [PrimaryGlobal] IDL extended attributes as per the
latest Web IDL specification:
http://heycam.github.io/webidl/#Global

The [Global] and [PrimaryGlobal] extended attributes can be used to give a name
to one or more global interfaces, which can then be referenced by the [Exposed]
extended attribute (already supported).

One slight difference with the specification is that the values for [Global]
and [PrimaryGlobal] are '&'-separated instead of comma-separated. This is
because having comma-separated here would make IDL parsing a lot harder. This
is consistent with the [Exposed] IDL extended attribute.

There is no web exposed behavior change with this CL. It just makes our IDL
closer to the specification.

R=haraken@chromium.org, nbarth@chromium.org
BUG=369115

Review URL: https://codereview.chromium.org/261243002

git-svn-id: svn://svn.chromium.org/blink/trunk@173595 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The style checker tries to catch std::x references and recommends
'using namespace std;' instead. However, 'using std::swap;' is an
established idiom for swapping objects in generic code, to permit ADL.

BUG=none

Review URL: https://codereview.chromium.org/276513005

git-svn-id: svn://svn.chromium.org/blink/trunk@173594 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Replacing transition types to real types.

BUG=340522

Review URL: https://codereview.chromium.org/270253004

git-svn-id: svn://svn.chromium.org/blink/trunk@173593 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This just updates a bunch of pointers so a WebRemoteFrame can replace a
WebLocalFrame node, or vise versa. This does not currently preserve the
JS global context, which will be addressed in future patches.

BUG=346764
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/271793002

git-svn-id: svn://svn.chromium.org/blink/trunk@173592 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Oilpan: Make DateTimeEditElement::m_editControlOwner and DateTimeFieldElement::m_fieldOwner strong references.

We don't need to use WeakMember for them because owners never die before owned
elements.
In non-Oilpan, owners can die before owned elements because parentNode is not a
strong reference.

BUG=357163

Review URL: https://codereview.chromium.org/275513003

git-svn-id: svn://svn.chromium.org/blink/trunk@173590 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This feature was once enabled in M35 but we had to unlaunch it (wire
format changes being under consideration). The decoder patch for the
format change is landed [1], and we are not expecting further format
change at the moment.

[1] https://code.google.com/p/ots/source/detail?r=113

> Enable Woff 2.0 font compression format by default
>
> Feature Dashboard: http://www.chromestatus.com/features/6718644721549312
> PSA: https://groups.google.com/a/chromium.org/d/topic/chromium-dev/j27Ou4RtvQI/discussion
>
> BUG=242809, 223731
>
> Review URL: https://codereview.chromium.org/199773002

Review URL: https://codereview.chromium.org/265833004

git-svn-id: svn://svn.chromium.org/blink/trunk@173589 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361729,371104

Review URL: https://codereview.chromium.org/272633003

git-svn-id: svn://svn.chromium.org/blink/trunk@173588 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173571

BUG=361729
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/270783003

git-svn-id: svn://svn.chromium.org/blink/trunk@173587 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173571

BUG=361729
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/270803003

git-svn-id: svn://svn.chromium.org/blink/trunk@173586 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Working on https://codereview.chromium.org/264183002/ I ran
into some const correctness issues with the fact that containerForRepaint
returns a non-const pointer, despite repaint being a const operation.
Fixing this before landing that patch.

BUG=320139

Review URL: https://codereview.chromium.org/276583002

git-svn-id: svn://svn.chromium.org/blink/trunk@173585 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=369485

Review URL: https://codereview.chromium.org/274463002

git-svn-id: svn://svn.chromium.org/blink/trunk@173584 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously the animation clock was only frozen during animation frame
callbacks. This meant that the timeline was able to advance during other
tasks. 

This patch allows the clock to advance once per task, either to the
compositor supplied frame start time or to an approximation of the next
expected frame time.

http://dev.w3.org/fxtf/web-animations/#script-execution-and-live-updates-to-the-model

BUG=367903

Review URL: https://codereview.chromium.org/251183006

git-svn-id: svn://svn.chromium.org/blink/trunk@173583 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173562

BUG=361729
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/268363015

git-svn-id: svn://svn.chromium.org/blink/trunk@173582 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds another speculative assert in deepestBlockContainingAllText
to check for containingBlock() returning null which it can when the
subtree is detached.

I wasn't able to hit this in a synthetic test so this patch is a
speculative fix. If this improves stability we can consider guarding
all of the containingBlock() calls.

BUG=370764

Review URL: https://codereview.chromium.org/273613002

git-svn-id: svn://svn.chromium.org/blink/trunk@173581 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=364139

Review URL: https://codereview.chromium.org/268363013

git-svn-id: svn://svn.chromium.org/blink/trunk@173580 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make HTMLAnchorElement.text getter behave according to specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/text-level-semantics.html#dom-a-text

According to the specification, the 'text' IDL attribute, on getting, must
return the same value as the textContent IDL attribute on the element. However,
Chromium was returning 'innerText' instead. Upon setting, Chromium was
correctly updating the 'textContent' attribute though.

The new behavior is consistent with Firefox 29 and IE11.

This CL is based on arv's comment at:
https://codereview.chromium.org/263353004/#msg2

R=arv@chromium.org, tkent@chromium.org
BUG=369950
TEST=fast/dom/HTMLAnchorElement/get-text.html

Review URL: https://codereview.chromium.org/272693002

git-svn-id: svn://svn.chromium.org/blink/trunk@173579 bbb929c8-8fbe-4397-9dbb-9b2b20218538

HTMLTableElement.insertRow()'s argument default value should be -1, not
0, as per the specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/tabular-data.html#htmltableelement

The new behavior matches the one of Firefox 29 and IE11.

R=arv@chromium.org, tkent@chromium.org
TEST=fast/dom/HTMLTableElement/insertRow-default-argument.html
BUG=369803

Review URL: https://codereview.chromium.org/270213007

git-svn-id: svn://svn.chromium.org/blink/trunk@173578 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173545

BUG=367088
TBR=dominik.rottsches@intel.com

Review URL: https://codereview.chromium.org/267363006

git-svn-id: svn://svn.chromium.org/blink/trunk@173577 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173545

BUG=367088
TBR=dominik.rottsches@intel.com

Review URL: https://codereview.chromium.org/270533006

git-svn-id: svn://svn.chromium.org/blink/trunk@173576 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add the DOM part of the picture element, without actually using it for anything useful just yet.

BUG=368830

Review URL: https://codereview.chromium.org/261823002

git-svn-id: svn://svn.chromium.org/blink/trunk@173575 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We can't use will-change: top (and similar) as a compositing trigger because it
changes the paint order by giving the RenderObject a RenderLayer of type
NormalLayer. That will cause us to paint incorrectly.

In a future CL, we could consider this property as a compositing hint if the
RenderObject already has a self-painting RenderLayer. However, let's first
restore correctness in the system before making that change.

R=esprehn@chromium.org
BUG=370604

Review URL: https://codereview.chromium.org/271753002

git-svn-id: svn://svn.chromium.org/blink/trunk@173574 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173545

BUG=367088
TBR=dominik.rottsches@intel.com

Review URL: https://codereview.chromium.org/268353007

git-svn-id: svn://svn.chromium.org/blink/trunk@173573 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This method returns false when isAcceleratedCompositingActive() is
not enabled. In the future this will always be enabled (at least for
callers of the compositeAndReadbackAsync() method), so having to
support a branch and NOTREACHED() at each call site it awkward.

Instead make this method ASSSERT(isAcceleratedCompositingActive()) and
not return a value.

R=abarth
BUG=251960

Review URL: https://codereview.chromium.org/263253002

git-svn-id: svn://svn.chromium.org/blink/trunk@173572 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=japhet@chromium.org
NOTRY=true
BUG=361729

Review URL: https://codereview.chromium.org/272693003

git-svn-id: svn://svn.chromium.org/blink/trunk@173571 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=38618
TEST=none
TBR=senorblanco

Review URL: https://codereview.chromium.org/276593002

git-svn-id: svn://svn.chromium.org/blink/trunk@173570 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Appears to break webkit_unit_tests:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/13112

> Use skia discardable memory for decoded images on Android.
> 
> BUG=330041
> 
> Review URL: https://codereview.chromium.org/266633010

TBR=reveman@chromium.org

Review URL: https://codereview.chromium.org/274563005

git-svn-id: svn://svn.chromium.org/blink/trunk@173569 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=370410
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/274763002

git-svn-id: svn://svn.chromium.org/blink/trunk@173568 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Confirmed with Firefox source code and some vague Wikipedia references, as well
as IE's behavior on a test image.

BUG=38618
TEST=none
TBR=senorblanco

Review URL: https://codereview.chromium.org/279433002

git-svn-id: svn://svn.chromium.org/blink/trunk@173567 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change turns ScriptLoader a ResourceOwner, that ensures that
it subscribes Resource if the owner has a reference to it, and that
it unsubscribes the Resource otherwise. Before this change,
There are some situation where ScriptLoader has a reference to Resource
but doesn't subscribe it, that is error prone and left deleted instance
being subscribed. ResourceOwner guarantees reference and subscription
consistency.

TEST=script-cancel-crash.html
BUG=368551
R=eseidel@chromium.org, japhet@chromium.org, esprehn@chromium.org

Review URL: https://codereview.chromium.org/271533002

git-svn-id: svn://svn.chromium.org/blink/trunk@173566 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ajuma@chromium.org

Review URL: https://codereview.chromium.org/269343005

git-svn-id: svn://svn.chromium.org/blink/trunk@173565 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove bad assertion in SVGSMILElement's constructQualifiedName() by passing
IGNORE_EXCEPTION instead ASSERT_NO_EXCEPTION to Document::parseQualifiedName().
The constructQualifiedName() function handles parseQualifiedName() failures
propertly by returning early so there is no reason to assert on parsing
failures.

R=pdr@chromium.org, eseidel@chromium.org
BUG=368325
TEST=svg/custom/bad-attributeName-crash.html

Review URL: https://codereview.chromium.org/271693003

git-svn-id: svn://svn.chromium.org/blink/trunk@173564 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to the stack at crbug.com/367210 it is believed that the crash is a result of null RenderView,
since a plugin is running a script that adds a new HTMLImageElement during the document teardown.
This CL adds a null check for such a case, as well as a fixme, so that null check can be removed once the underlying issue is resolved.

BUG=367210, 371084

Review URL: https://codereview.chromium.org/271613004

git-svn-id: svn://svn.chromium.org/blink/trunk@173563 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361729

Review URL: https://codereview.chromium.org/267323005

git-svn-id: svn://svn.chromium.org/blink/trunk@173562 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173545

BUG=367088
TBR=dominik.rottsches@intel.com

Review URL: https://codereview.chromium.org/270403003

git-svn-id: svn://svn.chromium.org/blink/trunk@173561 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Cleanup change to the createImageCHROMIUM api to follow up https://codereview.chromium.org/255713008/

BUG=

Review URL: https://codereview.chromium.org/267283003

git-svn-id: svn://svn.chromium.org/blink/trunk@173560 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This member variable and m_viewportConstrainedLayersNeedingUpdate aren't used
by anything.

R=vollick@chromium.org

Review URL: https://codereview.chromium.org/270633003

git-svn-id: svn://svn.chromium.org/blink/trunk@173559 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=370814
TBR=dominicc@chromium.org,dglazkov@chromium.org

Review URL: https://codereview.chromium.org/273523006

git-svn-id: svn://svn.chromium.org/blink/trunk@173558 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We've decided not to ship this configuration. The implementation also doesn't
work because it incorrectly changes the paint order of elements with
will-change: contents by make them into a NormalLayer.

R=esprehn@chromium.org
BUG=370604

Review URL: https://codereview.chromium.org/270383002

git-svn-id: svn://svn.chromium.org/blink/trunk@173557 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173545

BUG=367088
TBR=dominik.rottsches@intel.com

Review URL: https://codereview.chromium.org/270753002

git-svn-id: svn://svn.chromium.org/blink/trunk@173556 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=370149

Review URL: https://codereview.chromium.org/273503004

git-svn-id: svn://svn.chromium.org/blink/trunk@173554 bbb929c8-8fbe-4397-9dbb-9b2b20218538