- 25 Dec, 2020 18 commits
-
-
Kuo Jen Wei authored
Replace all calc(0px - ...) with calc(-1 * ...) for avoiding 'Use "0" for zero-width lengths (i.e. 0px -> 0)' presubmit warning. Bug: b/172340545 Test: Manually check all layout looks the same. Change-Id: I7a5b80da98f9248ebb929eb576bae9845e781442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602055 Commit-Queue: Inker Kuo <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#839308}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/59e5b444..c1afed6d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6e632f80c02d0de292107479811eb1d861adb841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603545Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839307}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/33079a7c5a98..5a107d009bac 2020-12-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 715a601a to 3aea2528 (65 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bungeman@google.com Change-Id: I804b4013af8cac1face976580ccfa4223b189bf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603544Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839306}
-
Kuo Jen Wei authored
To avoid scrollbar thumb being covered by edge-fading effect, this CL reimplements the effect by covering the fading area with gradient background |before|, |after| of |div#mode-selector|, using |calc()| with extracted |--scrollbar-height| variable to ensure their height won't overrun onto scrollbar thumb. Bug: b/176209338 Test: Manually check fading effect in both rtl and ltr layout. Change-Id: I86b6943a5f041b05287dcc7151075f67950cbcde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601981Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1608767282-83d533bf0c6d8552268a5dae9b5fbaf3cb0c558d.profdata to chrome-win64-master-1608853059-0dcfb673635de803fb698f0d0400a1fa42afd5b9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4bbe99411749a210d8dcd301ba060116dc1b5a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603480Reviewed-by:
-
Hiroki Sato authored
AX-Relnotes: n/a. Bug: none Test: unit_tests Change-Id: I12159738edf5c9be6c6ca2e830f8e3e266e13a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596670 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#839303}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9f0748eaa125..c6e63da8ed53 2020-12-25 syoussefi@chromium.org Suppress IOBlocksSeparate xfb test on AMD/Linux/GL If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I2ee49d54205a4642a01207cb711d76068f5d25b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603543Reviewed-by:
-
Satoshi Niwa authored
This flag will be still useful as an escape hatch or as a debugging option after the launch of ARC R. BUG=None TEST=trybot Change-Id: I060be7354d8636c6bb78cc6a20601f7cbdde2120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596572 Auto-Submit: Satoshi Niwa <niwa@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#839301}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fafa67016f36..c1fec5e03eca 2020-12-25 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie4e090e42c65e0c1cdc7e254b56b5036d56f3dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599395Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a8bf1679ab63..fa231668873c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC johannkoenig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: johannkoenig@google.com Change-Id: Id873b598e3bf0808e5dda2883dc9b8d5247b6f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603423Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839299}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=srinivassista@chromium.org Change-Id: I7ac4f6c6ad3afee0443e5c29a5cf790068322b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603579Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839298}
-
Tal Pressman authored
Change-Id: I3448e3a73e84981cc1a4f2c22aabb0ec5cfa703c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601893 Commit-Queue: Tal Pressman <talp@google.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Tal Pressman <talp@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#839297}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608830970-9befd678e76078f2c65564ac077af3538df4e10e.profdata to chrome-mac-master-1608853059-9800c03774f1d236dc7067221e3faf5369628854.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I35d4950920ea9c2129bce5b38b499edd5d95c734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603539Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1608830970-bef8b1aa7d39b4138181a62c506862672f366cdb.profdata to chrome-linux-master-1608853059-8a29d646ea3e5af684665e23d10e9ea9b05df2e0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7cff73a51f15e2e6dda0ee22b83fe5b892c927d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603538Reviewed-by:
-
Shik Chen authored
The barcode chip should be keep on the screen if the camera is still pointing to the barcode. This CL replaces the old fixed CSS animation duration with a resettable timer in JS. Bug: b/172879638 Test: Manually. Change-Id: I8759b4eadbe23d30930ece1209b7a7699a55f83f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602042 Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#839294}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I48da08b65156bfa3fd590a7f26656d70817fb159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603418Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839293}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ie90d4dff1f73e233ea0f9fafb3c8b5a7afd31ed6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603478Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/26c8aaadd1e1..9f0748eaa125 2020-12-24 ynovikov@chromium.org Skip TransformFeedbackTestES31.IOBlocks* on Linux AMD Vulkan If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I4964f4e3d73b1496d4b88c0bc589834026a6e9bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600595Reviewed-by:
-
- 24 Dec, 2020 22 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/58ce6ff51006..a8bf1679ab63 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I94844ea27cf9ae25560c09bf6e7ede777a079ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603399Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/67e12286df04..46ef281c525f 2020-12-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ib70dab1fd1d00fb9e2f77744ff0abac39a4437fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603479Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/40ac7da7..59e5b444 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I14a5c6dc8d6d6914a9336e182b599defb4a46257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600593Reviewed-by:
-
ssid authored
The crash traces will skip some of the upload limitations we have so that we can get more number of traces. Since crashes are rare, this should not affect many users. We would skip the one upload per week limit and crashes while tracing checks. This still does not workaround the network upload limit, incognito and crash reporting enabled checks. TBR=michaelbai@chromium.org Change-Id: I75de638611ccc276f6a73addff538c97629a23a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596440 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#839287}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I41a51d2ab50b89d5ac1634b6e3c6f8466951d204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602394Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839286}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1608787557-31ff0671a914778dedeecc66b385c527d4908f70.profdata to chrome-linux-master-1608830970-bef8b1aa7d39b4138181a62c506862672f366cdb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1a491b95a50d9ed0192cb25cec4063da0775c347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603166Reviewed-by:
-
Tim Volodine authored
This patch implements the remaining bits needed for the client-side phishing detection (CSPD) to work in weblayer. The classes ClientSideDetection{Host,Service} which previously lived in chrome/browser/safe_browsing/ have been moved to components. To make this move possible the relevant chrome dependencies have been removed and the necessary embedder specific bits extracted into the corresponding delegate interfaces. The chrome/ and weblayer/ implementations now provide their own implementations of the delegates which are then used by the ClientSideDetection{Host,Service} classes in components. In particular in this patch: - Extract embedder specific bits into delegate interfaces from the ClientSideDetection{Host,Service} code. - Componentize ClientSideDetection{Host,Service} code. - Add ClientSideDetection{Host,Service}Delegate embedder specific implementations in chrome/ and weblayer/. - Add factory for ClientSideDetectionService in weblayer. - Add SafeBrowsingTabObserver in weblayer which creates the host and service for each tab. It is itself created in TabImpl constructor. - Update GetSafeBrowsing{UI,DB}Manager signatures in weblayer's SafeBrowsingService. - Update traffic annotations. - Update existing tests and includes. - Add weblayer browsertests. The weblayer CSPD code follows chrome's implementation, with the relevant bits replaced by the weblayer analogues/implementations. BUG=1138995,1115700 TBR=haraken@chromium.org Change-Id: I5c15f747db4529cf8987b18ecd803701ee72679e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584982 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:Clark DuVall <cduvall@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#839284}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9ad6182f4408..58ce6ff51006 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I02e32a945a26ab25d13ef13bafadf5a5c8924a30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603397Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608787557-11e1f998b809b7ef9fcada523ed8459afde2ca06.profdata to chrome-mac-master-1608830970-9befd678e76078f2c65564ac077af3538df4e10e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I478f0aac1888138224f67b0b03e9b6d747549c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603164Reviewed-by:
-
David Black authored
After view destruction layer animations will immediately advance to end. This causes unowned animation observers to run their callbacks which attempt to access the destroyed view. This CL ensures that unowned animation observers are still cleaned up but only invoke view methods while the view is still alive. Bug: 1154998 Change-Id: I20e44a60565f8d15926190021d1f6ca94e007542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603044Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#839281}
-
Mihai Sardarescu authored
This CL starts using the new OnPrimaryAccountChanged events in the IdentityManager code. It also fixes a few issues related to the way the PrimaryAccountChangeEvent was created when sync consent was revoked. This CL also updates test UKMTest.singleSyncSignoutCheck() to turn sync on as it is intended (calling setUpAccountAndSignInForTesting() did not enabled sync, so this test was incorrect and was now failing as I fixed a wrong notification sent when the user signs out without enabling sync). Bug: 1158855 Change-Id: I8f843dd0c0e3e4a0e372a36a23441cce74167292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602416 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#839280}
-
Mario Sanchez Prada authored
This reverts commit 3e0f4064. Reason for revert: This CL made the test MediaSessionBrowserTest.WebContents_Muted flaky. Original change's description: > Migrate MediaPlayerDelegateHostMsg_OnMedia{Playing,Paused} to mojo > > Migrate these legacy IPC messages to the media.mojom.MediaPlayerObserver > mojo interface, implemented by MediaSessionController in the browser > process, and update callers in the renderer process. > > Relevant design document: > https://docs.google.com/document/d/1OLMNxLvGkRO6ju_WfHbRMrgaVnW7bsMnW7XlJQI0A2E > > Bug: 1039252 > Change-Id: I40b5263f00bb2abe82e234a4e369df8732407d7f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561389 > Commit-Queue: Mario Sanchez Prada <mario@igalia.com> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#839275} TBR=kinuko@chromium.org,haraken@chromium.org,mlamouri@chromium.org,chcunningham@chromium.org,beccahughes@chromium.org,mario@igalia.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I9fc25228f0b879d63e19a269d9d46021ceadacf7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1039252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598901Reviewed-by:
Mario Sanchez Prada <mario@igalia.com> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#839279}
-
Findit authored
This reverts commit af61f076. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 839276 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2FmNjFmMDc2OGE4Njc2NGE1YTY1MTJkNTcyMWJhMjg5MjQyN2I5OWQM Sample Failed Build: https://ci.chromium.org/b/8860005635688044320 Sample Failed Step: compile Original change's description: > ImageData: Fix serialization of detached buffers > > This changes to match previous behavior where serialization would > succeed, but the result would fail during deserialization. > > This was crashing because it called ImageBuffer::GetSkPixmap while > the buffer was detached. Add a CHECK to ensure that this sort of > bug happens more dramatically in the future. > > Add a test. > > Bug: 1161498 > Change-Id: I1c6d58433b2f148e726681c628410caca1bf5300 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603038 > Commit-Queue: ccameron <ccameron@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#839276} Change-Id: I862988d7ae8947f8ba2d061e25aceeaf4ffd838c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1161498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600594 Cr-Commit-Position: refs/heads/master@{#839278}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e2c48afdd80d..9ad6182f4408 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1139098,chromium:1161396 Tbr: Change-Id: I16724164d971176a9a1cdd57347e392c2aff3dc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601294Reviewed-by:
-
Christopher Cameron authored
This changes to match previous behavior where serialization would succeed, but the result would fail during deserialization. This was crashing because it called ImageBuffer::GetSkPixmap while the buffer was detached. Add a CHECK to ensure that this sort of bug happens more dramatically in the future. Add a test. Bug: 1161498 Change-Id: I1c6d58433b2f148e726681c628410caca1bf5300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603038 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#839276}
-
Mario Sanchez Prada authored
Migrate these legacy IPC messages to the media.mojom.MediaPlayerObserver mojo interface, implemented by MediaSessionController in the browser process, and update callers in the renderer process. Relevant design document: https://docs.google.com/document/d/1OLMNxLvGkRO6ju_WfHbRMrgaVnW7bsMnW7XlJQI0A2E Bug: 1039252 Change-Id: I40b5263f00bb2abe82e234a4e369df8732407d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561389 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#839275}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/789bfeb2..40ac7da7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7c3dc28c12ecdf5813e885e01a4943f204e14241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603162Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a281380c8e26..7a1af10b707b 2020-12-24 chrome-bot@chromium.org Update config settings by config-updater. 2020-12-24 chrome-bot@chromium.org Update config settings by config-updater. 2020-12-23 lamontjones@chromium.org config: enable HW tests for eve-kernelnext If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I3eb582c8be1f36b0ccea04f6018a66fbf2d796d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603021Reviewed-by:
-
Tim Volodine authored
ReadLaterIphTest#testShowBookmarksReadLaterIPH is very flaky on android-arm64-beta-tests bot. BUG=1161737 TBR=shaktisahu@chromium.org Change-Id: I5b2749feafee24277037734d9160150c317e12a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600915Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#839272}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f4dec18e935b..e2c48afdd80d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I7fdc7ef06b27f764f3b4d661a85e8284db5700b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603396Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202012240600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/Ot222ZkhWE_CCmp_BEURD6tXpvwOmgCUpa0le6qaZD8C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/174321021,b/176201275 Tbr: help-app@grotations.appspotmail.com Change-Id: If254ca77429e08ff9cf99d02c4d8d33ebf0d6e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603179Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/949ec59fd819..a45df0b3491e 2020-12-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision cc240573..8baa5d6f (839139:839243) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If5604f2e8c09fc9f4d7c36cf7475a122464a7fa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603118Reviewed-by:
-
