GitLab

This stuff is needed to get blink linking in android.

R=brettw@chromium.org,fbarchard@chromium.org

Review URL: https://codereview.chromium.org/541953002

Cr-Commit-Position: refs/heads/master@{#293668}

Let's let the compiler do its job :). As mentionned in https://codereview.chromium.org/532533002/ this preprocessor precondition is useless as the linker will removed the unreferenced code anyway, and this break the PGO build.

TBR=magjed, tommi
NOTRY=true

Review URL: https://codereview.chromium.org/546043003

Cr-Commit-Position: refs/heads/master@{#293667}

BUG=387288

Review URL: https://codereview.chromium.org/547593002

Cr-Commit-Position: refs/heads/master@{#293666}

Revert of Cast: Re-factor rtcp_sender.cc into rtcp_builder.cc and do some cleanup (patchset #3 id:40001 of https://codereview.chromium.org/513313004/)

Reason for revert:
Caused cast_unittest rtcp test failures on Linux Asan Lsan builders (memory leaks).

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/7132

Original issue's description:
> Cast: Re-factor rtcp_sender.cc into rtcp_builder.cc and do some cleanup
>
> Committed: https://chromium.googlesource.com/chromium/src/+/6217e450d9e75037c62fff773c94aebe7f3ed2e6

TBR=miu@chromium.org,hubbe@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/541293004

Cr-Commit-Position: refs/heads/master@{#293665}

Cr-Commit-Position: refs/heads/master@{#293664}

To support unbundled updates we need to stop depending on system
libraries. Disable using the system version of libjpeg and instead link
Chromium's libjpeg_turbo.

This increases binary size by ~120KB.

BUG=409851

Review URL: https://codereview.chromium.org/548513002

Cr-Commit-Position: refs/heads/master@{#293663}

https://skia.googlesource.com/skia/+log/ce23aaee8dfb3dff1acc2294f775e4f3fcf002ba..9f8cab153878f6e88190c5e2ef572ee708791177

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/549923002

Cr-Commit-Position: refs/heads/master@{#293662}

Removing LOG(WARNING) from DataReductionProxyUsageStats that made it in https://codereview.chromium.org/510353004/

BUG=409934

Review URL: https://codereview.chromium.org/547753003

Cr-Commit-Position: refs/heads/master@{#293661}

Cr-Commit-Position: refs/heads/master@{#293660}

Review URL: https://codereview.chromium.org/513313004

Cr-Commit-Position: refs/heads/master@{#293659}

BUG=409705

Review URL: https://codereview.chromium.org/545683003

Cr-Commit-Position: refs/heads/master@{#293658}

Review URL: https://codereview.chromium.org/535773002

Cr-Commit-Position: refs/heads/master@{#293657}

If a mask layer's width or height are larger than the max texture size,
we do not use the contents of the mask layer. So if we're not going to
use the contents, there's no reason to make tiles and allocate memory
for them.

This changes PictureLayerImpl to return an empty tile size for masks
that are too large to have tiles. Then changes PictureLayerTiling to
use the empty tile size as a signal to make the whole tiling an empty
size.

Last, we use the empty tile size to also signal not making a low res
tiling, so that masks continue to not get a low res tiling if they are
large.

R=enne, vmpstr
BUG=409984

Review URL: https://codereview.chromium.org/547463002

Cr-Commit-Position: refs/heads/master@{#293656}

They are:
- app_locale_settings.h
- ui_unscaled_resources.h
- webui_resources.h

BUG=401588
TEST=None
R=thestig@chromium.org,thakis@chromium.org
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/530623002

Cr-Commit-Position: refs/heads/master@{#293655}

behind the fullscreen and profile buttons.
Calculate the maximum number of times we can show and hide the rest, similar
to how it works on Linux and Windows.
Also changed so that only the one active tab has a bigger minimum width (and
draws the close button) instead of potentially multiple selected tabs. This also
matches Linux and Windows.

BUG=392137

Review URL: https://codereview.chromium.org/476313003

Cr-Commit-Position: refs/heads/master@{#293654}

Revert of [Mac] Shut down connections to WindowServer before engaging the sandbox. (patchset #1 id:1 of https://codereview.chromium.org/545603002/)

Reason for revert:
Speculative revert: seems this change caused 135 layout tests failures on the webkit mac builders, from OSX 10.6-10.9

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20%28deps%29/builds/30830

Original issue's description:
> [Mac] Shut down connections to WindowServer before engaging the sandbox.
>
> The connection is only needed during sandbox warmup to initialize the default
> color space. It was formerly needed by scrollbar NSAnimations, but that was
> replaced via https://codereview.chromium.org/529103002/.
>
> BUG=397642,306348
> TEST=Manually tested on 10.6-10.10.
> R=avi@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/d9707172e540487d14c53363c5d1c2151999c2d8

TBR=avi@chromium.org,rsesek@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=397642,306348

Review URL: https://codereview.chromium.org/550763002

Cr-Commit-Position: refs/heads/master@{#293653}

BUG=411648
TBR=hans@chromium.org

Review URL: https://codereview.chromium.org/548083002

Cr-Commit-Position: refs/heads/master@{#293652}

https://skia.googlesource.com/skia/+log/a1ae66d252edf6da932caed1fe43d11216e56c0e..ce23aaee8dfb3dff1acc2294f775e4f3fcf002ba

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/550743002

Cr-Commit-Position: refs/heads/master@{#293651}

In https://chromiumcodereview.appspot.com/473583002/ we removed a
'shadow' element in thumbnail <iframe> to improve customization. A side
effect is that this exposes the thumbnail image, thereby alow the user
to futilely access the chrome-search://thumb/#/# image below. This CL
adds back a transparent "blocker" in front of the thumbnail to restore
old behavior. Also making 2 CSS changes to:
- Fix fake box text positioning for RTL.
- Move top-margin back from #ntp-contents to #logo, for correctness.

BUG=411005

Review URL: https://codereview.chromium.org/542033002

Cr-Commit-Position: refs/heads/master@{#293650}

BUG=411565

Review URL: https://codereview.chromium.org/549723002

Cr-Commit-Position: refs/heads/master@{#293649}

BUG=411473
TBR=rtenneti@chromium.org

Review URL: https://codereview.chromium.org/554453002

Cr-Commit-Position: refs/heads/master@{#293648}

Should help to investigate sandbox failures on user side.
Logs from the attached bug have records about failed start of utility process, but without clues about cause.

BUG=408184

Review URL: https://codereview.chromium.org/546903002

Cr-Commit-Position: refs/heads/master@{#293647}

Content/public/app was messed up and didn't link everything properly, so this separates it out into browser and child like content/app is.

R=jamesr@chromium.org
Reland of https://codereview.chromium.org/545313002/ but with public/utility dependency added

TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/549863004

Cr-Commit-Position: refs/heads/master@{#293646}

Typecheck chrome://help using CompilerPass.java, everything except dependency to options and Element.prototype.contains(Node)

R=dbeam@chromium.org
BUG=393873
TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/help/compiled_resources.gyp && ninja -C out/Default

Review URL: https://codereview.chromium.org/443553002

Cr-Commit-Position: refs/heads/master@{#293645}

It doesn't need to run in Chrome's unit_tests suite.

BUG=397164
TEST=extensions_unittests

Review URL: https://codereview.chromium.org/546933002

Cr-Commit-Position: refs/heads/master@{#293644}

They don't need to run in Chrome's unit_tests

BUG=397164
TEST=extensions_unittests

Review URL: https://codereview.chromium.org/545293002

Cr-Commit-Position: refs/heads/master@{#293643}

Also ensure that if we don't post the callback to the java side to run the js dialog callback in the embedding app that we run the callback.

BUG=411399

Review URL: https://codereview.chromium.org/545963002

Cr-Commit-Position: refs/heads/master@{#293642}

BUG=405765

Review URL: https://codereview.chromium.org/546673002

Cr-Commit-Position: refs/heads/master@{#293641}

Rename private methods for consistency: Start*() for something that invokes
an async operation and Handle*() for something that gets called back by such
an operation.  That leaves On*() reserved for observers.  Also update some
comments.  Lastly, use the current state key from the parameter passed to
HandleStateKeysResult() instead of requesting it again from the broker (line
222).

EnrollmentHandlerChromeOS and EnrollmentScreen: Don't report metrics on
unreached code paths.  Generally, remove some obsolete instances of
NOTREACHED() after switches over enums:  The compiler ensures that all enum
values are covered, there's no need to complicate the code by checking the
same thing again.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290841

Review URL: https://codereview.chromium.org/465413002

Cr-Commit-Position: refs/heads/master@{#293640}

On android platform, it often fails to fetch searchdomaincheck url right
after network changes because of conflict between DNSObserver::OnDNSChanged
event and NetworkChangeObserver::OnNetworkChanged event.
This patch enables re-fetching when such conflict happens.

BUG=407442

Review URL: https://codereview.chromium.org/544833002

Cr-Commit-Position: refs/heads/master@{#293639}

Currently this is either a list or a string. However, this is causing some problems because templates can't add to the invoker's visibility list without knowing if the original is a string or a list.

In an effort to make this consistent, I'm converting all visibiltiy to be lists, and will remove support for strings in a future build.

This exempts cld from header checking since it was confusing GN's header checker. It adds a ppapi header target as well that will be used by libyuv (that requires a roll).

TBR=scottmg

Review URL: https://codereview.chromium.org/544423002

Cr-Commit-Position: refs/heads/master@{#293638}

chrome.tabs.onUpdated may fire when the listener is not set up yet.

BUG=

Review URL: https://codereview.chromium.org/537953002

Cr-Commit-Position: refs/heads/master@{#293637}

R=dbeam@chromium.org
BUG=393873
TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/options/compiled_resources.gyp && ninja -C out/Default | grep WARNING

Review URL: https://codereview.chromium.org/517413002

Cr-Commit-Position: refs/heads/master@{#293636}

BUG=411648,82385
TBR=hans@chromium.org

Review URL: https://codereview.chromium.org/550713002

Cr-Commit-Position: refs/heads/master@{#293635}

content: Make sure GpuProcessHost replies to all outstanding CreateGpuMemoryBuffer requests when GPU process dies.

BUG=
R=piman@chromium.org

Review URL: https://codereview.chromium.org/547073002

Cr-Commit-Position: refs/heads/master@{#293634}

BUG=None

Review URL: https://codereview.chromium.org/542413002

Cr-Commit-Position: refs/heads/master@{#293633}

In the SingleThreadProxy+SchedulerClient patch,
LayerTreeHostClient::Layout is now called via DoCommit which is called
via Composite(Immediately).  In no cases should the embedder call
Layout() manually.

R=danakj@chromium.org,piman@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/545343003

Cr-Commit-Position: refs/heads/master@{#293632}

BUG=404893

Review URL: https://codereview.chromium.org/549553002

Cr-Commit-Position: refs/heads/master@{#293631}

To make things simpler, also make congestion control into an interface with
fixed and adaptive implementations.

BUG=405622

Review URL: https://codereview.chromium.org/542883004

Cr-Commit-Position: refs/heads/master@{#293630}

This adds methods to SingleThreadProxy to support impl-side painting
when using the scheduler.  This allows most unit tests to test impl-side
painting classes through both the single and threaded paths.

The biggest caveat to this approach is the "commit waits for activation"
logic that mailboxes want to use.  Because there is no easy way to block
the only thread there is while activation happens, activation always
happens immediately during commit, even if the tree is not ready.  To
cause the tree to wait to draw until it is ready, drawing is prevented
via SetRequiresHighResToDraw.  This prepares the way for the future
where the SingleThreadProxy will likely commit directly to the active
tree.

The synchronous CompositeImmediately function does not support impl-side
painting yet.  This is the path used by everything but unit tests at
this point.

R=danakj@chromium.org
BUG=329553

Review URL: https://codereview.chromium.org/508373002

Cr-Commit-Position: refs/heads/master@{#293629}