- 25 Nov, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f1d198eaf22f..f26135c33f22 Created with: gclient setdep -r src-internal@f26135c33f22 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I2b0852b961a82607a5d3923198dc9323b169d4e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934164Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718629}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a2ebcd22. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ib6f556fdd1b0b3fd7ee6096ec603beefafb5b49b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933483Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718628}
-
Andreas Haas authored
The next data structure we change to size_t. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: I586fcb0c0fcbc7be30c6c617eeab037b64af7c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930826Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#718627}
-
Francois Doray authored
Testing in a slow build (e.g. debug) shows that there can be nested main frame navigations in a WebContents. For example: WebContentsObserver::DidStartNavigation() a.com WebContentsObserver::DidStartNavigation() b.com WebContentsObserver::DidFinishNavigation() a.com WebContentsObserver::DidFinishNavigation() b.com Also, FirstWebContentsProfiler may be created when DidStartNavigation() has not been dispatched yet. This CL handles this by tracking the first top-level navigation id observed by DidStartNavigation() or DidFinishNavigation(). Once the first top-level navigation id is set, if DidStartNavigation() observes a different top-level navigation id, profiling is aborted. Bug: 1026053, 1022492 Change-Id: Ieff3e67ddd1a5a8ce5f2406a10cfe137a083d2ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924699 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#718626}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=mcasas@chromium.org Bug: 1023677 Change-Id: I1e859f39bbeff1f234af35f21c6194ad74014dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924805 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#718625}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=mcasas@chromium.org Bug: 1023677 Change-Id: Ie3adc120e44ee5e9a758a2dad85b65d76bf334c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927010 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
Renato Silva authored
Moves the error messages from the footer-container in 'oobe-dialog' to the subtitle area. Tested locally. Bug: 994515 Change-Id: Ice89a651298a7872797bcab6bd02a49b628f452c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921980 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#718623}
-
Maksim Moskvitin authored
In case some datatype entries changes too often they could bypass nudge delay and trigger infinite (or too long) commit cycle. This happened because we asked for contributions in a cycle until we have no entries to commit. This CL changes this behavior: commit cycle is exited once we committed less than max_commit_batch_size() and it wasn't caused by Nigori commit (which blocks contributions from regular datatypes). There are some small refactorings to avoid API misuse in the future: CommitProcessor is now owned by BuildAndPostCommits() and there is no way to change commit_types in the middle of commit construction. kSyncPreventCommitsBypassingNudgeDelay can be used to revert behavioral changes in case there are some unexpected side effects. Bug: 1022293 Change-Id: I19f2bba09396cde0cf0d415e929f34189e80ac0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904068 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#718622}
-
Friedrich Horschig authored
The linked bug shows crashes that might have to causes: * without focused frame, creating the factory fails * the factory is created successfully but the manager is invalid (this might be the default case for Android WebViews) This CL aims to fix both crashes by returning early in all methods that require a frame or manager to do their work. Bug: 1023241 Change-Id: I14ff3ef96a4d0bef22059b12cc5f872fb1d7897b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932899Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#718621}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4a5ee9541e55..b245e85651eb git log 4a5ee9541e55..b245e85651eb --date=short --no-merges --format='%ad %ae %s' 2019-11-25 fmayer@google.com Merge "Add data source names to data_source_config proto." Created with: gclient setdep -r src/third_party/perfetto@b245e85651eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib833f1cfb6ecc7f2e70c1cdc8d77215d6d0de220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934098Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718620}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ad9d72b765c5..204f9ad496e5 git log ad9d72b765c5..204f9ad496e5 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 almuthanna@google.com Create Karma tests for Progress.js 2019-11-25 tvanderlippe@chromium.org Add TypeScript Ninja integration 2019-11-25 janscheffler@chromium.org Show cookies after reloading a single resource 2019-11-25 almuthanna@google.com Revert "Cover find function and modify Karma reporting" Created with: gclient setdep -r src/third_party/devtools-frontend/src@204f9ad496e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic5c8bac792d406e068dc6df9c77c117ef68423f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934101Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8f2a89dc..7b44da5f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I843da5456272955b8afa55bdda464ff81d2e7467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933482Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718618}
-
Wei-Cheng Xiao authored
We'll keep using the metrics to track number of parallel tasks in cryptohome, so keep the historgram. Bug: 1025885 Change-Id: Idb9e038565a82036b3a0a372dbe31728b2b286e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924335Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Wei-Cheng Xiao <garryxiao@chromium.org> Auto-Submit: Wei-Cheng Xiao <garryxiao@chromium.org> Cr-Commit-Position: refs/heads/master@{#718617}
-
Mathias Carlen authored
This patch waits for the initial loadUrl to be done before running the rest of the direct action availability tests. Running this 20x locally resulted in no flakes. R=arbesser@google.com Bug: 1027688 Change-Id: I04cd376160b8a62dd475a94abfb3311d2890b206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932898Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#718616}
-
Maksim Sisov authored
As stated in https://crrev.com/c/1917765, to provide more flexibility and avoid casts to PlatformWindowLinux, the extension interfaces were added instead. This fixes the crash when Ozone for Linux is run with --ozone-platform=headless. Please note that the most x11 specific interfaces will be removed as soon as there are no callers for them. Bug: 1016556 Change-Id: I90591fc6e2e2fd776685384a05cc3f9bdd770fc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917536 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#718615}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5d1805321ee6..f1d198eaf22f Created with: gclient setdep -r src-internal@f1d198eaf22f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:None Tbr: jbudorick@google.com Change-Id: I8a1e1b629954f00377e4e4a2f1969e4713e6d4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934100Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/31b01c053492..eac63e7e0262 git log 31b01c053492..eac63e7e0262 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 yvesg@webrtc.org Remove temporary workaround for generate_licenses. Created with: gclient setdep -r src/third_party/webrtc@eac63e7e0262 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I29060ff496613175914695dca2ad218163dc334f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934097Reviewed-by:
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Convert BUILD.gn files below //ui to instead use conditional to include source files only on the platformn where they are used. The conversion was done by using a modified version of gn that display all files filtered by set_sources_assignment_filter() and updating the BUILD.gn files manually to explicitly add the source files only on the platform that used them. This CL was uploaded by git cl split. Bug: 1018739 Change-Id: I3e857ca87a2bcadc4ff1f95c501c0b59d8786b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930829Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#718612}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Convert BUILD.gn files below //ui to instead use conditional to include source files only on the platformn where they are used. The conversion was done by using a modified version of gn that display all files filtered by set_sources_assignment_filter() and updating the BUILD.gn files manually to explicitly add the source files only on the platform that used them. This CL was uploaded by git cl split. Bug: 1018739 Change-Id: I27b45e7f11292110fe046a7c6a20aac45fd6998c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930805Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#718611}
-
David Roger authored
Change-Id: I168a0748cf644098c78066210d0642d2517311b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932545 Commit-Queue: David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#718610}
-
Oriol Brufau authored
This patch adds support for a ::marker PseudoElement that obeys the 'content' property similarly to ::before and ::after. This PseudoElement is only generated when 'content' is not 'normal', otherwise the marker continues being an anonymous box. This will be addressed in a follow-up patch. Also, this only works in LayoutNG, since the legacy LayoutListMarker doesn't allow children. Will also be addressed in a follow-up patch. Spec: https://drafts.csswg.org/css-pseudo-4/#marker-pseudo Bug: 457718 TEST=external/wpt/css/css-pseudo/marker-content-003.html TEST=external/wpt/css/css-pseudo/marker-content-003b.html TEST=external/wpt/css/css-pseudo/marker-content-004.html TEST=external/wpt/css/css-pseudo/marker-content-006.html Change-Id: I34097f9763cec626e898aff07681cd3e766afb49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930835Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#718609}
-
Alexander Hendrich authored
Following the translators guidance and renaming 'login' to 'sign-in'. Bug: b/144558524 Change-Id: Ib367e085a77e24e030fe158aca5d3c8a02ac124a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932897 Auto-Submit: Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#718608}
-
Antonio Gomes authored
... and RTCStatsResponseBase. It is also possible to merge RTCStatsResponse and RTCStatsResponseBase in a future step, once they are both solely used in renderer/modules/peerconnection. Today, there is still some code in renderer/platform using RTCStatsResponseBase. BUG=787254, 919392 R=guidou@chormium.org, haraken@chromium.org Change-Id: I788a81507447d990ca7d047d4a370f3bf8ec73d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930941 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9f9b8c9c. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I08ce0cdebb5b33c66d1c3e999bfefde3ca8744b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933481Reviewed-by:
-
sreejakshetty@chromium.org authored
- Add kBackForwardCacheMemoryControl feature which can be controlled via experiment. - Introduce "memory_threshold_for_back_forward_cache_in_mb" to control the factor via experiment. Bug: 1017090 Change-Id: I44d95da16f4023ea5b8ad890dd539784c74006c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875091Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#718605}
-
Colin Blundell authored
This class will shortly be supplied to blocking pages other than SSLBlockingPage (e.g., in supporting captive portals). Hence, make it visible. Bug: 1025059 Change-Id: I9713fd160774ef8903ff217c76594ec17e3a732e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932437Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#718604}
-
Colin Blundell authored
This addition is necessary following https://chromium-review.googlesource.com/c/chromium/src/+/1926471; without it, weblayer_shell crashes at startup on Android due to not being able to find safe browsing Java files. Change-Id: I506f1f0c28304e963780829b3e6bf172ee03ca60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932798Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#718603}
-
Tsuyoshi Horo authored
Bug: 1026147 Change-Id: I059799f7055c9eca1e6605838b061a7ca46c57cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930354Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#718602}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b1393d70e91a..04e074d1aae0 git log b1393d70e91a..04e074d1aae0 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-headers/src 24347673152e..2b89fd4e2734 (1 commits) 2019-11-25 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 131a1ba8d06a..afc52b0b26d7 (7 commits) 2019-11-25 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 43fe7bafb14e..38b4db48f98c (4 commits) Created with: gclient setdep -r src/third_party/angle@04e074d1aae0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None,chromium:None,chromium:None Tbr: cwallez@google.com Change-Id: I3565f0db23e532857e917974bc340b12a252c9b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934095Reviewed-by:
-
Tim Schumann authored
This reverts commit 13ea1158. Reason for revert: Suspected to have broken the fuchsia-x64-dbg CI: instance: https://ci.chromium.org/p/chromium/builders/ci/fuchsia-x64-dbg/3167 logs: https://ci.chromium.org/p/chromium/builders/ci/fuchsia-x64-dbg [3236/8507] SOLINK ./lib/libpolicy_component.so FAILED: lib/libpolicy_component.so lib/libpolicy_component.so.TOC lib.unstripped/libpolicy_component.so python "../../build/toolchain/gcc_solink_wrapper.py" --readelf="readelf" --nm="nm" --strip=../../buildtools/third_party/eu-strip/bin/eu-strip --sofile="./lib.unstripped/libpolicy_component.so" --tocfile="./lib/libpolicy_component.so.TOC" --output="./lib/libpolicy_component.so" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -Wl,-soname="libpolicy_component.so" -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -fuse-ld=lld -Wl,--color-diagnostics --target=x86_64-fuchsia -Wl,-z,stack-size=0x800000 -Wl,--no-as-needed -lfdio -Wl,--as-needed -m64 -Werror -nostdlib++ --sysroot=../../third_party/fuchsia-sdk/sdk/arch/x64/sysroot -L../../third_party/fuchsia-sdk/sdk/arch/x64/lib -o "./lib.unstripped/libpolicy_component.so" @"./lib/libpolicy_component.so.rsp" ld.lld: error: undefined symbol: MutableProfileOAuth2TokenServiceDelegate::MutableProfileOAuth2TokenServiceDelegate(SigninClient*, AccountTrackerService*, network::NetworkConnectionTracker*, scoped_refptr<TokenWebData>, signin::AccountConsistencyMethod, bool, base::RepeatingCallback<bool ()>) >>> referenced by profile_oauth2_token_service_builder.cc >>> obj/components/signin/internal/identity_manager/identity_manager/profile_oauth2_token_service_builder.o:(std::__Cr::__unique_if<MutableProfileOAuth2TokenServiceDelegate>::__unique_single std::__Cr::make_unique<MutableProfileOAuth2TokenServiceDelegate, SigninClient*&, AccountTrackerService*&, network::NetworkConnectionTracker*&, scoped_refptr<TokenWebData>&, signin::AccountConsistencyMethod&, bool&, base::RepeatingCallback<bool ()> >(SigninClient*&, AccountTrackerService*&, network::NetworkConnectionTracker*&, scoped_refptr<TokenWebData>&, signin::AccountConsistencyMethod&, bool&, base::RepeatingCallback<bool ()>&&)) clang: error: ld.lld command failed with exit code 1 (use -v to see invocation) Original change's description: > [signin] Do not build MultableProfileOAuth2TokenService delegate on ChromeOS and iOS > > Change-Id: I4ca19ca4996dc7caab44d75125040a20ae8e6649 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930818 > Commit-Queue: David Roger <droger@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718589} TBR=droger@chromium.org,msarda@chromium.org,sinhak@chromium.org Change-Id: I4c8d779ce984ffb30f155423e50e6e59a44a71ca No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932366Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#718600}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/693bde6a69a2..ad9d72b765c5 git log 693bde6a69a2..ad9d72b765c5 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 almuthanna@google.com Cover find function and modify Karma reporting 2019-11-25 yangguo@chromium.org Roll js_protocol.pdl and css_properties.json5 from upstream Created with: gclient setdep -r src/third_party/devtools-frontend/src@ad9d72b765c5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idb84a60c4720a301880f02366222335121a37659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934094Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cbc3e409299b..5d1805321ee6 Created with: gclient setdep -r src-internal@5d1805321ee6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I26aea55abde58c879a61c8caff42f33f257c7a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934096Reviewed-by:
-
David Roger authored
Fixed: 777774 Change-Id: I9abee0112f345ea4421c4f809588066f976fc645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929817 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#718597}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4a0fd75b105f..4a5ee9541e55 git log 4a0fd75b105f..4a5ee9541e55 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 lalitm@google.com Merge "trace_processor: migrate all slice/counter tests to use track instead of ref" Created with: gclient setdep -r src/third_party/perfetto@4a5ee9541e55 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ibe79cb744fc89c4737102118c6be96c3705a2ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934093Reviewed-by:
-
Mathias Carlen authored
Before this patch android specific build targets were not gated by the is_android build flag. In preparation of the autofill assistant extension api we need to be able to add autofill_assistant as deps to non android targets. This patch gates what's needed and exposes strings in the AA component so that it can properly build on non android platforms. R=arbesser@google.com Bug: b/143736397 Change-Id: Ic1c962fa795bd8cff3d043430fb2bf1f49165745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929223Reviewed-by:
-
Ross McIlroy authored
BUG=chromium:1028072 Change-Id: Ic71c6d0ad1d764a6b10619d641a4c42e90e8c448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932780 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#718594}
-
Renato Silva authored
Changes the direction of arrows on Chrome OS OOBE for RTL languages. OOBE Back and Next buttons now show the expected direction. Tested locally. Bug: 1016376 Change-Id: I8a00e900f9b3c02c9bca69a8f98d9c8a72244dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929829Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#718593}
-
Tanja Gornak authored
Bug: 1023813 Change-Id: I45edd98889dc82693ad3ea0cb16f2bf2d2e95db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911746Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#718592}
-
Olya Kalitova authored
Adds additional build deps to policy_fuzzer target so it would pass check on includes. Initial description: Initializes DBusThreadManager and CommandLine needed as a part of a policy_fuzzer setup. Test: gn gen out/libfuzzer --check Bug: 1015318 Change-Id: Iac41303e096b7a5f9ad664f228f58c336a64eaf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930809Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#718591}
-
Morten Stenshorne authored
We currently don't let a break before a float affect the appeal of breaking inside their container. This is possible and fairly straight-forward to implement, at least for floats that don't participate in an inline formatting context. Also, since we're not hooking the floats up to the break appeal system at all yet, we won't see class A breakpoints between floats, or between a float and an in-flow block, which the spec actually requires. Will get back to this when inline formatting context float fragmentation is supported. Being as consistent as possible regardless of a float belonging to an inline formatting context or not seems like a good idea. Let's figure out what's feasible for inline formatting context floats first. Bug: 829028 Change-Id: Iccb22d91865ca6aad464c2ee12462843281643a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929825Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#718590}
-
