- 30 Jan, 2020 40 commits
-
-
Xida Chen authored
TBR=odejesush@chromium.org NOTRY=true Bug: 1047282 Change-Id: I430d96beb39ddf88c3bc9ab94db49fdbb5d5be29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031549Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#736943}
-
Boris Sazonov authored
Follow-up to https://crrev.com/c/2027531. Renames CoreAccountInfo.getName to getEmail to match the C++ CoreAccountInfo object. Bug: None Change-Id: Icbe98595e75ff8d1827dd780e31c1babc8efd6f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027807 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#736942}
-
Clark DuVall authored
The URLLoaderFactory created in AppCacheHost::MaybePassSubresourceFactory() was not being passed through ContentBrowserClient::WillCreateURLLoaderFactory(), so wasn't getting picked up by things like AwProxyingURLLoaderFactory or WebRequestProxyingURLLoaderFactory. This change required threading the correct origin through to AppCacheHost so it can call WillCreateURLLoaderFactory() with the correct origin. Bug: 998340 Change-Id: I3d417ca2d07e14909f9ebca13eef367160951b44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028164Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#736941}
-
Himanshu Jaju authored
Logs the result of sending a SharingMessage via the webrtc service. Bug: 1021984 Change-Id: I71a722e2ac79c00cc237d5ffb306b5f212f28778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027411Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#736940}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/916bee6fe15b..0b3f3f156be2 Created with: gclient setdep -r src-internal@0b3f3f156be2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I52b00af720e3cbcfc64fa2922ad84a70d34f2307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031131Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736939}
-
Maks Orlovich authored
Seeing some flakiness due to timeouts in them, and they do look like they do a lot of things. Bug: 1047067 Change-Id: I1892f35a8047fdad8c50aeafc2da54665b522bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031364Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#736938}
-
Allen Bauer authored
Bug: 1041614 Change-Id: Ie2bd59392a07d83d693603ccc4d540bc99680193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028737 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#736937}
-
Erik Jensen authored
The Apple Japanese keyboard has two language keys: kana to the right of the spacebar, and eisu to the left. These use the USB codes for Lang1 and Lang2, respectively. The uievents-code spec mentions this in the (non-normative) notes for Lang1 and Lang2: https://www.w3.org/TR/uievents-code/#table-key-code-alphanumeric-functional-2 This can also be seen in the USB-to-ADB mapping table used by the HID driver source code published by Apple: https://opensource.apple.com/source/IOHIDFamily/IOHIDFamily-1090.260.23/IOHIDFamily/Cosmo_USB2ADB.c.auto.html Change-Id: Ib856fbba2d0916c6016625abe226d394edcb5fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029173Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#736936}
-
Chris Lu authored
TBR=kkhorimoto@chromium.org Bug: 1047238 Change-Id: Ib471dcc5f902e8e9acc84f9ad0e0f97750297a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031325Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#736935}
-
Garrett Beaty authored
The scheduled beta trigger and the poller stable trigger do not trigger any jobs. This can't be generated natively by lucicfg, so remove the triggers. stable-gitiles-trigger-scheduled was renamed to stable-gitiles-trigger to match what will be generated by starlark. Bug: 1011908 Change-Id: I9827d933c8b92c78ab4a44a3ca4b2a883b00875a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031185Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#736934}
-
Chris Lu authored
TBR=gambard@chromium.org Bug: 1047236 Change-Id: I24137cf7f0de7d8abd962d3099005edd3783c043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031206 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
-
Roman Sorokin authored
Fixed: 1047219 Change-Id: I8d8dfcb7052986ea8f2625fa5385891a5a49d1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030946 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#736932}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic7100caf2c25ab46b4737e745db4be4dd223f5a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031135Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736931}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/65080795f53f..691480bbcc7d git log 65080795f53f..691480bbcc7d --date=short --first-parent --format='%ad %ae %s' 2020-01-30 lalitm@google.com Merge "tp: add very rudimentary caching support" 2020-01-30 hjd@google.com Merge "ui: Roll legacy trace viewer" 2020-01-30 lalitm@google.com Merge "tp: add support for strongly typed id columns" Created with: gclient setdep -r src/third_party/perfetto@691480bbcc7d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ief7c3e934aadd3baaa3eb3b3e61305d4a483e70c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031133Reviewed-by:
-
Rushan Suleymanov authored
Add callback in sharing message bridge to handle commit failures. In next patch enum for specific errors will be added. Bug: 1047123 Change-Id: I60451e080da0f23763cfad1240cd7d8a517b9f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028769Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#736929}
-
Tricia Crichton authored
On Windows 10, connecting to DevTools on users' systems is persistently taking just over 2 seconds. This causes the first connection attempt to fail, and increases the overall startup time to over 4 seconds. This cl increases the first timeout to 4 seconds which allows the initial connection to succeed more frequently. The overall time given to attempt connecting to DevTools remains around 30 seconds. Bug: chromedriver:3301 Change-Id: I29fcf45143d3daa714fa1ba2c0651e092234c63c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029457Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#736928}
-
David Tseng authored
prefer-const is fairly safe: make all instances of let which only assign once into const. no-var is more dangerous, so only apply to chromevox and hand audit e.g. don't do for externs. Test: browser_tests Change-Id: I343fc5acecb93d33e28a7914c3ff71a0d9880452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029257 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#736927}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/cd8060e73e83..6b7add10ae84 git log cd8060e73e83..6b7add10ae84 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 chrome-bot@chromium.org Update config settings by config-updater. 2020-01-29 cjmcdonald@chromium.org Add SDK/Clean service endpoint 2020-01-29 wbbradley@chromium.org contrib: introduce cl-size-diff tool 2020-01-29 saklein@chromium.org cros deploy: Fix ignore slot emerge argument. 2020-01-29 saklein@chromium.org cros deploy: Fix slot conflicts on deploy. 2020-01-29 dhaddock@chromium.org Enable paygen on jetstream and disable paygen tests. 2020-01-29 tbegin@google.com packages: uprev_ebuild_from_pin change order of modified ebuilds Created with: gclient setdep -r src/third_party/chromite@6b7add10ae84 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: If0c183c1122bcd181d940f3b27a9d4115ec1697c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031124Reviewed-by:
-
Mikel Astiz authored
The recent https://crrev.com/c/1981610 removed the logic to update local bookmark GUIDs upon remote incremental sync updates, but overlooked the issues in the browser-upgrade path: and old client would indefinitely continue with local bookmark GUIDs that never got updated, and yet during commits those arbitrary GUIDs could get uploaded because PopulateFinalGuid() had been called, and in fact client tag hash does represent the authoritative bookmark GUID. The fix proposed here is to revert back to the logic prior to the offending patch linked above, and in addition add extra precautions when uploading changes, via the newly-introduced SyncedBookmarkTracker::Entity::final_guid_matches(). Because it's hard to reason about the effect of bad data in the affected version range, and since the protobuf field number was recently introduced (with no branch-point in between), BookmarkSpecifics is updated again to start using a clean proto field number. Change-Id: I52bc516c3074cff778e10b55652d74bf8fc44684 Bug: 978430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030768 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#736925}
-
rbpotter authored
- Add js_modulizer and polymer_modulizer rules to autogenerate Polymer 3 versions of most files in controls/ and their dependencies. - Note: settings_idle_load is excluded, as it may not be feasible to autogenerate (may need to check in a manually created P3 version). - Add closure compilation targets for the Polymer 3 files. - Autogenerate P3 versions of browser_tests for the elements that have browser_tests currently. Bug: 1026426 Change-Id: I55d77c0432fb81df5e6976987685477d2bbc0cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024283 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#736924}
-
Alex Chau authored
Android changes - Use SharingService::GetDeviceByGuid to populate SharingInfo fields - Removed unused last_updated_timestamp throughout the code SharingMessage proto - Added message_id as Sync cannot pipe through FCM message_id Registration / VAPID key handling - Only generate VAPID key if preference is syncing - Only register for VAPID when there is a VAPID key available - Only register for sender ID when send-via-sync flag is enabled - VAPID/sender ID target info can now be empty and has be to checked before using Synced preference - Return a FCMConfiguration object instead of target info that contains all valid target info FCM sender / handler - Added support of server config target - Sending to FCM target will pick the valid target info, with sender ID as priority - Attached both VAPID and sender ID in every message for receiver to choose the channel for Ack DeviceInfoSpecifics - Changed field tag of sender_id_ fields so M80 clients cannot populate sender_id fields. M80 clients do not understand embedded message_id in SharingMessage and thus cannot send acks. - Added _VAPID suffix to existing click-to-call and shared-clipboard features, M81 clients that does not support VAPID will not set enable _VAPID features to avoid old clients from listing M81 sign-in only devices Bug: 1044607 Change-Id: I06ae2fc0d9ba89306a6da68653aa521542e774ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012286Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
-
Evan Stade authored
This will allow us to componentize JavaScriptDialogTabHelper and reuse it for WebLayer. Bug: 1045499,1025256 Change-Id: I07d6b2123a00898a8aa03400b4b60c203b694252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023397Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#736922}
-
Nazerke authored
This CL modernizes the ActivityOverlayCoordinator to use the superclass -initWithBaseViewController:browser: initializer. Also this CL updates unit tests for Activity Overlay Coordinator. Bug: 1029346 Change-Id: I3e16373e7096355c7be9b1a7b1df53f1de4cb0c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019030 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#736921}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5dca3f1336a6..c31a4ec66af2 git log 5dca3f1336a6..c31a4ec66af2 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 ivoc@webrtc.org Disable opus tests to allow upgrade to opus 1.3 2020-01-30 srte@webrtc.org Default disables legacy overhead calculation. Created with: gclient setdep -r src/third_party/webrtc@c31a4ec66af2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id95f4d958bb6315e0b42686f69d6a425a93e1f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031132Reviewed-by:
-
Dominic Mazzoni authored
To repro, create a page with: <iframe src="..." aria-hidden="true"></iframe> When swiping left/right, TalkBack shouldn't navigate to any elements inside the iframe. The fix is to mark those nodes as not "interesting" internally, that means we won't navigate to those elements. Bug: 1046491 Change-Id: I48ba337829035cc6cd1508df8e78f6d460e36536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023482Reviewed-by:
-
David Tseng authored
This is the continuing work to modernize accessibility extension js and make them uniform. The test js in Chrome is somewhat complicated because it needs to run through V8 shell in a first pass and in a real Chrome renderer when actually running the test. The first pass does not have access to the bulk of the test-only modules. Steps for conversion: - run automated conversion script - change classes from class Foo to Foo = class (assumes global scope) - move 'first pass' data onto prototype; unfortunately, we cannot instantiate the test object class in the V8 shell - remove all empty super() constructors (since default super constructors are automatically called) Test: all tests pass. Enforce object-shorthand in c/b/r/c/accessibility Change-Id: I7cf69c4bdcaf7c71d7d0355e802a2e48086fd9a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025631 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#736918}
-
Nazerke authored
This CL removes public properties for WebStateList and dispatcher values and updates the coordinator implementation to get the WebStateList and dispatcher from self.browser. Bug: 1029346 Change-Id: I613a9ad5a6b9048c4cab1f874eda7474cd3ee538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010946 Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
-
Sophie Chang authored
This also migrates subresource redirect to use the new API Bug: 1036490 Change-Id: Ia8b68f9fd46f93b4e01ea1d3e1140490e83d7837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026901Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#736916}
-
Joe Downing authored
This CL adds conditions to the create/remove symlink rules for the Windows installer which will cause the symlink to be created on install and removed when either the MSI is being removed or being upgraded, but not when the same version is re-run. Change-Id: I7d9bbb24312ab9ad42c18d87528f1cdb9e4b5735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031136Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#736915}
-
sandromaggi authored
Before this change, there was already a boolean attribute to let the layout know it has an edit button. It has not been in use however. This CL reads the attribute (defaulting to true, for backwards compatibility) and disables the third column in the layout if necessary. This CL also removes the |can_add_items| attribute that seems to have been replaced with |add_button_text|. Screenshot (after): https://screenshot.googleplex.com/eKQcLrJBey9 Bug: b/146041576 Change-Id: I5865b71c7e9a726d1793b3a0016b42bebb4c45fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027454Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#736914}
-
Yue Zhang authored
Bug: None Change-Id: I936e72faad21a0bb707c9f9e545dfa78cce87eb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029233 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Auto-Submit: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#736913}
-
Joe DeBlasio authored
Fixed: 1039315 Change-Id: I18f7dbb06242ab5ccfedffb8035790ce359051c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031245 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#736912}
-
Yusuke Sato authored
Some ARC browser tests such as ArcAuthServiceTest.ChildTransition instantiates a profile and an ArcSessionManager object associated with the profile twice on purpose. On the other hand, ArcAppListPrefs object can be _asynchronously_ created while the first profile is in use. As a result, if the following happens, the DCHECK_EQ in the class fails, making such browser tests flaky: 1. The first profile is created. 2. The first ArcSessionManager is created. The first profile is associated with the manager. 3. A unrelated class e.g. ArcDefaultAppList does some PostTask operations. 4. The second profile is created. 5. The second ArcSessionManager is created. The second profile is associated with the (second) manager. 6. The PostTask operation finishes, and an ArcAppListPrefs object is created with the first profile. 7. The DCHECK_EQ fails. This CL changes the DCHECK_EQ to LOG(ERROR) to remove the race. BUG=b:144199481 TEST=try Change-Id: I0153a2ceba87c5a292b7b34f257e18868dc1f9bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030002 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#736911}
-
Andy Paicu authored
Records the amount of times the infobar is shown and how many it times it does not need to be shown. Records the action that was taken as a result (granted/dismissed/denied) This helps us prepare some data for when the Android-level ephemerality changes will land and give us a baseline to compare to as we expect the number of times this infobar is shown to increase significantly. Bug: 1047184 Change-Id: If9dbec366d8c57b37585b990531432f5a1235ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030865 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
As ChromeBrowserState has been moved to the global namespace and all client code fixed, the code added to support the incremental migration can be removed. Bug: 1042208 Change-Id: I35a69dfcf6256f0990ec3b3deeb847fa3a7c4ab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026976Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#736909}
-
Garrett Beaty authored
There's no reason to have a noop job triggered by a trigger: it is known that it will not do any work and doesn't simplify any other code. The 2 noop jobs that were being triggered by a trigger are not set as children of any builders in chromium_tests code, the fake builders exist only as the builder for trybot mirrors. Bug: 819899 Change-Id: Icfded342fc7c379e790f453fe3fe0196a1d3a483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031045 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
Owen Min authored
Change-Id: Ia417d2d3c4eb49b0fca84eeeaf0bcd0f3ca79b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031205Reviewed-by:
Yann Dago <ydago@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#736907}
-
Boris Sazonov authored
Reconcile CoreAccountInfo with its C++ counterpart by removing Android-specific Account object and using email as a string instead. This improves consistency and simplifies creating CoreAccountInfo in tests. CoreAccountInfo.getName() will be renamed to getEmail() in the subsequent CL. Bug: 1042197, 1046412 Change-Id: I99d721771841ca361df63c17f1d77be8cb450abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027531 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6ef0942f. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I71b39572018fd02b1619a12596b0d9f4d2e65e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031084Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736905}
-
Miguel Casas-Sanchez authored
This reverts commit 72037f82. Reason for revert: M80 Stable blocker bug 1046501 Original change's description: > media: use VEA SupportedProfile |min_resolution| for PeerConnection > > crrev.com/c/1828078 added and wired the video encode acceleration > minimum resolution; this CL uses this information from peerconnection's > rtc_video_encoder.cc and video_codec_factory.cc to avoid using a > hw accelerator for resolutions below the given one. > > TEST=https://codepen.io/miguelao/full/jONQBYb on nocturne (pixel slate), then > inspecting chrome:webrtc-internals, verifying that resolutions below 321x241 > are encoded using libvpx while larger ones are encoded using "ExternalEncoder", > i.e. the video encode accelerator in Chrome, in this case VA-API. > > Bug: 1008491 > Change-Id: Iccfe6be8811ca265d6dbc742beb3ec0901406a40 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848398 > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720981} TBR=mcasas@chromium.org,haraken@chromium.org,sprang@chromium.org,hbos@google.com,guidou@chromium.org,ilnik@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1008491 Change-Id: Ie7279fcc02e041f4e1a4a0ed0cef248aa24d472e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028889Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#736904}
-
