- 12 Aug, 2020 40 commits
-
-
Yunke Zhou authored
Add browser test to verify behavior for back button on the gaia screen when kChildSpecificSignin feature is enabled. Bug: 1101318 Change-Id: Ibaff1cf629520b3fbbe8cd620d8727bd35922295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343068 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#797176}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8e1380996d6a..13a65b1aee42 2020-08-11 alanbaker@google.com Only validation locations for appropriate execution models (#3656) 2020-08-11 andreperezmaselco.developer@gmail.com spirv-fuzz: Fix in operand type assertion (#3666) 2020-08-11 andreperezmaselco.developer@gmail.com spirv-opt: Add spvOpcodeIsAccessChain (#3682) 2020-08-11 vasniktel@gmail.com spirv-fuzz: FuzzerPassPropagateInstructionsUp (#3478) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: Ic4b47cb923d7bb3dad5bc89bf0b77f2486747adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351868Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797175}
-
Ehimare Okoyomon authored
Replace getPermissionsSubpageFragmentForUrl method with getSiteSettingsClient because SingleWebsiteSettings is now visible directly from page info. Bug: 1077766 Change-Id: If2c032b889ec51a36456edf0c92aec91eb27faf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343030Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#797174}
-
Side Yilmaz authored
This CL replaces deprecated functions of IdentityServicesProvider with the newer service getters with profile parameter. Since AccountTrackerService runs only in regular mode, using |Profile#getLastUsedRegularProfile| is safe. Bug: 1041781, 1075562 Change-Id: I3158024805c17ab20713005162de741ecb1ff433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339659Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#797173}
-
chrome://settings/passwords/deviceVictor Hugo Vianna Silva authored
The border of "View and manage saved passwords in your Google Account" should actually have a width of 1px and color --google-grey-refresh-300 (or --google-grey-700 in dark mode). https://www.figma.com/file/PN9sJ5Mx2lx4nHBm3la4oT/Butter-for-passwords?node-id=4024%3A74326 https://source.chromium.org/chromium/chromium/src/+/master:ui/webui/resources/cr_elements/shared_vars_css.html;l=49 Bug: 1114702 Change-Id: Ie7931ccac155482e1e020b2c61399c2bde426b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346432Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#797172}
-
Kent Tamura authored
WrongBaselineOfButtonElement counter had issues: - We couldn't distinguish multiple-line button cases and empty-line button cases. - We counted cases where a wrong baseline didn't affect button rendering. This CL splits the counter into two, and adds baseline-necessity check. Bug: 304848, 690036 Change-Id: Ief25cea26d6d1e260752c79848f51e6c4b0416b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351641Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#797171}
-
Alex Chau authored
chrome/services/sharing/* - Introduced AcceptConnection, RejectConnection for accepting/rejecting connection with remote endpoints, AcceptConnection also pass a PayloadListener - Introduced SendPayload and CancelPayload for sedning/canceling outgoing payloads chrome/browser/nearby_sharing/nearby_connections_manager* - Browser side usage of the above APIs NearbyConnectionsManager uses AcceptConnection to accept connection, and implements PadloadListener. For outgoing payloads, OnPayloadTransferUpdate will pass the status to its listeners directly - SendPayload and CancelPayload are straight forward Bug: 1076008 Change-Id: If32e703e1d701373df1833719214039a990fafa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339670Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#797170}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/afbc899f2ff2..13f04d59c727 2020-08-11 sugoi@google.com Fix for dEQP-VK.wsi.*.swapchain.acquire.too_many_timeout If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ib48777255685285a849d0c4842c908bfa636f3d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350020Reviewed-by:
-
Milica Selakovic authored
As password scripts have a confirmation step, we don't need to validate an intent to change a password. This CL removes timer that will rest password state. Password manager will be suspended for all autobot flows. This CL also changes what origin is used for password store request. If a password script is started from Settings, GetLastCommittedURL is not set yet. So, we have to use the deep url provided. Bug: 1086109 Change-Id: I636d3f7891d98212a3998c450b94f72a0fc51573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348771 Commit-Queue: Milica Selakovic <selakovic@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#797168}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/95027d0c5d61..2c4fc0c32598 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC noel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1115099 Tbr: noel@google.com Change-Id: I1242bbe92a1e5971221c8cde96bf1ac6f74d0cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351853Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797167}
-
Jit Yao Yap authored
Bug: 1101208 Change-Id: Ib1fb7d92548c2f2b7bc909548a7a464fb0034c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332614 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797166}
-
Rouslan Solomakhin authored
This patch adds a test for JSON serialization of a very long string being passed into PaymentRequest API. Bug: 1110324, 1115091 Change-Id: I7966d71c3752d1e4378a54f534a1915fb8fade39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348411 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#797165}
-
Tim Van Patten authored
Previously, absl_hardening_tests was updated to only not depend on //base/test:run_all_unittests when building Abseil as part of a standalone build (!build_with_chromium). However, while this fixed the gn dependency errors in ANGLE, building all of ANGLE (not just the "angle" target) still failed due to missing main(), which is built as part of //base/test:run_all_unittests. Instead, the entirety of absl_hardening_tests will be excluded when building outside of Chromium, which allows the ANGLE build to complete successfully. Bug: angleproject:4873 Test: ~/code/chromium/src/third_party/angle$ ninja -v -C out/ClangDebug Change-Id: Idc2d81d03a454f7aa280a2b05f332c231904408d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350195Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#797164}
-
Viktor Semeniuk authored
This change removes possibility to cancel Password Check. Bug: 1075494 Change-Id: Ia9602bf8b8660dd61db5e8bb8df2b22726eb9a9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339743 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#797163}
-
Thanh Nguyen authored
Remove this flag as it is expired. Bug: 1110581 Change-Id: I6230447949feb3aeeaca92d702b1b6e2091b48b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351479 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#797162}
-
Miyoung Shin authored
This is a reland of 97950371. Reason for revert: Flaky SafeBrowsing tests on android_webview: https://bugs.chromium.org/p/chromium/issues/detail?id=1111868 Fix : Destroy the callbacks on the compositor thread when |widget_base_| is nullptr. Original change's description: > Reland "Convert FrameMsg_VisualStateRequest to mojo" > > This is a reland of f7d812d9. > > Reason for revert: org.chromium.android_webview.test.VisualStateTest#testVisualStateCallbackWhenContainerViewDetached__multiprocess_mode was flaky > > Fix : Fire the swap callback in QueueReportTimeSwapPromise::DidActivate > if synchronous compositing is enabled on Android WebView. > > Original change's description: > > Convert FrameMsg_VisualStateRequest to mojo > > > > This CL converts FrameMsg_VisualStateRequest to FrameWidget Mojo message > > and FrameHostMsg_VisualStateResponse to the return callback of > > FrameWidget mojo message. > > > > The legacy IPC message sent a single IPC with the multiple sub IPC > > messages in reply, but this CL invokes each mojo message's callback > > queued in the queue when the frame swap has occurred. > > > > This CL also includes to > > - add WidgetCompositorHost interface bound on the compositor thread. > > - move the implementation of |visual_state_callbacks_| from > > RenderFrameHost to RenderWidgetHost. > > - introduce WidgetSwapQueue queuing |id| having the same source > > frame number to invoke the callbacks. > > > > Bug: 1071588 > > Change-Id: If8c4db40be397921d19ca6a9a9287760879f3ff1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2178480 > > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#789884} > > Bug: 1071588 > Change-Id: If7bfaa21277da199632e5c6ec748b54cea7eef58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309317 > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > Cr-Commit-Position: refs/heads/master@{#793560} Bug: 1071588, 1111868 Change-Id: I2cf298cf75ad75d9345230e34d23412b773870b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342532Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#797161}
-
Siyu An authored
Bug: 1112095 Change-Id: I98d73139ed1be588e53d46eb8f1f63feeda74f07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342120 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#797160}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I85236b7692c31aa4c9ce08f10a010280cc274ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351854Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597190183-f5edc71fe82787227048a24a0d9d0eec5f67340b.profdata to chrome-mac-master-1597211695-37c2210c4f6de3e68198b41f1297acfc22a0b10f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I72d821e1df9303eb214eae9e5e4bafad20cedf8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351863Reviewed-by:
-
Gavin Williams authored
This destination replaces the existing Save To Drive destination when the printSaveToDrive flag is enabled. Bug: 1112416 Change-Id: I860a026ede69161beb169cae01d5b91388be5374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343972 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#797157}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ab6f9ef34a2b..7e7cae79f10a 2020-08-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 59b4828f293e to 13f04d59c727 (3 revisions) 2020-08-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 5246cdb2 to 7a75987d (417 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: I2728b146143713d8dd972bb24f727d3af4e384f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351451Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9981690ea644..65eb98d6ed3a 2020-08-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I4b21b65ea4a27c2f60e9cc83ae006cfc1d7ba0aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351450Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4183.48-1597052523-benchmark-86.0.4228.0-r1 to 86-4183.48-1597052523-benchmark-86.0.4229.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I5fb5e68772bfc3e518a00e354be77ff9ff91d4f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351860Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.57-1597053344-benchmark-86.0.4228.0-r1 to 86-4183.57-1597053344-benchmark-86.0.4229.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I991570b097f4d35b9cd7fa741b52edf87dfefa9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351862Reviewed-by:
-
Sadrul Habib Chowdhury authored
Disable the following stories that have been failing: blink_perf.events/EventsDispatchingInDeeplyNestedV0ShadowTrees.html blink_perf.events/EventsDispatchingInDeeplyNestedV1ShadowTrees.html blink_perf.events/EventsDispatchingInV0ShadowTrees.html blink_perf.events/EventsDispatchingInV1ShadowTrees.html BUG=1115356 R=masonfreed@chromium.org TBR=masonfreed@chromium.org Change-Id: I63e125cac6479a069eb0f438d96c4dc23392050a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351619Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#797152}
-
Daniel Hosseinian authored
Add a skeleton thumbnail bar element containing empty thumbnails corresponding to each page of the PDF content. Bug: 652400 Change-Id: I2266a0636ebdea2415a6cb1116cd3264b9db29c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340498Reviewed-by:
-
Jit Yao Yap authored
The |pem_path_| member of ChromeTestExtensionLoader is currently always empty and so will be unused. This CL adds a method to set the pem_path to be used when packing an extension. Change-Id: I977c29de7f8078d054ee9d8052c7628551356d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332613 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
-
Mahmoud Gawad authored
Currently, telemetry_extension_ui files are behind !is_official_build flag, while creation of the SystemAppType::TELEMETRY is not. This generates an error when the is_official_build=true indicating that the TelemetryExtension cannot be installed because there are no resources. To achieve consistency, move the creation of SystemWebType::TELEMETRY behind !defined(OFFICIAL_BUILD). Future work, when Telemetry SWX is ready to be shipped with Chrome, move out the SystemApp and resources creation outside !is_official_build flag. Bug: b:153335834 Change-Id: Id4add254e0e032c201c6dd7e54020ab6f262e802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346659Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Commit-Queue: Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#797149}
-
Emily Stark authored
This CL fixes a bug where we were incorrectly bailing out on simplified domain elision all together when the whole URL doesn't fit in the omnibox. As background, note that the simplified domain field trials code sets the steady-state omnibox's RenderText into NO_ELIDE mode. This is because RenderText over-elides when a display offset has caused part of the text to scroll offscreen. (I'm not sure if this RenderText behavior is a bug or not, but it's tracked at crbug.com/1099078.) The bug is that ElideURL() was bailing out early if the RenderText() didn't fit the whole URL; instead we want to switch the RenderText into NO_ELIDE mode and then elide in OmniboxViewViews as best we can. (Currently, if the full domain doesn't fit, we elide from the right, but a follow-up CL implements left-edge elision which is better from a security perspective.) This change also serves as a speculative fix for crbug.com/1107912, which I can't reproduce. In that bug, the omnibox seems to somehow get set back into ELIDE_TAIL mode when switching tabs, so that ElideURL() early-returns when landing on a different tab instead of properly eliding to the simplified domain. I'm not sure how the omnibox would be getting set back into ELIDE_TAIL mode, but if this fix makes the problem go away, then it confirms the theory that that is indeed what's happening. Bug: 1107912 Change-Id: I22ede3b875bac343a6d01fc8d5d8aeb25c2bb5e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348156 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#797148}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.57-1597055597-benchmark-86.0.4228.0-r1 to 86-4183.57-1597055597-benchmark-86.0.4229.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If2518c4d7d06fbeb3fc80b26075c4d6a2ab2804e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351855Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0376edf14e58..c4451adcce85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I090e2c0ed74f1efa5bcaf5528a102055a98286ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351162Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f6ca01b98c51..0377420e4c71 2020-08-12 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1a7566b77503f77308085c1820538a5f0be46ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351446Reviewed-by:
-
Keishi Hattori authored
Replaces WebFrame::opener_ with the equivalent Frame::opener_ OpenedFrameTracker has also been moved from WebFrame to Frame Inside WebFrame::Swap(), opener_ needs to be cleared on the old frame before it is detached to avoid it from calling DidChangeOpener() and notifying the browser process. Also the opener must be saved to a local variable, |old_frame_opener| because old_frame->Opener() will be cleared in Detach(). Bug: 1100056 Change-Id: I403afbf7558a84d9ae1a3ba427b7613efd9edeb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331958 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#797144}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ic00a45c271769c471acce9eb08679e42d4f15848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351444Reviewed-by:
-
Meilin Wang authored
Bug: b/161481195 Test: manually. Change-Id: Ia86508989c58adb32faef27d74be2910507a382c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333037 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#797142}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/db1dd1b60d1c..95027d0c5d61 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC noel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:810097 Tbr: noel@google.com Change-Id: I2fa27e98c89f83c6e28d423b6b91c876e49c3319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351440Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797141}
-
yiyix authored
Moved all video related tests and drawImage related tests. Bug: 1077148 Change-Id: I7eabfa7a2b2770919b7774fb8193a2f6d6d51ff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268381Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#797140}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/48d951e22d45..d667ad2f0127 2020-08-11 cnorthrop@google.com Tests: Add Mobile Legends trace 2020-08-11 cnorthrop@google.com Capture/Replay: Allow starting capture at an unknown frame If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Test: Test: Capture application frames using triggerTest: Test: angle_perftests --gtest_filter=TracePerfTest.Run/*mobile* Change-Id: I0a60fd9366b1139eb16509439b903d4925c194cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351441Reviewed-by:
-
nancylingwang authored
Since we have the circle checking, we can call the CreateStandardIcon interface to convert all apps (including the essential apps/default apps) to the standard icons, and the CreateStandardIcon interface can check whether the icon is circle or not to apply shrink or not. So the default apps checking can be removed. BUG=1114771 Change-Id: I6c60fa8127c6f22e19824e21bffc8720100576f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351259 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#797138}
-
Peter Kasting authored
Bug: none Change-Id: I8e0a3a1770185108d270569d9cedafd2853d1914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348193 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#797137}
-
