- 09 Apr, 2019 40 commits
-
-
Mei Liang authored
This CL adds the following user actions for TabGroups UI: * GridTabSwitcher.UndoCloseTab * GridTabSwitcher.UndoCloseTabGroup * TabGridSheet.UndoCloseTab * TabStrip.UndoCloseTab Bug: 950190 Change-Id: Ic456b9f118e185f62c3866492e77ade27b51f7aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553090 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#649244}
-
Amit Hilbuch authored
WPT tests will now fail with different error message (due to RTCError not being translated correctly). Tests are disabled temporarily until WebRTC change is merged. Bug: webrtc:10491 Change-Id: I89525bbe51a6606e71affa0e035b9e12f828b02c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560330Reviewed-by:
Steve Anton <steveanton@chromium.org> Commit-Queue: Amit Hilbuch <amithi@chromium.org> Cr-Commit-Position: refs/heads/master@{#649243}
-
Tanya Gupta authored
Bug: 941124 Change-Id: I0955071e3aefccbe947752bd9ceea4fb8edfe088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559397 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#649242}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/80658204f417..d54b1fcdd915 git log 80658204f417..d54b1fcdd915 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 nifong@google.com full collection of externs 2019-04-09 herb@google.com Reland "Handle translating blob to origin in bulk" 2019-04-09 halcanary@google.com SkPDF: move annotations away from device. 2019-04-09 mtklein@google.com some refactoring ideas 2019-04-09 ethannicholas@google.com SkSL 'key' variables can now be controlled by 'when' expressions Created with: gclient setdep -r src/third_party/skia@d54b1fcdd915 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I4cf00e7fb7a99cec5e74606bcdb4f625c4e87d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560173Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649241}
-
Caroline Rising authored
Prior behavior was for bubbles to stay within the screen bounds. With this change the bubble will also attempt to stay within the parent window bounds (if one exist) while always staying within the screen bounds. Also add ability for any bubble to offset if out of given bounds instead of mirror. This behavior is used for tab hover cards. Bug: 910739 Change-Id: Ib1137646e818b09fe5192896414be9686d1e01fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552284Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#649240}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cce609cb3785..572984e9ca2b Created with: gclient setdep -r src-internal@572984e9ca2b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:949743,chromium:946405 TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: Ife907dace76f72caafa13309fc4a8b1340a5261f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558763Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649239}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fc15ae5571b3..3702d8c9d300 git log fc15ae5571b3..3702d8c9d300 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 geofflang@chromium.org Propogate dirty bit signals from TextureImpl to Texture up to Context. 2019-04-09 timvp@google.com Re-Enable MipmapTest.TextureCubeGeneralLevelZero/ES2_VULKAN Created with: gclient setdep -r src/third_party/angle@3702d8c9d300 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:949985 TBR=ynovikov@chromium.org Change-Id: I85b61516d4fd1c118469780b5650f2107ff6050a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560212Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649238}
-
Raul Tambre authored
Ran "2to3 -w -n -f print ./base" and manually added imports. There are no intended behaviour changes. Bug: 941669 Change-Id: If5eb9217385a6d9a7807a4ca03116e1db9999695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559958 Commit-Queue: Raul Tambre <raul@tambre.ee> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#649237}
-
khmel@chromium.org authored
In case arc-disable-locale-sync is used this limits ARC container to start with 'en-US' as a locale and 'en-US,en' as preferred languages. This stabilizes tests that expects UI resources be fixed in English. There is an alternative solution that could be implemented when needed to pass required combination as a switch. However this is not required at this time once we don't have such auto-tests. TEST=Set locale for local test account to 'ru' and confirmed that cheets_AppCompatTest.clamshell.com.google.android.apps.books is failing similar as described in bug. Apply this patch and test passes. BUG=b:130142125 Change-Id: I2219207d2d75c00c6ee04590e430a929389c7319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559463Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#649236}
-
Devlin Cronin authored
Add an install warning for extensions added with a higher manifest version than is fully supported. We use a warning (rather than an error) so the extension still loads, and runs as best it can. Bug: 950647 Change-Id: I32ae2b21bb8cc83e2ec0effaab6d58324a93a25d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559021Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649235}
-
Dominik Laskowski authored
DisplayConfigurator serializes asynchronous content protection requests by storing pending query/apply tasks as closures in a queue. It also maintains queues for the query/apply callbacks supplied by the client. This CL consolidates the queues by relating QueryContentProtectionTask and ApplyContentProtectionTask by a common base class. It also replaces the Boolean for task success/failure with tri-state, whose extra bit is used to distinguish killed tasks during DisplayConfigurator destruction and (in a future CL) display reconfiguration. Bug: 929449 Test: display_unittests Change-Id: I3640b657ed5952c40e0999836ae92287984a3e9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495201Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Cr-Commit-Position: refs/heads/master@{#649234}
-
Mehran Mahmoudi authored
This fixes an issue which prevented the progress bar to be dismissed. Bug: 950988 Change-Id: I790b0eb4a3ef02b2d166edbc6e636c2803067e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560018 Auto-Submit: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#649233}
-
Greg Thompson authored
We find that C:\Windows\System32\OpenWith.exe sometimes has focus and prevents tests from running to completion. This change logs the command line of the process and of its ancestors. With luck, this will shed a little more light on why this window appears. BUG=711256 Change-Id: I0553665f5f36e1e2be5be268479d5095a5771b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559073 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#649232}
-
Chris Lu authored
Add integration test coverage for calling FindInPageNext and FindInPagePrevious actions. Bug: 919685 Change-Id: If8894564135dacf61c4bd3510504013d4ef74ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551498 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#649231}
-
Sam Maier authored
We had upstreamed min-sdk so that R8 could use it, but Proguard was forgotten. This adds min-sdk support for Proguard. Bug: 950918 Change-Id: I46aeb63ed89abcb2e384f874d3dbc1d43093884d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559579 Commit-Queue: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#649230}
-
Luke Halliwell authored
libinteraction is used in certain internal builds. Bug: b/110808839 Change-Id: I51c29bd0033d608413e97029f288de44b89fc441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560138Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#649229}
-
Felix Ekblom authored
This informs the user that enrollment is on-going. The 'alert' role is probably not perfect for this use case but it's the best I could find, and it's used in nearby code for similar scenarios. Testing by running through the remora enrollment flow and observing that "Enrolling device..." is read out. BUG=b:80126209 Change-Id: Iee7388dae29458412cb44f9d3578cfeee2d234cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559182 Auto-Submit: Felix Ekblom <felixe@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#649228}
-
Elly Fong-Jones authored
Bug: None Change-Id: Id7d285352115e0aa97288a391b28782271a7bbd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559700 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#649227}
-
Sidney San Martín authored
Followup from https://crrev.com/c/1427799. Bug: 868398 Change-Id: Id0c1f9ee80b90b9c3db0847b7df9de8e7aa8e888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560149 Commit-Queue: Sidney San Martín <sdy@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#649226}
-
Elly Fong-Jones authored
This change leaves the backing switch intact for later in-depth cleanup. Bug: 951038 Change-Id: I7b411324bee03ff0082fc69f1505f7150411d559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560147Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#649225}
-
Dan Beam authored
* GB900 isn't used anywhere * Add some missing #hex annotations for -rgb vars R=dpapad@chromium.org BUG=none Change-Id: I7ca3063ba5e66af946638c9cb99caa7ae07a036c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559400 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#649224}
-
Tao Bai authored
- Added ContentCaptureController for whitelist which could be host name or regex. - Added mojom interface to let ContentCaptureReceiver talk to ContentCaptureSender to start/stop the ContentCapture. - ContentCapture is stopped by default in renderer side. Bug: 947639 TBR=pdr@chromium.org Change-Id: I42221afe78937ed696afa4bc6e2ab321159f6c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557000Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#649223}
-
Hesen Zhang authored
> Cleaned up a TODO flag for one corner case: for filename with double extension like "foo.tar.gz", "foo" should be highlighted by recognizing the extension ".tar.gz"; Previously using Java side util function, now using RenameUtils instead which connects the one in backend under FilePath class. Bug: 924751 Change-Id: Iea09538eccda452c1ebf91c2bf9e8e42458bec8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546586 Commit-Queue: Hesen Zhang <hesen@google.com> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#649222}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6fdbba3a0381..6a489f22c71b git log 6fdbba3a0381..6a489f22c71b --date=short --no-merges --format='%ad %ae %s' 2019-04-09 mbonadei@webrtc.org Fully qualify googletest symbols. 2019-04-09 guidou@webrtc.org Revert "Adding a restriction for legal RID values." 2019-04-09 noahric@chromium.org Remove atlbase dependency and lowercase Windows header includes. 2019-04-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6c8246bc..fe4d0c8e (648994:649101) 2019-04-09 srte@webrtc.org Disables slow scenario test on IOS ARM64 debug builds. 2019-04-09 ssilkin@webrtc.org Field trial to control inter-layer prediction. 2019-04-09 hbos@webrtc.org Implement RTC[In/Out]boundRtpStreamStats.contentType. 2019-04-09 srte@webrtc.org Refactoring scenario stats analysis. 2019-04-09 srte@webrtc.org Replacing SequencedTaskChecker with SequenceChecker. 2019-04-09 crodbro@webrtc.org Clean-up of unused PacingBufferPushback feature. 2019-04-09 aleloi@webrtc.org Fuzzer fix for multistream opus. 2019-04-09 srte@webrtc.org Adds GetStats to scenario receive streams. 2019-04-09 eladalon@webrtc.org Name changes inside VideoEncoder 2019-04-09 eladalon@webrtc.org Forward LossNotification from RTCPReceiver to EncoderRtcpFeedback 2019-04-09 nisse@webrtc.org Delete local convenience alias Buffer 2019-04-09 mbonadei@webrtc.org Make audio_device_module_from_input_and_output visible. 2019-04-09 hbos@webrtc.org Revert "Refactor FrameDecryptorInterface::Decrypt to use new API." 2019-04-09 marinaciocea@webrtc.org Fix comment - ice transport is cleared on the networking thread. 2019-04-09 nisse@webrtc.org Delete autoroll config for src/third_party/winsdk_samples 2019-04-09 hta@webrtc.org Datachannel: Use absl::optional for maxRetransmits and maxRetransmitTime. 2019-04-09 nisse@webrtc.org Delete interface class VideoCaptureExternal 2019-04-09 kwiberg@webrtc.org Add thread safety annotations for some more PeerConnection members (part 13) 2019-04-09 benwright@webrtc.org Added some more debugging logs 2019-04-09 danilchap@webrtc.org Fix and test CreateVideoStreamDecoder 2019-04-09 phensman@webrtc.org Update visibility of java_audio_device_module_jni target 2019-04-09 hbos@webrtc.org Wire up RTCOutboundRtpStreamStats.totalEncodeTime. 2019-04-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision afc02859..6c8246bc (648860:648994) 2019-04-08 amithi@webrtc.org Adding a restriction for legal RID values. 2019-04-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 827b96d7..afc02859 (648742:648860) 2019-04-08 benwright@webrtc.org Refactor FrameDecryptorInterface::Decrypt to use new API. Created with: gclient setdep -r src/third_party/webrtc@6a489f22c71b The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None,chromium:949536,chromium:950813,chromium:None,chromium:907849,chromium:854385,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I38e7b531ffba08e0b3b42c46efb1d92af3f4f1f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560213Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649221}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/78334315..b4c008bb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I942af034e8125c1d4dfca43a34b9c0f1a4eecc13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559578Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649220}
-
Ted Choc authored
login was choosen to match login_handler.h in native. NOPRESUBMIT=true BUG=876369 Change-Id: Ibce85b4cdeeeedc33d762f18ed5939d5f388cd35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559877 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#649219}
-
Sammie Quon authored
Its really hard to see, and almost impossible to read when shrunk. But animating the transform/opacity will add extra animations for most overview operations. This call is a no-op because we now suspend shelf changes until overview mode is animated in/out. The calls in workspace manager handled updating the shelf even without the suspend changes, so this was not needed for a while. Test: none Bug: 946780, 914147 Change-Id: Ica1c61ea5ae408addd401a9e797fcf4c5aa5003c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544231 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#649218}
-
Stephen Martinis authored
Change-Id: Ic23a007188bcda0775e76633e72fc4f2047602b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539180Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#649217}
-
Xing Liu authored
We would like to know how long does the user interacts with the notification after shown, aka the age of notification. This CL adds metrics to track the age for notification body click, button click and dismiss. Bug: 942743 Change-Id: Ib806da9482a9a94025f509dd33259b9da09e1139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558454 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#649216}
-
Elly Fong-Jones authored
Bug: None Change-Id: I1c886560a1ae294bccd6b2fe4a000ae948d27d2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559890 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#649215}
-
Dana Fried authored
Technique is courtesy of oshima@ (via sajadm@) and makes use of new layer masking API. Should fix the vast majority (if not all) rendering bugs on Bubble dialogs, but is not a general fix for all dialogs. As per markchang@'s guidance, we will now enable rounded corners on all bubble dialogs to get better telemetry from users in case there are still issues. Dialogs using DialogDelegate and lower-level dialog implementations will still be behind the flag (whose description I have updated accordingly) as they still have significant issues. Bug: 932970, 946673 Change-Id: I96c39d75ac9c79b9c33424c28d986093eb12caf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553508 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#649214}
-
Dan Beam authored
I accidentally used GG200 for the fill color (should be GG500). R=dpapad@chromium.org Change-Id: Ic178eaac3f254254d5bd15ee613a9cbd8e8871b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559399 Auto-Submit: Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#649213}
-
Dana Fried authored
Change-Id: I04205a7b585dc1cc3868705ff964a57a98fb0d7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559885Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#649212}
-
Micah Morton authored
This reverts commit e87a5139. Reason for revert: Remove this flag as we will be unconditionally running shill in minijail from M75 onward Original change's description: > Expose enable/disable switch for shill sandboxing over DBus > > This feature flag gates the use of minijail to sandbox shill (the > network manager) on CrOS. Defaults to true. We want a feature flag for > this in case any unforseen sandboxing compications occur on the beta or > stable channels and Finch is our only way of reverting. > > CQ-DEPEND=CL:1172729,CL:1177883 > "sudo -u chronos dbus-send --system --type=method_call --print-reply \ > --dest=org.chromium.ChromeFeaturesService \ > /org/chromium/ChromeFeaturesService \ > "org.chromium.ChromeFeaturesServiceInterface.IsShillSandboxingEnabled" > > Bug: 649417 > Test: Following command returned true (flag is true by default): > Change-Id: I359b28d463f8f0ce861739d7f165f5437690bae5 > Reviewed-on: https://chromium-review.googlesource.com/1173260 > Commit-Queue: Micah Morton <mortonm@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583750} Bug: 875028 Change-Id: Icd6dafd0ed677f597bffa6a96b13bc92d9d6c6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515273 Commit-Queue: Micah Morton <mortonm@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#649211}
-
Daniel Rubery authored
Since official builds don't use the fieldtrial_testing_config, I need to enable kInspectRarContent within the test, so the Official builders can succeed. Bug: 950908 Change-Id: I779f3a2d2f7321225f5ef838cd8419f8ef432e68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559880 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#649210}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4ffbfe61777f..80658204f417 git log 4ffbfe61777f..80658204f417 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 fmalita@chromium.org Revert "[skottie] More snug kTop Shaper alignment" 2019-04-09 halcanary@google.com SkPDF: remove unused field 2019-04-09 egdaniel@google.com Fix to barrier batching. 2019-04-09 mtklein@google.com --parameters -> --properties 2019-04-09 michaelludwig@google.com Detect simpler quad type when possible 2019-04-09 reed@google.com remove guard for bitmap shader api Created with: gclient setdep -r src/third_party/skia@80658204f417 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I9092ddacf5810f36bb4ebc04cb76b7c083b1a50a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559849Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649209}
-
Austin Eng authored
Bug: 877147 Change-Id: I1f7a57faec80ae5896e6c2101093d04af38e124c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554139 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#649208}
-
Tatiana Buldina authored
Change-Id: I4081b451d59e6c3ef164b343e8f60cfbc07081b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559151Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#649207}
-
Alexei Filippov authored
Change-Id: I3e02b365b0a30ab852a1eb141086bc2c2d23f74a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553503Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#649206}
-
Tom Sepez authored
TCPServerSocketPrivate, TCPSocketPrivate, and UDPSocketPrivate now require this permission in addition to a whitelisted site/URL. Tidy code a bit while at it: - use early returns - use std::make_unique<> - pull a redundant permission check Bug: 950005 Change-Id: I6c24c39bf55c08fd538da62d1dc3a8a58610be2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553877Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#649205}
-