- 18 Jul, 2018 40 commits
-
-
Ahmed Fakhry authored
Allowing a browser window to be resized such that the contents view's size is 0x0 caused the contents view's window to become invisble and stop it from being able to accept events. Instead we use a minimum size of 1x1 for the contents. BUG=847179 Change-Id: I7790d5e2e4862fce8bb19a5c7d3134b45c6a0c63 Reviewed-on: https://chromium-review.googlesource.com/1141344Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#575907}
-
Dmitry Gozman authored
This is a small wrapper around NSKillRing functions, solely used by editing code. There is no need to put it separately from the rest of editing. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ie529f834464a413bd252fcf0a45778ae17b48a61 Reviewed-on: https://chromium-review.googlesource.com/1140509Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#575906}
-
Orin Jaworski authored
This CL addresses a performance concern with the way a font list was being derived with size delta, applies minor style changes to entity suggestions, and simplifies the logic for presenting styled answers. Now answers and entities will always be styled to spec, regardless of the flag determining whether to reverse content/descriptions fields. Change-Id: Idb604f655ccbdcffdbe08e99c7d8c1462c636d18 Reviewed-on: https://chromium-review.googlesource.com/1140620 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#575905}
-
Justin Cohen authored
CIPD packages: infra_internal/ios/xcode/mac 10l213o infra_internal/ios/xcode/ios 10l213o TBR: hinoka@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I66bf9c3544bee0d3d67634b17fdbcf49a92058ac Reviewed-on: https://chromium-review.googlesource.com/1140836 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#575904}
-
Kim Paulhamus authored
Bug: 678885 Change-Id: I7d9f7d7776171f702bf1d79b4ad0e740c68511b8 Reviewed-on: https://chromium-review.googlesource.com/1139577 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#575903}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4c64e737. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21503 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=foolip No-Export: true Change-Id: Id62f43a405a6d6f3a9a331b8cff94b7ab94c6d0d Reviewed-on: https://chromium-review.googlesource.com/1141183 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#575902}
-
David Black authored
This builds off of DialogPlate motion spec part 1: https://chromium-review.googlesource.com/c/chromium/src/+/1137843 This CL: - Fixes issue which caused settings to fade in/out. Previously we used two settings buttons, now we use a single button which exists outside of the layout containers being animated. - Implements translation phase of the animation. See bug for spec/demo. Bug: b:111500701 Change-Id: I269666dafa815018e0cf65df299aa734eaf80b79 Reviewed-on: https://chromium-review.googlesource.com/1139031 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#575901}
-
Maks Orlovich authored
URLFetcher will stop working with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. Bug: 840378 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ie318335f2d3a21cac1042862fd6a49e62cc931a4 Reviewed-on: https://chromium-review.googlesource.com/1124771 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#575900}
-
Kurt Horimoto authored
Bug: 851962 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I355a361c16f679b39a0b6bec5a68df0e89248ed5 Reviewed-on: https://chromium-review.googlesource.com/1136012 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#575899}
-
Dominick Ng authored
BUG=None Change-Id: Ida08d49ff1a8b642ce8004fd3ac5d5c931810079 Reviewed-on: https://chromium-review.googlesource.com/1140343Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#575898}
-
Theresa authored
Wait to request a texture capture until a layout pass, ensuring that the toolbar buttons container has the proper width. BUG=863819 Change-Id: I52b6288c1970ed16427e0231c092af13a228e9bc Reviewed-on: https://chromium-review.googlesource.com/1141172Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#575897}
-
Rohit Rao authored
This reverts commit 9441c306. Reason for revert: Breaks ExternalURLSSLTestCase/testMixedContentWarning in the downstream tree. https://browsingtest.appspot.com/mixedContent.html does not show a mixed content warning. Original change's description: > [Nav Experiment] Skip SSL status update when webview is loading. > > -webViewSecurityFeaturesDidChange is meant to update the SSL status of > the last committed item. With WKBasedNavigationManager, on a back/forard > navigation, there exists a small window between web view starts loading > and -webView:didStartProvisionalNavigation is triggered that > WKBasedNavigationManager::GetLastCommittedItem() returns the pending > item instead of the last committed item. > -updateSSLStatusForCurrentNavigationItem must not be called in this > window, otherwise the wrong navigation item will be used. > > Bug: 842151 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I57eb96f74c3a6a133b1fdad6559de093f5d125c5 > Reviewed-on: https://chromium-review.googlesource.com/1141054 > Commit-Queue: Danyao Wang <danyao@chromium.org> > Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575803} TBR=kkhorimoto@chromium.org,danyao@chromium.org Change-Id: Ia764eeca4fcb26cc3cf9cd8778fe4cedb5e98c3f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 842151 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1141384Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#575896}
-
Devlin Cronin authored
Extract chrome api sources from chrome/common/extensions/api/BUILD.gn to a separate gni file at chrome/common/extensions/api/api_soruces. This allows us to pull the api registration step of generation out from chrome/common and into chrome/browser. This is helpful, since it is a purely-browser dependency (and has browser dependencies itself). Also make this step a public dependency of chrome/browser/extensions so embedders do not need to explicitly depend on it themselves. Bug: None Change-Id: I6f2f973a5ba1c04b01aa36b096de847b73964148 Reviewed-on: https://chromium-review.googlesource.com/1139394 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#575895}
-
Douglas Creager authored
Per https://w3c.github.io/reporting/#try-delivery, the field in a JavaScript report object that contains the body is called `body`, not `report`. Bug: 704259 Change-Id: Iba3186a0104c2192ced5e4233d55e042e05908f3 Reviewed-on: https://chromium-review.googlesource.com/1140193Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Douglas Creager <dcreager@chromium.org> Cr-Commit-Position: refs/heads/master@{#575894}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/718bcd15ec60..664261cb3f4d Created with: gclient setdep -r src-internal@664261cb3f4d The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:853946 TBR=mmoss@chromium.org Change-Id: Ic50448d8ff622c644d4ab673deb2629034e63a51 Reviewed-on: https://chromium-review.googlesource.com/1140621Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575893}
-
Scott Chen authored
This CL cleans up some remnant of paper-input, now that paper-input is mostly removed. Bug: 720276 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id17298df731d1fbfc111fdb6db40202e1036dd4a Reviewed-on: https://chromium-review.googlesource.com/1139086Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#575892}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e6ddf1942ca0..302bb847d356 git log e6ddf1942ca0..302bb847d356 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 jbudorick@chromium.org gclient: run cipd ensure in paranoid mode. 2018-07-17 ehmaldonado@chromium.org git_cache: Add tests for reset fetch config. 2018-07-17 ehmaldonado@chromium.org metrics: Fix countdown to metrics collection. Created with: gclient setdep -r src/third_party/depot_tools@302bb847d356 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:860251,chromium:862547,chromium:832386 TBR=agable@chromium.org Change-Id: I654f3810c18eef26eda782285927c8bef5bfd3d7 Reviewed-on: https://chromium-review.googlesource.com/1140797Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575891}
-
Kurt Horimoto authored
Previously, TableViewURLCell always returned a lazily created a11y label created using the values of the UILabel subviews, which was squashing the custom a11y label provided by TableViewItems. Bug: 862306 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7210e683f4dfdcdbf0f2c60ecec3eb2a0683eeec Reviewed-on: https://chromium-review.googlesource.com/1136902Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#575890}
-
Christopher Cameron authored
Disabling it didn't fix the crashes. TBR=lgrey Bug: 863817 Change-Id: I6cf6ea476856b2e20cf37cf080c59aeec41119dd Reviewed-on: https://chromium-review.googlesource.com/1141330Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#575889}
-
Victor Costan authored
Bug: 167187 Change-Id: I4d26741ca9b41751ed8dc3b121fc3d6e7bff9d5b Reviewed-on: https://chromium-review.googlesource.com/1137916Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#575888}
-
Tommy C. Li authored
See the bug for screenshots. Currently, the selection bounds in the Omnibox are not vertically symmetric. This is becoming a lot more noticeable with the MD Refresh redesign. This CL extends RenderText to allow expanding the selection bounds to be vertically symmetric with respect to the display rect. This CL only turns on this flag for the OmniboxViewViews. Bug: 249065 Change-Id: I031017335a0efb5e8842d137fc55efce5520e6cd Reviewed-on: https://chromium-review.googlesource.com/1140901 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#575887}
-
Chris Hamilton authored
This will allow enterprises to opt-out or opt-in to lifecycles while the feature is under development. Change-Id: I68838306ac3d22fab1290f47011dc4d14c909c43 Reviewed-on: https://chromium-review.googlesource.com/1132299Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#575886}
-
Lei Zhang authored
Effectively removing them from Android, where there is no PPAPI. Also fix an "is_chromeos" typo. Change-Id: I1395ccf368c1d0f593352d1ae2755fcb5920468a Reviewed-on: https://chromium-review.googlesource.com/1140531Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#575885}
-
Victor Costan authored
Bug: 112250 Change-Id: I63369b826307acea4b01f15fbc4cbef2f41514a1 Reviewed-on: https://chromium-review.googlesource.com/1137925Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#575884}
-
Varun Khaneja authored
Default quota: 5 Bug: 853382,730646 Change-Id: Ib989a9053da93d7e083f3217082627fa8635da5e Reviewed-on: https://chromium-review.googlesource.com/1138864 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#575883}
-
Min Qin authored
This CL calls the InProgressDownloadManager to delete ResourceDownloader after response is completed. It also fixes the issue when download is cancelled. BUG=864189 Change-Id: I184d5faaace90f49874e45b4126a0a9821fdced7 Reviewed-on: https://chromium-review.googlesource.com/1138676 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#575882}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/004af3cf8045..82b059ecb6a4 git log 004af3cf8045..82b059ecb6a4 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 vapier@chromium.org lint: fix singleton-comparison warnings 2018-07-17 vapier@chromium.org lint: fix no-value-for-parameter warnings Created with: gclient setdep -r src/third_party/chromite@82b059ecb6a4 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I45415863772236473072d5116dd8ac87caff7654 Reviewed-on: https://chromium-review.googlesource.com/1140613Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575881}
-
Dominick Ng authored
BUG=None. Change-Id: I3edc7ba50a20c6e1fb87cd950a9f73d5c9a6c724 Reviewed-on: https://chromium-review.googlesource.com/1140112 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#575880}
-
Takuto Ikuta authored
This is for following nearly 1 hour builds. * linux_chromium_tsan_rel_ng 3783s https://ci.chromium.org/b/8940786382570619168 * mac_chromium_compile_dbg_ng 3534s https://ci.chromium.org/b/8940786382570619152 * linux_chromium_compile_dbg_ng 3534s https://ci.chromium.org/b/8940786382570619056 Bug: 804251 Change-Id: If82c10b26628271dfc01011da204c59858395bd7 Reviewed-on: https://chromium-review.googlesource.com/1139934Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#575879}
-
Roberto Carrillo authored
R=hinoka,chanli,stgao,liaoyuke,lijeffrey,prasadv Bug: 787918 Change-Id: I0766fa1c9d575b9960d336152aa62c56a7a2b945 Reviewed-on: https://chromium-review.googlesource.com/1141117Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#575878}
-
Luum Habtemariam authored
This service will serve the ARC CUPS API by accepting an IPP request via mojom calls, validate its format in a heavily restricted/jailed process, and return the result. This change just contains the scaffolding for the service, validation/jailing to follow soon. Test: WIP Bug: chromium:831913 Change-Id: I5cd88b82746d999743e3ebddfc6aef15e408506d Reviewed-on: https://chromium-review.googlesource.com/1121108Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#575877}
-
Victor Costan authored
0-based ref-counting is deprecated. 1-based counting is described in //base/memory/ref_counted.h. In summary, instaces must be created by base::MakeRefCounted<T> or (less ideal) base::AdoptRef(new T). This CL switches Connection::StatementRef to 1-based ref-counting, and std::move()'s scoped_refptr<StatementRef> in a few places where that avoids refcount churn. Bug: none Change-Id: I14755dc2482f18c8a9582066104f346c2873941d Reviewed-on: https://chromium-review.googlesource.com/1137848 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#575876}
-
Zach Helfinstein authored
Dictation is an accessibility feature that allows users who opt-in to have their speech transcribed into any text field in ChromeOS. Screenshot: https://screenshot.googleplex.com/EkLrrNDAohB.png BUG=850690 TEST=None Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I11ca4051b38a4beec7876ba35899e337f36411e4 Reviewed-on: https://chromium-review.googlesource.com/1120852 Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#575875}
-
Hongchan Choi authored
Because AudioWorkletHandler is ThreadSafeRefCounted, wrapping with CrossThreadUnretained() when the handler is passed via CrossThreadBind() is unnecessary. Use scoped_refptr<> instead. Bug: 853520 Test: All existing layout/WPT tests pass. Change-Id: I83409b89e80a9bbb60ea98649b16efb59facbbd4 Reviewed-on: https://chromium-review.googlesource.com/1140744 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#575874}
-
Min Qin authored
if DownloadDB is enabled, there is no need to update incomplete download in history db. The DownloadDB should contain all information. BUG=863602 Change-Id: Idf20bbb91e8e5156aa21354695b0781493c723ef Reviewed-on: https://chromium-review.googlesource.com/1137235 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#575873}
-
Christian Biesinger authored
This reverts commit 43df04fe. Looks like there is no need for a flag-specific expectation anymore for virtual/layout_ng_experimental/fast/multicol/flexbox-with-overflow-auto-child-crash.html Original change's description: > [layoutng] Use the correct layout algorithm to compute min/max sizes > > This also required adding a check in NGBlockNode::ComputeMinMaxSize > for whether we are inside of PerformLayout -- on Mac, we can > compute preferred sizes outside of layout; however, we can't do > actual layout in that case, so we have to fallback to legacy > min/max size in this case (c.f. RenderViewImpl::CheckPreferredSize()) > > Bug: 635619 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng > Change-Id: I0caf0c6c79264074ccaf9f45b83a420950dab715 > Reviewed-on: https://chromium-review.googlesource.com/1131562 > Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575545} Bug: 635619 Change-Id: I28ca2367e21327d9f911c75b9f9950d171d48e1b Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/1140206Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#575872}
-
Becca Hughes authored
min() and max() are not supported and should throw a parse error when used with env() and var(). BUG=864435 Change-Id: I7e89607cc6bb41910131b35a72dabb979f10b7dc Reviewed-on: https://chromium-review.googlesource.com/1140746 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#575871}
-
Wez authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio Change-Id: I0ff88b708c490cc760902e245e6473e90546c4b9 Reviewed-on: https://chromium-review.googlesource.com/1137750Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#575870}
-
Xiaocheng Hu authored
Bug: 864797 Change-Id: I4becdf1fcbc4b9cfd9821ad61641753df14e1407 Tbr: afakhry@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/1141136Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#575869}
-
Weidong Guo authored
1. Add TransitionAnimationObserver to layout app list at the end of animation to make sure child views are in right position. 2. Replace old expand arrow icon with Skia-drawn arrow and implement the new transition. 3. Change the layout of apps grid and make the rows and cols adaptive to the width and height. 4. Enlarge the folder icon. Demo: https://drive.google.com/open?id=1xlGUpNv1X-s4D9mSjAPkyfZBMWhCjJag Change-Id: I3bc86870c66d0b35b36a801c16befb2624a33a55 Reviewed-on: https://chromium-review.googlesource.com/1121547Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#575868}
-