- 16 Oct, 2019 40 commits
-
-
Alexey Baskakov authored
Decouple icon pixel data from icons meta-description. In the new web app system we store icon pixel data separately. This change will allow us to forward declare WebApplicationIconInfo and use a collection of WebApplicationIconInfo structs in utility functions even if we don't have full WebApplicationInfo data. See dependent CLs for examples of improvements: https://chromium-review.googlesource.com/c/chromium/src/+/1861443 Bug: 860583 Change-Id: Ia4fcfc55c6b8e45cf1261dac9649491bc53333ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859807 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Auto-Submit: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#706355}
-
Juan Antonio Navarro Perez authored
The former component no longer exists. Change-Id: I96d62847c908a97dff82b1ebce1cefbb0a7c6c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847341Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#706354}
-
Benoît Lizé authored
The feature is not used anymore, remove the histograms and the collection code. Bug: 1006991 Change-Id: Ic5f8f703ebdd7b6ae4c91441179f9fab0f7fb479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862444Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#706353}
-
James Cook authored
Add the new syncer::ModelType entries for Chrome OS system preference sync. These follow the existing convention of not being wrapped in platform ifdefs. Add support to PrefServiceSyncable for registering prefs in the new categories. The new registration flags are wrapped in ifdefs, since it doesn't make sense for non-Chrome OS platforms to register Chrome OS system prefs. Add a base::Feature SplitSettingsSync to control whether the new model types are actually used for syncing. This must stay disabled until the server-side protobufs have been deployed to production. Add unit tests for PrefServiceSyncable for the new categories. There are no user visible changes. A design doc is linked from the bug. Bug: 1013466 Test: added to components_unittests Change-Id: Ice645292353c91dbd6c27a305bed95bd99ed9ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859884 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#706352}
-
nancy authored
Built_in_apps is used to replace the internal apps. However, InternalDataSource is still used for the continue reading and release notes, which is confusing. So move the continue reading to Built_in_apps, and AppSearchProvider should depend on AppServiceDataSource for all apps' search and recommended. InternalDataSource and InternalAppResult are removed to avoid duplicate code. All the related code from InternalDataSource and InternalAppResult has been moved to AppServiceDataSource and AppServiceAppResult. Also GetInternalAppNameByAppId is removed, because no one uses it. It should be removed by CL:1851890. This CL is the preparation for the CL:1816256, which moves the internal app list to Built_in_apps. BUG=1013540 Change-Id: Ic3087807fe520ff5a1ffcb200cb1cf459b42e2cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847698 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#706351}
-
Ramin Halavati authored
Traffic annotation auditor binary is updated for linux and windows. Bug: 1005537 Change-Id: Ia131fe6430f0031d20dce0f627599eb639a58ded TBR: nicolaso@chromium.org Change-Id: Ia131fe6430f0031d20dce0f627599eb639a58ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864669Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#706350}
-
Mathias Bynens authored
This patch adds support for emulating timezones through the Sensors drawer. It’s based on the idea that emulating geolocation without also emulating the local timezone (and vice versa) is detectable, and therefore the two should be tied together for more robust emulation. Boring but useful test/demo page: https://mathiasbynens.be/demo/timezone Video: https://www.youtube.com/watch?v=pIpN_AuV4AI Design doc: https://goo.gle/devtools-timezone-emulation Bug: chromium:993628 Change-Id: I5ef867ac2723a341444ab1ee04a26c0fa9a9d62d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860014 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#706349}
-
Peter Kasting authored
This reverts commit b25e7445. Reason for revert: The ink drop path here was not the same as the highlight path; in particular, the ink drop path is manually mirrored, while the highlight path is auto-mirrored. Reverting since this results in the wrong appearance in RTL. Original change's description: > Add HighlightPathGenerator to TabCloseButton > > Replaces OnBoundsChanged override which resulted in a lot of path > generation (per-tab + frame) while opening new tabs or resizing the > window. > > Also removes a ::GetInkDropMask() override which just generated the same > path. > > Bug: chromium:1007546 > Change-Id: I0131f9a589c1525e2c0eacd61c9fcd9f6ac05948 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861016 > Auto-Submit: Peter Boström <pbos@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705972} TBR=ellyjones@chromium.org,pbos@chromium.org Change-Id: Ic7bd1312d452c828877669db89af45ac59160455 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1007546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864393Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#706348}
-
Tim Schumann authored
This reverts the proto changes from commit d70c086c. Reason for revert: Server side code has a lot of dependencies that need to be cleaned up first. Original change's description: > Sync: Delete deprecated SUPERVISED_USERS and _SHARED_SETTINGS data types > > These two types are deprecated and can be removed. Note that > SUPERVISER_USER_SETTINGS and SUPERVISED_USER_WHITELISTS are *not* > deprecated. > > This includes removing the ModelType enum entries, removing the fields > in the EntitySpecifics proto, and deleting the specifics proto files. > > Bug: 965503 > Change-Id: I53038fdc28ed8518cd99d4a4769b5f1f52d3e94b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824882 > Commit-Queue: Marc Treib <treib@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700687} TBR=treib@chromium.org,mastiz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 965503 Change-Id: If5d1ee616f2ca4daefe69fd1e0ad3a516d726675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863789Reviewed-by:
Tim Schumann <tschumann@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Yang Guo authored
Bug: chromium:1014840 Change-Id: Idb98dcf0888fdecb74dad6f43163daa7a81c2302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864670 Commit-Queue: Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#706346}
-
Roman Sorokin [CET] authored
This reverts commit 05103cd7. Reason for revert: Broke OOBE pin keyboard, reverting in favor of CL:1862914. See bug for details Original change's description: > [CrOS Settings] Fix number alignment on PIN keyboard. > > Each button on the keypad includes space for a number as well as the > letters which represent the numbers (e.g., "ABC" for 2, "DEF" for 3). > However, since 1 does not have any associated letters, its alignment was > incorrect and noticeably different from the rest of the buttons. > > This CL fixes this alignment issue by aligning the number to the top of > the button and the letters to the bottom of the button. > > Fixed: 1004974 > TBR: stevenjb@chromium.org > Change-Id: I9be7be402b853cbf6ba76985151f77a0696ac13b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854638 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> > Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704900} TBR=stevenjb@chromium.org,khorimoto@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ida1e2ecc148859f38ae4b6075daa5a412453d707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863793Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706345}
-
Jinsuk Kim authored
https://crrev.com/c/1844341 implemented security requirements to BottomSheet-based Preview Tab. This CL ports it to OverlayPanel version, which is required to start stable experiment. Bug: 968567, 1007499 Change-Id: Id6bdb73a9038c9cf81db89afbd4881417d61d4bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859423 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#706344}
-
Sergio Villar Senin authored
In order to remove the dependency, the web_loading_behavior_flag.h file was moved to third_party/blink/public/common/loader. Since the file is no longer in the public/platform/ directory we are also renaming it loading_behavior_flag.h (and the enum defined in that file to LoadingBehaviorFlag). Bug: 1008303 Change-Id: I61141aacb431e6c53a2cde7beaeb091ea9eeac2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844951 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#706343}
-
Peter Kasting authored
Bug: 82078 Change-Id: Idf76d2ff85d63c7b26775c3fd9241892d31ff764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862494 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Peter Boström authored
Removes OnBoundsChanged overrides and unnecessary path updates. Bug: chromium:1007546 Change-Id: I78e1d2207c318d6b48bcf9825ad4064db97ed209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861140Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#706341}
-
Huanzhong Huang authored
This to a great extent prevents the knob animation on every opening of an incognito ntp. Bug: 967668 Change-Id: Ib99ba020b419d8c9aed2c910049d2662a3850d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855962 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#706340}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2b3a883db586..7274850f96f2 git log 2b3a883db586..7274850f96f2 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 2d0e5b554d4f..0b9ebe58e380 (2 commits) 2019-10-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 083c52f7..fbf280c2 (475 commits) Created with: gclient setdep -r src/third_party/skia@7274850f96f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: chromium:None,chromium:None Change-Id: I85cd5637e065977f5db13818c38f9a2a59e309d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864510Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706339}
-
Peter Kasting authored
This reverts commit 2dd2b245. Reason for revert: Seems to have broken android-archive-rel compile, though this may be exposing some pre-existing bad dependency elsewhere: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/5717 Original change's description: > [DevUI DFM] Change install flow to use NavigationThrottle. > > Previously, DevUI DFM installation used BrowserURLHandler to modify > DevUI URLs to chrome://dev-ui-loader, whose host performs DFM install > flow by calling C++ API via JavaScript. On install success, the page > forwards to the original DevUI URL. > > A flaw of the old flow was that it allows for URL "laundering", where a > compromised chrome:// page may use chrome://dev-ui-loader's ?url= query > param to access another chrome:// page, thereby bypassing potential > restrictions (e.g., referrer or origin). > > Another problem is that BrowserURLHandler does not run when a webpage is > restored on Chrome restart. This causes crbug.com/1013522, where DevUI > pages fail to load because resource load was not triggered. > > This CL uses NavigationThrottle to re-implement the DevUI DFM install > flow as DevUiNavigationThrottle. This solves the above problems, and is > simpler. Additional changes: > * Add i18n support to the install error page messages. > * Add extensive unit tests for DevUiNavigationThrottle. > > Bug: 927131,987040,1013522 > Change-Id: I5c384671c858d26a303afc58c03f4314c8ef0117 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854524 > Commit-Queue: Samuel Huang <huangs@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Dan Beam <dbeam@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706329} TBR=creis@chromium.org,huangs@chromium.org,thestig@chromium.org,dbeam@chromium.org,agrieve@chromium.org,tiborg@chromium.org Change-Id: I7eff36d7e01c31a76f39250a255d27972b0962d9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 927131, 987040, 1013522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864392Reviewed-by:
-
Timothy Loh authored
This CL tidies up PluginVmLauncherViewBrowserTest, removing the use of inheritance to observe state changes and instead allowing the class under test to have a callback which it calls upon completion. The newly added functions will also be used for an upcoming autotest private API, allowing the installer to be run from tast. Bug: 1006664 Change-Id: I3abb2d0fd08d0988c140dbb564c70a02929d1ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863063Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#706337}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/25741699ee0e..febc913dd024 Created with: gclient setdep -r src-internal@febc913dd024 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I591f774147df7415e8d9cfa6245f764298ce44ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864473Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706336}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a6896a8b. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" f399b336 "Fetch Metadata: Add a test for `<embed>` navigated after loading." 36ebfbe5 "Stop using private properties for data properties of cross-origin properties" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-writing-modes mstensho@chromium.org: external/wpt/css/css-multicol NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ic4421de2e1007d7190287fd91534a6215525bcc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863443Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706335}
-
Hiroki Nakagawa authored
Bug: 1014812 Change-Id: Id1ce9a48778fa71e188a35bc24d6191cb583e19d Tbr: nhiroki@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864752Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#706334}
-
Gyuyoung Kim authored
OnMediaRemoterCreated has still been using old Mojo types. This CL applies pending_remote and pending_receiver to the function. Bug: 955171 Change-Id: Iefbf6465dfd43940f4f0a9c46c28a1f4f2012ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829633Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#706333}
-
Juan Antonio Navarro Pérez authored
This reverts commit 37d44dbb. Reason for revert: Catapult roller failing with: AttributeError: type object 'StoryFilterFactory' has no attribute '_expectations' https://chromium-swarm.appspot.com/task?id=47eb08c183837510 Original change's description: > [Benchmarks] Smoke tests lay groundwork for move to story_filter. > > This change > https://chromium-review.googlesource.com/c/catapult/+/1839176 > makes it so that expectations config is passed to story_filter.py > using the project config (sometimes referred to as the > "environment"). This change lays the groundwork for that future > change. Until that change is committed, this is a no-op change. > > This change first requires this catapult-side change > https://chromium-review.googlesource.com/c/catapult/+/1854882 > to make sure that we don't pass an invalid argument to > GetRunOptions(). > > > Bug: 985103 > Change-Id: Idd53aaf7f84e792b0d7a7d0db6b45ce0562fb5f4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854794 > Commit-Queue: Caleb Rouleau <crouleau@chromium.org> > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Reviewed-by: Rakib Hasan <rmhasan@google.com> > Auto-Submit: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706080} TBR=perezju@chromium.org,crouleau@chromium.org,rmhasan@google.com Change-Id: I9cdcf778d4feaa3ab4d1dd1bd5385b53e99e4f21 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 985103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864671Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#706332}
-
Hiroki Nakagawa authored
Bug: 1014810 Change-Id: I1fb23439d996e8142353a05f6cc18c07ea3d0095 Tbr: nhiroki@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863068Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I654114143b038a86cc813bd5ce57508260abed5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864551Reviewed-by:
-
Samuel Huang authored
Previously, DevUI DFM installation used BrowserURLHandler to modify DevUI URLs to chrome://dev-ui-loader, whose host performs DFM install flow by calling C++ API via JavaScript. On install success, the page forwards to the original DevUI URL. A flaw of the old flow was that it allows for URL "laundering", where a compromised chrome:// page may use chrome://dev-ui-loader's ?url= query param to access another chrome:// page, thereby bypassing potential restrictions (e.g., referrer or origin). Another problem is that BrowserURLHandler does not run when a webpage is restored on Chrome restart. This causes crbug.com/1013522, where DevUI pages fail to load because resource load was not triggered. This CL uses NavigationThrottle to re-implement the DevUI DFM install flow as DevUiNavigationThrottle. This solves the above problems, and is simpler. Additional changes: * Add i18n support to the install error page messages. * Add extensive unit tests for DevUiNavigationThrottle. Bug: 927131,987040,1013522 Change-Id: I5c384671c858d26a303afc58c03f4314c8ef0117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854524 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#706329}
-
Julie Jeongeun Kim authored
This CL converts Model from model.mojom to new Mojo types using PendingReceiver, ReceiverSet, and Remote. Bug: 955171 Change-Id: Ie0ac1f426d46d8efe22bdb52c99d6c8e43051efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851367Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#706328}
-
Julie Jeongeun Kim authored
This CL converts ProxyConfigPollerClient and ProxyErrorClient from proxy_config_with_annotation.mojom to new Mojo types using PendingRemote, PendingReceiver, and Receiver. Bug: 955171 Change-Id: I3a877c85a6b0f7ec64beee91d56062e6de42bad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851985 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#706327}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/634d15032d37..2b3a883db586 git log 634d15032d37..2b3a883db586 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader a27dfcf868bf..9097eeb5359b (2 commits) Created with: gclient setdep -r src/third_party/skia@2b3a883db586 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: chromium:None Change-Id: I8c09ebdd682d7b8eb5e3fdb91d28faa46e8e6ac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864437Reviewed-by:
-
Alexey Baskakov authored
To avoid confusion with PendingAppManager's placeholder app. Bug: 860583 Change-Id: Ibd48d2114225b62b813e64aa2d563217929d9903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864494 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#706325}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c2615b7727cb..810ee9415435 git log c2615b7727cb..810ee9415435 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 cjmcdonald@chromium.org Return narrower & smarter paths for dependency service Created with: gclient setdep -r src/third_party/chromite@810ee9415435 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic24937cfde274aa908def3db27fcfcd8d051455e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864550Reviewed-by:
-
Yoshifumi Inoue authored
This patch change |LayoutText::CollectLineBoxRects()| to utilize |NGInlineCursor| instead of |NGInlineFragmentTraversal::SelfFragmentsOf()| as preparation of migrating to |NGFragmentItem|. This patch also makes |NGInlineCursor::MoveTo()| to work during layout to use previous layout result for scroll anchoring. Bug: 982194 Change-Id: I9f046540ab797f274b88072f26bb241e101175d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855152 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706323}
-
Daniel Rubery authored
These files should still be blocked, but the current UX only shows "Failed - Blocked". We would like to provide a little context to the user about the reason for the blocking. Mocks: https://docs.google.com/presentation/d/1MH7zM5YiuCZr3jYsqkTJRC0cqtdo8wuWZOOQ66jptVk/edit#slide=id.g5d9bcde872_0_0 Screenshots: https://screenshot.googleplex.com/eQvXRqtcGOJ.png https://screenshot.googleplex.com/JM7yHFkcBnc.png Bug: 980777 Change-Id: Ib097d0137d39383f66299fe891c710de693c828a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859579 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#706322}
-
Wanming Lin authored
Following Web NFC spec change at https://github.com/w3c/web-nfc/pull/383, this CL adds a test to check NFC scanning from top-level document will not be stopped when an iframe is focused Bug: 996250, 520391 Change-Id: If89079d7bf9d7dc58587abcd0c9a9a797420aa50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862475Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Wanming Lin <wanming.lin@intel.com> Cr-Commit-Position: refs/heads/master@{#706321}
-
Austin Tankiang authored
Paper ripples need an ancestor with style `position: relative` in order for the ripple to not escape. Bug: 1014819 Change-Id: I1f07fb769a47c573bafebf96172d5e2cfe309b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863058 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#706320}
-
Chase Phillips authored
* Update README.md with notes about where data model items are stored (db, disk/mem cache) * Update comment to point to HandleResourceFetchCompleted * Update section pointers for update spec items At some point, the AppCache spec gained a new section such that "6.9.4" became "7.9.4". This updates any "6.9.4" entries to "7.9.4". In at least one place, there were other spec changes so that the update steps within 7.9.4 also changed. I've tried to map them to the correct update step as best I could. * Update spec pointers for 6.9.5/6.9.6 to 7.9.5/7.9.6 Bug: 1014587 Change-Id: I0a787bd1eae6f5ffbc84dff225d863e8dc80ffc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862124 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#706319}
-
Yoshifumi Inoue authored
This reverts commit ff8a70bd. Reason for revert: Causes use-after-free in issue 1013490 Original change's description: > Make hit test on culled inline faster > > This patch changes |LayoutInlineCollector| to use |IsDescendantOf()| instead of > using |HashSet<T>| to make |SelftFragmentsOf()|, which is used by hit testing > and others, faster. > > I found the slowness of |LayoutInlineCollector| by CPU profiling[1] where > |HashSet<T>::insert()| consumes most of time. > > So, it seems traversing fragment tree + LayoutObject::IsDescendnatOf()| is > faster than two times of traversing fragment tree + |HashSet<T>::insert()|. > > > [1] https://bit.ly/2pXQbcE > > Bug: 1008523 > Change-Id: I825197f2b85fd2ef573e8ff159ddf966489361be > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847602 > Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704102} TBR=yosin@chromium.org,eae@chromium.org,kojii@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1008523, 1013490 Change-Id: Ie8b3757a3ce8ad5e2499195fef1f3cb48fbd8cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864491 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706318}
-
Manu Cornet authored
Rely on existing mechanisms to figure out the app list visibility, instead of maintaining a local boolean prone to get out of sync with the actual state. Remove extraneous test statements (they duplicate the calls to the "app list test helper" to check the same thing). Change-Id: If6385fae0ccec004a2afba9479abad452ecbdde9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860838 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#706317}
-
Jay Harris authored
Previously, hopping between threads had to be done manually at the call site of CreatePlatformShortcuts. This pushes this implementation detail down to the web_app_shortcuts layer, paving the way for shortcut creation from the AppShortcutManager. Bug: 860581 Change-Id: I6efca0f2f1fd08da1c27765ff82ff0b38f1b221d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862877 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#706316}
-
![Roman Sorokin [CET]'s avatar](https://secure.gravatar.com/avatar/7b28a287700b8b8659a03c33a38be1a8?s=80&d=identicon "Roman Sorokin [CET]")
