- 28 Sep, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I08cb627cece4a78e4cabbb170acafcc5343bfb53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436087Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811356}
-
Omar Morsi authored
This CL fixes a bug in ExtensionPlatformKeysService::SignTask::OnCanUseKeyForSigningKnown where a return statement is missing. That led to calling ExtensionPlatformKeysService::SignTask::OnCanUseKeyForSigningKnown::DoStep after the task is finished and deleted. Bug: 1132926 Change-Id: I0e5be5b4a90e54e045c33e0bfa3568c0737f9272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435197Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#811355}
-
Sonny Sasaka authored
This reverts commit eb59216d. Reason for revert: After evaluation, staying with green is decided. BUG=b:167556640 Original change's description: > [Bluetooth] Change Bluetooth subtext to gray > > As per recommendation in Comment #30 of crbug.com/1114876. > > BUG=b:167556640 > > Change-Id: I57bc4ff360d05d1d6a0b03f58d4f24e23492b858 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410746 > Reviewed-by: Tim Song <tengs@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Ryan Hansberry <hansberry@chromium.org> > Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808073} TBR=xiyuan@chromium.org,tengs@chromium.org,sonnysasaka@chromium.org,hansberry@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:167556640 Change-Id: I6dd86bf9e10c8c06bb2fec96561da7715d14ccee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430105Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#811354}
-
Jesse Schettler authored
Instead of manually setting each scan setting in the StartScanRequest of LorgnetteManagerClient::StartScan(), set them all at once using the given ScanSettings proto. This will eliminate the need to manually set additional settings that get added to the proto in the future. Bug: None Change-Id: I05f734c630beed8e9cfb9a7a5359c9441d5f0502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432310Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#811353}
-
Demetrios Papadopoulos authored
The IronA11Announcer approach does not work when a modal dialog is showing. A large number of cr-input instances reside within modal dialogs, and errors do not get announced to screen reader users. By using role="alert" the error gets announced, even when the cr-input resides in a modal dialog. Moreover, VoiceOver seems to not announce the same error text, even if the cr-input transitions from invalid->valid->invalid. A workaround has been employed to always removing role="alert" when the error is fixed and re-adding it when the error re-occurs which forces VoiceOver to always announce it. Bug: 1130778 Change-Id: I646e25814f4719fb1a39d206e0c970a8bb75aae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429943 Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#811352}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601294375-f18d3a3ac9a6313011d7149de4bf7e7984859ae2.profdata to chrome-linux-master-1601315959-4ec2d6a153e04750c200a2fe71bb63fd4f2d802c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I44d803cae53206a60d7f475480c12d79001b5c07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436094Reviewed-by:
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /content/browser/media This CL was uploaded by git cl split. R=sandersd@chromium.org Change-Id: I324ae893245bbd253e68e9e2d7b31fe0c62ccb87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434909 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#811350}
-
Mark Schillaci authored
This CL is the first part of an effort to port the existing Desktop feature to Android. This feature enables a user to send an image to Google to process to generate a descriptive alt text if a website does not provide one. Design Doc: go/2020-q1-android-image-descriptions Slide Deck: go/clank-imageDescriptions Launch Bug: 1057168 Original Desktop Design Doc for reference: go/chrome-a11y-annotations-design This is a conservative approach, we use a separate set of profile Prefs for this feature rather than syncing with the Desktop Prefs. This can be updated in time as needed. We have also hidden the entire feature behind a feature flag, so this CL is not visible to an average user. ---------- This CL adds the following: - Prefs, ContentFeatureFlag, and ChromePreferenceKeys - More Options menu item - User facing dialog - Associated strings etc for above ---------- AX-Relnotes: N/A Bug: 1057169 Change-Id: I61b0d21bfc665b194e5d181df3df8b7cbb9bbac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278304 Commit-Queue: Mark Schillaci <mschillaci@google.com> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#811349}
-
Ahmed Mehfooz authored
Limit the size of the pinned files container to make sure it's always 8px below the top of the screen. Bug: 1131268 Change-Id: I0533873d0039f1d1952e396724cebae10fc50200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427542 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#811348}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: If031db85723d9f2301446cfc3a351f1119dcf3bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431488 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#811347}
-
Lan Wei authored
MouseWheelEventQueueTest uses a non-existent #define for ChromeOS, defined(CHROME_OS), we should replace it with defined(OS_CHROMEOS). Bug: 1121653 Change-Id: Ia6ee5adf638aad3d25d03f36d0903c509d793ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433304Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#811346}
-
Mike Dodd authored
In 6f15f17c the audio focus was inadvertently being adjusted the Activity, Fragment, and Service, but we just want the Activity. Bug: internal b/169078948 Test: verify audio works for Cast and Bluetooth content Change-Id: Ia0e8991f82d2b44618307b67b9541f953d53f659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431409Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Mike Dodd <mdodd@chromium.org> Cr-Commit-Position: refs/heads/master@{#811345}
-
Sven Zheng authored
Error: File "build/lacros/test_runner.py", line 129, in _remove_unused_ash_chrome_versions age = time.time() - os.path.getatime(os.path.join(p, 'chrome')) File "/usr/local/google/home/svenzheng/.vpython-root/000cad/lib/python2.7/genericpath.py", line 67, in getatime return os.stat(filename).st_atime OSError: [Errno 2] No such file or directory: 'build/lacros/prebuilt_ash_chrome/for_bots/chrome' Bug: 1131739 Change-Id: I78dbaa624956a4e9019598eae3c07270907792bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429590Reviewed-by:Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#811344}
-
Jordan Bayles authored
The AudioDecoder tests are no longer broken on Android, and can be re-enabled. See: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8868055132639161312/+/steps/cast_unittests_on_Android_device_Nexus_5__with_patch_/0/stdout Bug: 831999 Change-Id: I1d7cbd3adbd1734adc04bd5f0fb6c713815986e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433664Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/master@{#811343}
-
Antonio Gomes authored
This is phase 4 on the design document [1]. [1] https://docs.google.com/document/d/19Zk6Fv1E-6QTQ2c33rpBjDNEkzlsSKvjb3hWkvZAE80/ BUG=787252 R=guidou@chromium.org, haraken@chromium.org Change-Id: If7d88ea6be23d46dd78a9c9bbdc564762ae86a80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435922Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#811342}
-
Alex Newcomer authored
Add this metric to help us understand usage and plan improvements. Add ClipboardHistory.ContextMenu.NumberOfItemsShown. This metric will help UX see if we should increase the size of multipaste, or whether 5 is enough. It will also function as a heartbeat metric for the feature. Add UserJourneyTime to understand usage. Bug: 1099338 Change-Id: If3253db5da7ba22554a806d8903929de3e81f17a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425005 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#811341}
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /content/browser/web_contents/web_contents_view_mac.mm This CL was uploaded by git cl split. R=ellyjones@chromium.org Change-Id: I23958320fc719b9b5f8179110aa789441313f251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435312 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#811340}
-
Dana Fried authored
This is a small workaround. Root cause is crbug.com/1132767, which is not as easily solved. Bug: 1129763 Change-Id: Ifa7daa12a0d36c99b4eacdc35c9dd2bb70b4e1c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434891 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#811339}
-
Bartek Nowierski authored
The old code is undesirable, because: 1. It was not following go/totw/28 advice about using the following pattern: VideoDecodeAccelerator::Client* client = nullptr; using std::swap; swap(client, client_); 2. Is not really needed, because the swap is with a known constant. 3. Might not compile if in the future, hypothetically the type of |client_| becomes |base::CheckedPtr<VideoDecodeAccelerator::Client>|. (this last issue may be fixable either by: A) using the new pattern or B) implementing |swap(T*&, CheckedPtr<T>&)| function in the base namespace). Bug: 1080832 Change-Id: I937a60cae6d9d164b088227cca209f4bcc0473a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435171 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:Ken Rockot <rockot@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#811338}
-
Chong Gu authored
By default, the host tools have the same architecture as the target cpu. Provide a variable to indicate when that's not the case. Add GN SDK scripts to data. Bug: 1080854 Change-Id: Ia2d55d7f95ddc2574cdd4ba0446ba2e4448a9da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433417Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#811337}
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /chrome/browser/ui/views/webauthn This CL was uploaded by git cl split. R=nsatragno@chromium.org Change-Id: I0d2cf195336da3a9bcb34465d2e5e8e144807ad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435881 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#811336}
-
David Grogan authored
Mozilla fixed two tests that had bad expectations. Change-Id: I3ca6a508d55a5b6f886f01145d779f88e82555aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433092 Auto-Submit: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#811335}
-
Gavin Williams authored
Remove the feature flag enable-streamlined-usb-printer-setup as the feature has been successfully released. Original tracking bug: crbug/951135 Bug: 1128737 Change-Id: I71faa115bc743aa9ff5e361cc6c6035809a98e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412832Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#811334}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1601098956-2811654f54d3946c8e0477e7d77d36d5dbdfab8f.profdata to chrome-win64-master-1601304808-a0959ded2b2639d64197cdec426ae296818dc3ae.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: Id7913a61214b06a6cb5002b5f154ebf23bd4bc7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435908Reviewed-by:
-
danakj authored
The Convert*ToDIP() and Convert*ToPixel() functions are problematic in that they hide what decision is being taken in the underlying code when moving from floating point to integer, and consumers should be thinking about what they want for correctness. They also act in inconsistent ways when converting a Rect vs its components. This removes the functions that perform float->int conversions in order to have callers show what they intend to happen and make it clear that data is being lost in some fashion. R=ccameron@chromium.org, sky@chromium.org Bug: 1130050 Change-Id: Icb49a8a392c50cfe85a646afe30528d9d7207057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426366 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#811332}
-
Henrique Nakashima authored
ChromeVersionInfo is now responsible only for showing the Chrome version, while PlayServicesVersionInfo for Play Services. Bug: 1131982 Change-Id: Ie6bc77f10a47c0d5379c3eb244f9b025f52e0d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428628 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /content/browser/appcache This CL was uploaded by git cl split. R=mek@chromium.org Change-Id: Ic95365fb8db7002cb97aa7b2a3a22ac6173e37d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435700 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#811330}
-
Henrique Nakashima authored
Now it looks like this: 7 outbound dependencies from .c.b.tabmodel.TabWindowManager may need to be broken (omitted 11 cleared dependencies): [chrome_java] -> .c.b.app.tabmodel.ChromeTabModelFilterFactory -> .c.b.multiwindow.MultiInstanceManager -> .c.b.multiwindow.MultiWindowUtils -> .c.b.tabmodel.AsyncTabParamsManager -> .c.b.tabmodel.TabModelSelectorImpl -> .c.b.tabmodel.TabPersistencePolicy -> .c.b.tabmodel.TabbedModeTabPersistencePolicy Used to be: Printing class dependencies for .c.b.tabmodel.TabWindowManager: 18 outbound dependency(ies) from .c.b.tabmodel.TabWindowManager: [chrome_java] -> .c.b.app.tabmodel.ChromeTabModelFilterFactory -> .c.b.multiwindow.MultiInstanceManager -> .c.b.multiwindow.MultiWindowUtils -> .c.b.tabmodel.AsyncTabParamsManager -> .c.b.tabmodel.TabModelSelectorImpl -> .c.b.tabmodel.TabPersistencePolicy -> .c.b.tabmodel.TabbedModeTabPersistencePolicy 7 dependencies above may need to be broken, ignored others. Change-Id: I78d7ff99316bbe213cee68f97846ffff54877818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432663 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by: -
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/059781eddd4e..7930477fba50 2020-09-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from e7fcc14d450b to 2bfd6a752dc6 (1 revision) 2020-09-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 8ab1c000aaa0 to db992e60cc7a (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I54cdac9d5a0eedbf0400b6ec5d4fadabf5c77f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434227Reviewed-by:
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /chrome/browser/ui/app_list/arc This CL was uploaded by git cl split. R=lgcheng@google.com Change-Id: I3a6915dc3a04977b760d9555352831f81a7081a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435351 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Commit-Queue: Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#811327}
-
Dana Fried authored
This is a small workaround. Root cause is crbug.com/1132767, which is not as easily solved. Bug: 1129763 Change-Id: I3a96f9aa7ca7bfebd7b410097f32a871df3abff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435145 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /components/offline_pages This CL was uploaded by git cl split. R=jianli@chromium.org Change-Id: Ifff21514df23ac39f13dff3228bd619760d8a679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434628 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#811325}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/59d660c075bd..defd223d4023 2020-09-28 robertphillips@google.com Add correctness checks to GrThreadSafeViewCache tests 2020-09-28 brianosman@google.com Revert "Support out parameters that use a swizzle." 2020-09-28 michaelludwig@google.com Update SkClipOp::kMax_EnumValue to match non-deprecated values 2020-09-28 herb@google.com remove unused call from remote glyph cache API 2020-09-28 johnstiles@google.com Simplify IsAssignable to only support one assignable var. 2020-09-28 kjlubick@google.com [fuzz] Add CIFuzz taskdriver 2020-09-28 kjlubick@google.com [canvaskit] Use linear metrics in shaping demo 2020-09-28 johnstiles@google.com Support out parameters that use a swizzle. 2020-09-28 kjlubick@google.com [canvaskit] Increase timeout for RenderSKPs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408,chromium:1132687 Tbr: brianosman@google.com Change-Id: I3b88e6e637e4dcb0257ba6b4c1d7778ff7bee3e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435502Reviewed-by:
-
John Lee authored
This CL adds a new menu observer to add an item to the context menu that when selected, copies the selected text and a URL to the selected text to the user's clipboard. Bug: 1105862 Change-Id: Ic827c6f6441f0af4d3df1958a285f90f59204448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429584 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
-
Robin Lewis authored
Also has fixes for issues discovered during integration testing with backend. Bug: 1130939 Change-Id: If92a34a451892d49dc4920643313896986a456d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423355 Commit-Queue: Robin Lewis <wrlewis@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#811322}
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /content/browser/sms This CL was uploaded by git cl split. R=reillyg@chromium.org Change-Id: I2ec4c07a65a3452bc23982b31d5b0e8f08068838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435999 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#811321}
-
Eric Orth authored
Remove //chrome/browser from the friend list for //net/dns:host_resolve. gn check passes without it now because all of //chrome/browser's usage has been fixed to use //net/dns/public. Also had to fix one last unused dns_config.h include. Fixed: 1129993 Change-Id: I405ecb969398972ed335fa6b3674dc659ad033b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427346 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#811320}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 87-4247.0-1600681610-benchmark-87.0.4275.0-r1 to 87-4258.0-1601290734-benchmark-87.0.4275.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I29c7c0a2a654abe576a0e33100ce5423a2d1df7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435915Reviewed-by:
-
Hoch Hochkeppel authored
Adding a wrapper function around Window's Share operation to allow using it like a traditional async operation. Adding tests (and one more test-helper class) that verify the behavior of the wrapper function. Bug: 1035527 Change-Id: I71cc7aaa6826d53cc1273c99b603db89612f1544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402293 Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#811318}
-
Haiyang Pan authored
This reverts commit a5707a7d. Reason for revert: Likely the cause of test failure in AccountPickerDialogFragmentTest on android builders: * https://ci.chromium.org/p/chromium/builders/ci/android-arm64-proguard-rel/2755 * https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/2363 The error said: Attempt to invoke virtual method 'boolean org.chromium.base.ObserverList.c(java.lang.Object)' on a null object reference at org.chromium.components.signin.identitymanager.IdentityManager.addObserver(IdentityManager.java:95) at org.chromium.chrome.browser.signin.ProfileDataCache.addObserver(ProfileDataCache.java:211) Original change's description: > [Android][Signin] Add observer to listen to monogram update > > This CL adds an observer to update ProfileDataCache when user's profile > photo(include monogram) from IdentityManager is updated. > > Bug: 1127886 > Change-Id: I0c70f72708e50dceb63eb122055315f7818cba06 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430984 > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Commit-Queue: Alice Wang <aliceywang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811237} TBR=msarda@chromium.org,bsazonov@chromium.org,aliceywang@chromium.org Change-Id: I91562cb8017c2a74afd391fede5d9b206e7e6b5d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1127886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435151Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#811317}
-
