- 09 Mar, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6ff3f116a334..a77d0ef73e6b Created with: gclient setdep -r src-internal@a77d0ef73e6b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I828160c34daa49c287446713332486646488de18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094539Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748108}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2f82a6e5ffe7..213a50aaa32d git log 2f82a6e5ffe7..213a50aaa32d --date=short --first-parent --format='%ad %ae %s' 2020-03-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@213a50aaa32d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iaf72885acc2831c515a574e37b55e373ad793ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094675Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748107}
-
Maggie Cai authored
This test is flaky on multiple builders. And I cannot find a CL that look suspecious. Disable this test for now. BUG=1059632 TBR=nasko@chromium.org Change-Id: I19c7a021f526833a5187f17361c4b07d88f77a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094518Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#748106}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: I6c4859b2213f37ff6fdbffb37177513e80448f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094459Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748105}
-
Kent Tamura authored
and rename it to MaximumOptionWidthMightBeChanged(). This CL has no behavior changes. Bug: 1052232 Change-Id: Ifb891a8c0bfb916075f44460ef85be301982932c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094475Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#748104}
-
Maggie Cai authored
This reverts commit 4e6e084b. Reason for revert: This CL is likely to cause the build failure for https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3799 and https://ci.chromium.org/p/chromium/builders/ci/Cast%20Audio%20Linux/68656 (first failure linked). Original change's description: > Use Mojo for Pointer Lock Requests > > Pointer lock requests were still using the old IPC workflow. This > updates the call to use Mojo. > > Bug: 1042293 > Change-Id: I5b3b58b56f37fd8ea3fb5960579340fc0d72514a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028453 > Commit-Queue: James Hollyer <jameshollyer@chromium.org> > Reviewed-by: Vincent Scheib <scheib@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748021} TBR=sky@chromium.org,danakj@chromium.org,dcheng@chromium.org,scheib@chromium.org,sammc@chromium.org,dtapuska@chromium.org,odejesush@chromium.org,jameshollyer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1042293 Change-Id: I38dd8c8c881e03c878fa9c85846e04f35ff6f661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094517Reviewed-by:
-
Jiawei Shao authored
This patch implements the destructor of Blink::GPUDevice so that when it is destroyed in Blink, all the related data structures in both the client and service side of WebGPU command buffer can also be destroyed. BUG=chromium:996713 Change-Id: Ibe11aabf395d2dfa33ae3ccfa404d250ffd4c10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088690Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Cr-Commit-Position: refs/heads/master@{#748102}
-
Yusuke Sato authored
BUG=None TEST=try Change-Id: Ibe7d51b4b2afe9697ca689ab9998433ab7eba5ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094189 Auto-Submit: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#748101}
-
Luciano Pacheco authored
Fixes: 1058532 Change-Id: I5acbc019aed63ebf55394bb2bc4bc8654e136439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094578 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#748100}
-
Yu Han authored
Previous to this CL, Imperative shadow DOM Slot API was put on hold. A previous implementation is still in place but disabled. Since then, in 2019 TPAC F2F, the Imperative Slotting API behavior has been updated. This CL adds new test cases which reflects this new behavior for Imperative Shadow DOM API. They are turned off for now, but will be enabled one by one as its functionality gets implemented. This is the post for I2P: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TNYIAu5E_M4 Bug: 869308 Change-Id: Ie875a3eb2b349942b6aa51af387460c470572491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083742 Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#748099}
-
Raul Tambre authored
../../base/containers/checked_range_unittest.cc(49,17): error: call to 'size' is ambiguous static_assert(size(array) == range.size(), ""); ^~~~ ../../buildtools/third_party/libc++/trunk/include\iterator(1875,16): note: candidate function [with _Cont = std::__1::array<int, 5>] constexpr auto size(const _Cont& __c) ^ ../..\base/stl_util.h(90,16): note: candidate function [with Container = std::__1::array<int, 5>] constexpr auto size(const Container& c) -> decltype(c.size()) { ^ ../../base/containers/checked_range_unittest.cc(62,17): error: call to 'data' is ambiguous static_assert(data(il) == range.data(), ""); ^~~~ ../../buildtools/third_party/libc++/trunk/include\iterator(1932,22): note: candidate function [with _Ep = int] constexpr const _Ep* data(initializer_list<_Ep> __il) noexcept { return __il.begin(); } ^ ../..\base/stl_util.h(146,20): note: candidate function [with T = int] constexpr const T* data(std::initializer_list<T> il) noexcept { ^ ../../base/containers/checked_range_unittest.cc(63,17): error: call to 'size' is ambiguous static_assert(size(il) == range.size(), ""); ^~~~ ../../buildtools/third_party/libc++/trunk/include\iterator(1875,16): note: candidate function [with _Cont = std::initializer_list<int>] constexpr auto size(const _Cont& __c) ^ ../..\base/stl_util.h(90,16): note: candidate function [with Container = std::initializer_list<int>] constexpr auto size(const Container& c) -> decltype(c.size()) { ^ ../../base/containers/checked_range_unittest.cc(164,17): error: call to 'size' is ambiguous static_assert(size(array) == range.size(), ""); ^~~~ ../../buildtools/third_party/libc++/trunk/include\iterator(1875,16): note: candidate function [with _Cont = std::__1::array<int, 0>] constexpr auto size(const _Cont& __c) ^ ../..\base/stl_util.h(90,16): note: candidate function [with Container = std::__1::array<int, 0>] constexpr auto size(const Container& c) -> decltype(c.size()) { ^ Bug: 752720 Change-Id: Icac3e6118db2e2fefa288ce23386b75714d1b979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094295 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#748098}
-
Noel Gordon authored
The iconSet property of most volume types is empty, but we expect that third party volumes (ANDROID_FILES, DOCUMENT_PROVIDERS and File System Providers) should provide icons in their iconSets. File System Providers icons are filtered via CSS, to try and create an "active" state icon for their directory tree tab [1]. The filtered icon can have poor visual quality, depending on the icon, but ANDROID_FILES, DOCUMENT_PROVIDERS icons are left alone - we do not try and filter them. Make File System Providers join the party, do not try and filter them either. [1] iconsSets do not provide "active" icon variants. Bug: 992819 Change-Id: I675f465d25ac45afdb669657d3a22c24a02ecf17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094516Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Sara Kato authored
Test: None (build passes) Bug: None (internal cleanup) Change-Id: I91e3351f2ac345c34f5e8f36566fa7f541a08275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094577Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#748096}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I205ee64f8fc092002c0a4f5ba3d7479b771859d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094537Reviewed-by:
-
Hugo Benichi authored
This patch removes net.mojom APIs and fields only used in ARC N: - NetworkConfiguration mac_address: the host mac_address of a network is now completely hidden in ARC P. - GetDefaultNetwork and DefaultNetworkChanged: ARC P is multinetwork aware and always need the full list of connected services. BUG=b:149716479 BUG=b:145960788 TEST=Compiled, flashed eve, ran CtsNetTestCases. Change-Id: I3368d620d44dd910aae7a12c84c207c3d5cb6cf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086362Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Hugo Benichi <hugobenichi@google.com> Cr-Commit-Position: refs/heads/master@{#748094}
-
Jae Hoon Kim authored
If Plugin VM was installed prior to DLC support being added, PluginVM will fail to launch as the rootfs components will be removed. This CL updates the launch flow to attempt installing the Plugin VM DLC if the dispatcher fails to launch. This also allows us to recover from unexpected errors where the DLC module might get uninstalled or fail to be updated. BUG=b:150867372 TEST=out/Default/unit_tests && out/Default/browser_tests # with PluginVM filters Change-Id: I9ed6287bf1a35d38778003e8f629166fa5b8dfc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090619 Auto-Submit: Jae Hoon Kim <kimjae@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#748093}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/475b9d0fb796..c56950442dd1 git log 475b9d0fb796..c56950442dd1 --date=short --first-parent --format='%ad %ae %s' 2020-03-08 martin@mainframe.co.uk fall back to vswhere.exe to find msvc Created with: gclient setdep -r src/third_party/skia@c56950442dd1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: I3f4713ddfadee630ece8ccef553d0488aa2543a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094536Reviewed-by:
-
Maggie Cai authored
This test start failing on multiple linux chrome os bots since 8th March. There is no CL on the blame list that looks suspecious. Disable the test and file a bug for the owner to look at it. BUG=1059626 TBR=afakhry@chromium.org Change-Id: I74770b256c9d6448d7cd3f581f44e8170b3828f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094416Reviewed-by:
-
Luciano Pacheco authored
When the element has the focus is hidden/removed/disabled the browser moves the focus to <body>, in this situation user doesn't have any visual clue where is the focus. To fix this we move the focus from <body> to file list which is the default element when opening Files app. Use "focusin" and "focusout" in the <body> element, because these two events bubble from any body's child element, whereas "focus" event doesn't. In the event handler we use requestIdleCallback() to give a chance for any synchronous code to finish and potentially set the focus somewhere else other than <body>. Test: browser_tests --gtest_filter="*tabindexFocusBody*" Bug: 1059137,957413 Change-Id: I9563294a3b6c541cf6bd2bba03470041bc8af41b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089444Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#748090}
-
Chih-Yu Huang authored
Originally USE_CHROMEOS_MEDIA_ACCELERATION is only used in //media/gpu. We plan to use it at other //media code. This CL moves this buildflag from //media/gpu to //media. Bug: b:149797442 Test: run `gn check` and `ninja chrome` on octopus and kevin boards Change-Id: I7b5139d2cbfe6cdd1242ba82b428865a6af41cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089539Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#748089}
-
Bence Béky authored
Bug: 1059073 Change-Id: I0ab1d5a5d311c7e5187acf16021e5a86e3325a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090506 Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#748088}
-
Zain Afzal authored
Previously for every js file we needed in index.html or app.html we would manually add a .grd entry, then an addResourcePath call and then a script tag in the relevant html file. This was tedious and cluttered up our html and cc files. This CL adds single js files which bundle together the scripts we need in index/app.html, adding more js sources now just involves adding a `// include<>` to the relevant bundle file (i.e media_app_(app|index)_scripts.js). Bug: 1059134, 996088 Change-Id: I972f538b8414b381529543b8d4692cf6c5390328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093957Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Zain Afzal <zafzal@google.com> Cr-Commit-Position: refs/heads/master@{#748087}
-
Chih-Yu Huang authored
Currently GpuArcVideoDecodeAccelerator bridges the video codec from ARC++ to a VDA instance. We plan to deprecate to VDA implementation at chromium by new VD implementation. So we temporary need an adapter to convert between these two interfaces, until the GpuArcVideoDecodeAccelerator is ported to the new VD interface. This CL implements VdVideoDecodeAccelerator as the adapter. With this class, GpuArcVideoDecodeAccelerator could bridge the video codec to a VD instance via the adapter. Bug: b:136716838 Test: Pass video_decode_accelerator_tests with following CLs on Kevin and eve Change-Id: I17f8607cc422c682eaad7760f5680a425de90095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913228 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#748086}
-
Noel Gordon authored
Use <cr-action-menu> for the drop-down menu items, style to match non- files-ng menus items (or as close as I could get them). Tune the <cr-action-menu> location to be under elider ... button, then tune its horizontal Location for RTL/LTR. <cr-action-menu> is position absolute and its code needs to calculate widths causing style resolves so our use of offsetLeft offsetWidth etc to locate the menu _does not_ add more style resolves overall. Change the breadcrumb HTML structure (simplify and remove unneeded DOM elements, p:before, p), and JS code to integrate <cr-action-menu>, and have it deal with drop-down menu keyboard/mouse/scroll interactions. Note: <cr-action-menu> handles menu item ARIA. Logical follow-up would be ARIA for the elider ... button itself and consider if we should use <cr-button>, deal with the elider button tap-target size ... Bug: 1035691 Change-Id: Ie241cec3911847be90971d13629fbdf47c54e1d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094057Reviewed-by:
-
Kazuki Takise authored
Even if a client sends the post-rotation buffer and new orientation at the same time during screen rotation, currently the orientation lock is reset before the frame with the buffer isn't completely processed. This CL moves the reset logic from OnPostWidgetCommit() to DidReceiveCompositorFrameAck(); BUG=b:118493249 TEST=Manually confirmed display rotation didn't cause black flashes for ARC apps. Change-Id: I470bef456345b67cfee396c80157cc97e852b603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089562 Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Reviewed-by:Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#748084}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/7d20b4450182..532be50b761b git log 7d20b4450182..532be50b761b --date=short --first-parent --format='%ad %ae %s' 2020-03-09 jiawei.shao@intel.com Check bindingType with shader stage when creating default pipeline layout Created with: gclient setdep -r src/third_party/dawn@532be50b761b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ifcf57a3015588e50ae5478c38c05a0d3215a5e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093530Reviewed-by:
-
Hitoshi Yoshida authored
This CL does following refactorings; a) Filter usable events in .py at the beginning b) Reduce the number of include files based on a) c) Remove an unnecessary branch Before this CL, make_event_factory.py filtered events to iterate in template system. Beside it, the code also iterated all given events to generate included files. As a result, a generated file included many unnecessary header files. After this CL, the code makes a list of events to work for, and does every iteration over it. Bug: 839389 Change-Id: I095a1c8e7b3a403687129160acca2f8ef880eb58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089545Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#748082}
-
Nicholas Verne authored
If Chrome crashes while crostini is running, old mount points for the sshfs file system are still polluting mtab, and if we don't remove them here, then on restarting the VM we still won't be able to use Linux files in the files app. Hence we remove the old mounts at session startup if it's an unclean startup. Bug: 1057899 Change-Id: Ib5082c973e245800ac976efcecfd0aad96fe998d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089538 Commit-Queue: Nicholas Verne <nverne@chromium.org> Auto-Submit: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#748081}
-
Maggie Cai authored
This reverts commit d6d50478. Reason for revert: This CL is very likely to cause the build failure for https://ci.chromium.org/p/chromium/builders/ci/Cast%20Audio%20Linux/68631. Original change's description: > Feed refactor: Proto conversion > > Add StreamModelUpdateRequest and functions for converting wire protos into store protos > > Bug: 1044139 > Change-Id: I243ebabc331884500dec480c69d843d38546a34e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020545 > Commit-Queue: Ian Wells <iwells@chromium.org> > Reviewed-by: Dan H <harringtond@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747983} TBR=iwells@chromium.org,harringtond@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1044139 Change-Id: Ide56a6466080cd643c9cf27632d158d8323fef07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094476Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b18390699ea2..475b9d0fb796 git log b18390699ea2..475b9d0fb796 --date=short --first-parent --format='%ad %ae %s' 2020-03-08 chrdavis@microsoft.com Remove global static mutex in SkScalerContext_win_dw.cpp Created with: gclient setdep -r src/third_party/skia@475b9d0fb796 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: I2872bdd6bc0224ad1c058445516fc75d92db10c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093528Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dd2dfc45b8a1..6ff3f116a334 Created with: gclient setdep -r src-internal@6ff3f116a334 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I80307c3fd4572aafbda25ef88aadb0af9690b129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093527Reviewed-by:
-
John Palmer authored
1) Actually use the mode parsing function 2) Default to "" rather than "text" which brings the behaviour to be more like what would be expected Change-Id: I6a46437ac797d59810e099af1ddf564d532e05b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087497Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#748077}
-
Timothy Loh authored
This CL updates the task manager so that the "End process" button will force kill Plugin VMs, instead of attempting to gracefully shut them down (which can be done via the shelf context menu). Bug: 1059152 Change-Id: I407ff4248625f8510e951227ec2ece66948e4c87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087328Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#748076}
-
nancy authored
BUG=1038487 Change-Id: If6e135795924159775428b4f10a95101dc506f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093074Reviewed-by:
-
Rachel Carpenter authored
This reverts commit 25d52129. Reason for revert: Launch being punted to M83. Original change's description: > Enable kHelpAppV2 by default. > > For M82. > Launch bug: https://crbug.com/1042109 > > Bug: 1012578 > Change-Id: I76e80ed1f8afc5a34f76fbad30ebef731fd84ff0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076738 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Commit-Queue: Rachel Carpenter <carpenterr@google.com> > Cr-Commit-Position: refs/heads/master@{#744935} TBR=tapted@chromium.org,alemate@chromium.org,carpenterr@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1012578 Change-Id: Ia50fb959b29c97d5e839fd67ecb5a562fadb45d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089537Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@google.com> Cr-Commit-Position: refs/heads/master@{#748074}
-
Rachel Wong authored
This change implements logging of features that are shared by all quick settings logging functions. - Audio feature was previously only logged for a volume change, but has been moved to become a shared feature. - There is also some reordering of the header file for readability reasons. Bug: 1014839 Change-Id: I4fc6cc9dc4d76acae5450894ec49258320b02d24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087300Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#748073}
-
Raul Tambre authored
The L suffix was removed in Python 3. Fortunately this can be simply removed. The long type was also removed in Python 3, where int does the same thing. Simply alias long to int on Python 3. Works on both now Python 2 and 3 now, producing the same results as before. Traceback (most recent call last): File "../../third_party/blink/renderer/build/scripts/make_names.py", line 33, in <module> import hasher File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\hasher.py", line 26 return uint32_t(long.__rshift__(self, other) & ((1L << 32) - 1)) ^ SyntaxError: invalid syntax Bug: 941669 Change-Id: Ib0369ebce8c3bd843ebbbe24188fbe941fa1a2ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093471 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: -
chrome://media-appTrent Apted authored
Currently there is only one typechecking pass for chrome://media-app. This means the two JS contexts are being typechecked together, and the compiler doesn't complain if receiver.js uses function signatures in launch.js even though they are isolated from each other. Create one type check target for each .html file, listing the .js files included in each (via script tags). Bug: 996088 Change-Id: I7d24a54a1869a535721ef162ec15d268b3b00171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091092Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#748071}
-
Hiroki Sato authored
This CL adds HasStandardAction in arc accessibility util. Bug: none. Test: unit_test Change-Id: I1380f1f89647bbe2b39dedc3da0f28ffb3fd90b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091098Reviewed-by:
Sara Kato <sarakato@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#748070}
-
Raul Tambre authored
iteritems() was removed in Python 3. items() does the same on both. Traceback (most recent call last): File "../../third_party/blink/renderer/build/scripts/make_feature_policy_helper.py", line 79, in <module> json5_generator.Maker(FeaturePolicyFeatureWriter).main() File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 337, in main writer = self._writer_class(args.files, args.output_dir) File "../../third_party/blink/renderer/build/scripts/make_feature_policy_helper.py", line 15, in __init__ super(FeaturePolicyFeatureWriter, self).__init__( File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 276, in __init__ self.json5_file = Json5File.load_from_files( File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 140, in load_from_files return Json5File(file_paths, merged_doc, default_metadata, File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 124, in __init__ self._process(doc) File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 155, in _process entry = self._get_entry(item) File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 197, in _get_entry self._validate_parameter(self.parameters[key], value) File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 218, in _validate_parameter elif not _is_valid(valid_values, value, valid_keys): File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 106, in _is_valid for key, val in value.iteritems()]) AttributeError: 'dict' object has no attribute 'iteritems' Bug: 941669 Change-Id: I5a60c0b54584a743ec86e51902e061af08c59c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093213 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
