Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 24 Oct, 2014 2 commits
    • bungeman@chromium.org's avatar
      Begin converting blink_skia_config from gyp to gypi. · 4af1b5c4
      bungeman@chromium.org authored 
      According to the design document for the existence of the
blink_skia_config.gyp file, it was originally intended to be a gypi
as proposed in this change. However, at the time, use of the
'<(webkit_src_dir)' gyp variable was required to get the correct
location of WebKit. Since variables do not expand in 'includes' in gyp,
a gyp file was used instead so that it could be used in 'dependencies'.

These limitations no longer exist and converting to a gypi allows for
easier interoperation with gn. There will be a subsequent change to
Chromium to use this new file, and then the existing gyp file will be
removed in a follow-up change.

Review URL: https://codereview.chromium.org/671323002

git-svn-id: svn://svn.chromium.org/blink/trunk@184315 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4af1b5c4
    • bashi@chromium.org's avatar
      IDL: Avoid global variables in compute_interfaces_info_individual.py · 79c6adce
      bashi@chromium.org authored 
      compute_interfaces_info_individual has global variables. These variables
are updated each time we call compute_info_individual(). This could be
a problem when we want to call compute_info_individual() for separate
components in the same process. Such cases could happen in
run-bindings-test when we add union types collection in
compute_info_individual(). We would want to collect all union types
which are used by IDL files under Source/bindings/test/idls, but we
don't want to collect them for IDL files under Source/{core,modules}.
This CL introduces a class and moves global variables into the class
as instance variables.

This CL doesn't change generated bindings code at this moment.

BUG=425916

Review URL: https://codereview.chromium.org/671863002

git-svn-id: svn://svn.chromium.org/blink/trunk@184314 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      79c6adce
  3. 23 Oct, 2014 38 commits