- 12 Sep, 2019 40 commits
-
-
Himanshu Jaju authored
Vector drawable is not supported for api < 21. srcCompat should fix this error. Bug: 1003194 Change-Id: Ib2bb4d0078b60552599969828ba43a2660af337c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800744Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#695985}
-
Julie Jeongeun Kim authored
This CL converts NavigationClientAssociatedPtrInfo, NavigationClientAssociatedPtr, NavigationClientPtr, and NavigationClientAssociatedRequest to new Mojo types. It also updates BeginNavigation from frame.mojom and methods and members which implements it with new Mojo types. Bug: 955171 Change-Id: I2ed4aa7cdf57361c982e3adc696cc9ead797630b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797823Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#695984}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ica28d8cb253e5c316e51f53054eaadbe59004ec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800504Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695983}
-
Vasilii Sukhanov authored
The update bubble is important and we want the user to interact with it. Otherwise, the user may lose the password. Bug: 1003046 Change-Id: I1a0667d139023362e5944647c298da10110c5baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798673 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#695982}
-
vitaliii authored
This reverts commit 447ff85d. Reason for revert: tests timeout in Win. https://bugs.chromium.org/p/chromium/issues/detail?id=1003278 Original change's description: > Build and test QUIC BBR2 code. > > Change-Id: I06895589359a77bb771d3b8f8a857ee50398dbec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790488 > Commit-Queue: Bin Wu <wub@chromium.org> > Reviewed-by: Ryan Hamilton <rch@chromium.org> > Cr-Commit-Position: refs/heads/master@{#695718} TBR=rch@chromium.org,wub@chromium.org Change-Id: Ic0f09bb22c6462875295064221dc267ef618dbe2 BUG: 1003278 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800407Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#695981}
-
Victor Costan authored
Change-Id: Ie47a640e059c902745b59bce36b4e94c5ac3b308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797831 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#695980}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/12b5425582ea..da5dbc1bca3e Created with: gclient setdep -r src-internal@da5dbc1bca3e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I811b9103f4628b1d9ccf4d158c11d5754752bf89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799848Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695979}
-
Pâris MEULEMAN authored
This adds reloadAccountsFromSystem on IdentityManager.java and updates SigninManager.java to use this instead of going through signin_manager_android.cc. This is the last IdentityManager access from signin_manager_android.cc remaining except for the construction of SigninManager.java. Bug: 934688 Change-Id: I3280102e03cb7b67b0f5ab3c569929854cc647bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789385 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#695978}
-
Polina Bondarenko authored
Add requiredKeyPairs ARC policy that contains certificate names for the smart card certificates, available to ARC. This policy is needed to be able to remove smart cards from the list once the reader is detached. The list is updated after the ArcSmartCardManagerBridge::Refresh is called. Bug: b:119914122 Test: ./out/Debug/unit_tests --gtest_filter=ArcSmartCardManagerBridgeTest* Test: ./out/Debug/unit_tests --gtest_filter=ArcPolicyBridgeRequiredKeyPairTest* Test: ./out/Debug/browser_tests --gtest_filter=Arc* Test: detach a smart card reader from the local device, make sure that there is no \ certificate shown in a client certificate user dialog launched from the test \ Android app. Change-Id: I524929ac25d67edaaf54eecdd61448a060393c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724083 Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
Edman Anjos <edman@chromium.org> Cr-Commit-Position: refs/heads/master@{#695977}
-
Rune Lillesveen authored
Change-Id: I83c453ef425d239912775aac6db791cec6c13e09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800165 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#695976}
-
Pâris MEULEMAN authored
Move retrieval of CoreAccountInfo by account name (email), from signin_manager_android.cc to SigninManager.java. This adds a mutable member to SigninManager's SignInState, which will hold the CoreAccountInfo when available, i.e. as soon as the account seeding is complete. This follows the creation of IdentityManager.java, PrimaryAccountMutator.java and is a step towards migrating all SigninManager.java accesses to IdentityManager through the java classes directly. A follow up CL will remove the remaining accesses by signin_manager_android, this includes move LegacyReloadAccountsFromSystem to IdentityManager.java. Bug: 934688 Change-Id: Iad797a835febb1a6bbb290cabf44e2e9125989b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789230 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#695975}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c0e9807094ef..ad7f2c5c4c7f git log c0e9807094ef..ad7f2c5c4c7f --date=short --no-merges --format='%ad %ae %s' 2019-09-11 afdx@google.com Add fuzzer pass to copy objects (#2853) 2019-09-11 rharrison@google.com Handle another case where creating a constant can fail (#2854) 2019-09-11 stevenperron@google.com Don't inline function containing OpKill (#2842) 2019-09-11 stevenperron@google.com Handle id overflow in wrap op kill. (#2851) 2019-09-11 dneto@google.com Assembler: Can't set an ID in instruction without result ID (#2852) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@ad7f2c5c4c7f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,syoussefi@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,syoussefi@chromium.org Bug: None Change-Id: Ieb493c868b6cb7f431fe4d4c3d98911aa66764b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799845Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695974}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f421e0e33e66..916720b02c76 git log f421e0e33e66..916720b02c76 --date=short --no-merges --format='%ad %ae %s' 2019-09-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src c0e9807094ef..ad7f2c5c4c7f (5 commits) Created with: gclient setdep -r src/third_party/angle@916720b02c76 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: chromium:None Change-Id: Ie36b62ca97dc0566980c492a2b2e3811ba9b132b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799846Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695973}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f4d6b677. With Chromium commits locally applied on WPT: cf88186a "[LayoutNG] Fix `vertical-align: top` and `bottom`" 20133397 "[sensor] Upstream sensor layout tests to wpt" cc3303b3 "[WPT/common/security-features] Introduce downgrade origin types" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I57eb2762c1b38a4ce000f47edb9599662b25b248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800143Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695972}
-
Daniel Hosseinian authored
Currently, PrintPreviewUI knows only if a source is modifiable or not. Both PDF and Flash sources are not modifiable and there is no way to distinguish them in the print preview UI. Knowing this information will allow changes to PDF printing while Flash is still supported on Chrome. The Renderer process can determine if the source is a PDF if a PDF interface can be loaded in the PepperPluginInstanceImpl class. The information is then relayed to the Browser process through an existing IPC message. Bug: 989978 Change-Id: If04a82d77d330e53a7425fcc9fdda862371f8bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788484Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#695971}
-
Pâris MEULEMAN authored
This makes GetJavaObject from oauth2_token_service_delegate_android virtual and defined on the base class, profile_oauth2_token_service_delegate. It is a prerequisite to the internalization of oauth2_token_service_delegate_android, as IdentityManager.java will need a reference on OAuth2TokenService.java on construction. This also avoids the use of a static_cast to oauth2_token_service_delegate_android in Identity_manager that is not always valid. details here: https://docs.google.com/document/d/1_ks5kg3qr6TVq7NT6MFg6lh5Yiv-1lic6Rsd9nu5ubI/edit?usp=sharing Bug: 934688 Change-Id: Ie0c6d3e004dadd36fe21147a55616d782f2939dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748892 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#695970}
-
vitaliii authored
Disable fast/harness/internals-observe-gc.html in Win10 (failure). TBR=shimazu@chromium.org Bug: 1003268 Change-Id: I4673f88ed08c2ec40a0e48835072c155e041682d No-try: true No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800406Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#695969}
-
arthursonzogni authored
In preparation to fixing: https://bugs.chromium.org/p/chromium/issues/detail?id=968529 1) Remove |bypass_cache| argument everywhere. I won't have an easy way to handle this argument in the future. Luckily, this argument is always false. It can be removed. There was a long chain of caller/callee transmitting this argument for no good reason. 2) Rename ReloadPage() → ReloadFrame() ReloadPage() implementation load the document again in the observed frame. It is used for both iframes and main frames. So a renaming is required here. Bug: 968529 Change-Id: Iedf72950b7fc4aa468eab8b3b94be572d8f6b2c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796422Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#695968}
-
Fredrik Söderquist authored
As soon as we get a progress time that isn't "in the future" we can terminate the search. Bug: 998526 Change-Id: Ic5bea2235ba6337dc9a7759438700716a865b651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798608 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#695967}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9f468ceb..34915c5e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ideec846527722f6ec892aedaf2fe7831a64565e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800142Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695966}
-
Henrique Ferreiro authored
Convert the implementation and all users of the ash::mojom::AssistantStateObserver and AssistantStateController interfaces. Bug: 955171 Change-Id: I8af0d30eb182849b5feea16bdb199a1fe6856781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790444 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#695965}
-
Nicolas Ouellet-Payeur authored
Previously, cache.dat was only updated once on startup (before loading XML sitelists from prefs), and then after all the XML sitelists were done downloading & parsing. This left a 1-minute period of time where cache.dat and Chrome's state didn't match. This would cause some back-and-forth switching between the two. Bug: 993054 Change-Id: Idb4da1c102a86392b88d7060664b16e1680c2deb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798526 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#695964}
-
Luciano Pacheco authored
Bug: 778674 Change-Id: Ic8b03529853bc384da64df6b13574f8796bbbda2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798254 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#695963}
-
Daniel Vogelheim authored
... even if default policy application fails. Bug: 739170 Change-Id: I2a44b281eea185f5b34b3050a14dca219f38d5fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789303Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#695962}
-
Fredrik Söderquist authored
SVGSMILElement::TriggerPendingEvents() and SVGSMILElement::repeat_event_count_list_ are no longer used. Bug: 998526 Change-Id: I79f58ffc434246d022bbc255d496ac492e7daaf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796668 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#695961}
-
Makoto Shimazu authored
TBR=rouslan@chromium.org No-Try: true Bug: 1003253 Change-Id: I87fbae4f1faed1f1ecc94da0b572cba235ad628b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800136Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#695960}
-
arthursonzogni authored
The BackForwardCache relies on pages to live in different BrowsingInstance. It means the current page and every pages in the BackForwardCache aren't sharing the same BrowsingInstance. The problem is that normal history navigation can specify a SiteInstance to reuse. It will be reused even when |force_browsing_instance_swap| is true in the RenderFrameHostManagerImpl. The basic idea of this CL: flush the BFCache before attempting a cross-BrowsingInstance history navigation. Bug: 993337, 999846 Change-Id: I26f1726a6ebe35eecb343b7310563e5001fc8f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795902Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#695959}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/de426021b595..12b5425582ea Created with: gclient setdep -r src-internal@12b5425582ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I5067c45ef93adce054c0271aefeab2b3eef13b58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800066Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695958}
-
Findit authored
This reverts commit f4d6b677. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 695951 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2Y0ZDZiNjc3N2RhMGVhY2JkY2ExNTg2Zjc1ZmM2ZWJkMGIxYzQxZDUM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/linux-archive-dbg/3691 Sample Failed Step: compile Original change's description: > heap: Move test utilities into a separate lib > > This also moves IncrementalMarkingTestDriver to heap_test_utilities. > > Change-Id: I17e0dc40d71925b7ff701c37ce6a6ef502f518fa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798671 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Anton Bikineev <bikineev@chromium.org> > Cr-Commit-Position: refs/heads/master@{#695951} Change-Id: I24f16dbde74caf22dd485b4c903cdd1b40edb9e5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799487 Cr-Commit-Position: refs/heads/master@{#695957}
-
Roman Sorokin authored
TBR=antrim@chromium.org Bug: 1000608 Change-Id: I4cdaaf6ca1699d8d9b861b8b8789c34f256245e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795823Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#695956}
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and child process for the content.mojom.ChildHistogramFetcherFactory and the content.mojo.ChildHistogramFetcher interfaces to the new Mojo types. Bug: 955171 Change-Id: I3e45219b9c027eb861507f7db9f0cac128eef5bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798357Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#695955}
-
Fredrik Söderquist authored
We no longer have a need for it - SMILAnimationSandwich::IsEmpty() will never return true in the loop in UpdateIntervals(). Tidy up the loops to use the Values() proxy. Bug: 998526 Change-Id: Ic7ebda4aece0989692293f3407c7f17c804495a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796667 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#695954}
-
Rakina Zata Amni authored
Currently we use strong references which will keep the shadow roots from getting garbage collected. Bug: 1002763 Change-Id: I62da84e94eaf52504efc80f1468349ee6d2f4fdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798222Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#695953}
-
Morten Stenshorne authored
No need to have the call sites both insert a break, and flag that we broke. Change-Id: I23447c98b8aff12e13027214e416e0e7cb0df26e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796348Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#695952}
-
Anton Bikineev authored
This also moves IncrementalMarkingTestDriver to heap_test_utilities. Change-Id: I17e0dc40d71925b7ff701c37ce6a6ef502f518fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798671Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#695951}
-
Gyuyoung Kim authored
This CL converts old Mojo types to the new Mojo types in GpuService interface. - Apply pending_receiver to FooRequest arguments. Additionally, CreateVideoEncodeAcceleratorProvider of Gpu interface needs to be converted to the new Mojo type together. Bug: 955171 Change-Id: I2636edd971d6d7962614204bf81ee0c25fce8edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792039Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#695950}
-
Morten Stenshorne authored
Some rebaselining turned out to be necessary. Change-Id: I5f7618feee3ff38dbe1d72a2f533fd161f03645f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796663Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#695949}
-
Makoto Shimazu authored
TBR=karandeepb@chromium.org No-Try: true Bug: 1003244 Change-Id: I935cf3775817a575d654425e648cf3337641d6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800133Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#695948}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5a2ba9996b20..578c88f047ec git log 5a2ba9996b20..578c88f047ec --date=short --no-merges --format='%ad %ae %s' 2019-09-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 0b8eca795349..f421e0e33e66 (6 commits) 2019-09-12 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-09-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 451d3245..4712e398 (443 commits) 2019-09-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader cebb9635a5d5..5a5ffe52a944 (4 commits) Created with: gclient setdep -r src/third_party/skia@578c88f047ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: Iaef50aaba3da98bd98d36bb06d46153c65180370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800064Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695947}
-
Makoto Shimazu authored
It's failing on LSan/TSan/MSan. TBR=nhiroki@chromium.org No-Try: true Bug: 1003217 Change-Id: I9cacf67f03a631ad8fbe1db8bea8bd063d910241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800131Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#695946}
-