GitLab

Review URL: https://codereview.chromium.org/252703006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266480 0039d316-1c4b-4281-b951-d872f2087c98

Store default search provider data in dictionary pref, and add DefaultSearchManager class to handle the reading and writing of this pref (DefaultSearchManager will eventually all default search related concerns).

This pref will be used to persist data about user-selected 
default search providers. In future CLs, support will be added for default search providers set by policy and sync.


BUG=365762

Review URL: https://codereview.chromium.org/229763005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266479 0039d316-1c4b-4281-b951-d872f2087c98

Per the spec DiscardPadding is a signed integer.  Sadly the parser
only supports UInt values at the moment.  To avoid refactoring the
world, we parse DiscardPadding as binary and have a one off parser.

A re-encoded bear-opus-end-trimming.webm will be landed separately
ahead of this change.

This patch also adds a check to ensure we never parse uint64 values
which will overflow an int64 container.

BUG=366750
TEST=Existing tests pass w/ DCHECK.

Review URL: https://codereview.chromium.org/251583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266478 0039d316-1c4b-4281-b951-d872f2087c98

R=Jói

Review URL: https://codereview.chromium.org/244313005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266477 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338759
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/250903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266476 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=wtc@chromium.org, brettw@chromium.org

Review URL: https://codereview.chromium.org/253643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266475 0039d316-1c4b-4281-b951-d872f2087c98

This CL reenables the change introduced in http://crrev.com/256939. The UI is updated to reflect the one approved by UX team.

BUG=314621

Review URL: https://codereview.chromium.org/225523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266474 0039d316-1c4b-4281-b951-d872f2087c98

ExtensionGarbageCollector collects isolated storages of disabled apps as garbages,
this may cause unexpected data loss for temporarily disabled extensions.
This CL protects non-enabled installed app's isolated storage from GC.

BUG=328637
R=ajwong@chromium.org, mek@chromium.org, rdevlin.cronin@chromium.org

Review URL: https://codereview.chromium.org/247113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266473 0039d316-1c4b-4281-b951-d872f2087c98

rather than failing mysteriously, this will autofill the number and then mark it invalid.

BUG=365630

Review URL: https://codereview.chromium.org/252803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266472 0039d316-1c4b-4281-b951-d872f2087c98

BUG=169282

Review URL: https://codereview.chromium.org/242803007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266471 0039d316-1c4b-4281-b951-d872f2087c98

This implements a touch dispatch model in which touchmove sending is throttled
while a scroll sequence is active and being consumed.  Such touchmove's are
marked with |cancelable = false|, indicating to any potential consumers that the
event cannot be prevented from triggering a platform gesture. Throttling limits
the touchmove sending rate during scrolling to 1 event per 200ms.

BUG=346693

Review URL: https://codereview.chromium.org/245833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266470 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a problem where the url gets stale after navigation.

BUG=365238
TEST=testTabUrl

Review URL: https://codereview.chromium.org/256843006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266467 0039d316-1c4b-4281-b951-d872f2087c98

Follow on for https://src.chromium.org/viewvc/chrome?revision=218548
which fixed various background tab issues related to visibility (see
for example bugs 118269, 142061, 155365 and 272962) by introducing a
WebContents initially_hidden creation-time flag.

Restored tabs don't currently set that flag, and that causes various
visibility issues (see bug). Fix that by ensuring that restored tabs
set their initially_hidden creation-time flag.

Note the delegated interface to tab restore service caused the error
so add tests for that: a direct test of the delegate, and a test for
a delegate user (recent tabs menu).

TEST=browser_tests --gtest_filter="*TabDisposition" 
BUG=358517

Review URL: https://codereview.chromium.org/227043004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266466 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366978

Review URL: https://codereview.chromium.org/251593005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266465 0039d316-1c4b-4281-b951-d872f2087c98

removed.

We explicitly cancel full screen mode on disconnection, which was resulting in
an exception in the event handler, preventing the full-screen class from being
removed from the <html> node. The left the plugin container full-screen on top
of the Disconnected dialog, making it unclickable.

BUG=365920
NOTRY=true

Review URL: https://codereview.chromium.org/258863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266464 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/256893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266463 0039d316-1c4b-4281-b951-d872f2087c98

This field is not used by the tile manager as it only affects the
resource pool and the tile manager is no longer responsible for
forwarding these changes to the resource pool.

Also removes inappropriate call to SetResourceUsageLimits in
TileManager::SetGlobalStateForTesting.

R=vmpstr
BUG=

Review URL: https://codereview.chromium.org/255533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266462 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=ben@chromium.org

Review URL: https://codereview.chromium.org/258833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266461 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/255993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266460 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266459 0039d316-1c4b-4281-b951-d872f2087c98

This CL
* Adds new filesystem type kFileSystemTypeDeviceMediaAsFileStorage,
which is handled by chromeos::FileSystemBackend.
It uses DeviceMediaAsyncFileUtil, so the implementation is
shared with MTP support in mediaGalleries API (MediaFileSystemBackend).

We need different types since we need different handlings.
(Permission management for file handler extensions, unlimited CopyOrMoveValidator
for allowing non-media files, etc.)

* Adds monitoring by storage_monitor::RemovableStorageObserver in
file_manager::VolumeManager so that MTP device is detected and
mounted to the file manager.

BUG=363960

Review URL: https://codereview.chromium.org/246293011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266458 0039d316-1c4b-4281-b951-d872f2087c98

This required disabling the benchmarks that were causing it to fail. It looks
like those failures were due to lack of tab support in ChromeShell.

BUG=337829

Review URL: https://codereview.chromium.org/250593003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266457 0039d316-1c4b-4281-b951-d872f2087c98

This depends on
https://codereview.chromium.org/247193002/

BUG=None

Review URL: https://codereview.chromium.org/250793004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266456 0039d316-1c4b-4281-b951-d872f2087c98

One of the horrors of using Xlib is its Output buffer.  When calling Xlib
functions, the X command bitstream is not actually sent right away.
Commands are first queued up in the Xlib output buffer, and only sent over
the wire when the output buffer is flushed.

X clients typically don't have to worry about this, since (a) commands
that require return a response are flushed immediately, and
(b) they usually have an event loop that calls XPending() (XNextEvent(),
or XWindowEvent()), which does a Flush internally.

Chrome, however, listens to the Xserver fd, and only enters its XPending()
loop if the File Can be Read Without Blocking.

The quick and dirty fix is to just send an explicit XFlush() after
XUngrabServer().
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>

BUG=chromium:366125
TEST=tbd

R=msw@chromium.org
R=erg@chromium.org

Review URL: https://codereview.chromium.org/246723006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266455 0039d316-1c4b-4281-b951-d872f2087c98

This appears to have introduced assertion failures on the
linux_gpu_triggered_tests try server -- and would have done so on the
Linux Debug (NVIDIA) bot, too, if the hardware had not failed late
last week.

Links to the failures have been added to crbug.com/269808.

> content: Add missing IPC traits for sync_query.
> 
> R=cdn@chromium.org, piman@chromium.org
> BUG=269808
> 
> Review URL: https://codereview.chromium.org/250803010

TBR=reveman@chromium.org

Review URL: https://codereview.chromium.org/252833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266454 0039d316-1c4b-4281-b951-d872f2087c98

Now nacl_irt_mmap with PROT_EXEC is implemented by non-EXEC
mmap and mprotect thanks to

https://codereview.chromium.org/239763005

BUG=359285
TEST=nacl_loader_unittests, trybots
R=jln@chromium.org, mseaborn@chromium.org

Review URL: https://codereview.chromium.org/247563004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266453 0039d316-1c4b-4281-b951-d872f2087c98

The live mode is indicated by presense of DateUTC element and unknown
segment duration and size.

BUG=338529

Review URL: https://codereview.chromium.org/231283005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266452 0039d316-1c4b-4281-b951-d872f2087c98

This prevents overwriting target bounds when reparenting layers during animation. In snapped scenario we snap a window (with a call to WindowState::OnWMEvent in WorkspaceWindowResizer::CompleteDrag()) which starts animation and then immediately reparent it (back to workspace in DockedWindowResizer::MaybeReparentWindowOnDragCompletion). Stopping (completing) BOUNDS animation allows the child window to honor previously set target bounds and keep them when it gets reparented.

BUG=364517, 366993
TEST=aura_unittests --gtest_filter=WindowTest.RootWindowSetWhenReparenting

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266115

Review URL: https://codereview.chromium.org/241983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266451 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366594
R=glider@chromium.org

Review URL: https://codereview.chromium.org/255793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266450 0039d316-1c4b-4281-b951-d872f2087c98

    
    Expose kServiceInitializationStartupDelay in ChromeBrowserPolicyConnector.
    
    Extract DeviceManagementServiceConfiguration to its own files.
    
    Add a command line flag to override the consumer DM server address for
    testing.
    
    Fix a comment in policy_switches as it no longer applies.
    
    BUG=353050
    TEST=manual

Review URL: https://codereview.chromium.org/240903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266449 0039d316-1c4b-4281-b951-d872f2087c98

They do not require any extra setup, so it is easier and they do not run on mac
or ios platforms.

BUG=331829
TEST=gfx_unittests --gtest_filter=XForm*:Interpolated*
TBR=danakj@chromium.org,ben@chromium.org

Review URL: https://codereview.chromium.org/255953005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266448 0039d316-1c4b-4281-b951-d872f2087c98

Mocks: https://docs.google.com/a/google.com/file/d/0BxMIIGI80eU-VW16NEloUFdyaXc/edit

This CL is related to its Mac cousin, https://codereview.chromium.org/235833002/.
Like the related CL, this one also does not implement the "round" avatar icon, nor the
top-left corner info button, but it does set up the layout for the other elements.

I've also added the option to be able to center the text in a textfield.

BUG=353398

Review URL: https://codereview.chromium.org/249813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266447 0039d316-1c4b-4281-b951-d872f2087c98

For Windows XP platforms, GOMA service is not supported.
Moreover we don't compile chorme when gs_bucket flag is set instead use builds archives, therefore ignore GOMA service for Windows XP.

NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/255963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266446 0039d316-1c4b-4281-b951-d872f2087c98

Need to be in google_malloc section just like every other alloc function.

R=willchan@chromium.org

BUG=364380

Review URL: https://codereview.chromium.org/257453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266445 0039d316-1c4b-4281-b951-d872f2087c98

Counts the number of successful handshake completion with
permessage-deflate enabled for each negotiated context_takeover
parameter value.

BUG=128156,359926

Review URL: https://codereview.chromium.org/244933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266444 0039d316-1c4b-4281-b951-d872f2087c98

Revert of GestureRecognizerTest tests both Aura and Unified Gesture Detectors. (https://codereview.chromium.org/258633005/)

Reason for revert:
Breaks compile on

http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29%2832%29/builds/23390

../../ui/aura/gestures/gesture_recognizer_unittest.cc: In constructor 'aura::test::{anonymous}::GestureEventConsumeDelegate::GestureEventConsumeDelegate()':
../../ui/aura/gestures/gesture_recognizer_unittest.cc:354:17: error: 'aura::test::{anonymous}::GestureEventConsumeDelegate::wait_until_event_' will be initialized after [-Werror=reorder]
../../ui/aura/gestures/gesture_recognizer_unittest.cc:352:7: error:   'int aura::test::{anonymous}::GestureEventConsumeDelegate::flags_' [-Werror=reorder]
../../ui/aura/gestures/gesture_recognizer_unittest.cc:70:3: error:   when initialized here [-Werror=reorder]

Original issue's description:
> GestureRecognizerTest tests both Aura and Unified Gesture Detectors.
> 
> This is in preparation of landing the unified GR
> (see https://codereview.chromium.org/251543003/).
> 
> There are some cases where behavior differs in minor ways.
> 
> This is sometimes dealt with by increasing the test's margin of error
> (for instance, slop handling is slightly different, so we now
> exceed the slop more thoroughly).
> 
> This is sometimes dealt with by ignoring the test if the test is
> run with the unified GR.
> 
> BUG=332418
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266440

TBR=sadrul@chromium.org,tdresser@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=332418

Review URL: https://codereview.chromium.org/254963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266443 0039d316-1c4b-4281-b951-d872f2087c98

Send commands from webcamPrivate API to the webcam via V4L2 ioctls

BUG=346492
TBR=tommi@chromium.org
TBR=kalman@chromium.org

Review URL: https://codereview.chromium.org/256833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266442 0039d316-1c4b-4281-b951-d872f2087c98

The @download attribute can be used to specify a suggested filename for
a download. However, this suggested name should only be used if the
referring document is in the same origin as the downloaded resource.
This CL clears the suggested name if the final download URL after
redirects is in a different origin than the original download URL.

The companion Blink CL at https://codereview.chromium.org/197033005/
ensures that the suggested name for a download initiated via a @download
attribute would only be non-empty if the referring document is allowed
to set a suggested name for the original download URL.

BUG=346744

Review URL: https://codereview.chromium.org/246893006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266441 0039d316-1c4b-4281-b951-d872f2087c98

This is in preparation of landing the unified GR
(see https://codereview.chromium.org/251543003/).

There are some cases where behavior differs in minor ways.

This is sometimes dealt with by increasing the test's margin of error
(for instance, slop handling is slightly different, so we now
exceed the slop more thoroughly).

This is sometimes dealt with by ignoring the test if the test is
run with the unified GR.

BUG=332418

Review URL: https://codereview.chromium.org/258633005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266440 0039d316-1c4b-4281-b951-d872f2087c98

TEST=TouchDispositionGestureFilterTest.TestDisallowedMultiFingerSwipe

Review URL: https://codereview.chromium.org/252753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266439 0039d316-1c4b-4281-b951-d872f2087c98