- 01 Nov, 2018 40 commits
-
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ib4878c92255a84bac7f1fceda59bf73f0bd93694 Reviewed-on: https://chromium-review.googlesource.com/c/1312154Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#604502}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d7a7586b0d2f..628f0a57d102 git log d7a7586b0d2f..628f0a57d102 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@628f0a57d102 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I921aaaf48309d698337c5085f6b13061a773c4a7 Reviewed-on: https://chromium-review.googlesource.com/c/1312259Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604501}
-
Zhuoyu Qian authored
This patch moves CreateVisiblePosition() out of VisiblePositionForContentsPoint() to the callers. Rename VisiblePositionForContentsPoint() to PositionForContentsPointRespectingEditingBoundary(). Bug: 657237 Change-Id: I00c60a783c35d5e5a59b9163eb3e42b7e9fa2b38 Reviewed-on: https://chromium-review.googlesource.com/c/1307315 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#604500}
-
Fergus Dall authored
Bug: 896540 Change-Id: I9bcd94d33825804d64a1cd59f88eaea5ae4996e8 Reviewed-on: https://chromium-review.googlesource.com/c/1301093Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#604499}
-
Mao Huang authored
Currently the safe search component always uses the API key gotten from google_apis. This limits the usage of the safe search component for projects using content shell but not Chrome directly. This patch allows the URL checker to take a custom API key so projects other than Chrome could also benefits from the safe search component. Bug: b/110951484 Change-Id: Ic2aa3fea758b4dc6d43d54a582c460df1b892b91 Reviewed-on: https://chromium-review.googlesource.com/c/1309557Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mao Huang <littlecvr@chromium.org> Cr-Commit-Position: refs/heads/master@{#604498}
-
sangwoo.ko authored
Replace old API with new API. This CL is a refactor and has no intended behavior change. To keep TabStrip UI consistent with model, make tabstrip UI the first observer. Bug: 842194 Change-Id: Icba9481d41ba32a7910593198cebd313ad531e5d Reviewed-on: https://chromium-review.googlesource.com/c/1249461 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#604497}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9d88af8f4ebe..f2f7c2a92321 git log 9d88af8f4ebe..f2f7c2a92321 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 tsepez@chromium.org Add |k| to CPDF_ContentMarkItem::ParamType enum constants Created with: gclient setdep -r src/third_party/pdfium@f2f7c2a92321 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I831d43b333fcb550ec75f65159bcd91322d3f5bc Reviewed-on: https://chromium-review.googlesource.com/c/1312255Reviewed-by:
-
Dmitry Gozman authored
This simple struct is being used to initialize DevTools in workers. Bug: 882467 Change-Id: I4d7fa582913b3be9a8466de24d727289a34f6ce0 Reviewed-on: https://chromium-review.googlesource.com/c/1308073 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#604495}
-
yoshiki iguchi authored
This CL adds ash window type (WindowStateType::PIP) to Chrome PIP window only in Chrome OS. This window type is used for distinguish PIP windows and manages them in Chrome OS ash shell. Bug: b/112060145 Change-Id: I9fb51e50577b8ebe9d690b6c2d83e300951d9846 Reviewed-on: https://chromium-review.googlesource.com/c/1242726 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#604494}
-
Nektarios Paisios authored
This is a reland of cb9c3091 Two things needed to be changed to fix the compilation failures: 1. Add build file entries for ui/accessibility/platform/ax_platform_node_base.* and ax_-platform_node_delegate_base.* so that these files would be compiled on platforms that don't have native accessibility support, such as Chrome OS. 2. Implement all the unimplemented methods in ui/accessibility/platform/ax_platform_node_base and ax_platform_node_delegate_base. R=dmazzoni@chromium.org,aleventhal@chromium.org TBR=afakhry@chromium.org,ellyjones@chromium.org,sky@chromium.org Bug: 811277 Original change's description: Adds code in ViewAccessibility to manage the focus of AXVirtualView descendants Also renamed some methods to make interface more consistent. In preparation for more changes in AXVirtualView. Change-Id: Ic83e231c0fd3bdf45e68f4e6279e705ce22b2aa7 Reviewed-on: https://chromium-review.googlesource.com/c/1304815 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#604493}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/861640f6c89b..0db62fcf9c7e git log 861640f6c89b..0db62fcf9c7e --date=short --no-merges --format='%ad %ae %s' 2018-11-01 yyanagisawa@chromium.org autoninja: don't set -l. Created with: gclient setdep -r src/third_party/depot_tools@0db62fcf9c7e The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:b/117810340 TBR=agable@chromium.org Change-Id: If3835943744d8ceaa356d95465509e8d0e1af4df Reviewed-on: https://chromium-review.googlesource.com/c/1312254Reviewed-by:
-
Xida Chen authored
This CL parameterize some tests using this flag. It does 2 things: 1. Move the kCompositorTouchAction flag from content/ to ui/events/blink. This is because InputHandlerProxy will need to have access to this flag, and that content/ depends on ui/events/blink. 2. Parameterize necessary tests based on this flag. Tests include: InputRouterImplTest, TouchActionFilterTest, InputHandlerProxyTest, TouchActionBrowserTest. In order to pameterize the InputRouterImplTest, we have to extract a InputRouterImplTestBase. The reason is that InputRouterImplTest has a subclass "TouchpadPinchInputRouterImplTest", which is already a parameterized test depending on another flag. Bug: 900202 Change-Id: I07e30739ee86aaf8b1840d6e0dccfc504a16b075 Reviewed-on: https://chromium-review.googlesource.com/c/1307833 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#604491}
-
Maks Orlovich authored
The former will have some problems with some proxy setups once the Network Service is on, so this introduces a replacement. This CL doesn't hook it up to anything, just builds & tests it. Next steps would require an equivalent to FakeSSLClientSocket, and then actually hooking those up and wiring the different injected config from Chrome. To ease the review of this somewhat, this CL was split in two, with https://chromium-review.googlesource.com/c/chromium/src/+/1237214 just copying over ChomeAsyncSocket and its tests to new files, to produce something of a meaningful diff. (Thanks to lassey@ for the idea) Bug: 875032 Change-Id: Ic5d4e4276c993e0e70f059d485b9d34aeab41e6d Reviewed-on: https://chromium-review.googlesource.com/c/1232034 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Cr-Commit-Position: refs/heads/master@{#604490}
-
Yuichiro Hanada authored
InputConnectionImpl waits for text input state updates by observer methods. However, some IME operations (like deleting '0' character) don't update the state. Also this CL stops ArcInputMethodManagerService observing OnCompositionBoundsChanged() because it's often called before text input state is updated. Bug: 900707 Test: Ran on DUT. Change-Id: Ib4c79ae19f0175d46e9ecf3cf0cac909f02fac3e Reviewed-on: https://chromium-review.googlesource.com/c/1311313Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#604489}
-
James Hawkins authored
R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I2c85ce8fcd794998583c7b5bb63a51b3e90ce450 Reviewed-on: https://chromium-review.googlesource.com/c/1312295Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#604488}
-
David Staessens authored
The TextureRef class will also be used by video encode tests, so it doesn't make sense to keep it in a decode-specific helper file. No code was added or changed, this CL is only moving the class to a separate file. TEST=ran VDA unittests on eve BUG=900433 Change-Id: Id104701554ea0bd1e12c10221346e946ff1b9c50 Reviewed-on: https://chromium-review.googlesource.com/c/1309381 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#604487}
-
Oystein Eftevaag authored
This caused trace events for these threads to go missing as Perfetto was not able to recover them from the shared memory chunks. Also: * Removed an unused variable from TraceEventDataSink, * Read the same member out of a TraceEvent union as the one we write to (thread_id vs process_id). R=primiano@chromium.org Bug: 900669 Change-Id: I80d4e39b154b138a540770e227f1006fec0a91b2 Reviewed-on: https://chromium-review.googlesource.com/c/1311125Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#604486}
-
Joel Hockey authored
Bug: 860355 Change-Id: I73b7eb298cf462c5e981f0cfb3a0132499b0083c Reviewed-on: https://chromium-review.googlesource.com/c/1312134Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#604485}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/46155299edb9..9a227bed7a0f $ git log 46155299e..9a227bed7 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 junyer Make Prefilter::Info::Walker::PostVisit() handle kRegexpAnyByte too. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Bug: 900671 Change-Id: Iad2dd959bdda48eeef6c5a4f6d7aa028c9c79538 Reviewed-on: https://chromium-review.googlesource.com/c/1311494Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#604484}
-
Christian Biesinger authored
When a flex item has a definite specified height (e.g. height: 100px), then percentages in children of the flex item should resolve even if the flexbox does not have an explicit height, ie. does not match the condition in https://drafts.csswg.org/css-flexbox/#definite-sizes Bug: 885185 Change-Id: Iba226f30e1e02e3a11273fa45fcdf1cef897120c Reviewed-on: https://chromium-review.googlesource.com/c/1311534 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#604483}
-
Livvie Lin authored
Metrics show that the Superfish interstitial shows up effectively 0% of the time, and we rarely receive Superfish certificate reports. This cl deletes the code for the Superfish interstitial. Bug: 899987 Change-Id: Ice48aad16fd06d74d1150c306fb5caf62c119022 Reviewed-on: https://chromium-review.googlesource.com/c/1306773 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#604482}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e3f4b1f5ee13..f92910970a44 git log e3f4b1f5ee13..f92910970a44 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 oprypin@chromium.org Basic Python3 compatibility for catapult tracing Created with: gclient setdep -r src/third_party/catapult@f92910970a44 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I9eb7a0a23536b9367332cd0942ce2f84a162e50b Reviewed-on: https://chromium-review.googlesource.com/c/1312054Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/06768fc14b7a..d7a7586b0d2f git log 06768fc14b7a..d7a7586b0d2f --date=short --no-merges --format='%ad %ae %s' 2018-10-31 caryclark@skia.org delete color4f pin from docs 2018-10-31 mtklein@google.com clean up some odd SkRefCnt features 2018-10-31 brianosman@google.com Remove SkRGBA4f pinning functions 2018-10-31 herb@google.com Move from a functional to object based interface between Painter and SkDraw 2018-10-31 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e36ca90f33e9..adfbbcbed6e7 (3 commits) 2018-10-31 mtklein@google.com implement SkPixmap::erase() as a draw 2018-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d60e42f8e79e..580baf379673 (3 commits) 2018-10-31 scroggo@google.com Treat start(Incremental/Scanline)Decode errors as failures 2018-10-31 mtklein@google.com try removing SkDraw::drawPaint() fast-path 2018-10-31 herb@google.com Refactor to create the blitter in the PaintAllMasks 2018-10-31 brianosman@google.com Replace GrColor4h with SkPMColor4f 2018-10-31 bsalomon@google.com Change mechanism that lets GrRenderTargetContext caller get op list ID. 2018-10-31 jvanverth@google.com More checks in ReflexHash setup Created with: gclient setdep -r src/third_party/skia@d7a7586b0d2f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I018e6ff8f1ffa84b43d2a9be6da22ee1b91ed018 Reviewed-on: https://chromium-review.googlesource.com/c/1311675Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/28fd7569985c..378f5ac017f8 Created with: gclient setdep -r src-internal@378f5ac017f8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8d5e8365eb3339efc3f7be360dafb15961cb589f Reviewed-on: https://chromium-review.googlesource.com/c/1312053Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604479}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/580baf379673..2197dc529052 git log 580baf379673..2197dc529052 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 syoussefi@chromium.org Vulkan: Implement masked depth & stencil clear Created with: gclient setdep -r src/third_party/angle@2197dc529052 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Icaa2803eed875a5686f901c9f0bfc841012df31d Reviewed-on: https://chromium-review.googlesource.com/c/1311836Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/062a691cae73..838643550f0c git log 062a691cae73..838643550f0c --date=short --no-merges --format='%ad %ae %s' 2018-10-31 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6271fcdc..734e273d (604273:604373) 2018-10-31 mellem@webrtc.org Add interfaces for using MediaTransport as the transport for data channels. Created with: gclient setdep -r src/third_party/webrtc@838643550f0c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1dc52ef1f77af0bbd9c542586fdfbf2168ad2cc1 Reviewed-on: https://chromium-review.googlesource.com/c/1311993Reviewed-by:
-
Kenneth Russell authored
Needed to generate new reference images. Tbr: mcasas@chromium.org Bug: 865957 Change-Id: I87e8f15550a7bddef25f2f7ce22d07184d13ea17 Reviewed-on: https://chromium-review.googlesource.com/c/1311842Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#604476}
-
Kenichi Ishibashi authored
Two reasons to remove these histograms: - We haven't been looking at these histograms. - We added milestone-style histograms for main/sub resource loading and some of these track event dispatching delays. Bug: 898020, 872567 Change-Id: I9f61da0101aa8e38ff4bca519126ef339b877863 Reviewed-on: https://chromium-review.googlesource.com/c/1307015Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#604475}
-
Brandon Wylie authored
A summary: - A bunch of work was being done on the UI thread. Now it's being done off-thread. - Network requests were dispatched all at once, slowing everything down. Now they're dispatched one at a time so the first thumbnail is loaded in quickly. - One weak ptr was being passed across threads, resulting in a crash. This is fixed now. Bug: 864634 Change-Id: I8dc3797a66c0ccc048b9d9613333df7450ec50c1 Reviewed-on: https://chromium-review.googlesource.com/c/1306634 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#604474}
-
Jun Mukai authored
The current behavior makes TransferEventsTo() before the window move starts, but don't care at its end. This causes errors like crbug.com/900363. But we can't simply transfer back to the original window unconditionally since someone (like TabDragController) may also want to continue dragging on a window other than the original source window. This CL introduces a new scoped class to control this; it makes TransferEventsTo first, and then invokes TransferEventsTo back again at the end, but it skips invoking the second transfer if someone else also transfers the touch events on the same window. BUG=900363 TEST=the new test case Change-Id: I81792872a13f0e4bb2c88b526c92cf689d656b71 Reviewed-on: https://chromium-review.googlesource.com/c/1310501 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
-
Aleks Totic authored
128 bits gone Bug: 835484 Change-Id: I50045dc72b3037edca348c94eecf2d00acf037d6 Reviewed-on: https://chromium-review.googlesource.com/c/1311805Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#604472}
-
Ted Choc authored
The suggestion view no longer has direct references to any of the backend suggestion data. BUG=898522 Change-Id: Iacb03cff130d659c845e134f593f87b8416c16ae Reviewed-on: https://chromium-review.googlesource.com/c/1306350Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#604471}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/22a617f93038..9d88af8f4ebe git log 22a617f93038..9d88af8f4ebe --date=short --no-merges --format='%ad %ae %s' 2018-10-31 thestig@chromium.org Roll third_party/skia/ 7258e97e8..c994a93b3 (302 commits; 17 trivial rolls) Created with: gclient setdep -r src/third_party/pdfium@9d88af8f4ebe The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If66f68f380076047cdf00c2fd4b224e1b1ce4e27 Reviewed-on: https://chromium-review.googlesource.com/c/1311674Reviewed-by:
-
Ned Nguyen authored
This is a pure refactoring change to make the code cleaner. There is no intended effects change. Bug: 893618 Change-Id: I68d59e804c637da07cefac7fcdcdef3c70626227 Reviewed-on: https://chromium-review.googlesource.com/c/1311801Reviewed-by:
-
Josh Gao authored
The official builds apparently doesn't print the error message from CHECK failure, so delete the death test regexes. While we're at it, switch from the ifdef to EXPECT_DEATH_IF_SUPPORTED. TBR=dcheng@chromium.org Bug: 900764 Change-Id: I61448b5fcb903b35a4cc01e0eb599ba35be1d402 Reviewed-on: https://chromium-review.googlesource.com/c/1311838Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Josh Gao <jmgao@google.com> Cr-Commit-Position: refs/heads/master@{#604468}
-
Amos Lim authored
Move: build/scripts/{ => core/css}/make_css_primitive_value_unit_trie.py build/scripts/{ => core/css}/templates/css_primitive_value_unit_trie.cc.tmpl This CL has no behavior changes. Bug: 732657 Change-Id: Iffd9b98f0eede7fc7349c89d26eb885de9953600 Reviewed-on: https://chromium-review.googlesource.com/c/1309377Reviewed-by: -
Esmael El-Moslimany authored
Bug: 866926 Change-Id: I4811f8cafd4febc39955ea4c076b83fb7c0035a9 Reviewed-on: https://chromium-review.googlesource.com/c/1309094 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#604466}
-
Joel Hockey authored
If 2 child dirs such as /a/a, and /a/b, are shared, then parent /a is shared, we no longer register both children as being shared and we only show the parent in settings page as being shared. If the parent is subsequently unshared, then children will also be unshared. Bug: 878324 Change-Id: I1c85d75ad934d48cd353299943f7de893ca62017 Reviewed-on: https://chromium-review.googlesource.com/c/1306945Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#604465}
-
Peter Boström authored
Removes Widget::SetFocusTraversableParent* calls since we don't want focus to escape bubble dialogs once they get here. There are several bubbles that close once focus escapes. We still set kAnchoredDialogKey of the anchor view to make sure that focus can move into attached dialogs (this makes them keyboard accessible). Bug: chromium:899601, chromium:899996 Change-Id: Idc5d60c2f41ae20a343324ae75b0fd304f273c94 Reviewed-on: https://chromium-review.googlesource.com/c/1311090Reviewed-by:
-
Yuichiro Hanada authored
When active IME is changed in Android side, the event is sent to OnActiveImeChanged(). ArcInputMethodManagerService should switch an active IME in Chrome OS side according to the event. Bug: 900756 Test: Ran on DUT. Change-Id: Ia8002ec678775f6349020b90766423987a4f714b Reviewed-on: https://chromium-review.googlesource.com/c/1311853 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
-
