- 30 Jul, 2020 40 commits
-
-
Nohemi Fernandez authored
These utilities already exist in Sign-in and should be kept within the codebase owned by the Sign-in team. Bug: 1103274 Change-Id: Idaa5827ca06bbb0b2edcfe603a8d83545de18087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325174Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#793133}
-
Rushan Suleymanov authored
This CL introduces a factory for SyncInvalidationsService and wires it to ProfileSyncService to add listener. The invalidations service is added behind a feature toggle which is disabled by default. Bug: 1082122 Change-Id: I94249979ae4fc17132670fba2d49a7ba50a56bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220029 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#793132}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 846c5c16. With Chromium commits locally applied on WPT: 3bd086b0 "Make CSP default-src without 'unsafe-eval' block eval in iframes" 6d63b58a "Split iceGatheringState tests into separate files & update expectations" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I35817b1a541678ae32d7289ade32f4a06f45603c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329244Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793131}
-
Balazs Engedy authored
The file contained redundant entries for virtual/* tests, remove those. Bug: None Change-Id: I2f6ea4a70bfc3d01dae66da251e4b39b0d3ffbab No-Try: True No-Presubmit: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329570Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#793130}
-
Mark Brand authored
This change removes the need for the separate response handling in MojoLPM fuzzer targets, instead handling responses to methods called on fuzzer-hosted receivers in the same way as calls to browser-hosted remotes. This also allows more significant reordering of responses on the fuzzer side, hopefully improving fuzzer performance. Bug: 1076336 Change-Id: I6faceedae2bef31ced28c415f84e7e6ca009f458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302749 Commit-Queue: Mark Brand <markbrand@google.com> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#793129}
-
Kenichi Ishibashi authored
This became flaky with crrev.com/c/2269982 Bug: 1111240,1091141 Change-Id: Ia79803d740d776022095b881e0ba66f608838103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328568 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#793128}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/369fe23b..9b215da6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iddf9e1c766e2f11a0fcd80fb0617327386966318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329284Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793127}
-
Avi Drissman authored
Bug: 1105907 Change-Id: I32836d2d1bfa0854f32930f0af7f98b1d46118f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328332 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#793126}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2d37958b2d44..5ba6534884d9 2020-07-30 borenet@google.com Change some instances of whitelist/blacklist If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1101491 Tbr: borenet@google.com Change-Id: I31a59c9b7fb4055dea0c1856677e531da15e4d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328752Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793125}
-
Balazs Engedy authored
This reverts commit 6549ee05. Reason for revert: Likely culprit for crash/timeout on: MultiDeviceSetupScreenTest.Accepted MultiDeviceSetupScreenTest.Declined MultiDeviceSetupScreenTest.Skipped https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/7383 Original change's description: > MultiDeviceSetupScreen: Skip screen properly. > > Use new MaybeSkip method for skipping screen. Add tests for UMA stats. > > Bug: 1064561, 1095062 > Change-Id: I9ba91dd8b132367a160b975f724b5e1692987832 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166263 > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> > Cr-Commit-Position: refs/heads/master@{#793103} TBR=rsorokin@chromium.org,raleksandrov@google.com Change-Id: Ic190563d2e266731d1fab4684b23adae5f487163 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1064561 Bug: 1095062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329424Reviewed-by:
-
Balazs Engedy authored
Bug: 1111287 Change-Id: Ia3678f2914e133d0676077ff96bd31de0131907b No-Presubmit: True No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328972Reviewed-by:
-
Travis Skare authored
Change-Id: Ifce678205ca39d7c53d364f150f92e8332e3b1e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327140 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#793122}
-
Antonio Gomes authored
LaCrOS/Chromium project allows one to launch Chromium/Wayland (Ozone) on top of ChromeOS/Exo, with the following commands: chromeos/chrome $ <out-cros>/chrome --enable-logging=stderr \ --user-data-dir=/tmp/chr_cros \ --ozone-platform=x11 --enable-wayland-server \ --wayland-server-socket=wayland-exo chromium/wayland $ WAYLAND_DISPLAY=wayland-exo <out-wayland>/chrome \ --ozone-platform=wayland \ --user-data-dir=~/tmp-- LaCrOS/chromium, then, should be able to open nested 3-dot menu instances, eg -> 3-dot -> More Tools -> Extensions However, today, ChromeOS/Chrome fails a DCHECK when opening a nested submenu (in the example above accomplished by hovering over "More Tools" menu and opening the respective submenu). The DCHECK fails because GetTargetSurfaceForLocatedEvent() - components/exo/shell_surface_util.cc - assumes the outter aura::Window window that originates the event is the same that has the event capture. In case of Exo, each windows (the 3-dot menu window itself and the nested submenu window) are a different top Exo windows: 3-dot menu window hierarchy (it originates the hover event): ExoShellSurface-7<-1> bounds=428,76 348x492 ExoShellSurfaceHost-7<-1> bounds=0,0 348x492 ExoSurface-11<-1> bounds=0,0 348x492 Submenu window hierarchy (it captures mouse events once created): ExoShellSurface-8<-1> bounds=104,168 328x111 ExoShellSurfaceHost-8<-1> bounds=0,0 328x111 ExoSurface-12<-1> bounds=0,0 328x111 The CL removes the DCHECK altogether, given that it does not reflect anymore the world where LaCrOS/Chromium can be launched on top of Exo within ChromeOS/Chrome. BUG=1110881 R=dcastagna@chromium.org Change-Id: I85629514dfcf3db8617d7b29d93d9f73c347efe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326870 Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#793121}
-
Sami Kyostila authored
This patch extends the Android battery drain metric to record a parallel discharge rate which is only reported for time intervals where Chrome was the only foreground app. This avoids accidentally attributing power draw from other apps that were running before the user switched to Chrome. We also add a metric to track the time durations between successive detected battery capacity drops to get a better idea of what the granularity of this data is. Bug: b/161693081 Change-Id: Ic5e71799333c4db188ab43a1f23200e84a027884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322986 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#793120}
-
Alex Chau authored
Bug: None Change-Id: Ifd413710a41b58b26095423037a60f32f6728ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328905 Auto-Submit: Alex Chau <alexchau@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#793119}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/eb1cf84b533e..d9705a3ee367 2020-07-30 szuend@chromium.org Add 'getTopFrame' method to 'FrameManager' 2020-07-30 janscheffler@chromium.org Move "front_end/perf_ui" to "devtools_entrypoint" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1080589,chromium:1101738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7046c8fe2e8264768a75fbc47f594f52def641eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328749Reviewed-by:
-
Henrik Boström authored
(Chromium follow-up to WebRTC CL https://webrtc-review.googlesource.com/c/src/+/180481.) This CL migrates to the non-racy version of SetLocalDescription, i.e. a version of SLD that invokes its callback immediately when the operation completes rather than with a delay, ensuring that SLD can resolve with the right states. This CL adds a WPT that verifies calling SLD and SRD in a way that without this CL would fail. This CL also makes the RTCPeerConnection-perfect-negotiation.https WPT expectations predictable: In Unified Plan, we always pass the first two tests and (due to https://crbug.com/1060083) always fail the remaining ones. In Plan B, we always Timeout (addTransceiver throws asynchronously leaving a promise unresolved). Bug: chromium:1071733, chromium:1019232 Change-Id: I21025226bd86e94456cc9a8c3deb980170d8bed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292252 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#793117}
-
Renato Silva authored
Add backfill operation to PIN auto submit. Users who set a PIN before the auto submit feature existed will have their auto submit preference backfilled upon their first successful PIN authentication. Only users with an existing six digits PIN will have the preference set to enabled, and only if autosubmit isn't disabled by policy. A metric is recording the number of users that are being backfilled to enabled and disabled. Unit tests cover the possible cases. Bug: 663982 Change-Id: Ic98a58b85776b1bc88d44bf23936a2e3667feed6 Fixed: 1104164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307219 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#793116}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a45f583aecc0..d755ba27aab7 2020-07-30 ddrone@google.com Change the order of packets in track_event_typed_args test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia66755335f2c14f24e1e9275468afd9012388353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328751Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596084863-9f8350c67999f4907bbdbafc211dfb921acc2de3.profdata to chrome-win32-master-1596095888-824adbe180e90d0db36c843038b46bf769e7f7bb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ief1d9e4a270829fae984aa94cf89d9cf5811e758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328750Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iad3ddb498c872c2b4af4c9ebb379385467eca139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329044Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fd60950e59a3..8d09e37670ed 2020-07-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from f9b088fe0dbf to c6e6597c4f51 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Change-Id: Iba775f1043262da5a57b90305218333e6e544494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328745Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d1338fe1c0f9..0138877b7594 2020-07-30 fancl@chromium.org Use start & end in the anomaly instead of AlertGroup If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1106244 Tbr: rmhasan@google.com Change-Id: I1ad368ddeb8cba30ab36d033718da0c0b9218cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328746Reviewed-by:
-
Matthias Körber authored
This CL adds the static address component tree for names that support two surnames as they are common for Hispanic/Latinx names. Change-Id: Icd54f986ab192101fbea5a8576c8abbabfffe636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264423 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#793110}
-
Thanh Nguyen authored
Make updating methods of InvertedIndex asynchornus. Heavy tasks are moved to a non-UI thread to improve the performance. Bug: 1101877 Change-Id: I4cb42da51d9fcae9b5c993ccf2d40a0a457ace25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310017Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#793109}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f9b088fe0dbf..c6e6597c4f51 2020-07-29 andreperezmaselco.developer@gmail.com spirv-fuzz: Implement the OpOuterProduct linear algebra case (#3617) 2020-07-29 vasniktel@gmail.com spirv-fuzz: Compute corollary facts from OpBitcast (#3538) 2020-07-29 dj2@everburning.com Update some language usage. (#3611) 2020-07-29 vasniktel@gmail.com spirv-fuzz: Relax type constraints in DataSynonym facts (#3602) 2020-07-29 vasniktel@gmail.com spirv-fuzz: Remove non-deterministic behaviour (#3608) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,tobine@google.com Change-Id: I5a476dd331bc8387617cedcd23dabc8abb3b73b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328516Reviewed-by:
-
mhasank authored
There are two overlods of OnProvisioningFinished and one is used mostly by tests. The two internal references are switched to using the remaining overload. BUG=b:62613791 TEST=unit tests Change-Id: I8df3b031355e9b3262fb4efa0f33f29cd8c1eb23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328017Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Cr-Commit-Position: refs/heads/master@{#793107}
-
Viktor Semeniuk authored
This change adds the same long hostname handling as on desktop, by truncating it on the leading end instead of trailing. Bug: 1075494 Change-Id: I1012ba35e8b1074da448329ac7e1fabadb38a672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325732 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#793106}
-
Viktor Semeniuk authored
This change adds possibility to delete password on Password Details Screen. Bug: 1075494 Change-Id: Ic0cb8f264bf9434dd963b05be6bbac4f99cd4e1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309436 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1596066946-9129567d6e9177db19fddcf4c1ff4281afd442eb.profdata to chrome-win64-master-1596088294-504dedae571570b11066feec00ad5216cd478cce.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I71bdbf59dda6a9dbfdb4a6dfd3d3ec95f89dc50d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328744Reviewed-by:
-
Roman Aleksandrov authored
Use new MaybeSkip method for skipping screen. Add tests for UMA stats. Bug: 1064561, 1095062 Change-Id: I9ba91dd8b132367a160b975f724b5e1692987832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166263Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#793103}
-
Maksim Ivanov authored
Provide test coverage for the scenario when the challenge-response login (a.k.a. smart card based login), fails due to the absence of the certificate provider extension (a.k.a. smart card middleware). Bug: 1033936 Change-Id: I74c121575595ef013b64173fa7094247e7e2fd59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326891 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#793102}
-
Maksim Ivanov authored
Switch the temporary verbose logging in the certificateProvider API implementation to use LOG(WARNING) instead of VLOG, since the latter was recently disabled for most of modules due to performance penalty (see https://b/77729987). These logs will be removed once we finish stabilizing the smart card user login feature and collecting feedback from the early customers. Bug: 1046860 Change-Id: I96223be406c267043d1995ccc8d905718dc465ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327930 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Reviewed-by:
-
Balazs Engedy authored
This reverts commit ab2ce732. Reason for revert: Likely cause for consistent failures with PersistentBackground/ExtensionPageCaptureApiTest/*. See CL comments for more details. Original change's description: > [Extensions] Enable the pageCapture API for SW-based extensions. > > Bug: 1093066 > Change-Id: I5dc3c7c9771793825dfa8e6ea89dc94a253b0a44 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321949 > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Commit-Queue: David Bertoni <dbertoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793047} TBR=karandeepb@chromium.org,dbertoni@chromium.org Change-Id: I6d0d744bea6437a9195f30e9e4896b6113cf686e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1093066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328853Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d640d034..369fe23b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iab92320c42ee21c15874f2871c16be2290cb224b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326621Reviewed-by:
-
Balazs Engedy authored
This reverts commit 02649e91. Reason for revert: testActionsWheelScroll is consistently failing on Mac 10.14, I have added details on the CL itself. Original change's description: > Support Wheel input source in Action API > > We will add a new input source type to simulate the mouse wheel scroll > to the Webdriver Action API, https://github.com/w3c/webdriver/pull/1522. > > In this CL, we are adding the wheel input source in the ChromeDriver's > ExecutePerformActions function, which implements the Webdriver Action > API in Chrome and we will use Devtool's input protocol, > Input.dispatchMouseEvent with a type of "mouseWheel". > > > Bug: 1040611 > Change-Id: Ieb46c24466b6149d9f398385652a5779b0fd2adf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324972 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792821} TBR=lanwei@chromium.org,johnchen@chromium.org Change-Id: I38b43583a3c9b73c4d2024fe9f6d88e7e80cc57e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1040611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329165Reviewed-by:
-
Ankit Kumar 🌪️ authored
Update PDFEngine layer and below to use gfx::Size instead of pp::Size in case of direct calls. Indirect calls like using pp::Size to create pp::Rect are the only places where pp::Size is still present. Bug: 1101101 Change-Id: Ica2a815ec1b85a3fb12cd0def5fa27cc3d042f1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324681 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:K. Moon <kmoon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#793097}
-
Eugene Zemtsov authored
- A fairly complex adapter from VideoEncodeAccelerator to media::VideoEncoder interface - new field in webcodecs/VideoEncoderConfig to indicate video acceleration preference - webtests to exercise accelerated video encoding when it's available on the test machine Bug: 1045248 Change-Id: I09998edf43ab5b8666965fa000d9572e302b143a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280332 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#793096}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/03cf7c3eaeaf..a36a91a4450c 2020-07-30 jiawei.shao@intel.com Support lazy initialization on the buffers bound into a bind group If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Id8073fa3847db6f2eae25733d0b16aa3ca7f5a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328523Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596073768-9a82f2d14033fa7ddc8a0ee8f109a4712d7e2f89.profdata to chrome-win32-master-1596084863-9f8350c67999f4907bbdbafc211dfb921acc2de3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I96349b0393978a4d0cd6f93f2cc9e58e5264317d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328521Reviewed-by:
-
