GitLab

When positioning its internal ImageSkia for painting, CENTER-aligned ImageViews
currently assume that any insets it may have are symmetrical (i.e. the
left and right or top and bottom insets are the same value). This causes the
image to be drawn in the incorrect position (e.g. it may cross the boundaries
set by the ImageView insets) when the insets are not symmetrical. Fix by
accounting for the inset width and height during positioning.

Bug: 801583
Change-Id: I65766fbea4c088ca45781a6a69cbae7b52178625
Reviewed-on: https://chromium-review.googlesource.com/917843
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536962}

This CL adds an util to know when the toolbar is split.

Bug: 804748
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7d6accb32de848ff2b3e0ff8aef68d7c278aeb9a
Reviewed-on: https://chromium-review.googlesource.com/916194Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536961}

Following bot results are included.
3759 3760 3761 3763 3770

50 lines were removed and 72 lines were deflaked by consecutive results
since 3723.

TBR=eae@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ifce72d0c37323b2fcd22713b5e8e1414493967a7
Reviewed-on: https://chromium-review.googlesource.com/919641
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536960}

It is necessary to be precise about the ScreenInfo that is to be sent
to a RenderWidget, because failing to be consistent will result in
violations of surface invarients (size and scale factor of the surface).

The RenderWidgetHostView is the source of truth about the surface
id and size, but it is not consistently the source of truth about the
device scale factor.

The device scale factor comes from the ScreenInfo which comes from
RenderWidgetHostDelegate->WebContentsImpl->WebContentsView, which
may or may not match the RenderWidgetHostView surface info.

Remove the GetScreenInfo method from WebContents and WebContentsView,
and restore RenderWidgetHostView as the one true source of ScreenInfo.

Bug: 805774
Change-Id: Id0d962a49ceb9ad91de783faf3fb1215c1333083
Reviewed-on: https://chromium-review.googlesource.com/917202Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536959}

This introduces LinkLoadParameters, which is a parameter object for
LinkLoader::LoadLink() and groups the parameters originated from a
<link> element or a Link: header.

Pure refactoring, no behavioral changes.

Change-Id: I32c86f5b7097f3f0540ae84906614ff8d30199ee
Reviewed-on: https://chromium-review.googlesource.com/918224Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536958}

Overview mode is one of the complex areas for improving animation speed.
This cl implements a new proposal to tone down the animations.

Changes:
1. Enter animation: only animate currently visible windows and put the
rest of the windows in place.
2. Exit animation: animate all of the Most Recently Used (MRU) windows
up to and including the MRU maximized/fullscreen window, with the other
windows behind not moving until the maximized/fullscreen window finishes
animation.

Bug: 801465, 795988
Test: Tested new animations in different modes: normal, tablet, and splitview.

Change-Id: Ia7046c670bb484447752b8e5545fa81e981256d2
Reviewed-on: https://chromium-review.googlesource.com/882008
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Mitsuru Oshima (In Tokyo) <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536957}

Simplified UI is approved to be the default UI for gesture nav. This CL
also cleans up the code to check overscroll history navigation flag
value.

BUG=787607
TEST=manual

Change-Id: I7f08534239ac988560892d3f44d056e5be865826
Reviewed-on: https://chromium-review.googlesource.com/907426Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536956}

U+014B (ŋ) => n
U+1004 (င) => c
U+100c (ဌ) => g
U+1042 (၂) => j
U+1054 (ၔ) => e

Bug: 811117,808316
Test: components_unittests -gtest_filter=*IDN*
Change-Id: I29f73c48d665bd9070050bd7f0080563635b9c63
Reviewed-on: https://chromium-review.googlesource.com/919423Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536955}

Change-Id: I4db6b3d75d349071025bb481982370d7e139de32
Reviewed-on: https://chromium-review.googlesource.com/920541
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536954}

Previously all FragmentClips under a fragmented subtree were at the
same level below the parent clip state of the top-level fragmented
object. A FragmentClip was used in a chunk property state only if
the chunk had no other clips under the parent clip state of the top-
level fragmented object, causing FragmentClip was not applied in
some cases.

Now let Fragments be in clip tree hierarchy. When we create a new
tree builder context for a fragment, we need to try to find the
parent context from which to inherit the paint properties:
1. For a new LayoutFlowThread:
  a) if it's the top level, use the first (and only) parent context;
  b) otherwise, convert logical_top_in_flow_thread in itself to
     logical top in the parent flow thread which is used to match
     the parent context.
2. For an object which has column-span:all or is out-of-flow
   positioned, skip matching against parent contexts because the
   fragment is definitely (column-span:all) or probably (out-of-flow)
   not the child of any fragment of the parent fragments.
3. Otherwise, match the parent context using
   logical_top_in_flow_thread.

If the above algorithm matches a parent context, make a copy the
parent context as the new context, and overwrite fragment_clip and
logical_top_in_flow_thread.

Otherwise, we'll use the first parent fragment as if it were the
parent fragment, but traverse up the Container tree (which includes
all containing flow threads) to find the correct clip state.

Bug: 803649
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I42e84263b709e184dde92b972c74da96becd8a23
Reviewed-on: https://chromium-review.googlesource.com/912551
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536953}

This cl adds a horizontal line class to separate item views in Keyboard
Shortcut Viewer (KSV).

Bug: 768932
Test: Manually test that the separator line is correctly created.
Change-Id: Ia09d52ad120bc4d2ba9d36eef4fce27225ecfedb
Reviewed-on: https://chromium-review.googlesource.com/911980Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536952}

This is a reland of 391d909b.

This was once reverted due to potential cause for Mac bot's
flakiness: crbug.com/805383

Original change's description:
> Remove dead code after multiple shadow removal [4/5]
>
> Remove ShadowRoot::{Younger,Older}ShadowRoot
>
> Bug: 795221
> Change-Id: Ib4754de2184d08db9bb5fc35379f27dea5ef2997
> Reviewed-on: https://chromium-review.googlesource.com/831810
> Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
> Reviewed-by: Hayato Ito <hayato@chromium.org>
> Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#531478}

TBR=hayato@chromium.org, futhark@chromium.org

Bug: 795221
Change-Id: I61a8c2d7b39398fc676515f67a7c0d0a9536da22
Reviewed-on: https://chromium-review.googlesource.com/920941Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536951}

The old wallpaper picker must generate and save a thumbnail for each
custom wallpaper, so that they can persist even after the original
image file is deleted. This is not needed for the new picker:
the thumbnails under 'My Photos' section are real-time representation
of the files under Downloads. We do not want to cache or save them
since the files may change all the time.

Therefore, to simplify the logic, we only need to read the image data,
and then use CSS to resize the image to display as the thumbnail
(the same with backdrop wallpapers for consistency).

The new wallpaper picker doesn't display the thumbnail of the history
custom wallpaper like the old picker. So basically the 'generate and
save thumbnail' code path can be deprecated in the future.

Bug: 809793
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ibf00bec636a52081c77cd7cf1b94e934fd97b11c
Reviewed-on: https://chromium-review.googlesource.com/912282Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536950}

This cl adds a '+' icon between the bubble views of modifiers and key in
the Keyboard Shortcut Viewer (KSV).

Changes:
1. ui::VKEY_UNKNOWN is used as a separator indicator and will be shown
as a highlighted "+" icon.
2. Insert the ui::VKEY_UNKNOWN into |shortcut_key_codes| as the separator.
3. Replace the separator with '+' icon when creating
KeyboardShortcutItemView.

Bug: 768932
Test: Manually test that the separator icon is correctly created.
Change-Id: I2d01beb3f4c4b69a18cbb4820afc024f92679dc3
Reviewed-on: https://chromium-review.googlesource.com/912135Reviewed-by: Mitsuru Oshima (In Tokyo) <oshima@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536949}

https://webrtc.googlesource.com/src.git/+log/ea86bb74fc81..ae8a90a1d4db

$ git log ea86bb74f..ae8a90a1d --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Id3ebac3930b5b1ee90734f2d5b973bfbd8febe24
Reviewed-on: https://chromium-review.googlesource.com/920744Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#536948}

Change-Id: I6e59596d70954af52806f1cb5d5ea4867a53d420
Reviewed-on: https://chromium-review.googlesource.com/920562Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536947}

Bug: None
Change-Id: I4098f2da62665acb63d868f3dc4a4001f44a9ae9
Reviewed-on: https://chromium-review.googlesource.com/920681Reviewed-by: Nick Harper <nharper@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536946}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/62d82cfd..12457874

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: If3c89bc9d82728c4dc662e0784ac5b11c8cf3457
Reviewed-on: https://chromium-review.googlesource.com/920703Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536945}

This CL aligns CookieManager's interface for listening to cookie changes
(observer pattern) with the proposed addition to
RestrictedCookieManager, which will be used by the Async Cookies API.

Bug: 729800
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I0464b0d1d0388279e549d19c5dbeea2d0342cc60
Reviewed-on: https://chromium-review.googlesource.com/913151Reviewed-by: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536944}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=anantha@chromium.org

Change-Id: I6d5289a138617312e09d7eded0d95c7266727045
Reviewed-on: https://chromium-review.googlesource.com/920827Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536943}

-Creates ChromeTableViewController with basic unittests.
-Implements basic UITableViewDataSource methods.

Bug: 805136
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Idbc59f0c0b71c01b9c8513e8bd7907b0f9713971
Reviewed-on: https://chromium-review.googlesource.com/915261
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536942}

This is a reland of 4c50e3e1.

It is reverted as shown in crrev.com/c/920222, because of a compile error.
blink::WebInputEvent::kTimeStampForTesting is moved to
blink::WebInputEvent::GetStaticTimeStampForTests(). This CL fixes the compile
error.

TEST=content_browsertests RenderViewTapDisambiguationTest.CanvasSizeUseZoomForDSF
on NEXUS 5X.

Original change's description:
> Adjust location and size of TapDisambiguator
>
> As shown in crbug.com/737777#c72, the location and size of Android tab
> disambiguator is not correct when --use-zoom-for-dsf is enabled. It is because
> RenderViewImpl::DidTapMultipleTargets() assumes |touch_rect| is in DIPs while it
> is in physical pixels when --use-zoom-for-dsf is enabled. This CL solves this
> problem.
>
> TEST=Android Chrome with production code on NEXUS 5X,
> content_browsertests RenderViewTapDisambiguationTest.CanvasSizeUseZoomForDSF
> on NEXUS 5X, NEXUS 4, NEXUS 9 (w/ and w/o this change).
>
> Bug: 737777
> Change-Id: I64ca0b9b76fcfc3798036a80c9213973de8f3f77
> Reviewed-on: https://chromium-review.googlesource.com/898824
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#536868}

Bug: 737777
Change-Id: Id21123049c71d49460f1f428f6baafb9807084a4
Reviewed-on: https://chromium-review.googlesource.com/920801Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Jaebaek Seo <jaebaek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536941}

Comment added to benchmark sharding map file causes a crash while
loading the benchmark sharding map. This change allows the code to
ignore the comment at the start of the map and continue running the
script.

Bug: 758630
Change-Id: Ia0617a53fb6f5b43c9f22288ca916218e8472d37
Reviewed-on: https://chromium-review.googlesource.com/916891Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#536940}

Accessibility checks require all views, even in content shell, to have a name.

Bug: None
Change-Id: I6a4d4c7ff826cbd48fc0b91f7173dd2e93862412
Reviewed-on: https://chromium-review.googlesource.com/919305Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536939}

This fixes an a11y regression in the page info button label under the
experimental conditions of the HTTPS Indicator UI Study
(https://crbug.com/803501), where only the green lock icon would be
shown but no explanatory label would be included for screen readers.
This modifies the accessibility label under these conditions for both
views and cocoa UI to make sure that secure connections are always
labeled as such.

On Windows/Linux/ChromeOS (Views), this appends a new String Attribute
to the description in the AXNodeData. On Mac (Cocoa), this prepends the
"Secure" text to the beginning of the Accessibility Label.

Bug: 812034
Change-Id: I1fe2e6d1afa7110d445154da682846fd82738939
Reviewed-on: https://chromium-review.googlesource.com/917282
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536938}

Before duplicating this bot's configuration to create a new bot,
let's see how many of these exceptions are legitimate.

Bug: 810907
Change-Id: I87d0607394af6ce9dbdd1932a240bcea7cbc9e1b
Reviewed-on: https://chromium-review.googlesource.com/920321Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536937}

Bug: 731384
Change-Id: I1385fbece81e7e68f41c41b66aacfb3795c36af7
Reviewed-on: https://chromium-review.googlesource.com/920842Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536936}

This reverts commit 01b39191.

Reason for revert: Causes crash

Original change's description:
> [MacViews] Wire up AutofillPopupView
> 
> Show toolkit-views AutofillPopupView with --secondary-ui-md.
> 
> Removed AutofillPopupBaseView FocusManager accelerator code.
> The code is no longer necessary since it was added for a now
> obsolete rAc dialog. The autofill popup will get dismissed by
> the web contents, which listens for the accelerators.
> 
> Bug: 728182
> Change-Id: I9f7816fe41279a397f5066d28d88099d50ef033e
> Reviewed-on: https://chromium-review.googlesource.com/889983
> Commit-Queue: Sarah Chan <spqchan@chromium.org>
> Reviewed-by: Trent Apted <tapted@chromium.org>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#534527}

TBR=ellyjones@chromium.org,tapted@chromium.org,estade@chromium.org,spqchan@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 728182
Change-Id: Ibda0e0f4a15e54e2f2d4c19951719f7d604473ff
Reviewed-on: https://chromium-review.googlesource.com/919972Reviewed-by: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536935}

Adding measurements for few key AnimationWorklet feature in
preparation of an upcoming Origin Trial.

Bug: 811922
Change-Id: Icc69cfa1980a0b562cd3e64385103776059c9fc4
Reviewed-on: https://chromium-review.googlesource.com/916886
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536934}

There were only three callsites.

- Two were for editing commands. They should not be performance-
  sensitive. So we may use the generic CreateElement(q_name, flags,
  is_value).

- One was for Document::createElementNS(). It's performance-sensitive,
  and this CL folds the content of CreateElement(q_name, flags) into it.

Bug: 806641
Change-Id: I3863687c4fdb5a126d60fae74f8690cb0ba8f918
Reviewed-on: https://chromium-review.googlesource.com/917846Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536933}

Bug: 690217
Test: manually verified at chrome://histograms after opening a zip


Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5bb3dae99444973322704dc4248d9c6bb3e8a3f8
Reviewed-on: https://chromium-review.googlesource.com/915542Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536932}

This is part of converting the follwoing IPC messages to Mojo:
https://cs.chromium.org/chromium/src/content/common/cache_storage/cache_storage_messages.h

This is a continuation of http://crrev.com/c/906046 .

This has been split from http://crrev.com/c/875510 .

In service_worker_types.h removed an include to avoid circular
includes also added include <vector> to fix lint error.

Bug: 612287
Change-Id: Ifdd96596c709abc9f5e91b900bf21ee72f4a2b27
Reviewed-on: https://chromium-review.googlesource.com/906164
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536931}

This bot is for testing that we can build with the libc++ standard
library on Windows.

Bug: 801780
Change-Id: Ifeb58bf7dfeec79afcdb30308b436d86d5769d36
Reviewed-on: https://chromium-review.googlesource.com/920741
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536930}

Changes the location of the RGB→Grayscale conversion of the
CopyFromSurface() result SkBitmap to be in
NavigationEntryScreenshotManager, as it is the only use case. This
unblocks a massive clean-up effort for bug 759310.

For reference, the following was the code that was doing the conversion
before (and is a part of a major chunk of code that we want to delete):
https://cs.chromium.org/chromium/src/content/browser/compositor/surface_utils.cc?rcl=2fe7073e23caa42cbd01575ab206ba8928ccd645&l=146

Bug: 759310
Change-Id: I2687e69b284d5c24ead10b05b49f678cf8375651
Reviewed-on: https://chromium-review.googlesource.com/919603
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536929}

Since the Learn more link was within paper-checkbox, it will get
triggered by the on-change event.

Bug: 812183
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I29b23fcf6bdeb8e485c36d8e100b39288b3b236a
Reviewed-on: https://chromium-review.googlesource.com/919429Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536928}

There was a build step (site_per_process_webkit_layout_tests) on Linux Xenial
that for some reason was requesting Trusty swarming bots.  All of the other
steps were using Xenial bots.  This CL explicitly requests Xenial swarming bots
to fix this step.

BUG=789768
R=dpranke@chromium.org

Change-Id: Id9b33f0fd189f2286cf6dbb03cfd1553bafdf354
Reviewed-on: https://chromium-review.googlesource.com/920764
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536927}

Tapping on the notification for prefetched content should open
downloads home and expand the prefetch content section.

Bug: 810098
Change-Id: If2078ab2dfff2d187d8a4331c850a4266c037607
Reviewed-on: https://chromium-review.googlesource.com/907743
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536926}

- Remove the text that indicated that the default was false.
- The default was changed but the text was not updated.

BUG=chromium:775518

Change-Id: I869b471a9b3772543c5e67824d41c9fcaa17eb8c
Reviewed-on: https://chromium-review.googlesource.com/917655
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536925}

https://chromium.googlesource.com/angle/angle.git/+log/2f23f35afb94..f3803d4f74a5

$ git log 2f23f35af..f3803d4f7 --date=short --no-merges --format='%ad %ae %s'
2018-02-14 ynovikov Fix standalone Linux build
2017-11-07 geofflang StateManagerGL: Use dirty bits for framebuffer bindings.
2018-02-14 jmadill Vulkan: Cache clear color in ContextVk.
2018-02-14 jmadill Vulkan: Pass RendererVk to Allocate helpers.
2018-02-14 jmadill Vulkan: Implement basic Renderbuffer creation.
2018-02-14 lucferron AngleWrangle: Suppress newly introduced flakyness
2018-02-08 lucferron Vulkan: Autogen mandatory texture caps
2017-09-21 geofflang D3D: Implement robust resource init for Surfaces.
2018-02-14 jmadill Revert "Vulkan: Add glslang validator to build."
2018-02-13 yunchao.he Code refactoring for end2end tests.
2018-02-09 lucferron Vulkan: Add culling rasterization states tests and invert front face
2018-02-07 lucferron Vulkan: Texture caps map
2018-02-13 oetuaho Store invariant varying names as ImmutableString
2018-02-08 oetuaho Don't search for nonexistent brackets in InitializeVariables
2018-02-12 tobine Put Vulkan mock ICD json file in separate dir
2018-01-29 oetuaho Add a constexpr constructor for TVariable
2018-02-12 geofflang Remove usage of ANGLE_FALLTHROUGH in EmulatePrecision.cpp
2018-02-12 jmadill Add test for scissored clear.
2018-02-08 brandon1.jones Enable Multisample Sources in copyImageInternal For D3D11
2018-02-12 jmadill Vulkan: Add glslang validator to build.
2018-02-02 jiawei.shao ES31: Add link validation on geometry shader itself
2018-02-12 geofflang Revert "GLES1: Link against angle_util_static instead of angle_util."
2018-02-02 jie.a.chen Vulkan: Prepend layer path to VK_LAYER_PATH

Created with:
  roll-dep src/third_party/angle
BUG=810767


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=lucferron@chromium.org

Change-Id: I7efd5cb74b02148bd9dd16e1e7d5be7274cf1819
Reviewed-on: https://chromium-review.googlesource.com/920642Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#536924}

The split is to separate codes that focus on different testing areas.

This CL only did the split without any behavior or functionality changes.

Bug: none
Change-Id: Ie5fa011e92eb3905cb3bd9fdbd68966993af4bf9
Reviewed-on: https://chromium-review.googlesource.com/919199
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536923}