- 08 Nov, 2018 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/491b15b4a4a0..63924982b3fd git log 491b15b4a4a0..63924982b3fd --date=short --no-merges --format='%ad %ae %s' 2018-11-08 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@63924982b3fd The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I9331a75b8d87389b1bfae97f45efc99680f05847 Reviewed-on: https://chromium-review.googlesource.com/c/1326332Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606503}
-
Adithya Srinivasan authored
This just duplicates documentation from base::subtle::ScopedTimeClockOverrides but I thought it was worth adding it here, as ScopedMockClockOverride doesn't currently fix any of the limitations. Also, because of this limitation we can't use ScopedMockClockOverride as-is in Blink tests. We create a task scheduler and a thread pool before running tests on the main thread (and also call TimeTicks::Now from one of the threads created). Bug: 866930 Change-Id: If7b081bd980b8ac8780c892c21b082923edd1a29 Reviewed-on: https://chromium-review.googlesource.com/c/1324103Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#606502}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 96395f60. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: If2a09c7a955f8f16123c6a0b791c5ced96b7f5fd Reviewed-on: https://chromium-review.googlesource.com/c/1326422 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606501}
-
James Hawkins authored
R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: Ib749683f19dad9fad2e0917673f319acb8bb3983 Reviewed-on: https://chromium-review.googlesource.com/c/1325310 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#606500}
-
Theresa authored
BUG=902032 Change-Id: Ia733b78e28f454420e1a176746451967c5aaebbf Reviewed-on: https://chromium-review.googlesource.com/c/1321731Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#606499}
-
Rayan Kanso authored
Fetches started from non top level frames should begin in a paused state, even if the permission is granted. Bug: 903248 Change-Id: Ia8583b23735fa865089979c0159259142225cd30 Reviewed-on: https://chromium-review.googlesource.com/c/1326148Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#606498}
-
Etienne Pierre-doray authored
base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more explicit counterpart. It should have been replaced by : * base::ScopedAllowBaseSyncPrimitivesForTesting in test files. * base::ScopedAllowSyncPrimitives in non-test files * base::ScopedAllowSyncPrimitivesOutsideBlockingScope when it's used on threads that don't allow blocking The last one is strongly frowned upon but this CL aims to document existing behavior rather than address it. Owners are encouraged to follow-up by fixing unnecessary waits and more particularly unnecessary waits outside-blocking-scope. Note: The non-for-testing versions require friend'ing in thread_restrictions.h but care was taken to add these friends ahead of git cl split (since it wasn't possible to do a line-by-line associated CL split). Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1288533 Please CQ if LGTY! This CL was uploaded by git cl split. R=kylechar@chromium.org Bug: 766678, 902653 Change-Id: I30a5956028c8d7bca56be07433b2b2f31592ae9f Reviewed-on: https://chromium-review.googlesource.com/c/1324395Reviewed-by:
-
James Hawkins authored
R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I500b7249e5d7d87b028c1446cfb28f4d4159f7df Reviewed-on: https://chromium-review.googlesource.com/c/1325215 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
-
Stephen Kyle authored
With this CL in place, --gtest_shuffle no longer breaks on blink_heap_unittests. BUG=899757 Change-Id: Ic1524b2c131d5629796c24bfe0d8903878540cae Reviewed-on: https://chromium-review.googlesource.com/c/1310313Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#606495}
-
Marc Treib authored
While we're here, also use the default (preferred) constructor of IdentityTestEnvironment. With this, there's no need anymore to create TokenService, SigninManager, SigninClient, etc manually. Bug: 859874 Change-Id: I765e0898ac232c70255a19bd05f2d2e694e6639e Reviewed-on: https://chromium-review.googlesource.com/c/1326506Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#606494}
-
Elly Fong-Jones authored
On 10.14, a file selection dialog whose default path doesn't exist will default back to ~/Documents, which breaks this test. To avoid this issue, have this test use /private/var, which is always present. Bug: 892174 Change-Id: I3f50a74566bdc5a3bf4eb14433138e65d1cfe2d5 Reviewed-on: https://chromium-review.googlesource.com/c/1316109Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#606493}
-
Koji Ishii authored
Following bot results are included. 11543 11546 11548 11551 11555 11562 11567 11573 11577 11579 11582 11584 15 lines were removed and 4 lines were deflaked by consecutive results since 11543. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I2bffbfa93bb633b2c99d7f710c08889330d29525 Reviewed-on: https://chromium-review.googlesource.com/c/1322336 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#606492}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cf6df902d647..edcefdcf7d5a git log cf6df902d647..edcefdcf7d5a --date=short --no-merges --format='%ad %ae %s' 2018-11-08 ehmaldonado@chromium.org git-cl: Print git push stdout. Created with: gclient setdep -r src/third_party/depot_tools@edcefdcf7d5a The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:881860 TBR=agable@chromium.org Change-Id: I2dc822ca14d6ccb75c468f62a0cd01cd0ecaa3b3 Reviewed-on: https://chromium-review.googlesource.com/c/1326331Reviewed-by:
-
Etienne Pierre-doray authored
base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more explicit counterpart. It should have been replaced by : * base::ScopedAllowBaseSyncPrimitivesForTesting in test files. * base::ScopedAllowBaseSyncPrimitives in non-test files * base::ScopedAllowBaseSyncPrimitivesOutsideBlockingScope when it's used on threads that don't allow blocking The last one is strongly frowned upon but this CL aims to document existing behavior rather than address it. Owners are encouraged to follow-up by fixing unnecessary waits and more particularly unnecessary waits outside-blocking-scope. Note: The non-for-testing versions require friend'ing in thread_restrictions.h but care was taken to add these friends ahead of git cl split (since it wasn't possible to do a line-by-line associated CL split). Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1288533 Please CQ if LGTY! This CL was uploaded by git cl split. R=gab@chromium.org Bug: 766678 Change-Id: I51b024db95473edf6ee3efb82879c95be92b9191 Reviewed-on: https://chromium-review.googlesource.com/c/1325219Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#606490}
-
Mythri Alle authored
This reverts commit 3e7d4477. Reason for revert: Failing on https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.ci/linux-xenial-rel/4786 Original change's description: > Reland: Add layout tests for javascript code caching. > > This add layout tests to ensure javascript code caching is working as > expected. This also adds virtual tests with ( > --enable-features=IsolatedCodeCache --site-per-process) to test that the > isolated code cache is behaving as expected. These tests test that: > 1. code cache is created on the second visit to the script > 2. code cache is consumed on the third visit to the script > 3. code cache for the same script resource is not reused if > requested from a different origin (for the virtual tests). > > This also adds a timeout expectation for the failing tests. > > Bug: chromium:879494 > Change-Id: I4504da0fb0222f73bbf12e93d85e12a0717f8749 > Reviewed-on: https://chromium-review.googlesource.com/c/1310173 > Commit-Queue: Mythri Alle <mythria@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606455} TBR=alph@chromium.org,mythria@chromium.org Change-Id: Ib60eda1642334b6fa08f89d8f19cf4c262815f5e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:879494 Reviewed-on: https://chromium-review.googlesource.com/c/1326510Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#606489}
-
Takuto Ikuta authored
To speed up build time on windows component build, I will enable newly added /Zc:dllexportInlines- flag. The flag is similar to -fvisibility-inlines-hidden in gcc/clang. This flag makes inline member function is not exported if it does not have static local variables. But in few classes of chromium, we need to add additional EXPORT specifier to prevent link failure. This is a part of effort adding EXPORT speicifer to enable the flag. Master CL is https://chromium-review.googlesource.com/c/chromium/src/+/1317069 This CL was uploaded by git cl split. R=morlovich@chromium.org Bug: 901709 Change-Id: I1ef0284430ca511ab15dfe53fcf49bfe758a03f7 Reviewed-on: https://chromium-review.googlesource.com/c/1322333Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#606488}
-
Samuel Huang authored
Under LLD ThinLTO, if thin_lto_enable_optimizations is enabled then "promoted global names" can appear. For these, mangled symbol names get the suffix '.llvm.1234' or '.1.llvm.1234', where '1' is a small number, and '1234' is a hash. When demangled, the suffix becomes ' (.llvm.1324)' or ' (.1.llvm.1324)' if successful; and is left alone otherwise. These suffix interferes with name comparison, leading to secondary problems like symbols losing path info. This CL makes SuperSize detect and strip these suffixes, to reduce spurious diffs from enabling ThinLTO optimization. The transformation is applied when parsing .map and nm output. Details: * Add demangle.StripLlvmPromotedGlobalNames(), which performs a quick-reject substring test for '.llvm.', followed by RegExp string substitution. * Print the number of promoted global names found in .map file. * Minor updates to comments and tests. Bug: 902723 Change-Id: I4ca4142c891c948894c10180b31ff65b759cccfe Reviewed-on: https://chromium-review.googlesource.com/c/1324192 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#606487}
-
Greg Thompson authored
This allows users and admins to see when Chrome last updated (rather than when it was originally installed) by looking in the Programs and Features control panel. This seems to be the general behavior of other apps. BUG=807242 R=georgesak@chromium.org Change-Id: I361efba2c48a88e7b9175ecd4c24a750fa3b8562 Reviewed-on: https://chromium-review.googlesource.com/c/1326007Reviewed-by:
Georges Khalil <georgesak@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#606486}
-
Arthur Sonzogni authored
This CL is a prerequisite for: https://chromium-review.googlesource.com/c/chromium/src/+/1172290 After sending: URLLoaderClient::OnReceiveResponse(response_head), not all URLLoader are sending: URLLoaderClient::OnStartLoadingResponseBody(response_body). It even happens to send URLLoaderClient::OnComplete(net::OK) after that, which may confuse the URLLoaderClient. This CL updates the AboutURLLoader class. The goal is to align every URLLoaders, they will always send a data pipe after OnReceiveResponse(). Bug: 826868, 831155 Change-Id: Iab3be1ed84011793a23eac304621d0ec0fc7f47e Reviewed-on: https://chromium-review.googlesource.com/c/1323070Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#606485}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/743899de3f2d..d856ca48f425 git log 743899de3f2d..d856ca48f425 --date=short --no-merges --format='%ad %ae %s' 2018-11-08 syoussefi@chromium.org Vulkan: add clear test for emulated stencil or depth formats Created with: gclient setdep -r src/third_party/angle@d856ca48f425 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I87e4d6b0be05966a9d34e28b9074d171bd131657 Reviewed-on: https://chromium-review.googlesource.com/c/1326329Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4e6c54b6026d..6721478ef112 git log 4e6c54b6026d..6721478ef112 --date=short --no-merges --format='%ad %ae %s' 2018-11-08 greg@lunarg.com Don't assume one return means function can be inlined. (#2018) (#2025) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@6721478ef112 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8e74bf8c951f432291428c9251822e36d4b61a43 Reviewed-on: https://chromium-review.googlesource.com/c/1326330Reviewed-by:
-
Henrique Grandinetti authored
This cl simplifies how the Time Limit policy is created on the unit tests. It also adds a few tests cases that were not being covered and that we have prevously found bugs on. Bug: 902364 Change-Id: I1a2a5f9288740c0fa51dd5ccaabafd39432ba1d6 Reviewed-on: https://chromium-review.googlesource.com/c/1320269Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#606482}
-
Sean Gilhuly authored
Reflector doesn't work with OOP-D enabled, so use SurfaceLayers to embed the root surface of the source display onto mirrored and unified displays. e.g. chrome --ash-host-window-bounds=1200x1200*2,1202+0-1200x1200*2 --ash-enable-unified-desktop --ash-dev-shortcuts --ash-debug-shortcuts --user-first-display-as-internal --enable-features=VizDisplayCompositor Bug: 884805 Change-Id: I809600606e65f970e00396ff8fa0a75819a5ec7b Reviewed-on: https://chromium-review.googlesource.com/c/1251766Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Hugo Holgersson authored
This simplifies spatnav's inner loop, the evaluation of DOM nodes when looking for candidates, a tiny bit. Now that CanBeScrolledIntoView lost its call site we can remove it completely to reduce spatnav's code footprint. Bug: 770147 Test: snav-div-overflow-scroll-hidden.html Change-Id: Icbf4cb4d0274d63658dbeab1cdae1ce63557576f Reviewed-on: https://chromium-review.googlesource.com/c/1319678 Commit-Queue: Hugo Holgersson <hugoh@vewd.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#606480}
-
Ioana Pandele authored
Bug: 903249 Change-Id: I5997e54df4c96bf77bb8f64908d70801ae3fbc27 Reviewed-on: https://chromium-review.googlesource.com/c/1326011 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#606479}
-
Etienne Pierre-doray authored
base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more explicit counterpart. It should have been replaced by : * base::ScopedAllowBaseSyncPrimitivesForTesting in test files. * base::ScopedAllowSyncPrimitives in non-test files * base::ScopedAllowSyncPrimitivesOutsideBlockingScope when it's used on threads that don't allow blocking The last one is strongly frowned upon but this CL aims to document existing behavior rather than address it. Owners are encouraged to follow-up by fixing unnecessary waits and more particularly unnecessary waits outside-blocking-scope. Note: The non-for-testing versions require friend'ing in thread_restrictions.h but care was taken to add these friends ahead of git cl split (since it wasn't possible to do a line-by-line associated CL split). Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1288533 Please CQ if LGTY! This CL was uploaded by git cl split. R=wittman@chromium.org Bug: 766678 Change-Id: I2c45612b77a49ca5720da95093b0cdd8845b6f03 Reviewed-on: https://chromium-review.googlesource.com/c/1325191Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#606478}
-
Tim Volodine authored
Add a constructor to AwWebResourceRequest to make it possible to create AwWebResourceRequests directly from network::ResourceRequest. Also use this constructor in the new code path related to Network Service. This reduces duplicate code and increases readability in current and future code. Also because of the recent introduction of is_renderer_initiated member which is not included in any existing constructor, this patch simplifies the actual creation of requests. BUG=897149,841556 Change-Id: I91c3337fe9d9c3cb2b12f36e53b888bbeebb0d30 Reviewed-on: https://chromium-review.googlesource.com/c/1312484 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#606477}
-
Friedrich Horschig authored
Before this CL, the accessory would only clear the accessory suggestions when the origin changes during a navigation or when new suggestions overwrite the existing ones. With this CL, the accessory also clears the suggestions when a reload was the reason for a page navigation. Bug: 902716 Change-Id: I897dd774a31676adb4aede8fc4016446f058ffa0 Reviewed-on: https://chromium-review.googlesource.com/c/1323712Reviewed-by:
-
Egor Pasko authored
Also rewrite matching to be more assertive on particular sub-parts of the string. Hopefully this would allow resolving particular cases before the perf/memory regressions creep in. The new parsing finds extra ~2000 symbols compared to the previous version. For testing I compared the extracted symbol infos with the output of 'arm-linux-androideabi-nm --print-size --size-sort --reverse-sort' on the instrumented binary. The differences are: * 'linker_script_end_of_text' is ignored by the symbol extractor (the 'linker_script_start_of_text' is output as a special case because we rely on it later) * the symbol extractor seems to rightfully ignore local labels and pointers deep into functions, like: 'PRE_LOOP_STAGES_7_OR_8' or 'jsimd_idct_islow_neon_consts' * v8 builtins like 'Builtins_RecordWrite' have the size 0 and unfortunately are not distinguishable from labels above Bug: 893981 Change-Id: Ie2ac9a76508832cb90fdedda1ceb46f6c2b24dba Reviewed-on: https://chromium-review.googlesource.com/c/1326486Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#606475}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/63ae28d13da9..7491c965b291 Created with: gclient setdep -r src-internal@7491c965b291 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8690844804eea6609d8f9fd1d72dc16a97c4e31a Reviewed-on: https://chromium-review.googlesource.com/c/1326327Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606474}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/de6267f6e213..0bbca7f95d2f git log de6267f6e213..0bbca7f95d2f --date=short --no-merges --format='%ad %ae %s' 2018-11-08 lalitm@google.com trace_processor: fix build Created with: gclient setdep -r src/third_party/perfetto@0bbca7f95d2f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I5dfc9b910287a0fa5089003608c84ed42232fefd Reviewed-on: https://chromium-review.googlesource.com/c/1326326Reviewed-by:
-
Philip Rogers authored
The compositor has a concept of "damage" that is similar to the raster invalidation calculated in blink and represents the part of the screen that needs to be redrawn. Damage in the compositor is calculated using |Layer::subtree_property_changed()|. This patch uses SPV2's property node "changed" bits to mark cc::Layers as changed if any ancestor property tree node changes. Bug: 901051 Change-Id: I8899ce2ef8dd2b37855f38c71dea443d28520788 Reviewed-on: https://chromium-review.googlesource.com/c/1324093 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#606472}
-
David Jean authored
This is a reland of 50ac3f62 The problem is fixed in https://crrev.com/c/1326155 Original change's description: > [ios] add manual fallback address cell > > Will merge the cell_utils with card_cell after crrev/c/1303730 is merged. > > Bug: 845472 > Change-Id: Iead98637aeaa8b7e3b0252057b8592ef4fff0529 > Reviewed-on: https://chromium-review.googlesource.com/c/1317853 > Commit-Queue: David Jean <djean@chromium.org> > Reviewed-by: Eric Noyau <noyau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606423} TBR=noyau@chromium.org,mahmadi@chromium.org Bug: 845472 Change-Id: I6524b3ed9d38233c0c5489a2b6ecd2753708d09a Reviewed-on: https://chromium-review.googlesource.com/c/1326484Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#606471}
-
Max Morin authored
The current code assumes that the time stamp given by CRAS is from the clock that base::TimeTicks uses. It is not, leading to incorrect time stamps. I verified that, in a VM, the new code in apprtc reports ~the same latency as running "cras_test_client --capture_file /dev/null --show_latency". Bug: 903213 Change-Id: Ib998414d4c4c8a3df7c7ef62f8386960f7439156 Reviewed-on: https://chromium-review.googlesource.com/c/1326142Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#606470}
-
Hans Wennborg authored
Disable flaky test org.chromium.chrome.browser.partnercustomizations.PartnerHomepageUnitTest#testHomepageFeatureFlag TBR=danielpark Bug: 901769 Change-Id: I3b6b67f3381f77cc3520139eea3c11d5a189ae8c Reviewed-on: https://chromium-review.googlesource.com/c/1326485Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#606469}
-
Vadym Doroshenko authored
This reverts commit 7b104ecc. Reason for revert: test AshKeyboardControllerTest.ShowAndHideKeyboard which was added on this CL fails on some bots. Here is the first failure https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/30008 Original change's description: > Add Show/HideKeyboard methods to keybaord_controller.mojom > > This CL: > * Introduces ShowKeyboard, HideKeyboard, and IsKeyboardVisible > to keyboard_controller.mojom. > * Includes HideReason for HideKeyboard (User or System). > * Introduces keyboard::mojom::KeyboardEnableFlag::kTemporarilyEnabled > for temporarily enabling the keyboard and showing it. > * Renames keyboard::mojom::ReloadKeyboard() -> RebuildKeyboardIfEnabled(). > * Introduces keyboard::mojom::ReloadKeyboardIfNeeded() which calls > KeyboardUI::ReloadKeyboardIfNeeded() which updates the keyboard URL if > it has changed and otherwise does nothing. > * Replaces direct calls to KeyboardController from most of src/chrome > Notable exception: ChromeVirtualKeyboardDelegate which will be > transitioned in a follow up CL. > > Bug: 843332 > Change-Id: I2faf000c8233ee0253b799a6e4780020ba3bbe1f > Reviewed-on: https://chromium-review.googlesource.com/c/1309215 > Commit-Queue: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Darren Shen <shend@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Shu Chen <shuchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606311} TBR=jamescook@chromium.org,stevenjb@chromium.org,sky@chromium.org,shuchen@chromium.org,tsepez@chromium.org,shend@chromium.org Change-Id: Ib2634d6ebc0274049368ebf86488fc185d81f9c4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843332 Reviewed-on: https://chromium-review.googlesource.com/c/1326490Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#606468}
-
François Doray authored
This reverts commit 4d971424. Reason for revert: Caused a binary size regression on Android. https://crbug.com/883902 TBR=alemate@chromium.org,chili@chromium.org,kouhei@chromium.org Bug: 883902 Original change's description: > Base: Mark TimeDelta::In...() methods as constexpr. > > This will allow use of these methods in constexpr expressions such as > https://chromium-review.googlesource.com/c/chromium/src/+/1195852/4/chrome/browser/resource_coordinator/tab_manager_features.h#118 > > Change-Id: I4407ac72846e7c826e5cf3d920cda5f4b5d5071c > Reviewed-on: https://chromium-review.googlesource.com/1220446 > Commit-Queue: François Doray <fdoray@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590667} TBR=fdoray@chromium.org,mark@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ib3b8ead36933549c238622ea2b6641dc427f65ad Reviewed-on: https://chromium-review.googlesource.com/c/1226098 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#606467}
-
Hans Wennborg authored
This reverts commit e1a5c58c. Reason for revert: Multiple reports of flakiness, see bugs. Original change's description: > [Autofill] Add Autofill StrikeSystem to waterfall testing config > > Bug: 884817 > Change-Id: Iab61ac0b51d4541313f48263cadbfe2110fac543 > Reviewed-on: https://chromium-review.googlesource.com/c/1321255 > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Commit-Queue: Jared Saul <jsaul@google.com> > Cr-Commit-Position: refs/heads/master@{#606087} TBR=rkaplow@chromium.org,jsaul@google.com Change-Id: I6b8f3f6961891fc876900a574d2e3683fc63d5c0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 884817, 903055, 903080, 903083, 903228 Reviewed-on: https://chromium-review.googlesource.com/c/1326503Reviewed-by:
-
Koji Ishii authored
This test is identical to: external/wpt/css/CSS2/text/white-space-normal-007.xht Found when the two tests start to fail in a local change. TBR=foolip@chromium.org Change-Id: I5c8c9767c2279867fc48379146f322703cc37103 Reviewed-on: https://chromium-review.googlesource.com/c/1325589Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#606465}
-
Mark Cogan authored
This CL makes BVC's tabModel property synthesized, and changes all uses of the previous backing ivar to uses of the property. Change-Id: If75a5b72e0fd222d08a0aa8b7c493d07e404b24f Reviewed-on: https://chromium-review.googlesource.com/c/1323556 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#606464}
-
