GitLab

Files in chrome/android/sync_shell/javatests use the
org.chromium.chrome.browser.sync Java package, but were located under
src/chromium/chrome/browser/sync. This fixes the problem by adding an
"org" directory.

R=nyquist@chromium.org, pvalenzuela@chromium.org
TBR=manisicalco@chromium.org

Review URL: https://codereview.chromium.org/1132173003

Cr-Commit-Position: refs/heads/master@{#329547}

R=sky@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1133893003

Cr-Commit-Position: refs/heads/master@{#329546}

Renamed a class in the HTML and forgot to update CSS.

R=estade@chromium.org
BUG=487234

Review URL: https://codereview.chromium.org/1133013004

Cr-Commit-Position: refs/heads/master@{#329545}

Currently the SourcePageHandleWebContents holds a scoped_ptr<WebContents>,
which means that when distillation of the source page is finished, the
WebContents will be destroyed. This makes it hard to distill the contents
from one WebContents, and view the result in another.

This CL makes the SourcePageHandleWebContents only optionally own the
WebContents by taking in a raw pointer an a bool flag of whether it should
own it or not.

In the current chrome-level API DistillCurrentPageAndView the old behavior
is kept, and the source WebContents is destroyed when distillation finishes.

In addition, this CL adds a new chrome-level API DistillAndView(...), where
the caller passes in two WebContents, one for the source page, and one for
where the caller wants to view the distilled content. The distiller code does
in this case not take ownership of any of these.

BUG=None
TEST=browser_tests,components_browsertests

Review URL: https://codereview.chromium.org/1058193002

Cr-Commit-Position: refs/heads/master@{#329544}

BUG=486889

Review URL: https://codereview.chromium.org/1141453003

Cr-Commit-Position: refs/heads/master@{#329543}

Adds handling to show the selection handles for a tap or long-press
on an existing selection that does not yet show the selection handles.

This approach works fine when the selection does not wrap,
and it's currently very rare that we have a multi-line selection.
However, some day we'll have the ability to expand the selection,
so we should revisit this implementation then.
More info on this in issue 393025.

Based on CL 1086393003 by jdduke@.

BUG=chromium:393025, chromium:420281

Review URL: https://codereview.chromium.org/1102933003

Cr-Commit-Position: refs/heads/master@{#329542}

When we close a tab that shows a modal dialog, and another tab has a modal
dialog pending, we'll end up deactivating the first tab after closing it. In
that case, just ignore the event.

BUG=484550
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/1141493002

Cr-Commit-Position: refs/heads/master@{#329541}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f0a5894..6394784

TBR=dpranke@chromium.org,alancutter@chromium.org

Review URL: https://codereview.chromium.org/1138813004

Cr-Commit-Position: refs/heads/master@{#329540}

There are four metrics for proxy resolution:
1. ResolvedUsingScript is whether a script was executed to resolve the URL.
2. ResolveTime is the total time taken to resolve a URL, including retries
   due to resolver crashes. This is regardless of whether or not the script
   was executed.
3. GetProxyUsingScriptTime  is the time taken to resolve a URL when executing
   the PAC script.
4. ScriptTerminated is whether or not a resolution caused the resolver to crash.
   Having this as a boolean on total resolutions indicates how crashy the
   out-of-process resolver is.

BUG=467832

Review URL: https://codereview.chromium.org/1121823004

Cr-Commit-Position: refs/heads/master@{#329539}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/dd4e568..8c9b6f1

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/1134283002

Cr-Commit-Position: refs/heads/master@{#329538}

This provides the implementation and tests to maintain an
exponentially-decaying average of feedback signal values.  This will
be used in soon-upcoming changes that will allow screen capture to
auto-adapt the frame resolution and frame rate to the user's
environment.

BUG=156767

Review URL: https://codereview.chromium.org/1097633005

Cr-Commit-Position: refs/heads/master@{#329537}

This works the same way as NativeAppWindowCocoa. Common code
is factored out to ui/gfx/mac/nswindow_frame_controls.

BUG=459877

Review URL: https://codereview.chromium.org/1105613002

Cr-Commit-Position: refs/heads/master@{#329536}

Sanitize |session_id| passed to load() and |response| passed to update().

BUG=456398
TEST=new blink layout tests

Review URL: https://codereview.chromium.org/1132223002

Cr-Commit-Position: refs/heads/master@{#329535}

This clobbers --extra_annotation_names in compile.py.

BUG=

Review URL: https://codereview.chromium.org/1140593003

Cr-Commit-Position: refs/heads/master@{#329534}

|level| is no longer used as a result of crbug.com/443151.
So currently video canvas painting is broken as the call has an empty implementation.

BUG=485482

Review URL: https://codereview.chromium.org/1138343004

Cr-Commit-Position: refs/heads/master@{#329533}

The new name indicates that the tests are using chrome_shell. Future
tests will live in the javatests folder and won't be based on
chrome_shell.

BUG=484934
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1139643006

Cr-Commit-Position: refs/heads/master@{#329532}

BUG=486231

Review URL: https://codereview.chromium.org/1135923004

Cr-Commit-Position: refs/heads/master@{#329531}

BUG=485381

Review URL: https://codereview.chromium.org/1138893003

Cr-Commit-Position: refs/heads/master@{#329530}

The new histograms measure the performance of session cookie deletion.

BUG=485694

Review URL: https://codereview.chromium.org/1131413004

Cr-Commit-Position: refs/heads/master@{#329529}

Previously SSLServerSocketOpenSSL was ignoring disabled_cipher_suites
list and require_forward_secrecy flag from SSLConfig. Fixed
SSLServerSocketOpenSSL to trim the list of cipher suites used in BoringSSL.

BUG=481163

Review URL: https://codereview.chromium.org/1138813003

Cr-Commit-Position: refs/heads/master@{#329528}

BUG=457566

Review URL: https://codereview.chromium.org/1133303003

Cr-Commit-Position: refs/heads/master@{#329527}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/80f95a7..f0a5894

TBR=dpranke@chromium.org,alancutter@chromium.org

Review URL: https://codereview.chromium.org/1141573004

Cr-Commit-Position: refs/heads/master@{#329526}

The software compositor's canvas is only used between BeginPaint and EndPaint. Those happen consecutively for a compositor, so we can share a single buffer to back multiple canvases, one per compositor. This cuts down on memory used to that necessary to contain just the largest window of the process.

Review URL: https://codereview.chromium.org/1132133004

Cr-Commit-Position: refs/heads/master@{#329525}

This removes the TEXTURE_2D target and normalized coordinates
assumption from the YUVVideoQuad code. This is a prerequisite
to using IOSurface/SurfaceTexture backed GpuMemoryBuffers for
zero-copy transfer of software decoded video frames to the
graphics hardware.

BUG=485859
TEST=cc_unittests --gtest_filter=VideoGLRendererPixelTest.*

Review URL: https://codereview.chromium.org/1131253003

Cr-Commit-Position: refs/heads/master@{#329524}

BUG=483212

Review URL: https://codereview.chromium.org/1140823004

Cr-Commit-Position: refs/heads/master@{#329523}

This has likely been failing for a while, just noticed on my latest
try job.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1132233003

Cr-Commit-Position: refs/heads/master@{#329522}

This should have been part of https://codereview.chromium.org/1094103003

TBR=ncbray
BUG=479262

Review URL: https://codereview.chromium.org/1116223005

Cr-Commit-Position: refs/heads/master@{#329521}

Follow-on CL for https://codereview.chromium.org/1130793006/

BUG=

Review URL: https://codereview.chromium.org/1128213003

Cr-Commit-Position: refs/heads/master@{#329520}

BUG=

Review URL: https://codereview.chromium.org/1137513004

Cr-Commit-Position: refs/heads/master@{#329519}

The rv == 1 case was getting a little unwieldy. This should hopefully be
simpler. DoHandshake converts the error to a net error code and decides which
state to transition to. DoHandshakeComplete handles the result of the
handshake.

BUG=none

Review URL: https://codereview.chromium.org/1126113004

Cr-Commit-Position: refs/heads/master@{#329518}

Due to sandbox restrictions and for the sake of code simplicity, we have
to specify the directory in two environment variables:
SANITIZER_COVERAGE_DIR=XXX
and
ASAN_OPTIONS=coverage=1:coverage_dir="XXX"

This CL supercedes https://codereview.chromium.org/1113013003/

R=timurrrr@chromium.org,cpu@chromium.org
BUG=430156

Review URL: https://codereview.chromium.org/1140653002

Cr-Commit-Position: refs/heads/master@{#329517}

Idea here is to try and protect our scoped handles so that any third party close/accidental close could be some what restricted.

Besides adding flag following changes are in this CL.
1. While launching test process (Python executable), we pass it a pipe handle which we add it to ScopedHandle before passing, this marked handle as protected, now when we let python process inherit that handle, python process cannot close it and throws exception. We now duplicate handle without protection and then pass it onto python process and let host process continue with protected scoped handle.
2. Other change is related to disabling of active verifier dynamically. If ActiveVerifier gets invoked before disabling it (because someone used scoped handle before instruction pointer reached to UseHooks/InstallCloseHandleHooks) then it protects handle from closing. If now we disable ActiveVerifier when scoped handle goes out of scope, it tries to stop tracking handle, but in this case as active verifier got disabled later, that particular handle remains protected. Now we don't disable active verifier dynamically, but just decide on setting up of CloseHandleHook based on certain parameters.

BUG=475872
R=cpu@chromium.org,rvargas@chromium.org

Review URL: https://codereview.chromium.org/1113063004

Cr-Commit-Position: refs/heads/master@{#329516}

BUG=

NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/1140823005

Cr-Commit-Position: refs/heads/master@{#329515}

As ResourceBundle uses the scale factor we gate loading until we know
the scale factor.

I also made it so ViewportMetrics::device_scale_factor is 0 until we have a real value. This way ViewManager clients have a way to know when the real value is available.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1136743003

Cr-Commit-Position: refs/heads/master@{#329514}

This is https://codereview.chromium.org/1082973004 ported to chrome.

BUG=none
TEST=none
R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/1139973002

Cr-Commit-Position: refs/heads/master@{#329513}

Return the NetworkError if the connectGATT fails.

This is the second of two patches to implement NetworkError:
  [1] https://codereview.chromium.org/1124973003
  [2] This patch.

BUG=484779

Review URL: https://codereview.chromium.org/1118053003

Cr-Commit-Position: refs/heads/master@{#329512}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/d995009..dd4e568

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/1132993005

Cr-Commit-Position: refs/heads/master@{#329511}

This restricts the test apk's resources to just be those not already
included in the tested apk. Because GN apk targets typically don't
include java of their own, this requires supporting javac+jar for the
case where there is no java files.

Fixes deps so that chrome_shell_test_apk actually builds.

TBR=nyquist,dalecurtis,cbentzel

BUG=359249

Review URL: https://codereview.chromium.org/1127233005

Cr-Commit-Position: refs/heads/master@{#329510}

Serve the build dir when origin is 'localhost'.
(so runners can access those output dir .mojos)
Build apptests and runner apk for mandoline:all.

BUG=486220
TEST=For Android: clobber, build mandoline:all; apptests can run.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/1138933004

Cr-Commit-Position: refs/heads/master@{#329509}

Revert of Have Notifications appear over docked windows (patchset #4 id:60001 of https://codereview.chromium.org/1121893004/)

Reason for revert:
varkha@ noticed that this change will cause the virtual keyboard to obscure the notifications. Which I confirmed on my local branch.

Reverting before the regression is released.

I'll work on a followup change that also accounts for the keyboard region.

Original issue's description:
> Have Notifications appear over docked windows
>
> Update AshPopupAlignmentDelegate calculations of its work area.
>
> When windows are docked this reduces the work area for windows.
> AshPopupAlignmentDelegate uses the work area to determine the positioning of
> notifications. Update this calculation to include the docked region.
>
> TEST=AshPopupAlignmentDelegateTest.DockedWindow
> BUG=284574
>
> Committed: https://crrev.com/5b4e72c6ad0924d64d5eb9a10e063bc9334e95b2
> Cr-Commit-Position: refs/heads/master@{#329486}

TBR=oshima@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=284574

Review URL: https://codereview.chromium.org/1135323002

Cr-Commit-Position: refs/heads/master@{#329508}