- 17 Aug, 2018 40 commits
-
-
Marcin Wiacek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values. 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Main goal of patch is writing "static final" values, enum and some classes in one common @IntDef/@StringDef form: 1. with @IntDef/@StringDef first, @Retention second and related @interface third 2. with values inside @interface 3. with NUM_ENTRIES declaring number of entries if necessary 4. with comment about numbering from 0 without gaps when necessary 5. with @Retention(RetentionPolicy.SOURCE) 6. without "static final" in the @interface Change-Id: I6aeb3571f6e72dd3599a4a6055189a227312d5c4 Reviewed-on: https://chromium-review.googlesource.com/1154527Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#584198}
-
Maja Kabus authored
New class TrustedScript added as a C++ implementation of JS TrustedScript. Bug: 739170 Change-Id: Ife70f8838aefa6bb4aac45f09639464c19de6e1b Reviewed-on: https://chromium-review.googlesource.com/1168494 Commit-Queue: Maja Kabus <kabusm@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#584197}
-
nacl-chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/1c78a7ba9366..9a87d6b9de35 git log 1c78a7ba9366..9a87d6b9de35 --date=short --no-merges --format='%ad %ae %s' 2018-08-17 dschuff@chromium.org Don't run the performance tests in the emulator Created with: gclient setdep -r src/native_client@9a87d6b9de35 The AutoRoll server is located here: https://nacl-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:868204 TBR=mseaborn@chromium.org Change-Id: I26c25267ac7a2f43446d968c2a9cee6f4fe9c4df Reviewed-on: https://chromium-review.googlesource.com/1180187Reviewed-by:
nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584196}
-
Christopher Grant authored
This allows future UI library module to have one less needless dependency. There's no reason the UI needs to look up the icon for a given omnibox suggestion. BUG= R=acondor Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6fd8152ed64dd2201a4d1ad1fef139ce309965b0 Reviewed-on: https://chromium-review.googlesource.com/1180162 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#584195}
-
Robbie McElrath authored
GoogleURLTracker needs to be migrated from NetworkChangeNotifier to NetworkConnectionTracker to unblock enabling the network service. NetworkConnectionTracker currently needs a network::mojom::NetworkService* in order to to be constructed, but GoogleURLTracker is used in ios, which doesn't have a NetworkService instance to give it. NetworkConnectionTracker only actually uses the NetworkChangeManager interface, so this change makes it depend only on that, not on the entire NetworkService. Bug: 868018 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ia2d422686eaf2473c25698f6aa3e6bd66dd04ad4 Reviewed-on: https://chromium-review.googlesource.com/1177186 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#584194}
-
Moe Ahmadi authored
Splits Autofill settings page into two separate pages, one for addresses and the other for credit cards. TBR=rohitrao@ Bug: 860526,875313 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1b579976f44b413d24d71e04bfb6ef8642e5c78f Reviewed-on: https://chromium-review.googlesource.com/1180266Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#584193}
-
Steven Valdez authored
https://boringssl.googlesource.com/boringssl/+log/6b0d82229b2c4ce85b1c3f6d55bda661e07bead2..01e8e625ad83cc9a07288bd4dc285bd8b0ccd550 BUG=none Change-Id: Ia06d532d0a15b3b898396594e1f118818b408437 Reviewed-on: https://chromium-review.googlesource.com/1177906Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#584192}
-
Jennifer Apacible authored
TBR=pkasting@chromium.org NOTRY=true (disabling tests) Bug: 875444 Change-Id: I25183c656dab7f8ef061d2261dbfe517369f68ba Reviewed-on: https://chromium-review.googlesource.com/1179257Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#584191}
-
Daniel Erat authored
Update chromeos::CrosDBusService::Start to call ServiceProviderInterface::Start methods (which export methods) before calling dbus::Bus::RequestOwnership. Otherwise, there's a brief window of time where other D-Bus clients may attempt to call methods before they're available. Bug: 874978 Change-Id: I69bc36e465e8086921b67122514f2607399ea33d Reviewed-on: https://chromium-review.googlesource.com/1178757Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#584190}
-
Sam Maier authored
execute() is a confusing function, with a hidden implicit meaning that changed in API 11. It would be better if everyone had to use the more explicit executeOnExecutor() so their preference (serial or thread pool) is called out. Bug: 869907 Change-Id: I79be6d2b3114cb0520df1104ec5849f7c070c99e Reviewed-on: https://chromium-review.googlesource.com/1172446Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#584189}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/adc48799090c..c8993d8b01c9 git log adc48799090c..c8993d8b01c9 --date=short --no-merges --format='%ad %ae %s' 2018-08-17 buildbot@webrtc.org Roll chromium_revision 409b9c00..77bf1926 (583992:584099) 2018-08-17 nisse@webrtc.org Delete webrtc::PacketTime and backwards compatibility. 2018-08-17 saza@webrtc.org Toggle AECs via AudioProcessing::Config 2018-08-17 titovartem@webrtc.org Switch webrtc users from deprecated ctors. 2018-08-17 sprang@webrtc.org Don't drop keyframes even if TemporalLayers says so. Created with: gclient setdep -r src/third_party/webrtc@c8993d8b01c9 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ided700bf4eb02c9e1f3cfb9cc5e9eaff4f7eb8b0 Reviewed-on: https://chromium-review.googlesource.com/1180246Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584188}
-
Eric Orth authored
Slight behavior change to never return any address results when the flag is set (to prevent misuse). Affects even the old API usage, but should be safe since a quick check showed that all current usage of the flag never reads the resulting addresses. Bug: 821021 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I2579521d181022a8b0c425f959bcc0808f7ed7fa Reviewed-on: https://chromium-review.googlesource.com/1177913 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#584187}
-
Xiangjun Zhang authored
This CL setup a sandboxed utility service for mirroring. The service encodes the captured audio/video streams and sends them to the remote Cast receiver. The sandbox type is set to "renderer" since the service does media encoding and cast control messages parsing, which has similar requirements as a renderer in term of sandbox policy. Bug: 734672 Change-Id: Ieeb1e373241266c15535f6d4d8fa54337ca59941 Reviewed-on: https://chromium-review.googlesource.com/1162932Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#584186}
-
Jacob Dufault authored
Change-Id: I923d4987dcfaa7788451f28005998417521589ce Reviewed-on: https://chromium-review.googlesource.com/1179245Reviewed-by:
Xiaoyin Hu <xiaoyinh@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#584185}
-
Mitsuru Oshima authored
We now uses dsf for display zooming. Notable changes: * removed ui_scale_, effective_ui_scale parameters. * ZoomInternalDisplay/ResetInternalDisplayZoom is now used only for UnifiedDesktop (we probably want to change this crbug.com/873828) * ModeList for internal display now contains just one mode. I simplied the code for this cases. I also left methods in ScreenManagerOzoneInternal because it's deprecated. Bug: 823922 Test: Removed tests that are no longer necesary. Adjusted tests when they still make sense. Change-Id: Ifca7d45bba15346bb1d0ae78faa150a57e1cb6e6 Reviewed-on: https://chromium-review.googlesource.com/1173726Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#584184}
-
Robert Sesek authored
This target was removed in 1a726e03 and the data are now pulled via CIPD. Tbr: jialiu@chromium.org Bug: 817663 Change-Id: I1fc102f8417f2876bed82699dd8ef2092a070d39 Reviewed-on: https://chromium-review.googlesource.com/1180283 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#584183}
-
Nate Fischer authored
No change to logic. This removes some include statements for unneeded headers under //android_webview/. I identified these errors by running 'cppclean --include-path="$PWD"', and manually sorting out false positives. Test: ninja -C out/Default system_webview_apk (it still compiles) Change-Id: I724be2e179bb5da6ae7aa1eb9ec8840ed6a7c745 Reviewed-on: https://chromium-review.googlesource.com/1180259 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#584182}
-
Stephen McGruer authored
This CL adds some checks to help investigate crbug.com/826627. They are highly speculative, as currently the bug seems to be in a "this can't happen" state; we seem to be getting a null start_ interpolable_value in TransitionInterpolation even though the existing CHECK in TransitionKeyframe::SetValue never fires. My only currently theory is that the stacktrace file view is misleading, so this CL moves a few things around and adds some CHECKs to try and confirm/refute that. Bug: 826627 Change-Id: I9058e0387f79c9a0ba0bd04cdc54ec128a386782 Reviewed-on: https://chromium-review.googlesource.com/1178263Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#584181}
-
Becca Hughes authored
This adds an AudioFocusObserver content API that can be used to listen to audio focus events on platforms where AudioFocusManager is being used. This also refactors AudioFocusType out of AudioFocusManager as we need it for the observer. BUG=870418 Change-Id: I34dcd664f1bfd5c5d63c0cb8d3a7528534bd2c65 Reviewed-on: https://chromium-review.googlesource.com/1161095 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#584180}
-
Toni Barzic authored
This is a reland of d6bbb56c Inheriting from the original cl (as the files for which these lgtms were given have not changed) TBR=isherman@chromium.org, alemate@chromium.org, gab@chromium.org Original change's description: > Remove pre-installed demo mode resources on low disk space > > Introduces a class that will handle removing pre-installed demo mode > resources when needed. > First incarnation observes low disk space signal from cryptohome > service, and removes pre-installed resources when low space is detected > (provided that the device is not in demo mode). > When demo mode resources get removed from disk, this is recorded in > local state, to avoid future attempts to remove these resources. > > More logic for requesting demo mode resources removal to come. > > BUG=827368 > > Change-Id: I721d1995fa818fc2fc1d056e33ba513380bf441e > Reviewed-on: https://chromium-review.googlesource.com/1173670 > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583976} Bug: 827368 Change-Id: Idd8f42f1f85d8ed0eccd17a342750a4a1150e679 Reviewed-on: https://chromium-review.googlesource.com/1180041 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#584179}
-
Jennifer Apacible authored
These are being disabled on all bots now as they fail on more bots than just Mash. TBR=noel@chromium.org NOTRY=true (disabling test) Bug: 874954 Change-Id: I3b0f4076e7aa4f43abd52040e0120f0bcc8b8ca1 Reviewed-on: https://chromium-review.googlesource.com/1180277 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#584178}
-
Justin Cohen authored
CIPD packages: infra_internal/ios/xcode/mac 10l232m infra_internal/ios/xcode/ios 10l232m Also fixes the LUCI buildbucket caches for Xcode 10. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I30453ed7b40c86547ed34ff0bc9fd6d53a2a5127 Reviewed-on: https://chromium-review.googlesource.com/1177916Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584177}
-
gogerald authored
Rename protocols as well Bug: 806868 Change-Id: Ib24e4d4f8821451a9ee56d27efd1c142a4f2d60b Reviewed-on: https://chromium-review.googlesource.com/1179966Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#584176}
-
sczs authored
ClearBrowsingDataManager causes a cell reload on CBDTableVC. A crash was happening since this reload was occuring before the TableView was properly loaded, this CL prevents those updates. Once the TableView load it will use the latest model, so there's no need for that reload. Bug: 873929 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9f50fbd039d3572895d5424a7ad1855e414ffb62 Reviewed-on: https://chromium-review.googlesource.com/1175106 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#584175}
-
Fredrik Söderquist authored
If |values_| does not contain any entries, then CheckIndexBound will fail, so the 'values_.IsEmpty()' condition can never be true here. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3c96b6b198a8d9f345a08a436101d803384d11e2 Reviewed-on: https://chromium-review.googlesource.com/1179834Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#584174}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/21068062a038..1f867bb6e2c7 git log 21068062a038..1f867bb6e2c7 --date=short --no-merges --format='%ad %ae %s' 2018-08-17 thestig@chromium.org Remove default arguments from CFPF_SkiaFontMgr. 2018-08-17 tsepez@chromium.org Introduce safer CJS_Return::Success() and Failure(). Created with: gclient setdep -r src/third_party/pdfium@1f867bb6e2c7 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iff8f931de6cad4be2aae3bfc30669525ad2a39e5 Reviewed-on: https://chromium-review.googlesource.com/1180009Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584173}
-
Alex Deymo authored
This new metric computes the image file size relative to the image area, also called "compression density" in the compression world. This value is the number of compressed bits per pixel, and it is only reported for large enough images (at least 100px per side), to avoid degenerated cases where the image is too small giving a meaningless value. Image compression formats and encoders for these formats use different techniques to compress an image, discarding some of the original data (for lossy compression). Depending on the range of the desired quality (as measured in bits per pixel) some techniques are more efficient than others. For example, at very low qualities (such as 0.2 bits per pixel) typical 8x8 DCT strategies like in JPEG are not the best since the 8x8 independent blocks are too small to allow sharing information (only 12.8 bits per block). Test: Added unittest. Checked chrome://histograms after browsing some pages. Bug: None Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia4454f66f1b7bde6a1d1b2cfb533f7539f425780 Reviewed-on: https://chromium-review.googlesource.com/1177750Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#584172}
-
Jennifer Apacible authored
Relanding to fix compiler error. TBR=tedchoc@chromium.org NOTRY=true (disabling a test) Bug: 875372 Change-Id: Idc4c7863dd6e8e1d97ec974c2b8dff3fd09d91f1 Reviewed-on: https://chromium-review.googlesource.com/1180268 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#584171}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 46b48ae1. With Chromium commits locally applied on WPT: 53b12b9d "TrustedTypes tests updated to match newest API version." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22791 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio meade@chromium.org: external/wpt/web-animations mkwst@chromium.org: external/wpt/cookies yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib86630540d7a9c20844e1c4cb67e1b76d3f2c565 Reviewed-on: https://chromium-review.googlesource.com/1180077 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#584170}
-
chaopeng authored
The layout test crash because: 1. We always create scrollbar layers even the outer viewport does not scrollable 2. Outer viewport does not scrollable then we don't create scroll node in NeedsScrollNode. 3. cc gen property trees alway create scroll node because it is scrollable in cc side (RequiresCompositingForRootScroller). In this patch, we always add scroll node for layout view. After this CL, some tests in virtual/android/fullscreen still failure but not crash, devtools mobile emulator still other crash. Bug: 865560 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I21a54cf7739055832b4634e28b850bf63543d9ed Reviewed-on: https://chromium-review.googlesource.com/1156002 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#584169}
-
Timothy Gu authored
The tests themselves were moved in https://github.com/web-platform-tests/wpt/pull/11927. NOEXPORT=true Change-Id: I680e2155b34f37e8693e36bacbf8aafeed918db4 Reviewed-on: https://chromium-review.googlesource.com/1179617Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#584168}
-
Jun Mukai authored
Those three boolean window properties are used both in ash (split screens, overview mode, and tablet mode) and browser / tab-dragging. They need to be synchronized. ash::kTabDraggingSourceWindowKey also needs to be addressed for the same reason, though the aura::Window* type requires some additional complications. Another CL should deal with it. Bug: 867074 Test: none Change-Id: I3f71b13322724cf20fbe103826532074c21c3c38 Reviewed-on: https://chromium-review.googlesource.com/1180094Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#584167}
-
Xida Chen authored
Right now in TouchActionFilters we have DumpWithoutCrashing for debugging purpose. Since there are too many reports, it could impact the decision of which crash is more important. This CL makes the report to be generated once every 100 times. Bug: None Change-Id: Ie370f0bdbf5d84e2bcf410fbf06a183f9b20aa6f Reviewed-on: https://chromium-review.googlesource.com/1179609 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#584166}
-
Xida Chen authored
When there is a pinch zoom gesture, it will always be sent to the root frame even if the fingers are targeting the child frame. In this case, the TouchActionFilter::allowed_touch_action_ of the root frame may not have a value and results in a crash. This CL fixes it by force the allowed_touch_action_ of the root frame to auto in this case. A new browser test is added. TBR=creis@chromium.org Bug: 851644 Change-Id: I1c9d87a1b5fecd7140fdc0ef3bfcfc4b0ea930ea Reviewed-on: https://chromium-review.googlesource.com/1178634 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#584165}
-
Aaron Leventhal authored
TBR: dmazzoni@chromium.org NOTRY: true Bug: 875163 Change-Id: Ic18bb12718321ac17673581697901fbd864eec60 Reviewed-on: https://chromium-review.googlesource.com/1180000Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#584164}
-
rbpotter authored
Correct Print Preview custom margin logic to match the old UI. The following rules should be followed: 1) If there is no sticky custom margins value, when custom margins are selected, they should be initialized to the document margins to avoid a preview regeneration. 2) If there is a sticky value, custom margins should be initialized to that sticky value, even if this results in a regeneration of the preview. 3) If at any point the user changes the orientation or the media size, the sticky custom margins value is cleared. This happens even if the media size is changed while the margins are not available, i.e., while previewing a PDF, because the media size value is sticky. Bug: 870249 Change-Id: Ibbe5084e34a8b80ec452ec9697184f0c274d2132 Reviewed-on: https://chromium-review.googlesource.com/1161288Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#584163}
-
Joshua Bell authored
Bug: 467150 Change-Id: I4d45b7aab0f8fcac5fe0d812c172d9fa0194f9b9 Reviewed-on: https://chromium-review.googlesource.com/1174920 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#584162}
-
Clark DuVall authored
http://crrev.com/c/1179263 switched SocketExtensionWithDnsLookupFunction::StartDnsLookup to use mojo API. Bug: 874659 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ia65b22c593e6df68dfc20b60942747015a46cc8d Reviewed-on: https://chromium-review.googlesource.com/1180256Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#584161}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bc414ed5dec5..54ff302cdc5a git log bc414ed5dec5..54ff302cdc5a --date=short --no-merges --format='%ad %ae %s' 2018-08-17 caryclark@skia.org avoid degenerate point in addPath extend mode 2018-08-17 caryclark@skia.org pathops remove degenerate line on close 2018-08-17 fmalita@chromium.org [skottie] Initial text layer plumbing 2018-08-17 allanmac@google.com Documentation updates and improved gcc compatibility. 2018-08-17 robertphillips@google.com Revert "Make directFilterMaskGPU & directFilterRRectMaskGPU no longer require canFilterMaskGPU's permission" 2018-08-17 robertphillips@google.com Remove occluder feature from blur mask filter 2018-08-17 caryclark@skia.org fixup winding contours 2018-08-17 benjaminwagner@google.com [Bazel] Enable GPU for Android build. 2018-08-17 z102.zhang@samsung.com After call 'va_start',some place not call 'va_end' 2018-08-17 z102.zhang@samsung.com BAD_COPY_PASTE in SkSLLayout.h 2018-08-17 kjlubick@google.com [PathKit] Add docs page 2018-08-17 robertphillips@google.com Make directFilterMaskGPU & directFilterRRectMaskGPU no longer require canFilterMaskGPU's permission Created with: gclient setdep -r src/third_party/skia@54ff302cdc5a The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I8a7337f8e7278f392886303b5be26db192743de2 Reviewed-on: https://chromium-review.googlesource.com/1180010Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584160}
-
Bill Budge authored
- Moves ScriptResource::SingleCachedMetadataHandlerImpl out of ScriptResource and into the blink namespace so it can be used by other script-like resources. - Creates this CacheHandler type for RawResource type kRaw, which will be needed for WASM modules. Bug: chromium:719172 Change-Id: I34a2740310d2d3f4ccb0cea1bb664db0b9c53f5e Reviewed-on: https://chromium-review.googlesource.com/1174903 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#584159}
-