- 31 Oct, 2018 40 commits
-
-
Zhuoyu Qian authored
This patch clears a call site of CreateVisiblePosition() in VisiblePositionOfHitTestResult(), since canonicalization on hit test result is unnecessary. Rename VisiblePositionOfHitTestResult() to PositionWithAffinityOfHitTestResult(). Bug: 657237 Change-Id: I2e88ac02e7b8c3afb307c4fe1033cc21d9f20161 Reviewed-on: https://chromium-review.googlesource.com/c/1297227Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#604105}
-
Wan-Teh Chang authored
Passing the address of a timestamp local variable as the user_priv argument to vpx_codec_decode() merely verifies that vpx_codec_get_frame() copies that value to the user_priv field of vpx_image_t correctly. No other clients of libvpx that I've inspected do this, including vpxdec.c, the sample decoder program. BUG=chromium:899916 Change-Id: I65dfd479fa3634429c4b76285c257aa54d860d81 Reviewed-on: https://chromium-review.googlesource.com/c/1306413 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#604104}
-
Erik Luo authored
When editing a breakpoint (disable, edit condition), we trigger BreakpointRemoved, BreakpointAdded by resetting live UILocations. Un-evaluated Snippets and Filesystem scripts may have a 'defaultUILocation' but no live UILocation, so edits will not update the decoration. This CL resets the defaultUILocation to trigger decoration update. Bug: 899369 Change-Id: I4474d39c5fd25f14588e0488ce9b284aa453988e Reviewed-on: https://chromium-review.googlesource.com/c/1303096 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#604103}
-
Sergey Ulanov authored
Previously scenic platform was using FIDL Scenic interfaces directly. SDK now includes scenic_cpp wrappers for Scenic interfaces. This CL updates Scenic Ozone platform to use scenic_cpp, which makes the code more readable and less error-prone. Bug: 899348 Change-Id: Id5fac3485b6a8cfac1aaefe1a921555090ec8138 Reviewed-on: https://chromium-review.googlesource.com/c/1308987 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#604102}
-
Luciano Pacheco authored
This change is part of allowing folders/files inside My files, My files will be VolumeEntry instead of EntryList. Change VolumeEntry.createReader to use CombinedReaders, to combine volume's root reader with a StaticReader which returns any entries that have been added to VolumeEntry, this is what combine volume's own entries with Linux and Play files. Copy the following methods from EntryList to VolumeEntry type: - addEntry: To be able to append Linux and Play files inside My files when it is an actual volume. - findIndexByVolumeInfo: To be able to check if Linux and Play files is already appended. - removeByVolumeType: To be able to remove Linux and Play files when they aren't available anymore. - removeByVolumeType: To be able to remove Linux files fake entry, which is used before mounting the real Linux files. Remove EntryList method removeEntry, this method wasn't in use. Test: --gtest_filter="FileManagerJsTest.FilesAppEntryTypes" Bug: 873539 Change-Id: Ic9a659aed1e7c3b40fecd678240be99915121a90 Reviewed-on: https://chromium-review.googlesource.com/c/1304186Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#604101}
-
Bailey Berro authored
This change is part of an ongoing series of changes to pull the add-smb-share dialog out of settings. - Creates smb_shares_localized_strings_provider - Switches the settings localized strings provider to using the smb_shares_localized_strings_provider Bug: chromium:887135 Change-Id: If061c2175497188772cfaa06cccb4727e438e962 Reviewed-on: https://chromium-review.googlesource.com/c/1287037 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#604100}
-
Shu Chen authored
Also add the transform rules for the deva_phone (Devanagari Phonetic) keyboard. Bug: 859432 Change-Id: If76c01252606601f645fc01a17783f1089e9bbc8 Reviewed-on: https://chromium-review.googlesource.com/c/1297223Reviewed-by:
Leo Zhang <googleo@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#604099}
-
Yuke Liao authored
This CL is pure non-op refactoring, it simplies the structure of existing compiler wrappers and makes it easier to add new wrappers. Specifically, this CL maintains the following behaviors: 1. When goma is off and static_analyzer is off: cxx command: clang++ <flags> asm command: clang <flags> 2. When goma is on and static_analyzer is off: cxx command: gomacc clang++ <flags> asm command: gomacc clang <flags> 3. When goma is off and static_analyzer is on: cxx command: analyzer_wrapper.py clang++ <flags> asm command: clang <flags> 4. When goma is on and static_analyzer is on: cxx command: analyzer_wrapper.py gomacc clang++ <flags> asm command: gomacc clang <flags> Basically, goma wapper applies to both cxx and asm while static_analyzer only applies to cxx. Bug: 898695 Change-Id: I12ed474d1286daa9fdc2f7ab5611745e99dd66a3 Reviewed-on: https://chromium-review.googlesource.com/c/1307847Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#604098}
-
Joe Downing authored
We had a few places in strings and code which referenced older MacOs versions as the minimum version, I've updated these so they should be inline with reality. Change-Id: I6f004754d25dd76a6b3d185f560b1e01a6f98eb5 Reviewed-on: https://chromium-review.googlesource.com/c/1300683Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#604097}
-
Ben Pastene authored
Needed to pack up the bios-256k.bin file in the test isolates. The latest lkgm bumps fail w/o it: https://chromium-swarm.appspot.com/task?id=40e0280b72f15510 NOTRY=true Bug: 897540 Change-Id: If731c73a677cff02523b17599a1a50629b6ff430 Reviewed-on: https://chromium-review.googlesource.com/c/1308716 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#604096}
-
Chris Morin authored
Factor out common code in UpstartClient, and allow UpstartClient to start arbitrary jobs instead of a fixed set of them. BUG=b:115779632 TEST=./out/Debug/unit_tests TEST=./out/Debug/component_unittests TEST=Ensure dummy job can be started with UpstartClient Change-Id: I362ad288b93615753cd778e823173d24a9ac16df Reviewed-on: https://chromium-review.googlesource.com/c/1307238Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
-
wutao authored
Decoder could read media data when the data source is deleted. This cl fixes this by allowing decoder to clean up defore deletion. Bug: b/118403995 Test: manual. Change-Id: I1c7336e417f8a8b5d57880d49e126fbc8873a6d4 Reviewed-on: https://chromium-review.googlesource.com/c/1304066 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#604094}
-
Khushal authored
The metadata decoder is never used for decoding anything other than the header, so it should never have any pixel data to evict. Its unnecessary to evict it from BitmapImage. R=chrishtr@chromium.org Bug: 899666 Change-Id: I93a5baa48d95e6c94f7081e9c9c02196a584b9b2 Reviewed-on: https://chromium-review.googlesource.com/c/1305973Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#604093}
-
Oliver Chang authored
R=eugenis@chromium.org Bug: 899943 Change-Id: Ia8b67dd16a924d24c40aebfd713096bbbaeab5d7 Reviewed-on: https://chromium-review.googlesource.com/c/1306933 Commit-Queue: Oliver Chang <ochang@chromium.org> Reviewed-by:
Evgeniy Stepanov <eugenis@chromium.org> Cr-Commit-Position: refs/heads/master@{#604092}
-
Ryan authored
Avoid risky casts between void* and object pointers by using the wincx method on the CryptoModuleBlockingPasswordDelegate. While safety was assured by virtue of being passed as a scoped_refptr<> to the appropriate base class, consistently use the wincx() method of the password delegate so that safety can be reasoned about from the callsite, rather than inferred from the type. BUG=none Change-Id: I120584dd5a62d1533689871f4a207f7205c6ada7 Reviewed-on: https://chromium-review.googlesource.com/c/1309097Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#604091}
-
Nico Weber authored
See https://chromium-review.googlesource.com/c/1307937 for why. Bug: 899437 Change-Id: I996feae20627688fefd09419dedc78f015347cf4 Reviewed-on: https://chromium-review.googlesource.com/c/1308494Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#604090}
-
Tarun Bansal authored
Change-Id: Ibac0faa988dfa05b727967251d0f51cfe0b474d1 Bug: 900432 No-Presubmit: true No-Tree-Checks: true No-Try: true TBR: dgozman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1309322 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#604089}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/98bc0ce5c15f..295328449111 git log 98bc0ce5c15f..295328449111 --date=short --no-merges --format='%ad %ae %s' 2018-10-30 tsepez@chromium.org Better test for AFSpecial_KeystrokeEx. Created with: gclient setdep -r src/third_party/pdfium@295328449111 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8343df1024a3141f97eaaf3d31fbc1e6160ac9c3 Reviewed-on: https://chromium-review.googlesource.com/c/1308513Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604088}
-
Aleks Totic authored
80+ unexpected passes makes testing new code hard, you can't tell what passes belong to your patch. This patch updates ~50 tests that unexpectedly passed in Linux/Win/Mac recently. There is some turbulence in test suites because of "--enable-display-compositor-pixel-dump" test running flag. Tests that were marked as failing because of this flag got a [ Failure Pass ] expectation. For the rest of the passing tests I just removed the failure line. https://test-results.appspot.com/data/layout_results/linux_chromium_rel_ng/219487/site_per_process_webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html https://test-results.appspot.com/data/layout_results/win7_chromium_rel_ng/117191/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html https://test-results.appspot.com/data/layout_results/mac_chromium_rel_ng/172497/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html Bug: 726520 Change-Id: I109e731dd318782d3e492227455ba264a435d1c2 Reviewed-on: https://chromium-review.googlesource.com/c/1303339 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#604087}
-
Wenzhao Zang authored
The added code is mostly the ones deleted in https://chromium-review.googlesource.com/c/chromium/src/+/1297308 as part of "old-wallpaper-picker only" code path. Bug: 899872 Change-Id: I7dbad13c00d50841091b9f51656428025efae096 Reviewed-on: https://chromium-review.googlesource.com/c/1308936Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#604086}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f5973509ec68..9877e8407b5c git log f5973509ec68..9877e8407b5c --date=short --no-merges --format='%ad %ae %s' 2018-10-30 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-30 bsalomon@google.com Remove unused GrOpList::numOps() 2018-10-30 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-30 mtklein@google.com some SkDraw_text cleanup 2018-10-30 brianosman@google.com Switch GrColor4h to use float storage 2018-10-30 reed@google.com hide the SkPaint::Align enum entirely Created with: gclient setdep -r src/third_party/skia@9877e8407b5c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I5f6bf281e31fc3d01e0ee38cdd3f8bc391e66873 Reviewed-on: https://chromium-review.googlesource.com/c/1308693Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1b114f20625d..76eeb8565846 git log 1b114f20625d..76eeb8565846 --date=short --no-merges --format='%ad %ae %s' 2018-10-30 rsavitski@google.com Merge "Kokoro: add a new dependency to container image & small tweaks." 2018-10-30 lalitm@google.com Merge "trace_processor: fix build on Google3" Created with: gclient setdep -r src/third_party/perfetto@76eeb8565846 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ieddd43852314f932a7248a1da39a8eed36844e1c Reviewed-on: https://chromium-review.googlesource.com/c/1308699Reviewed-by:
-
Josh Gao authored
When available, use ScopedGeneric's ownership tracking to guard its file descriptors with fdsan. Bug: 882733 Change-Id: Ibe600465d6bb7e3032e23ed813dea3d8f8ededa8 Reviewed-on: https://chromium-review.googlesource.com/c/1225309 Commit-Queue: Josh Gao <jmgao@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#604083}
-
Alexander Alekseev authored
Bug: 900233 Change-Id: I7af0c470dc7c1d23b5e7fa8fd0db42d42bf9d03d Reviewed-on: https://chromium-review.googlesource.com/c/1309140Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#604082}
-
Krishna Govind authored
R=benmason@chromium.org Change-Id: If86d1a24434133585d5aa6daf80b4a2610bbc7e9 Reviewed-on: https://chromium-review.googlesource.com/c/1309174Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#604081}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f8b5a7154479..034e897f55b6 Created with: gclient setdep -r src-internal@034e897f55b6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:790153,chromium:790158,chromium:790159,chromium:790163,chromium:790153,chromium:790158,chromium:790159,chromium:790163 TBR=mmoss@chromium.org Change-Id: I19186aa8c7856bc22712679e5a843875f84e0002 Reviewed-on: https://chromium-review.googlesource.com/c/1309077Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604080}
-
John Delaney authored
Currently reporting bytes to the MediaMetricsProvider is causing a performance regression due to the frequency of IPCs being sent. Buffer updates in the media player and send every 500 milliseconds to limit the number of IPCs sent over the lifetime of the mediaplayer. Bug: 897145 Change-Id: I7468a750e2a96106aa080559321902cf0636d3c0 Reviewed-on: https://chromium-review.googlesource.com/c/1308761 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
-
Yuly Novikov authored
Needed after https://chromium-review.googlesource.com/c/1303679 TBR=kbr@chromium.org Bug: angleproject:2923 No-try: true Change-Id: I9fa12435f768d31f52a21c738ff366a33a190e76 Reviewed-on: https://chromium-review.googlesource.com/c/1308599 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#604078}
-
Tarun Bansal authored
Change-Id: I4c4f853fa45e146cfaaacd18ebf5e8dc5a35c944 Bug: 900356 TBR: zmin@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1309074 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Khushal authored
Make the list of commands which require consistent GL state in the RasterDecoder explicit instead of defaulting to it for unhandled commands. Its easy to add a new command and miss updating this list. This makes sure you get a compile time error to avoid this. R=piman@chromium.org Bug: 894200 Change-Id: I71407d33c3339342d9ebf26b6ce94e475324a37e Reviewed-on: https://chromium-review.googlesource.com/c/1308714 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#604076}
-
Scott Chen authored
Bug: 891807 Change-Id: I7d630d5736de4c4b33efd958298cb3f941780129 Reviewed-on: https://chromium-review.googlesource.com/c/1300675 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
-
Dominic Mazzoni authored
Follow-up to other similar patches. This also fixes ax::mojom::TextStyle so that it just encodes the possible flags for the bit fields, rather than trying to encode every permutation of bits. Bug: 882660 TBR=halliwell@chromium.org Change-Id: If16be583e6ee35728116b568334b1b89aad0b2ef Reviewed-on: https://chromium-review.googlesource.com/c/1300414 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#604074}
-
Tarun Bansal authored
This reverts commit 1c7e7665. Reason for revert: Fails test org.chromium.chrome.browser.SubresourceFilterTest#resourceFilteredClose See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/3471 Original change's description: > [url_pattern_index] Print matching rule for tracing > > This is useful for debugging. > > Bug: None > Change-Id: I8e6260f09b3c17f0a9952739387f70a431571011 > Reviewed-on: https://chromium-review.googlesource.com/c/1308013 > Commit-Queue: Charlie Harrison <csharrison@chromium.org> > Reviewed-by: Josh Karlin <jkarlin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603990} TBR=jkarlin@chromium.org,csharrison@chromium.org Change-Id: I44e487142ab5c3477ff77945a3f2854bb9762056 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/1308904Reviewed-by:
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/137d99c91fc7..fa0076282e62 $ git log 137d99c91..fa0076282 --date=short --no-merges --format='%ad %ae %s' 2018-10-29 johannkoenig vp8 bilinear: ensure non-16x16 arrays are aligned 2018-10-29 johann.koenig vp8 bilinear: ensure temp array is aligned 2018-10-24 sdeng Enable 10 bit tpl support 2018-10-26 johann.koenig remove "register" keyword 2018-10-26 jingning Remove unused macros from vp9_firstpass.c 2018-10-25 johann.koenig vp8 bilinear: rewrite 4x4 2018-10-24 johann.koenig vp8 bilinear: rewrite 16x16 2018-10-10 ritu.baldwa Add Memory to Enable Row Decode 2018-10-24 johann.koenig vp8 bilinear: rewrite in intrinsics 2018-10-23 jingning Enable tpl model to support multi-layer ARF 2018-10-23 chiyotsai Add AVX2 support for 4-tap interpolation filter. 2018-10-18 chiyotsai Clean up vpx_dsp/x86/convolve_sse2.h 2018-10-23 jingning Reset frame udpate flags after qp estimate in tpl 2018-10-23 yunqingwang Use 8-tap interp filter in temporal filtering 2018-10-22 jingning Bypass processing on use existing frame 2018-10-22 jingning Fix frame offset computation for GOP extension 2018-10-22 jingning Refactor gop_length use case in tpl model 2018-10-22 jingning Remove empty else branch in mode_estimation 2018-10-22 jingning Use the proper gfu_boost factor to compute rd_mult Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I372218619232822361042cff13e10ec162972e4d Reviewed-on: https://chromium-review.googlesource.com/c/1308985Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#604072}
-
Wez authored
- Add a CastRunner and main() under //webrunner/app/cast. - Add "castrunner" executable, package and runner targets to GN. This rudimentary Runner handles caller requests for cast:// URIs, extracts the application-Id from them, and if the Id matches a dummy Id for testing, then it instantiates a component hosting a standard web URL, for now. Bug: 893229 Change-Id: Ia2cb5d7c1f69ff0a828af9e5c71b7f4422ce58d3 Reviewed-on: https://chromium-review.googlesource.com/c/1303646 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#604071}
-
Evan Stade authored
- improve comments/bug links for some tests - enable some tests which pass locally for 30 runs without any failures Bug: none Change-Id: I4e7731d4f5a6c9e7a2dad2e6dd701af381195094 Reviewed-on: https://chromium-review.googlesource.com/c/1308596Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#604070}
-
Luciano Pacheco authored
Fix flakiness by adding call to this.expanded=true in EntryListItem. Change updateSubDirectories: - use arrow function and const; - change error callback calling style to match the same style used by success callback (without if). - change check from isFakeEntry to check for presence of the method that's used "createReader". Change the sorting to be an method, so it can be customized per sub-class, later it will be used to sort My files to show Linux and Play files at the bottom. Fix unittest that started failing because it metadataModel was null. No changes in behaviour for users, the small change in behaviour is EntryListItem.updateSubDirectories now reads its children using FS API which isn't synchronous. CrOS FilesApp UI Tests: ensure downloads selected and refreshed in setup TBR: joelhockey@chromium.org Bug: 899664 Change-Id: I8a93616f74cf3bf2b99851dc2452249e1353d85e Reviewed-on: https://chromium-review.googlesource.com/c/1306963Reviewed-by:
-
Evan Stade authored
No flakes in single or multi process mash over 30 local runs. Bug: 815379 Change-Id: I3d1a7c62ee4d431e8b092a625d641ff91b6b2730 Reviewed-on: https://chromium-review.googlesource.com/c/1308654Reviewed-by:
-
Josh Gao authored
Add support for ScopedGeneric traits that track the ownership of owned objects externally. The intent is to use this with Android Q's file descriptor ownership sanitizer, but this is conceivably useful for other purposes as well (e.g. guarded_fd on Darwin). TBR=wez@chromium.org,sergeyu@chromium.org,alexilin@chromium.org,vollick@chromium.org,dcastagna@chromium.org Bug: 882733 Change-Id: I2fb0617ce6471b290edcc726de4117041d91d10d Reviewed-on: https://chromium-review.googlesource.com/c/1224112 Commit-Queue: Josh Gao <jmgao@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
-
Zach Reizner authored
R=reveman@chromium.org Bug: 887036 Test: wayland client that uses INVERT_Y Change-Id: I9ac108165ac68911ab61b3340410e538f8a843db Reviewed-on: https://chromium-review.googlesource.com/c/1298739 Commit-Queue: Zach Reizner <zachr@chromium.org> Reviewed-by:
-
