GitLab

This CL moves the underline in the subpage search up by two px, to match
mocks (request by Alan).

BUG=638453
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2321733002
Cr-Commit-Position: refs/heads/master@{#417319}

Cr-Commit-Position: refs/heads/master@{#417318}

https://chromium.googlesource.com/skia.git/+log/da7136750d30..2b3c2a3ff916

$ git log da7136750..2b3c2a3ff --date=short --no-merges --format='%ad %ae %s'
2016-09-08 mtklein GN: add sanitize arg

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=caryclark@google.com

Review-Url: https://codereview.chromium.org/2323823002
Cr-Commit-Position: refs/heads/master@{#417317}

As the variable is now true (it's end state), it can be removed and
the corresponding legacy code.

BUG=637065

Review-Url: https://codereview.chromium.org/2316683002
Cr-Commit-Position: refs/heads/master@{#417316}

Responding to wez@'s comments in crrev.com/2281323002.

This change removes a BackoffEntry for a component extension if it has loaded and there has been no additional failures for that extension within 60s.

BUG=639104

Review-Url: https://codereview.chromium.org/2310463002
Cr-Commit-Position: refs/heads/master@{#417315}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/e5402e7..3d67882

$ git log e5402e7..3d67882 --date=short --no-merges --format=%ad %ae %s
2016-09-08 minyue@webrtc.org Separating video settings in VideoQualityTest.
2016-09-08 ehmaldonado@webrtc.org Add a DEPS gclient hook to prune corrupt mockito remote.
2016-09-08 solenberg@webrtc.org Revert of Don't use VoE legacy APIs in force_mic_volume_max tool. (patchset #5 id:80001 of https://codereview.webrtc.org/2268183007/ )
2016-09-08 henrika@webrtc.org Avoids crash in WebRtcAudioTrack.initPlayout (part II)
2016-09-08 solenberg@webrtc.org Don't use VoE legacy APIs in force_mic_volume_max tool.

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2323023002
Cr-Commit-Position: refs/heads/master@{#417314}

StartSandboxedProcess was missing a Release call, so this was always
leaking. Use scoped_refptr instead to fix that and prevent it from
happening in the future.
TBR=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2316333003
Cr-Commit-Position: refs/heads/master@{#417313}

BUG=637385

Review-Url: https://codereview.chromium.org/2306563002
Cr-Commit-Position: refs/heads/master@{#417312}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/0d5b7bd87099c2c5d5590c13116c6e3aa7d2c408 Canary new LogDog Butler on Infra. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:643243

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2324813002
Cr-Commit-Position: refs/heads/master@{#417311}

pressed and WebAPKs are enabled.

When user clicks A2HS from the app menu, a A2HS dialog shows to add
a shortcut. When WebAPK is enabled, an app banner info bar is expected
to show for WebAPK-compatible site.
This CL includes:
- AddToHomeScreenManager creates an app banner to install WebAPKs.
- Refactory in AppBannerInfobarDelegateAndroid that passes in a ShortcutInfo
  instead of Manifest file.
- When installing WebAPK from the app menu, the app banner skips the state of
  showing "Add to Homescrenn" on its button but jumps to "Adding" state and
  starts the installation.

UX review see https://docs.google.com/presentation/d/1QbHDigLFR1oucsnlXQ9f6AxQYYI6Ka0Gl0A_vWpFjSA/edit#slide=id.g1503c2082e_0_28.

Review-Url: https://codereview.chromium.org/2290603005
Cr-Commit-Position: refs/heads/master@{#417310}

The code was making a reference to an attribute of a temporary object created by gridTrackSize().

BUG=641982

Review-Url: https://codereview.chromium.org/2325603003
Cr-Commit-Position: refs/heads/master@{#417309}

TIL about file:// in OWNERS. Unifying mainteinance of
tracing OWNERS.

Review-Url: https://codereview.chromium.org/2283703002
Cr-Commit-Position: refs/heads/master@{#417308}

BUG=639095

Review-Url: https://codereview.chromium.org/2322683002
Cr-Commit-Position: refs/heads/master@{#417307}

TBR=zmo@chromium.org
BUG=chromium:483282
BUG=chromium:angleproject:1492
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2320133002
Cr-Commit-Position: refs/heads/master@{#417306}

This CL (hopefully) removes all calls to these methods in ios:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2314243002
Cr-Commit-Position: refs/heads/master@{#417305}

1.3.1 now contains three local fixes we applied:
* Do not reconfigure the cascade list on 10.9.5
* Do reconfigure the cascade list on 10.9.5 for the Emoji font
* Blacklist Padauk GDEF

BUG=645090
R=behdad,eae

Review-Url: https://codereview.chromium.org/2318273003
Cr-Commit-Position: refs/heads/master@{#417304}

BUG=639860

Review-Url: https://codereview.chromium.org/2321653002
Cr-Commit-Position: refs/heads/master@{#417303}

Using update-w3c-deps in Chromium c7eb73ac.

Review-Url: https://codereview.chromium.org/2308153002
Cr-Commit-Position: refs/heads/master@{#417302}

Compiling cronet requires particular flags and it is advised to use the
helper script components/cronet/tools/cr_cronet.py to prepare the build
so add a gn flag to control whether cronet is build on iOS.

Due to the specific flags, the compilation of cronet is sometimes broken
on the downstream iOS bots causing unnecessary churn as cronet is unused
by Chrome on iOS.

BUG=640686

Review-Url: https://codereview.chromium.org/2312963002
Cr-Commit-Position: refs/heads/master@{#417301}

This CL moves the reusable code out of
webViewLongPressElementForContextMenu and into
webviewRunActionOnElement.

BUG=None.

Review-Url: https://codereview.chromium.org/2321613002
Cr-Commit-Position: refs/heads/master@{#417300}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/06c3b44d..cbbb79d3

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2322973002
Cr-Commit-Position: refs/heads/master@{#417299}

We currently do not use the Math and Symbols category for font
selection, hence disabling it, since it was also breaking sequences of
dotted circle plus combining marks which are frequently used to explain
combining marks.

BUG=641937
R=eae,kojii

Review-Url: https://codereview.chromium.org/2321043002
Cr-Commit-Position: refs/heads/master@{#417298}

Implements BaseAudioContext as the base class of an AudioContext and
OfflineAudioContext, moving the relevant attributes and methods from
AudioContext to BaseAudioContext.

The changes in the expected results are mostly caused by exception
messages now saying BaseAudioContext instead of AudioContext.

BUG=555608
TEST=no new tests

Review-Url: https://codereview.chromium.org/1865583002
Cr-Commit-Position: refs/heads/master@{#417297}

https://chromium.googlesource.com/skia.git/+log/56cbb2343625..da7136750d30

$ git log 56cbb2343..da7136750 --date=short --no-merges --format='%ad %ae %s'
2016-09-08 mtklein Flesh out SkOpts namespaces.
2016-09-08 borenet Asset management: Download from GS store instead of CIPD
2016-09-08 mtklein GN: do not set default GN args
2016-09-08 rmistry Further increase run_benchmark timeout
2016-09-08 msarett Add color xform support to SkWebpCodec

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=caryclark@google.com

Review-Url: https://codereview.chromium.org/2315353003
Cr-Commit-Position: refs/heads/master@{#417296}

BUG=644970

Review-Url: https://codereview.chromium.org/2320903002
Cr-Commit-Position: refs/heads/master@{#417295}

BUG=634350

Review-Url: https://codereview.chromium.org/2313373003
Cr-Commit-Position: refs/heads/master@{#417294}

This patches introduces the logic that computes Collapsing Margins for the
following pairs:
- top margin of a box and top margin of its first in-flow child
- bottom margin of box and top margin of its next in-flow following sibling

This implementation doesn't take into account any Margins Collapsing style exceptions, e.g. padding, borders etc.

Design document: https://docs.google.com/document/d/1uxbDh4uONFQOiGuiumlJBLGgO4KDWB8ZEkp7Rd47fw4/edit#bookmark=id.gk14n6z7jt8a

BUG=635619

Review-Url: https://codereview.chromium.org/2313873002
Cr-Commit-Position: refs/heads/master@{#417293}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/78bd90705b85ed14b345d002a4103a90c5e516fa V8: Adjust shards and timeouts to current needs. (machenbach@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2323783002
Cr-Commit-Position: refs/heads/master@{#417292}

This moves NewTabPageItem further away from being a generic base class for holding the data shown in the RecyclerView, and will allow pushing the responsibility to update the view into the merged item/group interface.

BUG=616090

Review-Url: https://codereview.chromium.org/2320573002
Cr-Commit-Position: refs/heads/master@{#417291}

The variable supressed an unnecessary re-collection of inspector
stylesheets when the stylesheet text is modified from the inspector. If
the text added contains an @import rule with a data: uri, it also
suppresses the collection of that sheet, which is wrong.

R=pfeldman@chromium.org,lushnikov@chromium.org
BUG=644719

Review-Url: https://codereview.chromium.org/2319533004
Cr-Commit-Position: refs/heads/master@{#417290}

BUG=633613

patch from issue 2276383002 at patchset 40001 (http://crrev.com/2276383002#ps40001)

Review-Url: https://codereview.chromium.org/2325473003
Cr-Commit-Position: refs/heads/master@{#417289}

At present many (all?) consumers of
RenderWidgetHostViewBase::GetNativeView() assume it always returns non-
null, but this may not be a safe assumption if the view is a
RenderWidgetHostViewChildFrame. This CL temporarily fixes a crash when
ChromeOS hits this case, while we review the behaviour of the consumers
of this function, and while we review the implementation in
RenderWidgetHostViewChildFrame.

BUG=644294, 644726

Review-Url: https://codereview.chromium.org/2322513002
Cr-Commit-Position: refs/heads/master@{#417288}

The test components/update_client/crx_downloader_unittest.cc depends
on net::LocalHostTestURLRequestInterceptor class that is not compiled
when disable_file_support is set to true.

Add a new file src/net/features.gni to allow conditional compilation
based on that flag from outside of //net.

BUG=640686

Review-Url: https://codereview.chromium.org/2318343003
Cr-Commit-Position: refs/heads/master@{#417287}

As for AutofillAgent, Password{Autofill,Generation}Agent, their destructions
are asynchronous with destructions of corresponding render frame.
Thus, even after corresponding render frame has been deleted, they can still
keep alive for some while and still able to receive mojo messages which maybe
lead to use-after-delete access on the render frame.

To solve above problem, this CL closes the mojo interface bindings immediatelly
when render frame got destroyed.

BUG=641156

Review-Url: https://codereview.chromium.org/2320993002
Cr-Commit-Position: refs/heads/master@{#417286}

This patch fixes the following warnings emitted by
buildtools/checkdeps/checkdeps.py by renaming the tests with duplicate
names:

WARNING: multiple definitions of org.chromium.chrome.browser.crash.LogcatExtractionCallableTest:
    chrome/android/junit/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableTest.java
    chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableTest.java

WARNING: multiple definitions of org.chromium.chrome.browser.payments.CurrencyStringFormatterTest:
    chrome/android/junit/src/org/chromium/chrome/browser/payments/CurrencyStringFormatterTest.java
    chrome/android/javatests/src/org/chromium/chrome/browser/payments/CurrencyStringFormatterTest.java

WARNING: multiple definitions of org.chromium.chrome.browser.notifications.NotificationPlatformBridgeTest:
    chrome/android/junit/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeTest.java
    chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeTest.java

WARNING: multiple definitions of org.chromium.chrome.browser.offlinepages.OfflinePageBridgeTest:
    chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
    chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java

WARNING: multiple definitions of org.chromium.chrome.browser.offlinepages.OfflinePageUtilsTest:
    chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java
    chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java

BUG=none

Review-Url: https://codereview.chromium.org/2314423004
Cr-Commit-Position: refs/heads/master@{#417285}

Reland of Allow canvases to be GPU-accelerated in Workers (patchset #1 id:1 of https://codereview.chromium.org/2323573002/ )

Reason for revert:
The failure that was the reason for the original revert is still happening, so this change was not the cause.  Reverting the revert...

Original issue's description:
> Revert of Allow canvases to be GPU-accelerated in Workers (patchset #5 id:80001 of https://codereview.chromium.org/2300633004/ )
>
> Reason for revert:
> This makes the following tests fail on Linux MSAN bot:
>
> virtual/gpu/fast/canvas/canvas-createImageBitmap-invalid-blob-in-workers.html
> virtual/display_list_2d_canvas/fast/canvas/canvas-createImageBitmap-invalid-blob-in-workers.html
>
> Build link:
> https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/12091
>
> Original issue's description:
> > Allow canvases to be GPU-accelerated in Workers
> >
> > This change sets up a per-thread shared GPU context that is managed by
> > a thread-specific singleton SharedGpuContext.  This means that all 2D
> > contexts on a given worker will use the same context, which avoids
> > having to rely on mailboxes all the time.  Also this CL makes deep changes
> > to AcceleratedStaticBitmapImage in order to support the use of
> > the current thread's shared context, and it handles transfers
> > between threads in order to support the transferrable behavior of
> > ImageBitmap objects.
> >
> > BUG=593514
> >
> > Committed: https://crrev.com/83ac5ff37da4ea1c6d052649ccea46dd4bd453d6
> > Cr-Commit-Position: refs/heads/master@{#416929}
>
> TBR=kbr@chromium.org,haraken@chromium.org,junov@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=593514
>
> Committed: https://crrev.com/5235c5b0662c2553b0c10ebece983c04d00ebed6
> Cr-Commit-Position: refs/heads/master@{#417127}

TBR=kbr@chromium.org,haraken@chromium.org,lushnikov@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=593514

Review-Url: https://codereview.chromium.org/2321063002
Cr-Commit-Position: refs/heads/master@{#417284}

Update code in device/bluetooth to use JavaRef when calling Java methods
via JNI, instead of passing bare jobject. Various function parameter
types are converted from jobject to JavaRef to enable calls to obj()
higher up the call chain to be removed.

BUG=506850

Review-Url: https://codereview.chromium.org/2313413002
Cr-Commit-Position: refs/heads/master@{#417283}

https://codereview.chromium.org/2280053002 adds the possibility to
filter for only SFNT fonts in Skia on Linux, avoiding Type 1 font
files, conditional on the define
SK_FONT_CONFIG_INTERFACE_ONLY_ALLOW_SFNT_FONTS.

This CL activates the filter in Chrome by defining this value.

BUG=632142

Review-Url: https://codereview.chromium.org/2288093002
Cr-Commit-Position: refs/heads/master@{#417282}

BUG=404831

Review-Url: https://codereview.chromium.org/2321023002
Cr-Commit-Position: refs/heads/master@{#417281}

BUG=361036

Review-Url: https://codereview.chromium.org/2316113003
Cr-Commit-Position: refs/heads/master@{#417280}