GitLab

Major changes.
- Add animation on laading
- Add a spinner on loading
- Handle failure of widget loading
- Refine the internal states of SuggestAppDialog

BUG=240152
TEST=manual
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/23717007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220553 0039d316-1c4b-4281-b951-d872f2087c98

Moves initialization part for SyncFileSystemService from SyncFileSystem's API
handling layer (sync_file_system_api.{cc,h}) to SyncFileSystemBackend so that
non-chrome API can start SyncFileSystemService.

This is a preparation patch for supporting window.resolveLocalFileSystemURL()
on SyncFileSystem. See the bug issue for more details.


BUG=177137
TEST=unit_tests
TEST=browser_tests --gtest_filter=SyncFileSystemApiTest.*

Review URL: https://chromiumcodereview.appspot.com/22810002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220552 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a background page to the good2.crx extension used in tests.
This is part of CL 23427003 but had to be committed separately because the
CQ cannot handle binary file changes.

BUG=175701
TEST=None

TBR=kalman

Review URL: https://codereview.chromium.org/23482005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220551 0039d316-1c4b-4281-b951-d872f2087c98

Chrome uses OPUS by default hence it makes sense to force ISAC instead.

BUG=279101
NOTRY=TRUE
TEST=Manual test verifying that iSAC is used instead of OPUS in chrome://webrtc-internals and that the sound is played back OK.

Review URL: https://chromiumcodereview.appspot.com/23460010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220550 0039d316-1c4b-4281-b951-d872f2087c98

If the DevTools window is invoked in-tab, the task manager refused to add it to the list of displayed processes, because there was no tab owning this WebContent. This CL improves the check in FindBrowserWithWebContents to recognise the DevTool's WebContent as valid in this case. To avoid crashing in TabContentsResource::GetIcon(), a FaviconTabHelper::CreateForWebContents() call had to be added.

BUG=237841

Review URL: https://chromiumcodereview.appspot.com/23576007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220549 0039d316-1c4b-4281-b951-d872f2087c98

Remove chromeos/dbus dependency from CandidateWindowController.

BUG=280438

Review URL: https://chromiumcodereview.appspot.com/23680003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220548 0039d316-1c4b-4281-b951-d872f2087c98

The operation is mapped to "Files: trash" on Drive API v2.
To adapt the API more, renames and changes the style.

BUG=277253
TEST=Ran unit_tests and tested manually.

Review URL: https://chromiumcodereview.appspot.com/23514007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220545 0039d316-1c4b-4281-b951-d872f2087c98

These are passed to run_test_cases.py

R=maruel@chromium.org

Review URL: https://codereview.chromium.org/22734004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220544 0039d316-1c4b-4281-b951-d872f2087c98

Now remove the flag and make this settings default.

BUG=243235
TEST=browser_tests --gtest_filter=TranslateManagerBrowserTest.*

Review URL: https://chromiumcodereview.appspot.com/23708004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220543 0039d316-1c4b-4281-b951-d872f2087c98

This just tests the success of the call to window.print(). It does not
test whether the call leads to a print preview window and ultimately to
a printout. It will be extended over time to provide additional coverage
of the print functionality.

BUG=NONE

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220467

Review URL: https://chromiumcodereview.appspot.com/23054002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220542 0039d316-1c4b-4281-b951-d872f2087c98

We were enabling native accessibility if any accessibility service was
running, but many Android users have accessibility services other than
screen readers. Now we only enable native accessibility if
getAccessibilityNodeProvider is called on the web content.
Many popular Android apps that happen to be accessibility services will
no longer trigger Chrome's accessibility mode.

BUG=280717

Review URL: https://chromiumcodereview.appspot.com/23750002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220541 0039d316-1c4b-4281-b951-d872f2087c98

When an app window is focused, a new menu item is created for that app 
and appended to the main menu. All of Chrome's menu items are hidden. 
When a Chrome window is focused, the app's menu item is removed and 
Chrome's menu items are unhidden.

This is a second attempt at https://codereview.chromium.org/18089012/
which had to be reverted because it broke keyboard shortcuts.

This moves all packaged app menu item handling into a new AppShimMenuController.

BUG=168080, 276052
Focus the app window, the only item in the main menu bar should be that app. 
Focus a browser window, the main menu bar returns to normal.

Review URL: https://chromiumcodereview.appspot.com/22867009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220540 0039d316-1c4b-4281-b951-d872f2087c98

This is required to let the auto-generated codes by scheme compiler refer the
API functions.

BUG=253358
TEST=file_manager_browsertests
R=hashimoto@chromium.org, satorux@chromium.org

Review URL: https://codereview.chromium.org/23715003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220539 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=True 
BUG=264859
TEST= 
1) Uninstall Google Chrome (if it's installed.)
2) Put mini_installer.exe for Google Chrome in the same folder as test_installer.py.
3) Run "python test_installer.py config\config.config". The test should pass.
4) Uninstall Chromium (if it's installed.)
5) Put mini_installer.exe for Chromium in the same folder as test_installer.py.
6) Run "python test_installer.py config\config.config". The test should pass.

Review URL: https://chromiumcodereview.appspot.com/23757002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220538 0039d316-1c4b-4281-b951-d872f2087c98

I also changed the signature of ui::ThemeProvider::GetDisplayProperty() because most of the callers were ignoring the return value. In some cases we were using uninitialized variables because of this.

BUG=279978
TEST=Manual, see bug
R=erg
TBR=sky (For trivial refactor)

Review URL: https://chromiumcodereview.appspot.com/23614007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220537 0039d316-1c4b-4281-b951-d872f2087c98

When scrolling by page, we just need to set scrollByPage to true.
Multiplying the scroll_delta by pixelsPerLine results in scrolling
much too far.

BUG=279035
TEST=manually tested following steps on the bug

Review URL: https://chromiumcodereview.appspot.com/23532015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220536 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/23441015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220535 0039d316-1c4b-4281-b951-d872f2087c98

R=joi@chromium.org, sievers@chromium.org, skyostil@chromium.org, vsevik@chromium.org

Review URL: https://codereview.chromium.org/23706005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220534 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TESTED=Open NTP, run chrome.embeddedSearch.searchBox.focus() in the DOM inspector.

Review URL: https://chromiumcodereview.appspot.com/23462014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220531 0039d316-1c4b-4281-b951-d872f2087c98

This is in preparation of reworking the default task selection logic.
This function will be needed from a place where FileBrowserHandler
pointers are not present.

BUG=282109
TEST=none
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/23455020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220530 0039d316-1c4b-4281-b951-d872f2087c98

BUG=275270
TEST=unit_tests
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/23565004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220529 0039d316-1c4b-4281-b951-d872f2087c98

Rename ResourceMetadata::GetChildResourceId to GetChildId

BUG=275270
TEST=unit_tests
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/23571006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220528 0039d316-1c4b-4281-b951-d872f2087c98

BUG=282116
TBR=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/23815002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220527 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220526 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220525 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=156937:156939&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/23553005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220524 0039d316-1c4b-4281-b951-d872f2087c98

This is likely a regression caused by r219217. Previously, hosted documents were
opened with fileBrowserPrivate.viewFiles(), but r219217 replaced viewFiles() with
executeTask(). The logic in executeTask() didn't handle the case where there were
no active browser windows correctly.

BUG=280936
TEST=see the bug
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/23463007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220522 0039d316-1c4b-4281-b951-d872f2087c98

The operation is mapped to "Files: insert" on Drive API v2.
To adapt the API more, renamed and changed the style.
Note that the request may be reused for simple/multipart file uploading.

BUG=277253
TEST=Ran unit_tests and tested manually.
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/23575004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220521 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a layering violation where content::RenderViewHost was forward declared in media code. It also lets content code use BrowserMediaPlayerManager directly without resorting to casting.

BUG=263652

Review URL: https://chromiumcodereview.appspot.com/23735002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220520 0039d316-1c4b-4281-b951-d872f2087c98

R=reveman@chromium.org
BUG=281795

Review URL: https://chromiumcodereview.appspot.com/23726006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220519 0039d316-1c4b-4281-b951-d872f2087c98

Switched PostTaskAndReplyRelay to use ThreadTaskRunnerHandle::Get() instead of MessageLoopProxy::current().

This allows PostTaskAndReplyRelay to be used with non-standard implementations of TaskRunner interface. One such example is remoting::PluginThreadTaskRunner that allows to posts tasks to the main thread of Chromoting Host plugin.

BUG=281750

Review URL: https://chromiumcodereview.appspot.com/23642004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220518 0039d316-1c4b-4281-b951-d872f2087c98

Suggest app dialog have to support 'newwindow' event from the CWS widget, as well as share dialog.

BUG=none
TEST=manual
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/23737005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220517 0039d316-1c4b-4281-b951-d872f2087c98

All shourtcuts target to drive. So they should not be available when the drive is disabled.

BUG=280152
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/23565003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220516 0039d316-1c4b-4281-b951-d872f2087c98

Currently the ThreadProxy recursively asks all layers in the tree if
they should block the commit. This is problematic as when you remove
a layer from a the tree, it may want to block the commit to get back
resources from its active-tree impl-layer.

Instead, have layers call SetNextCommitWaitsForActivation() when they
want the next commit to block on activate. This way we only block
commits that matter, not every commit when there's a texture layer
present. And we can allow a layer to block the commit when it is
leaving the tree.

Tests:
TextureLayerNoMailboxIsActivatedDuringCommit
TextureLayerMailboxIsActivatedDuringCommit
DelegatedFrameIsActivatedDuringCommit

R=enne, piman
BUG=277953

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220418

Review URL: https://chromiumcodereview.appspot.com/23530003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220515 0039d316-1c4b-4281-b951-d872f2087c98

Changes:
- Change the height of the title to 44px.
- Set the widget container as same size as the widget.
- Add gray borders at the top and bottom of the widget container.
- Fix the padding of the "See more.." text on the bottom.

BUG=240152
TEST=test manually

Review URL: https://chromiumcodereview.appspot.com/23484006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220514 0039d316-1c4b-4281-b951-d872f2087c98

Generating JSON values inside Find* functions is uncool
and makes it hard to write tests.

BUG=269929
TEST=Files can be opened with Files.app as before
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/23532010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220513 0039d316-1c4b-4281-b951-d872f2087c98

Support for the FTS databases was removed in July (r213442).  Mark the
Sqlite.Text.* histograms obsolete, and add new
History.DeleteFTSIndexDatabases tracking deletions.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/23782002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220512 0039d316-1c4b-4281-b951-d872f2087c98

Chrome runs in TSF mode at Windows8 metro.
We use COM interface ITextStoreACP::RetrieveRequestedAttrs to tell InputScope to IME in the mode.
TSFTextStore, which implements ITextStoreACP, knows target inputmode through TextInputClient::GetTextInputMode and get InputScope using tsf_inputscope::CreateInputScope appending to text input type.
RenderWidgetHostViewWin implements TextInputClient::GetTextInputMode.

BUG=244688
TEST=Run "chrome --enable-text-services-framework --enable-input-mode-attribute" at windows8 desktop and tests manually using hardware keyboard and onscreen keyboard. Both MS-IME and GoogleJapaneseInput works with hardware keyboard. Unfortunately, onscreen keyboard with MS-IME doesn't work but with GoogleJapaneseIME works. But there might be some issue in onscreen keyboard with MS-IME.

Review URL: https://chromiumcodereview.appspot.com/23542003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220511 0039d316-1c4b-4281-b951-d872f2087c98

BUG=280727

Review URL: https://chromiumcodereview.appspot.com/23534027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220510 0039d316-1c4b-4281-b951-d872f2087c98

This is a part of refactoring to replace all use of gfx::Font with gfx::FontList.  Also this replacement solves a possible vertical alignment issue of text rendering.

See "Background & Problem" section in the following doc why this refactoring is needed.
https://docs.google.com/a/chromium.org/document/d/1D_25fp9B8b9aZJORfAjDIFq61NWvUquZ5xmKH-VcC4k/edit#heading=h.olbd4u4vk3h6

NOTE:
a) Existing Font::GetStringWidth() is now obsolete and should be replaced by gfx::GetStringWidth() in ui/gfx/text_utils.h .
b) 'const' has internal linkage so it doesn't require anonymous namespace (in ui/views/widget/tooltip_manager.cc).

BUG=265485
TEST=Run unittests.

Review URL: https://chromiumcodereview.appspot.com/23483015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220509 0039d316-1c4b-4281-b951-d872f2087c98