- 04 Dec, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I041e17bba9e870e3042c00ad3178265ae138e79b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573627Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833608}
-
Kyle Horimoto authored
Change-Id: I2b7df8f0f529a8d5a7108db90ab49330cc3ad469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573392 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#833607}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5d919472c98c..63989d27ead7 2020-12-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If261af5e93b0a409239da0c8f41d07d8e63325b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572710Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0d2de6f05c54..1ad5791d97be 2020-12-04 ianelliott@google.com Revert "Vulkan: Use specialization constant for halfRenderAreaWidth" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: If342c179844716779ca0653308a65d9edadfe048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573635Reviewed-by:
-
Jérémie Boulic authored
When clicking the 'Delete' icon, a confirmation dialog is shown. Once closed, the dialog restores the focus to the previously active element. In the case of the 'Delete' button, it results in the tooltip showing again after a certain timeout. This change hides the 'Delete' button tooltip after the dialog is closed. The `hideTooltip` function is extended to cancel any potential timeout that has been initiated to show the tooltip. Bug: 1082019 test: browser_tests --gtest_filter=*filesTooltipHidesOnDeleteDialogClosed Change-Id: I4956174df6ad46c2a356cdb8b3985714ed3ff2de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483732 Auto-Submit: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#833604}
-
Esmael El-Moslimany authored
Bug: 1123905 Change-Id: Icd32d8adb20cb5e8ce16093b50c429ba25758ee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573338 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#833603}
-
Clark DuVall authored
I forgot to add split_name to this generate_jni call. Bug: 1155277 Change-Id: I06d56ad42ffbc6afda34e64ee8f6037933f7b3ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573160 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#833602}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I606e12df9cf0082cc9dec33e8d26cd4423b2a25d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572731Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833601}
-
Luciano Pacheco authored
Bug: 1102263 Change-Id: I43c12160d9e70959e36a071dea95fe8c2f600ee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571033 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#833600}
-
Nicholas Hollingum authored
This item is shown for the borealis app icon and currently uses pluginvm's strings until borealis ones can be approved. Bug: b/172006764 Change-Id: I9036b1e555d8848d7082e753f3c6ce576f508f4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570475Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#833599}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607007593-3407e023275e887982890e083190cec03a46fa25.profdata to chrome-win64-master-1607018334-2342e7b4fc523afed7119425e6663fe86ee0646f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I878f974c542c1a39b67acfbd8c23ba4d6c4f5661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572645Reviewed-by:
-
Lan Wei authored
Use testdriver Action API to simulate mouse and touch actions in pointerevents/pointerevent_fractional_coordinates.html. Bug: 1145677 Change-Id: I8ec66844c7662a88b9e7cb3d792778e9b6df6f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568605 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#833597}
-
David Reveman authored
This is causing more memory to be used in some cases because of this skia bug: https://bugs.chromium.org/p/skia/issues/detail?id=11038 48MB is enough to avoid that problem. Bug: 1155326 Change-Id: Ife884162d29ca4f1a46caaeb9aa0188c3fe44eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573156Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#833596}
-
Amanda Deacon authored
Tests: unit tests Bug: 1098112 Change-Id: Ia17ebf3407b4f9429b6b2ab006210b38a0d7fab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570878Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Amanda Deacon <amandadeacon@chromium.org> Cr-Commit-Position: refs/heads/master@{#833595}
-
Hirokazu Honda authored
Existing hardware decoders support only YUV 4:2:0 videos. We currently rely the underlying libraries and drivers to deny non YUV 4:2:0 videos. We would rater confirm it in AcceleratedVideoDecoder. From this CL, AcceleratedVideoDecoder::Decode() returns kDecodeError if a video is not YUV 4:2:0. Bug: b:172223934 Test: media_unittests Change-Id: Ib0ddbe526a801476e382f0b7665a74573bd6a28d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562618 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#833594}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b2c18f2f62b9..968b1fe7d7cb 2020-12-04 ehmaldonado@google.com [git-cl] Use owners client when processing --[tb]r-owners. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Id5703ca04743442ec4e9d3eb444712499acddb6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573632Reviewed-by:
-
Sebastien Marchand authored
Bug: 1155316 Change-Id: I70e84f9445edae16c4fcab6d03b33a8f958ba842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572888Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#833592}
-
Clark DuVall authored
For now the chrome module's manifest is merged into the base manifest to match the expectations files we have. If the chrome module launches, we may want to have more checks on what gets put in the base manifest vs. the chrome manifest. Bug: 1151529 Change-Id: I786175aec33cf5f454a416d3f51e9dd069dbac82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572792Reviewed-by:
-
Mohsen Izadi authored
Mouse-dragged events are interesting for two reasons: - Some of mouse-dragged events are interesting themselves, for example when they are used to select text; - Some of mouse-dragged events end up generating other interesting events. For example, dragging a scrollbar thumb in a page generates mouse-dragged events that end up generating gesture-scroll-update events. For these cases, we need to create EventMetrics objects for the original mouse-dragged events in order to have accurate event timestamps for reporting generated events. Addition to UKM is approved in: https://docs.google.com/document/d/1SDxdua997Gm7ihJFVjinHz9qTdBzTJrEzC7GEeQHs-8/edit?usp=sharing Bug: 1138918 Change-Id: Id4231d528fce64184273f6580a3895e1c1d96a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567631Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#833590}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1afb97a3..8abf9fa0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I74436fbdcd2aec16a8cfb698d533113e080b4fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572903Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833589}
-
Jeremie Boulic authored
This reverts commit 9d2bdda8. Reason for revert: Unwanted code submitted with this change. Original change's description: > [Files app] Generate modules for ui/file_manager/.../metadata_proxy.js > > Converted files: > - ui/file_manager/file_manager/background/js/metadata_proxy.js > - ui/file_manager/file_manager/background/js/metadata_proxy_unittest.js > > Bug: 1133186 > Change-Id: I81eb9d34fff12835ef5974acfee3817fec864340 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563105 > Commit-Queue: Jeremie Boulic <jboulic@chromium.org> > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833130} TBR=lucmult@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,jboulic@chromium.org Change-Id: I6a9840ebfbcd1643ae57ac0ecb0f30ee2dc54d3d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1133186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573698Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#833588}
-
Weblayer Skew Tests Version Updates authored
Skew tests are being added for the following versions: 1, 88.0.4324.29 2, 86.0.4240.99 3, 87.0.4280.86 R=rmhasan@google.com Bug: 1041619 Change-Id: Iaee1425137735a9ed834a4e78fc26dba0ce5a64d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573067 Commit-Queue: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#833587}
-
Nicholas Hollingum authored
This will be used by other parts of the codebase to initiate vm shutdown from the UI. Relatedly, we add a method to the ContextManager to query whether a shutdown is necessary (i.e. because we don't want to show various UI elements if it isn't). Bug: b/172006764 Change-Id: Ie9f2fee8995ee2b02bd1fec53ffce3cf1a0171a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569000 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#833586}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I459a40ff2458cc93d989936d65b3010b97456670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573625Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607018334-f670cab7a0d67beb5d9952b6762b75fa44bc4bec.profdata to chrome-linux-master-1607039886-9857a5090b09116b4b309953eec41db8862dfe90.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If6cf82defefd7de28544f3c4ce81a276073f63ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573631Reviewed-by:
-
Hiroki Nakagawa authored
This CL avoids starting navigation for prerendering when it already started for the same URL. To do that, this moves PrerenderHost::StartNavigation() call into PrerenderHostRegistry::RegisterHost(). This doesn't change behavior around networking. Even before this change, the duplicate navigation didn't issue a network request because PrerenderHost was destroyed right after PrerenderHost::StartNavigation() was called. The browser tests make sure this behavior. In addition to that, this change renames RegisterHost() to CreateAndStartHost() and then moves the PrerenderHost creation into the function for code cleanup. Bug: 1132746 Change-Id: Ibc1d51921d845c2746a1a0caca27e08e77256699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567514Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#833583}
-
Mitsuru Oshima authored
Which does not return false positive unlike might_have_observers(). Mark might_have_observers deprecated. I'll migrate the callers in a seperate CL. Bug: 1155308 Test: updated existing unit tests. Change-Id: I3dcab10c64ac3e6a3a0aacbb68844ef09ab9bef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572885Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#833582}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/238470adc0e5..7c97e90b17a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ksakamoto@google.com,tbergquist@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1111514,chromium:1131897 Tbr: ksakamoto@google.com,tbergquist@google.com Change-Id: I86cebb70e15f9f7600113be17ff84eb9771a9edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573617Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833581}
-
Changwan Ryu authored
I'm transferring to a new team and will no longer work on WebView/Chrome. ctzsm@ will step up to own IME for the content component. Also removing tobiasjs@ who no longer works on webview/chrome. TBR=yosin@chromium.org Bug: N/A Change-Id: Iad9ce8ce25d58569189830e1d64b9a5a7a8f4efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570394Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#833580}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607018334-4ec258faf10b8c54ec4574a66b7b864fdc99dca8.profdata to chrome-mac-master-1607039886-1ddd5c45cae9e9c7a03307d574bbe9f5985fa593.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib09f6471da37519f16f9b9e32aad05416d02dfd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573629Reviewed-by:
-
Hiroshige Hayashizaki authored
Follow-up of https://chromium-review.googlesource.com/c/chromium/src/+/2541362 that introduced ExecutionContext::GetV8CacheOptions(). This CL doesn't change the behavior. Bug: 1111134 Change-Id: I0b11b7f43b4d8b5574bb94b1aabd8d7e590cb475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556386 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#833578}
-
Alexander Dunaev authored
To short-cut round trips to the X server when drag and drop happens between two Chromium windows, XDragContext stored the raw pointer to XDragDropClient of the source window in its source_client_ attribute. This made possible to access the deleted object (use after free) if the source window had been destroyed during the operation. In short, although the target context can call the source client directly via the shortcut, the PropertyNotify event comes from the X server (not using the shortcut), and apparently it can come to the target context after the source window and its client had been destroyed but before the target context is notified. See the issue for full details. Here the XDragContext::source_client_ is removed, and all its uses are replaced with getting the client from the global map of clients [1]. The client removes itself from the map upon destruction [2] so this change eliminates the vulnerability. For the record, there is the test in the interactive_ui_tests suite (namely BookmarkBarViewTest22.CloseSourceBrowserDuringDrag) that should emulate this situation but is has some flaws [3]. [1] https://source.chromium.org/chromium/chromium/src/+/master:ui/base/x/x11_drag_drop_client.cc;l=120 [2] https://source.chromium.org/chromium/chromium/src/+/master:ui/base/x/x11_drag_drop_client.cc;l=200 [3] https://crbug.com/1106379 Bug: 1153595 Change-Id: Ibb875cb4fa04ddfa8f99b39e4dab654048da86c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567229Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#833577}
-
Moe Ahmadi authored
This is in preparation to promote the canary experiment which originally landed in cl/339288320 to Beta. Fixed: 1155314 Change-Id: I4b87b89736e4cb461d416aacef98ed888596568c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573130 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#833576}
-
Moe Ahmadi authored
Fixed: 1150983 Change-Id: I3be6ad5f6a0e2e8bfbca2f7cb67d8a0e532799d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572239 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
-
Nina Satragno authored
When trying to use a security key with the forcePINChange flag on, display an informative message telling the user they need to set a new PIN before using it. UXW review: go/force-pin-change-ux Bug: 1143427 Change-Id: I69812293b3db42599d5e350974510b15409cddf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562878 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#833574}
-
Luciano Pacheco authored
For our unittests Polymer wasn't working, this CL changes it by: 1. Always adding the HTML import polyfil. 2. Always importing the the Polymer config at the top, so any test using Polymer elements work. 3. If there is any dependency in the Files app Polymer elements (files inside //ui/file_manager/file_manager/foreground/elements/) it uses the elements_bundle.html instead of individual JS files. When I activated Polymer and imported the elements_bundle.html some tests started failing because they require the chrome.fileManagerPrivate mock. FileTransferController test uses ListContainer that requires the <files-spinner>. Also add the closing tag </cr-input> so the adjacent <input> remains outside the <cr-input> allowing the focus to flow properly as the test setting the focus on #test-input started failing once <cr-input> Polymer became fully functional. NOTE: This fix is only relevant for non-JS module unittest, we're migrating unittest to JS module and this problem doesn't happen when using the built-in JS import. Bug: 1102263 Change-Id: I2ea80bbe93afca2521bfa5ab9fcd6c32fcf8ecc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573696 Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
This is a reland of 5a3ffeb6 Original change's description: > media/gpu/video_encode_accelerator_tests: Validates each temporal layer stream > > The test originally validates the entire bitstream. This CL > enables the test to validate each temporal layer stream. For > instance, when --num_temporal_layers=3, the test validates three > streams, TL0, TL0+TL1 and TL0+TL1+TL2. > BitstreamFileWriter and VideoFrameFileWriter ignore bitstreams > and frames in upper layers than to be processed by them. > VideoFrameFileWriter also writes a file with a different prefix > from other VideoFrameFileWriter, so that multiple instances don't > write to the same file names. > > Bug: b:174318867 > Test: video_encode_accelerator_tests --codec=vp9 --num_temporal_layers=3 w/o output_bitstream --output_images=all > Change-Id: Idf2a1e4d2a50e11ca359435ec4495a43b61139f9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562801 > Reviewed-by: David Staessens <dstaessens@chromium.org> > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833103} Bug: b:174318867 Change-Id: Ifd87576869aebab313933afa7c7c0f202b152e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570476 Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#833572}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/38f2fff09dac..5d919472c98c 2020-12-04 jegarc@microsoft.com This CL adds an accessible name to boolean columns that are checked in a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1152607 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1519ae9f643a1623de6cb2b3c15afdd4ec6395ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573616Reviewed-by:
-
Yicheng Li authored
Since u2f credentials are not handled properly on ChromeOS, we decided to disable platform authenticator when U2F is enabled. This is done by making ChromeOS Authenticator return IsUvpaa=false when U2F is enabled. Thus ChromeOS platform authenticator and u2fhid are mutually exclusive for WebAuthn. Bug: 1155335, b/174709984 TEST=Enable U2F and enable ChromeOS WebAuthn feature flag, register PIN, ==> PublicKeyCredential .isUserVerifyingPlatformAuthenticatorAvailable() .then(console.log) returns false even if PIN is available. ==> When attachment=undefined or cross-platform, can use u2fhid to do WebAuthn MakeCredential and GetAssertion. ==> When attachment=platform, "Your device doesn't support the type of security key requested by this site". TEST=Disable U2F and enable ChromeOS WebAuthn feature flag, register PIN, => PublicKeyCredential .isUserVerifyingPlatformAuthenticatorAvailable() .then(console.log) returns true. => When attachment=undefined or cross-platform, u2fhid doesn't show up. => When attachment=platform, can use ChromeOS PIN to do MakeCredential and GetAssertion. Change-Id: I4ce5c9de4aecaa5c1569101065a1278576c9d0cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572130 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by: -
Michael Crouse authored
Implement the service that will handle loading TFLite models needed for the translate service in Chrome. Bug: 1151404 Change-Id: Ibcf242d7d4d54e032fd980fd244247bc1196fc69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553526Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#833569}
-
