- 03 Sep, 2018 40 commits
-
-
Mike West authored
Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/35t5cJQ3J_Q/FH45dl0vAwAJ Bug: 794548, 879994 Change-Id: Ie87aedd0027921960ff429d5d8ecf168572c82de Reviewed-on: https://chromium-review.googlesource.com/1199068 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#588364}
-
jdoerrie authored
TBR=yosin@chromium.org Bug: 698165 Change-Id: Id60c22d2729cedf72297700bb2a82d45f3b48029 Reviewed-on: https://chromium-review.googlesource.com/1201852 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#588363}
-
Mythri Alle authored
Earlier, the cached code was fetch along with the HttpResonse. With IsolatedCodeCache feature, the code cache is decoupled from HttpCache and cached code has to be fetched explicitly. This cl changes ResourceLoader to also request for cached code. ResourceLoader would wait for response both from HttpCache and CodeCache before it send response data to the resource. Bug: chromium:812168 Change-Id: I845e867fa452f270b787bedfd70105bda254ffdc Reviewed-on: https://chromium-review.googlesource.com/1154980 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#588362}
-
Rayan Kanso authored
Bug: 863939 Change-Id: I54735be657f2b8841de09c0e67738cd1ded1bcf7 Reviewed-on: https://chromium-review.googlesource.com/1194077Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#588361}
-
Yoichi Osato authored
We have TraversalInclusiveAncestorsIterator and TraversalAncestorsIterator for NodeTraversal and FlatTreeTraversal. However only difference between them is if it starts from node or its parent. It doesn't relate how traverse. Therefore, |TraversalInclusiveAncestorsIterator(node) === TraversalAncestorsIterator(parent(node))|. Then this patch unifies them. Change-Id: I7c37a23ecc3913433880fa3d83292cac475aea5e Reviewed-on: https://chromium-review.googlesource.com/1201703Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#588360}
-
Mihai Sardarescu authored
This CL allows users to be included in the Unified Consent experiment, regardless of their Desktop Identity Consistency state. Screenshots: https://drive.google.com/file/d/1B-rkxD3kPtdBw5toDYJGE-SWuO7PQULL/view?usp=sharing https://drive.google.com/file/d/1W8elDHLNBLJ5rK8QpX1K0xocgoTNpTI6/view?usp=sharing https://drive.google.com/file/d/1Abi8z1FPONLsuaErVgwkfFJdkeHT3o2c/view?usp=sharing Bug: 873064 Change-Id: I27674fe5e6826aba605bbb9b3b4edb3938dc036f Reviewed-on: https://chromium-review.googlesource.com/1169814 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#588359}
-
Erik Språng authored
Bug: chromium:853185 Change-Id: I5e0a76e83318d7761d9d010b0083abc048f563e4 Reviewed-on: https://chromium-review.googlesource.com/1183665 Commit-Queue: Erik Språng <sprang@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#588358}
-
Jan Wilken Dörrie authored
This reverts commit 9ce49488. Reason for revert: Likely culprit of https://crbug.com/879995. Original change's description: > a11y: hide the rest of the browser when a tab-modal dialog is present > > When a tab-modal dialog is shown, the page underneath it is inert. But > NVDA reads the page underneath the dialog when users press Insert+B to > read the whole dialog. To fix this, we hide the rest of the browser > from the accessibility tree when a tab-modal dialog is visible by > modifying AXPlatformNodeDelegate::PopulateChildWidgetVector to return > only the dialog. > > Bug: 775680 > Change-Id: I2a5ec2eeef5ffe50ebd8819836c89ae73ddfdd36 > Reviewed-on: https://chromium-review.googlesource.com/1189054 > Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588142} TBR=dmazzoni@chromium.org,sky@chromium.org,jamwalla@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 775680 Change-Id: I44b9322799880ee613a6380f8ead0c3d86e21549 Reviewed-on: https://chromium-review.googlesource.com/1201824Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#588357}
-
Marina Ciocea authored
Bug: 850878 Change-Id: I215d84b4e3c8234ba8e318fd27ecb22739f950d3 Reviewed-on: https://chromium-review.googlesource.com/1201842Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#588356}
-
jdoerrie authored
TBR=gab@chromium.org Bug: 879984 Change-Id: I994de9e8f5f9ac51fde51e7376b399d271f53181 Reviewed-on: https://chromium-review.googlesource.com/1201849Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#588355}
-
calamity authored
This reverts commit 45ed2663. Reason for revert: getsubstringlength-emoji-ligatures.html is failing on Webkit Win10 starting at https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/40081 Original change's description: > Distribute widths evenly among code points in SynthesizeGraphemeWidths > > Previously we did not consider the possibility of a typographic unit > containing multiple surrogate pairs, and could as an effect "lose" part > of the width. > > Distribute the width evenly among code points instead to at least get > some sort of consistency. > > Bug: 879361 > Change-Id: I51a4e6c574926215a087b0bc824ac90d580ff169 > Reviewed-on: https://chromium-review.googlesource.com/1199423 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Fredrik Söderquist <fs@opera.com> > Cr-Commit-Position: refs/heads/master@{#588183} TBR=pdr@chromium.org,fs@opera.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 879361 Change-Id: I2c73e397bcfb9d458e4bf29f022cc95ac53ed5c0 Reviewed-on: https://chromium-review.googlesource.com/1201628Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#588354}
-
Joel Hockey authored
This function will be called from FilesApp when a user shares a folder with the crostini container by doing either 'Share with Linux' on a folder, or by opening a file with a crostini app. This function calls through to seneschal/9p file server to mount the specified folder into the linux container. Bug: 878324 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I13199ce69679b31fc29cca38ce245e72eb2a1ca6 Reviewed-on: https://chromium-review.googlesource.com/1193624 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#588353}
-
Ioana Pandele authored
Password generation should only be offered via the keyboard accessory, so the code path leading to the generation poup needs to be removed. Bug: 879551 Change-Id: Iedea26b6e25d250d7d0d72168aa9ee7402e5aeea Reviewed-on: https://chromium-review.googlesource.com/1199382Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#588352}
-
Marina Ciocea authored
This is a reland of 2ea45c06 Reason for reland: Fixed i386 build. TBR=rsesek@chromium.org, nasko@chromium.org, olka@chromium.org Original change's description: > Sandbox audio service on Linux. > > Run audio service process in sandboxed mode on Linux. Sandbox is enabled behind finch experiment flag: > --enable-features=AudioServiceStreams,AudioServiceOutOfProcess,AudioServiceSandbox > > TBR=mpdenton@chromium.org, palmer@chromium.org, tsepez@chromium.com > > > Bug: 850878 > Change-Id: Iba6b84adc8c4a62ac4c20d5b36aa4f21b36a1574 > Reviewed-on: https://chromium-review.googlesource.com/1160844 > Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588100} Bug: 850878 Change-Id: Id56fb1b95cfcc8b78c013e7f1a90b63a419205ba Reviewed-on: https://chromium-review.googlesource.com/1199506 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#588351}
-
Harald Alvestrand authored
This counts usage of webkitMediaStream constructor and of webkitRTCPeerConnection constructor. Counting is a preliminary to removing them. Bug: chromium:690582 Change-Id: Iadb41a8d0039c3a1218f87032971598f21ce4e16 Reviewed-on: https://chromium-review.googlesource.com/1199107Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#588350}
-
Hirokazu Honda authored
This removes set_strides from VideoFrameLayout and VideoFrame. VideoFrameLayout in VideoFrame becomes constant. BUG=chromium:876986 TEST=media_unittests and VDA unittests on eve Change-Id: I24143321cb553e5e598df6574eb16059e9252be5 Reviewed-on: https://chromium-review.googlesource.com/1196623Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#588349}
-
Joel Hockey authored
Change-Id: Ifdfb055b8e5b9713373e204fcee5bd65958b4b95 Reviewed-on: https://chromium-review.googlesource.com/1200842Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#588348}
-
arthursonzogni authored
ChromeLauncherActivity is used as a intent dispatcher. Intents for a CustomTabActivity arrive here and are sent to the correct activity.. Chrome removes EXTRA_OPENED_BY_CHROME in this case. It means that even if the intent was sent by the ChromeLauncherActivity, the receiver must now it was not originally sent by Chrome. It must not trust it. A mistake was made, the old |intent| was updated, instead of the |newIntent|. Bug: None Change-Id: I6fc0a7327bdbbb866ec995993eb12b650023b1f1 Reviewed-on: https://chromium-review.googlesource.com/1199364 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#588347}
-
Rune Lillesveen authored
Bug: 813068 Change-Id: I6e486865e443643f0efd4d1bceaea6d6c3ecc4c2 Reviewed-on: https://chromium-review.googlesource.com/1201582Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#588346}
-
Tatsuhisa Yamaguchi authored
Bug: 840497 Test: manually verified Change-Id: Id853396b9ab2b1ca88df81fa028e0783a8377fe0 Reviewed-on: https://chromium-review.googlesource.com/1201633 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#588345}
-
Jan Wilken Dörrie authored
This reverts commit 8c8c3af0. Reason for revert: Likely culprit of https://crbug.com/879988. Original change's description: > Update V8 to version 7.1.6. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/e0a58f83..9f511b4e > > Please follow these instructions for assigning/CC'ing issues: > https://github.com/v8/v8/wiki/Triaging%20issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: I8d84565a9d1b7c7ec40c1af1bf07332c904f3181 > Reviewed-on: https://chromium-review.googlesource.com/1201162 > Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#588301} TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1187a4e8f0c9a9ac428931ca8a80f0d8d90582a5 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1201822 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#588344}
-
Jan Wilken Dörrie authored
This reverts commit 7e647f51. Reason for revert: 7.1.6 is likely culprit of https://crbug.com/879988, reverting this first to solve merge conflict. Original change's description: > Update V8 to version 7.1.8. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/9f511b4e..9c8d1a1e > > Please follow these instructions for assigning/CC'ing issues: > https://github.com/v8/v8/wiki/Triaging%20issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: I6f0420d9b51b5c7882416c3bbf0ce3174f17bb48 > Reviewed-on: https://chromium-review.googlesource.com/1201345 > Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#588322} TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I318c0f4f943727e0531608246b866f60822fe408 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1201823Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#588343}
-
Heng-Ruey Hsu authored
Since all launch bits are flipped, change it to stable channel BUG=879272 TEST=build pass Change-Id: I338c72a0700807eac4153ba4b4f17784a88b77de Reviewed-on: https://chromium-review.googlesource.com/1201511Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#588342}
-
Keiichi Watanabe authored
Add querying to report supported profiles for VP9 at enumeration time in Chrome V4L2 classes. BUG=chromium:819930 TEST=Play VP9 video from crosvideo on kevin TEST=Confirm that HW decoder is not selected when trying to play VP9.2 video on kevin Change-Id: If6ac5a83e95e727a8e0a2ea5af7dcea953d8cd00 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1013765 Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#588341}
-
Kenichi Ishibashi authored
The function is renamed CreateServiceWorkerSubresourceLoaderFactory to clarify that it is used for service worker. Also this CL updates the comment of the function as SubresourceLoaderFactory doesn't run on the IO thread any more but runs on a background thread. Bug: N/A Change-Id: Iaf393915d4d8f81d13069724ead6613f9685b6da Reviewed-on: https://chromium-review.googlesource.com/1201702Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#588340}
-
Jinsuk Kim authored
Moves |WebContents.simulateRendererKilledForTesting| to a test-only class. Bug: 873217 Change-Id: Ice84e5f4b7eb5ccc9eb852bc2957b7392b8eca92 Reviewed-on: https://chromium-review.googlesource.com/1198668 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#588339}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I38cd068df4007bcb0a40410491300e006d9aaccf Reviewed-on: https://chromium-review.googlesource.com/1201351Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588338}
-
Joel Hockey authored
Added/moved signalling logic into fake clients: * FakeConciergeClient::StartTerminaVm sends OnTremplinStartedSignal. * FakeCiceroneClient::CreateLxdContainer sends OnLxdContainerCreatedSignal * FakeCiceroneClient::StartContainer sends OnContainerStartedSignal Bug: 878324 Change-Id: I7bc8caabc5f4811595d9d58c893e2beda88918dc Reviewed-on: https://chromium-review.googlesource.com/1193525Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#588337}
-
Rijubrata Bhaumik authored
TEST= run the demo in https://codepen.io/rijuB/pen/BPyWzp use slider to change focusDistance. Tested using a brio-stream-4k-hd-webcam, where we could change the focus distance in manual mode. command line: v4l2-ctl -d 1 --set-ctrl=focus_auto=0 v4l2-ctl -d 1 --set-ctrl=focus_absolute=100 GUI: guvcview --device=/dev/video1 BUG=732807 Intent to Implement and Ship discussions: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/oNxzXaFY9c8 Change-Id: I63143426ff89505c27026c4b97e54ac9afae4b0f Reviewed-on: https://chromium-review.googlesource.com/1135134Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#588336}
-
Anand K. Mistry authored
cros-disks was updated to return an error code, and two weeks have passed. This backwards compatibility code is no longer needed. BUG=288974 Change-Id: Ibc2691bc1d301b196648b32198a13349f8948e86 Reviewed-on: https://chromium-review.googlesource.com/1201505Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#588335}
-
Hiroshige Hayashizaki authored
Element::nonce() returns either the null or empty string if nonce is not set, when rare data exists or not, respectively. Also, nonce() is checked whether it's null (rather than whether it's empty) in Element::CloneAttributesFrom() and ContentSecurityPolicy::IsNonceableElement(). This CL make nonce() return null consistently if the nonce is not set. This will fix the very large CleanScriptElementWithNonce use count. Change-Id: If00e6006a68be89ab449402b0a5e631327712e5e Reviewed-on: https://chromium-review.googlesource.com/1180821Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#588334}
-
calamity authored
This reverts commit a886f31e. Reason for revert: Causing failures on Mac starting at https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28803 Other examples: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests/4934 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/15151 Original change's description: > Add some more PPAPI TCP tests. > > In particular, add some tests for various errors and state transitions, > and make sure reading from a closed socket returns net::OK on the first > read. > > This CL also splits up the PPAPI TcpSocket browser test into multiple > tests to decrease the chance of the tests timing out. > > Bug: 848078 > Change-Id: I308cfa0ac60db63ada4a41dce8d93e68393600ff > Reviewed-on: https://chromium-review.googlesource.com/1197924 > Commit-Queue: Matt Menke <mmenke@chromium.org> > Reviewed-by: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588092} TBR=bbudge@chromium.org,mmenke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 848078 Change-Id: I3bdecc1e754da5d14cf184b5e285a6db3ec21362 Reviewed-on: https://chromium-review.googlesource.com/1201629Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#588333}
-
chrome://flags#app-window-cyclingTrent Apted authored
Mostly this is a revert of r876623. chrome://flags#app-window-cycling never worked right and was never enabled by default. Remove it, and the supporting code. In r585002 its test was disabled for unrelated reasons (NTP changes), but there's no point keeping this around. Window cycling will eventually be fixed properly as part of https://crbug.com/859152, and this will probably just get in the way. Bug: 278408, 484737, 876623 Change-Id: I6d1e453b1c5d258191913bce211785e818ee3247 Reviewed-on: https://chromium-review.googlesource.com/1198704Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#588332}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7e647f51. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23984 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I6892fb3792997c767a82c24bdca3616e94e2805c Reviewed-on: https://chromium-review.googlesource.com/1201347 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#588331}
-
Sam McNally authored
The file manager UI uses available_offline to determine whether an item is openable while offline so set it for hosted docs. Bug: 844291 Change-Id: I57c8135b24b0bdb069414000a0fb3fe73a1a23d6 Reviewed-on: https://chromium-review.googlesource.com/1201645Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#588330}
-
Heng-Ruey Hsu authored
GCA migration app will move all images and videos to Downloads/. BUG=b:73056417 TEST=click camera app icon launches migration app Change-Id: I3cb22ebbc09e609857f07367071e6816c7aeb5b7 Reviewed-on: https://chromium-review.googlesource.com/1187848 Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#588329}
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 786332 Change-Id: Ie0737135f42d7abba55080c007687a19d8c08897 Reviewed-on: https://chromium-review.googlesource.com/1198654Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#588328}
-
Alexandre Courbot authored
When creating output buffers, we were setting the number of planes to input_planes_count_ whereas it should be output_planes_count_. As it turns out, both members are currently always equal to 1, so the issue was not visible at runtime, but better fix it preemptively. BUG=None TEST=Checked that VDA unittest was passing on Kevin Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7c6e37fcaf1e836afbb2c56220ea10dd42000fbc Reviewed-on: https://chromium-review.googlesource.com/1195183Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#588327}
-
Sam McNally authored
For component platform apps, favicon, extension-icon, resources and theme hosts are whitelisted for the chrome scheme. However, in the network-service-enabled codepath, at most two of those hosts are passed in |allowed_webui_hosts|, leaving out the other two for component platform apps. Change the structure to more-closely match the non-network-service codepath, whitelisting the four hosts when appropriate. Bug: 837328 Change-Id: Ib10e8fa2dcca0cf77be565bab3ebf9dd87daf188 Reviewed-on: https://chromium-review.googlesource.com/1201510Reviewed-by:
Anand Mistry <amistry@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#588326}
-
Christopher Lam authored
This CL attempts to fix failing Mac builds by adding an AX mojom dependency to content/public/common:interfaces. TBR=jam@chromium.org BUG=879949 Change-Id: I0f004835ec33cde460961ec380bdb4325f12c1e7 Reviewed-on: https://chromium-review.googlesource.com/1201506Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#588325}
-