GitLab

kInvalidPlatformFileValue is the invalid platform file handle.

BUG=271533

Review URL: https://chromiumcodereview.appspot.com/22841004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217103 0039d316-1c4b-4281-b951-d872f2087c98

BUG=271005
TEST=Added checks in existing tests
R=rjkroege@chromium.org

Review URL: https://codereview.chromium.org/22354005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217102 0039d316-1c4b-4281-b951-d872f2087c98

INVALID_SOCKET for failure.

R=rsleevi@chromium.org
BUG=271530
TEST=none

Review URL: https://chromiumcodereview.appspot.com/22824005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217101 0039d316-1c4b-4281-b951-d872f2087c98

Add the command line flag --enable-overlay-scrollbars to enable
overlay scrollbars in Aura and Linux.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/22422010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217100 0039d316-1c4b-4281-b951-d872f2087c98

Added stub portalled wifi network for testing captive portal UI on the
ChromeOS build. To use it one's need run chrome with the folliwing
switches:
--disable-stub-ethernet
--use-new-network-connection-handler
--default-stub-network-state-idle
--enable-stub-portalled-wifi

BUG=246391
TEST=manual tests on Lumpy

Review URL: https://chromiumcodereview.appspot.com/22364005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217099 0039d316-1c4b-4281-b951-d872f2087c98

In GetDriveEntryPropertiesFunction::OnGetFileInfo(), we should not return failure when no
default task is associated with a particular MIME type. Instead we should still append all
apps that support the file type.

BUG=271570
TEST=manually on device, pass trybot
R=satorux@chromium.org, tbarzic@chromium.org

Review URL: https://codereview.chromium.org/22931003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217098 0039d316-1c4b-4281-b951-d872f2087c98

BUG=264497
TEST=manually
TBR=dbeam

Review URL: https://chromiumcodereview.appspot.com/22840004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217096 0039d316-1c4b-4281-b951-d872f2087c98

Since the addition of CA certificate PEMs, the test of the Shill to ONC translation of OpenVPN networks logged an error.

This commit fixes this error and adds another test of the Shill to ONC translation of WiFi with EAP.

BUG=NONE

Review URL: https://chromiumcodereview.appspot.com/22837002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217095 0039d316-1c4b-4281-b951-d872f2087c98

and disabled state and whether the extension updates from the webstore).

BUG=268666

Review URL: https://chromiumcodereview.appspot.com/22390005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217094 0039d316-1c4b-4281-b951-d872f2087c98

We wish to enable allow better selectivity in ShellUtil::RemoveShortcuts() and ShellUtil::UpdateShortcuts() to decide on which shortcuts to operate on. In this CL:
- BatchShortcutAction() is given a (newly defined) FileFilterCallback predicate that decides whether or not a given shortcut should be operated on.
- Currently this is only created by (newly defined) class FilterTargetEq.
- Also renamed FileOperationCallback to ShortcutOperationCallback.
- This is a refactoring CL, so we retain the old behavior: BatchShortcutAction() only considers shortcuts that have with a specific target.

BUG=235857

Review URL: https://chromiumcodereview.appspot.com/22607006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217092 0039d316-1c4b-4281-b951-d872f2087c98

This CL is almost the same as http://crrev.com/17573006, which was reverted because of a unit test breakage.

BUG=245578
TEST=Test manually.

Review URL: https://chromiumcodereview.appspot.com/22534003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217091 0039d316-1c4b-4281-b951-d872f2087c98

There is currently a race condition on updating the sync footer
visibility on the welcome page. If the web page is created after the
initial sync footer visibility state is sent, it is never sent again.

This CL ensures that on startup, the state will always be correct.

BUG=267352

Review URL: https://chromiumcodereview.appspot.com/22375004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217090 0039d316-1c4b-4281-b951-d872f2087c98

Adding the "Authenticate" step to the "MANUAL_Auth" test case. Also added the username and password command line options.

BUG=134210

Review URL: https://chromiumcodereview.appspot.com/22274016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217089 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217088 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=155929:155942&mode=html
TBR=tdanderson@chromium.org
BUG=

Review URL: https://codereview.chromium.org/22916004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217087 0039d316-1c4b-4281-b951-d872f2087c98

./build/sanitize-png-files.sh -o2 chrome/app/theme/chromium
Processed 3 files (out of 15 files) in 00:08:53s
Result : 10359 => 10322 bytes (37 bytes : 0 %)

BUG=271299
TBR=msw@chromium.org

Review URL: https://codereview.chromium.org/22951002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217086 0039d316-1c4b-4281-b951-d872f2087c98

As described in http://www.viva64.com/en/b/0205/.

BUG=271533

Review URL: https://chromiumcodereview.appspot.com/22886002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217085 0039d316-1c4b-4281-b951-d872f2087c98

Some of the chrome/browser/policy code will be moved to a new layered component.
This change prepares the ConfigurationPolicyPrefStore class for the move, by
removing its dependency on g_browser_process and BrowserThread.

BUG=271392

Review URL: https://chromiumcodereview.appspot.com/22812002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217084 0039d316-1c4b-4281-b951-d872f2087c98

BUG=270735
R=wtc

Review URL: https://chromiumcodereview.appspot.com/22758002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217083 0039d316-1c4b-4281-b951-d872f2087c98

BUG=269006

Review URL: https://chromiumcodereview.appspot.com/22751002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217082 0039d316-1c4b-4281-b951-d872f2087c98

There is no longer an Instant overlay that needs controlling, so we can
remove InstantOverlayController. Mac's view code is warped around the
existence of an overlay, so cut out as much of the dead Instant code as
possible without removing OverlayableContentsController; I'm not a Cocoa
expert and don't know the best way to do that.

BUG=251262
TEST=None.
TBR=erg@chromium.org, rsesek@chromium.org, samarth@chromium.org

Review URL: https://codereview.chromium.org/22694002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217079 0039d316-1c4b-4281-b951-d872f2087c98

$./build/sanitize-png-files.sh -o2 remoting/resources
 Processed 1 files (out of 6 files) in 00:00:50s
 Result : 3436 => 691 bytes (2745 bytes : 79 %)

BUG=271299
TBR=garykac@chromium.org

Review URL: https://codereview.chromium.org/22907003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217078 0039d316-1c4b-4281-b951-d872f2087c98

Change rAc suggestion text to return two string values, one which is preferred (but may not fit horizontally) and one which is a fallback (which has a better chance to fit horizontally).

BUG=264973

Review URL: https://chromiumcodereview.appspot.com/21724002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217076 0039d316-1c4b-4281-b951-d872f2087c98

chromebox died after completion, and lost the result. Sorry.

BUG=271299
TBR=msw@chromium.org

Review URL: https://codereview.chromium.org/22896004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217074 0039d316-1c4b-4281-b951-d872f2087c98

BUG=242299

Review URL: https://chromiumcodereview.appspot.com/21777003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217073 0039d316-1c4b-4281-b951-d872f2087c98

Monkey test has its own timeout which varies by the number of events, so pass None for the test_dispatcher timeout.

NOTRY=True
BUG=

Review URL: https://chromiumcodereview.appspot.com/22939002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217072 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217071 0039d316-1c4b-4281-b951-d872f2087c98

Moved from https://codereview.chromium.org/21052007/

Currently the ContextFactory is outliving the compositor thread in 
tests, which is bad since the contexts in there can be bound to the 
compositor thread. Then we end up reusing those contexts and bad 
things happen. 

This enforces ordering for initializing and destroying the 
compositor as follows: 

Initialize ContextFactory 
..Compositor::Initialize 
....Create Compositor instances 
....Delete Compositor instances 
..Compositor::Terminate 

The Compositor::Terminate call also destroys the ContextFactory. 

The ContextFactory can be initialized in one of two ways: 
1. ImageTransportFactory::Initialize will set up the 
ContextFactory. This is used by things that invoke all of 
content/browser/. 
2. Compositor::InitializeContextFactoryForTests() must be 
explicitly called by any unit tests that create a compositor. 

Since some tests want a real GL context and some don't, this 
does away with the misnomer of initializing the Compositor once 
for the entire test suite, and then re-initializing somewhere 
in the middle of the test suite. Instead, each test must 
Initialize/Terminate the compositor with the ContextFactory 
type of its choice. 

Incidently, this test enables 20 tests on aura or win_aura that 
were previously being skipped. 

TBR=piman@chromium.org
BUG=258625

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216780

Review URL: https://chromiumcodereview.appspot.com/22293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217069 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217068 0039d316-1c4b-4281-b951-d872f2087c98

TBR=asargent
BUG=268481

Review URL: https://chromiumcodereview.appspot.com/22895002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217066 0039d316-1c4b-4281-b951-d872f2087c98

This also closes the app. If the app crashes in the background,
it might interfere with subsequent instrumentation tests.

BUG=271071
R=craigdh@chromium.org

Review URL: https://codereview.chromium.org/22767002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217065 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217064 0039d316-1c4b-4281-b951-d872f2087c98

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/22891003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217063 0039d316-1c4b-4281-b951-d872f2087c98

On Linux, right clicking in the omnibox does not give it focus, so
right-clicking and pasting can change the contents without focus in
the omnibox. Take out the DCHECK that assumes this cannot happen.

Also, change the focus_source_ to assume the source was OMNIBOX in these cases.

BUG=271462
R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/22795005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217062 0039d316-1c4b-4281-b951-d872f2087c98

Reset page scale factor to 1.0f

This first time we tried to land this (https://codereview.chromium.org/17830003/)
it ran into problems with layout tests that incorrectly handled setPageScale. This
has since been fixed in https://codereview.chromium.org/18546003/, so we will try
to re-land this.

TBR=jamesr
BUG=162482

Review URL: https://chromiumcodereview.appspot.com/22848002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217061 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=True
BUG=264859
TEST=
1) Uninstall Chrome.
2) Put mini_installer.exe in the same folder as test_installer.py.
3) Run "python test_installer.py config\config.config".
4) The script will install Chrome and then uninstall Chrome.  At each state, it will check that a registry entry for Chrome exists (or doesn't exist). You should see output similar to the following:

"Test: clean -> install chrome -> chrome_installed -> uninstall chrome -> clean ... ok

----------------------------------------------------------------------
Ran 1 test in 12.345s"

Review URL: https://chromiumcodereview.appspot.com/22480002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217059 0039d316-1c4b-4281-b951-d872f2087c98

One http request field name wasn't correct.

NOTRY=true

BUG=271021

Review URL: https://chromiumcodereview.appspot.com/22532013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217058 0039d316-1c4b-4281-b951-d872f2087c98

BUG=166165
Test=WebViewTest.*, WebViewInteractiveTest.*
TBR=cdn@chromium.org for removing IPCs in browser_plugin_messages.h
NOTRY=true, previous patch worked, just merging.

Review URL: https://chromiumcodereview.appspot.com/21297005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217057 0039d316-1c4b-4281-b951-d872f2087c98

Add tests for: (all for editable and noneditable text)
Long-press on text shows selection handles.
Dragging selection handle changes selected text.
Single-click dismisses selection handles.
Long-press on text shows ActionMode with correct actions.
Single click dismisses ActionMode.

BUG=155548

Review URL: https://chromiumcodereview.appspot.com/21044008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217056 0039d316-1c4b-4281-b951-d872f2087c98

Moved binary from other CL for separate force-commit because of a bug that prevents CQ from applying binary patches.

BUG=103846
TBR=estade@chromium.org

Review URL: https://codereview.chromium.org/22877004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217055 0039d316-1c4b-4281-b951-d872f2087c98