GitLab

As requested by PgM and TLM.

AX-Relnotes: N/A
Bug: 1121204, 1160728
Change-Id: I47c20f62c2ea236d37f2a2537d659fc200069eb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638007Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846237}

Move ZoomToFindInPageRect and get rid of the WebRect usage.

BUG=738465

Change-Id: I50802f600b80d28694eac1538e22cc001021f6a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641120
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846236}

Bug: internal b/166313191
Test: None
Change-Id: I2d9c60c33a9076f73140a2b6181820ec2382c3b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643401Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
Commit-Queue: Guohui Deng <guohuideng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846235}

This CL depends on
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2611416

BUG=chromium:1163122
TEST=tast run arc.Boot[.vm]

Change-Id: I84a2f6c3a818877abba54cce15106a670386b1e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613917
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846234}

The tooltip is only useful when the profile name or the gaia name is
long enough to be truncated.

This CL also fixes the flickering of the profile card container and
profile card cursor at the bottom of the card due to the gaia name
tooltip.

Fixed: 1169169
Change-Id: I106cde6aff8e26b895af6293e73776f45732ea6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642371Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Monica Basta <msalama@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846233}

Rename |restore_focus_window_| to |active_window_before_overview_| to
better match the code. The active window might not be the same window
as the focused window, but by activating the right window, the focus
will be restored properly as well.

Pure renaming. No functional change.

Bug: None
Change-Id: I67250ce1fd5a48cf817ec04ef4f59de0ab83c38d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644348Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846232}

r834202 changed MutableCSSPropertyValueSet::SetProperty so that, when
changing the value of a property that belongs to a logical property
group, which is followed by a property in the same logical property
group but opposite mapping logic, the changed property is moved to the
end, to ensure it takes precedence.

However, this regressed the CSSPropertyUpdateValue perf test.

This patch adds a may_have_logical_properties_ flag. When false, it
means the MutableCSSPropertyValueSet has no logical property, so we can
skip the extra work added in r834202.

Bug: 1156321
Change-Id: I4ab6d92cf51126bcab16ffa9635bf91c98d6f738
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640097Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#846231}

A type converter for unique_ptr type should be able to accept a getter
which returns the raw pointer type. This CL adds such support. Also it
adds such a property in ToggleImageButton class as an example.

Bug: 1168309
Change-Id: I49488d475cd70a7441f4f7e5918929c8e5b35638
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639655Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846230}

This reverts commit b6f59baa.

Reason for revert: https://ci.chromium.org/p/chrome/builders/ci/lorenz-graph-dbg: No such file or directory: 'dirmd'

Original change's description:
> [Android] Read DIR_METADATA in getowners.py
>
> The getowners.py script periodically reads OWNERS files and git history
> and generates per-module data to be surfaced in go/clank-
>
> OWNERS files do not contain Monorail component, Team and OS information
> anymore, DIR_METADATA files have replaced them and broken the script
> since then.
>
> Bug: 1135347
> Change-Id: Ib88e9d576d94ad5484b6a3dbbfff156639275dea
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634833
> Reviewed-by: Peter Wen <wnwen@chromium.org>
> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#845754}

TBR=wnwen@chromium.org,hnakashima@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I5c1afaa0f5846f22db9e59fbc42438cca9aae68d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1135347
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644528Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846229}

Seems that Cronet may be still supporting ICS, but these removed parts
should not be needed to Cronet.

Bug: 1041930
Change-Id: I3ae0cd53ab410401d6318d9f2ac8f6ba6145f25f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633054
Commit-Queue: Egor Pasko <pasko@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846228}

Finch config change: cl/352943943
This CL also cleans up some testing configs, leaving only the one that
are most likely to be launched.

Change-Id: I9da17f9838b9d666cdd2f6f8993c3a189cc5ca38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641812Reviewed-by: Weilun Shi <sweilun@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846227}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9c81656e14af..bf47f1bdf381

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC nsatragno@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: nsatragno@google.com
Change-Id: I8d5e7526089cd7c5e512c1bc41ee3d554f1aaf91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645107Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#846226}

This reverts commit 495dcf2f.

Reason for revert: see https://bugs.chromium.org/p/chromium/issues/detail?id=1169201 .

Original change's description:
> Android: cleanup of transition types
>
> This removes adding the qualifier PageTransition.FROM_API for
> TabLaunchTypes of FROM_LINK and FROM_RESTORE. I believe this was
> unintentional, and doesn't make sense to use FROM_API with.
>
> This also removes FROM_API for intents that came from chrome and
> launched chrome. Again, seems like we shouldn't use FROM_API for
> this scenario either.
>
> I came across this while doing the other patches. AFAIK nothing
> depends upon this, just seems worth cleaning up.
>
> BUG=none
> TEST=none
>
> Change-Id: Id89fbc0e70fb52a662ac33a55d269460677ee152
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511853
> Commit-Queue: Scott Violet <sky@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#823388}

TBR=sky@chromium.org,mthiesse@chromium.org,tedchoc@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1169201
Change-Id: Idff0c0063f22b7290c37be33062d34eeb6572199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644148Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846225}

Previously it was implemented as an iron-icon-button + paper-ripple
inside a <a> element, which was problematic (infinite ripples showing
when holding down the enter key).

By leveraging cr-icon-button the bug above is fixed. As a side effect
the focus indicator changes from an outline to a ripple, which will
change back once cr-icon-button itself will transition from ripples to
outlines for focus (soon).

Fixed: 1167155
Change-Id: Ic899c251b3c56bf7b73fcde8682afa73b9918730
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644461
Commit-Queue: John Lee <johntlee@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846224}

This CL adds metrics for new user actions on the LanguageSettings page.

The actions that are added are:
  - Chrome Language
  - Target Language

It also adds the following PageImpressions for the LanguageSettings:
  - Chrome Language
  - Advanced Language Settings
  - Target Language

Additionally, the "Click on the 'Add Language' button" value is no
longer recorded on Android since it does not modify language
preferences and the same metric is in PageImpressions.

Bug: 1127531
Change-Id: I92fc0e50cab7683c21387eb263a031e1777dfdf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638077Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Josh Simmons <jds@google.com>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Commit-Queue: Trevor  Perrier <perrier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846223}

Previously was 24%. Spec calls for 30%.

Bug: 1169320
Change-Id: I793520a07de8fb706e7d5a73ceff0d20e05ebcd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643360Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#846222}

Made AXNode::IsDescendantOf work the same across BrowserAccessibility, AXPlatformNodeBase and AXNode

An inconsistency in the behavior of this method that
I found while merging BrowserAccessibilityPosition and AXNodePosition.

AX-Relnotes: n/a.

R=dmazzoni@chromium.org, aleventhal@chromium.org

Change-Id: I34ce5d10bc67a7b78438e94a4a9c4b6c21fd5bc9
Bug: 1049261
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644620Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Auto-Submit: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846221}

https://android.googlesource.com/platform/external/perfetto.git/+log/5b2a5204087d..57144c8685d3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: Iee8dd2bd50bbcf52f52e64307d29c4960bf32d31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644822Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#846220}

Bug: 1160725
Change-Id: I5f90794fbeadc3799c40b87388f46e7ba8221c53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643701Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846219}

This reverts commit bba4dc0e.

Reason for revert: Breaks v8 generation script for at least
linux and linux-chromeos.

FAILED: gen/v8/include/v8-gn.h 
python3 ../../v8/tools/gen-v8-gn.py -o gen/v8/include/v8-gn.h -p V8_COMPRESS_POINTERS -p V8_31BIT_SMIS_ON_64BIT_ARCH -p V8_DEPRECATION_WARNINGS -p CPPGC_CAGED_HEAP -n V8_ENABLE_CHECKS -n V8_COMPRESS_ZONES -n V8_HEAP_SANDBOX -n V8_IMMINENT_DEPRECATION_WARNINGS -n V8_NO_ARGUMENTS_ADAPTOR -n V8_USE_PERFETTO -n CPPGC_SUPPORTS_OBJECT_NAMES -n CPPGC_YOUNG_GENERATION
Traceback (most recent call last):
  File "../../v8/tools/gen-v8-gn.py", line 80, in <module>
    main()
  File "../../v8/tools/gen-v8-gn.py", line 63, in main
    header_stream = BytesIO("")
TypeError: a bytes-like object is required, not 'str'

Original change's description:
> Reland #4 (?) of "Force Python 3 to be used in build."
>
> This reverts commit 17801e45.
>
> Reason for revert: Fixes to the internal scripts that broke
> have landed.
>
> Original change's description:
> > Revert "Reland "Force Python 3 to be used in build.""
> >
> > This reverts commit 6ea5c38d.
> >
> > Reason for revert: build failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Deterministic%20Linux/30058/overview
> >
> > Original change's description:
> > > Reland "Force Python 3 to be used in build."
> > >
> > > This reverts commit b6172196.
> > >
> > > Reason for revert: We rolled GN to a new version with a fix for
> > > the win dev issues, so hopefully is good to go now.
> > >
> > > Original change's description:
> > > > Revert "Force Python 3 to be used in build."
> > > >
> > > > This reverts commit bb97ab9b.
> > > >
> > > > Reason for revert: Various breakages.
> > > >
> > > > Original change's description:
> > > > > Force Python 3 to be used in build.
> > > > >
> > > > > This CL makes Python 3 be the default script executable used by Ninja
> > > > > to run action() and action_foreach()'s during the build.
> > > > >
> > > > > This does *not* mean that everything works with Python3; many targets
> > > > > may still use Python 2 via the python2_action() and
> > > > > python2_action_foreach() targets or via custom logic.
> > > > >
> > > > > However, it does mean that it should prevent regressions from
> > > > > creeping in.
> > > > >
> > > > > This CL should not be taken to imply that we can start to write
> > > > > Python3-specific code that can run during the build; we should
> > > > > still be trying to ensure that everything is compatible with Python2.
> > > > >
> > > > > Also, this CL does not enable the use of vpython in actions; we should
> > > > > still avoid that because vpython is slower than direct Python
> > > > > invocations.
> > > > >
> > > > > Bug: 1112471
> > > > > Change-Id: I472b032b500715156d955b0758640a7ed0384305
> > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515787
> > > > > Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> > > > > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > > > > Cr-Commit-Position: refs/heads/master@{#836234}
> > > >
> > > > TBR=dpranke@google.com,brucedawson@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
> > > >
> > > > Change-Id: I72039140f401f1fefc1b515dcfe34f1984b0d914
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: 1112471
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587576
> > > > Reviewed-by: Dirk Pranke <dpranke@google.com>
> > > > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > > > Cr-Commit-Position: refs/heads/master@{#836284}
> > >
> > > TBR=dpranke@google.com,brucedawson@chromium.org,tikuta@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
> > >
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > >
> > > Bug: 1112471
> > > Change-Id: I55ee8ccb381b5aeeac58a85a6168765ed40457ba
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630725
> > > Reviewed-by: Dirk Pranke <dpranke@google.com>
> > > Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> > > Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> > > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > > Cr-Commit-Position: refs/heads/master@{#844885}
> >
> > TBR=dpranke@google.com,brucedawson@chromium.org,tikuta@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
> >
> > Change-Id: I01ac20d80f5fe38a1f8113010f803509df0d7861
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1112471
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637169
> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> > Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#844986}
>
> TBR=dpranke@google.com,yhirano@chromium.org,brucedawson@chromium.org,tikuta@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1112471
> Change-Id: Icbefaa2cb23b1bf9e54bbd674cb5ab564dae3785
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643157
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> Commit-Queue: Dirk Pranke <dpranke@google.com>
> Cr-Commit-Position: refs/heads/master@{#846193}

TBR=dpranke@google.com,yhirano@chromium.org,brucedawson@chromium.org,tikuta@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: Ic21ef3e38758d295dac893a02f8d206a67e49d52
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1112471
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645206Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846218}

Fixed: 1169417
Change-Id: I7a27f5ab0083287ee0dbd24313717b293a742ce4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642786Reviewed-by: Anastasiia N <anastasiian@chromium.org>
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Auto-Submit: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846217}

R=rsoroken@chromium.org

Fixed: 1161107
Change-Id: Ib4f1b2c5ac2c7d621175548859b902cc71b742da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643257Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846216}

This feature flag has been rollout to 100%. Now we need to change the
default value to 'enabled' for GA, and extend the expiry date in case we
need to turn it off because of any unexpected reason.

Change the owner of this feature flag to bmalcolm@ because I have been
out of this area. (We may need to cleanup this flag after the feature is
fully launch.)

Bug: 1169268
Change-Id: I0473ebbb9b998d11ec7931298718ab6e8b090c1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642635Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Brian Malcolm <bmalcolm@chromium.org>
Commit-Queue: Anqing Zhao <anqing@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846215}

This CL also introduces a new UMA metric,
ClearBrowsingData_SameSiteNoneData, which is used in
BrowsingDataBridgeTest.java and will also be used to track usage
of the feature once it is released.

Bug: 1166674
Change-Id: I00aebaf4b5192e187fb42e7947b52ea046bf4276
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627766
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846214}

https://android.googlesource.com/platform/external/perfetto.git/+log/57144c8685d3..3232876ee47b

2021-01-22 lalitm@google.com perfetto: initial implementation of building with LUCI

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: chromium:177349647
Tbr: perfetto-bugs@google.com
Change-Id: If953b3145bb3a5ba590fec6cd74e6af4bc10e04a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645026Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#846213}

They are useful when we finch CompositeAfterPaint.

Bug: 1167827
Change-Id: I51fa75f3c32ecbdbff28f199cca15974bedcb4d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643273Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846212}

Previously the holding space tray did not update visibility when the
user adding screen was shown and interacting with holding space items
appeared to no-op to the user since actions were being performed behind
the login screen.

Bug: 1168059
Change-Id: I8a55e811b2eb74edeecdcae11dc811173420aff8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643412Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#846211}

Disable build_with_tflite_lib on Windows on ARM as a workaround
until it is fixed generally.

Bug: chromium:1169611
Change-Id: I305a053fcf724783c31491a225eb4e4c28733ec2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643387Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Richard Townsend <richard.townsend@arm.com>
Cr-Commit-Position: refs/heads/master@{#846210}

This CL removes WebRemoteFrameClient::WasEvicted method, then
WebFrameWidgetImpl starts calling RemoteFrame::ResendVisualProperties
directly for the evicted frame.

Bug: 1166726
Change-Id: Ibd24bf2009631deac9018ff7ee0e848f7a84a9f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636823
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846209}

It seems the x86 emulator is a little bit slow or it connects to
cloud, the query response come back during the test.

This patch disable the download server in tests.

Bug: 1161326

Change-Id: I19171957ca266f8827eb14a55e017b901ea60201
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633203Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Commit-Queue: Michael Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846208}

Change-Id: I4d055320f6d410de25944c336da3486899479b64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643331Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Cr-Commit-Position: refs/heads/master@{#846207}

The dcheck bot should be identical to the non-dcheck bot, so this adds
the same filter file that the non-dcheck bot uses.

Bug: 1113456
Change-Id: Ieab2e779f18cc84f8120efedd3108623f02a58c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643575Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846206}

Change-Id: Icd30a001d44487a7536dc75cbaeb91d4c9038f9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643027Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Travis Skare <skare@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846205}

This change converts callbacks from base::Bind and base::Callback to
Once/Repeating in //chrome/browser/chromeos/lock_screen_apps.

Bug: 1148570
Change-Id: I85b8e4e83d9f61d3cdc0da02f6650418c1ccccff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644110
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846204}

Currently, counter style updates is a phase in UpdateActiveStyles. This
patch moves it out as a standalone phase of UpdateStyleAndLayoutTree,
so that we update counter styles only when needed.

This patch also adds MarkCounterStylesNeedUpdate() to indicate whether
counter style updates are needed.

Note: After refactoring, the framework of counter style updates looks
almost identical to font updates. This is intentional. We will try to
unify them in the future.

Bug: 687225
Change-Id: If07de2878ae5faa6800644a967029a569bef566a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639535Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846203}

BUG=1168231

Change-Id: I9f46b03f3c03a50382778c8d8ae404be8714ab31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644316
Auto-Submit: Robert Liao <robliao@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846202}

To support ANGLE, we need to create ANGLE context and surfaces from the
native EGL context and surfaces with the
EGL_ANGLE_external_context_and_surface extension. And ANGLE will save
and restore during make current or release the current context with
eglMakeCurrent() call. To do that, ScopedAppGLStateRestore will not
create gl::GLContext, save and restore GL state anymore. It only queries
stencil state with native GL binding instead of the ANGLE GL binding,
since ANGLE will not return the GL state from the native GL.
And SkiaRenderer may need the stencil state later. The ANGLE EGL context
will be created in OutputSurfaceProviderWebView, and make current in
HardwareRendererViz.

Bug: 1157501
Change-Id: Ieca9c85855df5ab529846fe2882d7451f50f51bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612925
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846201}

Since it is only used in one place, there is no reason for this
(deprecated) UI component to be in shared WebUI code.

As a result of this CL bubble_button.js/css is no longer part of the
build in non-CrOS, and in CrOS is inlined within arc_suport/main.html
as a result of the |flattenhtml| usage on that file.

Bug: None
Change-Id: I9838bc4a9a6b71370fbc212d1e189311045b0813
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643091
Auto-Submit: dpapad <dpapad@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846200}

This CL moves the dumper to be a test target.

This CL also refactors the FrameContentAsPlainText function into a
separate header so that it can be relied on by both testing and prod
code. The prod code is moved into a new machine usage only class which
will be the focus of many upcoming changes to add missing support and
logic that caused the method to be deprecated in the first place. See
the second bug for more context and details for that effort.

Bug: 585164, 1163244
Change-Id: I02fd5c204c71e9ffc82de5267d592ad316d0cbc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610941
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846199}

When hardware acceleration was disabled, the WebRtcVideoTrackSource can
receive NV12 frames in software. This patch adds support for the NV12
frames in WebRtcVideoFrameAdapter so that the WebRtcVideoTrackSource can
pass those frames safely.

with hardware acceleration off and confirmed that it worked. I also
confirmed that the NV12 frames in software are used as expected from
WebRTC, as they would be if they were from a GMB.

Test: https://webrtc.github.io/samples/src/content/peerconnection/pc1/
Bug: 1168948
Change-Id: I5b78ec01fe6ef1c4a4a047bb3fda908ad6813e4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645084
Commit-Queue: Evan Shrubsole <eshr@google.com>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Markus Handell <handellm@google.com>
Cr-Commit-Position: refs/heads/master@{#846198}