- 04 Mar, 2020 40 commits
-
-
Tom Anderson authored
This is to aid in debugging bug 1057943. BUG=1057943 R=nickdiego Change-Id: I29b2b77ac597ccdd154febb682dac14f7d92d13c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088016 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#746951}
-
Greg Daniel authored
Bug: skia:7966 Change-Id: Ia1e2a4e7bd60b3bb37574caee6bc7aa744840d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087980Reviewed-by:
Robert Phillips <robertphillips@google.com> Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Greg Daniel <egdaniel@google.com> Cr-Commit-Position: refs/heads/master@{#746950}
-
Natalie Chouinard authored
Missed formatting in this CL: https://crrev.com/c/2086292 Change-Id: Ie9af245d0b4bcab742cb7b50ae199ab65ea1db56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088186 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#746949}
-
John Lee authored
This CL adds support for a user clicking on a tab group chip, which then triggers the edit bubble dialog to pop open. This CL does not yet add support for keyboard access to the chip and focus management. Bug: 1027373, 1055537 Change-Id: I781e0761727f2115a9af2bf3387ee9842c0043e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083927Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#746948}
-
Danan S authored
Bug: 957832 Change-Id: Ieaf37b911a29bdf6462cf9a3e4faf81578a2d5f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086558 Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#746947}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. Bug: 1026641 Change-Id: Ib756059598a3444afb8cfd39209936f391d1c899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079091 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#746946}
-
Eric Willigers authored
Desktop PWAs and shortcut apps are now collectively referred to as "web apps". "Bookmark apps" is used to refer to the original Chrome implementation of these app using Extensions, this implementation is being replaced by the web_apps:: system. Bug: 953540 Change-Id: I37314085b1b068b244de46f018bb2138c6a839ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086361 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#746945}
-
Alexandre Frechette authored
TBR=ganesh@chromium.org Bug: 1058506 Change-Id: I3f10b57b4ae355714514bfef225536316ec408e8 Tbr: ganesh@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088019 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by:
Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#746944}
-
Rainhard Findling authored
* Defines dark mode colors for red and blue safety check icons * Screenshots: * Parent: https://screenshot.googleplex.com/LyPcX9YbWWT * Children: https://screenshot.googleplex.com/yN8qJgi6xrg Bug: 1056177 Change-Id: I63605f1ea085b8dfa0b040279bf5a38287c4cb92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080252 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#746943}
-
Nina Satragno authored
Pull calls to simulate_press_callback on virtual fido devices up to SimulatePress() and bail out if |this| has been destroyed. This fixes a potential crash if the device is destroyed from the callback. Fixed: 1057809 Change-Id: I1c3f190ba4d36b90c48173c7b3b9c9c2ab85edd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085531Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#746942}
-
adamta authored
Filter out any event or metric in ukm.xml that has an <obsolete> tag. Remove <obsolete> tags from in ukm.xml for metrics still being referenced. Bug: 1055550 Change-Id: If6538ecd87ddc6a8456c40fe08edd61c77664c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083603 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#746941}
-
Jonathan Backer authored
Bug: 1019787 Change-Id: I82cfdc3c76d0c7e1ef9a9a9939aa8b209ff9dd7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087428Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#746940}
-
Eugene Zemtsov authored
Make sure that fullscreen video playback is detected, even if the aspect ratio of a video is different from the screen's aspect ratio. The change was tested with automatic tests and manually on the 3 most popular video sites. Bug: 1044666, 1056123 Change-Id: If8fb513a86a0e24867f6e448461d93d3e682e928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065729 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#746939}
-
Tim Song authored
BUG=1040648 Change-Id: Id80e1353568d5f3d40d15618edf4f61989d5d754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082362Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#746938}
-
zhaoyangli authored
Enable users pass any arguments to EG2 test when launching or relaunching the host app in EG2 tests. Bug: 1057813 Change-Id: I7589d7065b086484d3f5789e17ee9d1320da7e77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084070 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#746937}
-
Xiaocheng Hu authored
Design doc: https://bit.ly/36E8UKB This patch introduces the following logic, so that preloaded fonts have a higher chance to meet the first rendering lifecycle: - When <link rel=preload> starts to load a font, register it to FontPreloadManager - FontPreloadManager blocks lifecycle updates if any font is being preloaded - FontPreloadManager resumes lifecycle updates if font preloading finishes, or a short timeout is fired Handling of Font Loading API and 'font-display: optional' will be done by followup patches. Bug: 1040632 Change-Id: Ib58416830156ee8b296b7d9d39e3fea3a50960b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006626Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#746936}
-
Daniel McArdle authored
Bug: 1048210 Change-Id: Ia2ba09cf13fa0db4b6dc68a9d968028cc97831cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081519Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#746935}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/040b65bece28..1c8921b8e2f4 Created with: gclient setdep -r src-internal@1c8921b8e2f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1005076,chromium:1038034,chromium:976428 Tbr: jbudorick@google.com Change-Id: I4b41fb9ac42e10f8199a1e85c30baa55fc86c25c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088254Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746934}
-
ssid authored
This CL moves the tracing agent to services/tracing so that it can depend on perfetto macros. Adds histogram trigger event to the trace. Removes components/tracing target and replaces with "graphics_provider", and remove all unnecessary dependencies. TBR=mseaborg@chromium.org Change-Id: Iae38bef4ac320f9f6a54cb1f20587bb76d766250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067249 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#746933}
-
David Black authored
Previously, as reported in the bug, Assistant Ui was *not* closing in tablet mode. Bug: b:150252578 Change-Id: I3410fa8fcebc13d564f12f84dc7fe731e1e32ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076097 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#746932}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/35645a601a73..e5534c4419d5 git log 35645a601a73..e5534c4419d5 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 enga@chromium.org Add SlabAllocator and tests Created with: gclient setdep -r src/third_party/dawn@e5534c4419d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I3d12259019a33e0c66d331201e8bb2ca61cd5c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088255Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746931}
-
Lan Wei authored
After we finish the scroll unification, the scrolls happens mainly on the compositor thread, and the scroll code in the main thread will be removed. eventSender sends the scroll events to main thread, so it would not work after the scroll unification. We should replace eventSender.continuousMouseScrollBy with gpuBenchmarking.smoothScrollBy in pointer events web-platform tests. Bug: 1047176 Change-Id: Ie88bb707188b701d3f5a99e588fe6cffd3e23194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083852Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#746930}
-
Nektarios Paisios authored
Given the following accessibility tree (notice the space at the end of the text field's value): ++TextField value="testing " ++++StaticText name="hello " ++++++InlineTextBox name="hello" ++++++InlineTextBox name=" " ++Paragraph ++++StaticText name="second line" ++++++InlineTextBox name="second line" And the following text position: AXTextPosition anchor=TextField offset=6 text="hello <>" Calling AtStartOfLine() and AtEndOfLine() on this position should return false and true respectively, even though the position is equivalent to a position before "second line", because the assistive software is trying to determine the presence of a line boundary from the purspective of the text field and not of the accessibility tree's text representation which is entirely made up of inline text boxes. In general: To determine whether an inline text box is truly at a line boundary, we need to take into account not only its relation to other inline text boxes, i.e. its kNext/PreviousOnLineId, but also any line boundaries that are created due to a static text parent. R=dmazzoni@chromium.org, kbabbitt@microsoft.com Change-Id: I2dc2819b41a091d8ecac7b6dcda978fc4209db23 Bug: 1057671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082360Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#746929}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4eb885a01e2c..e894e9c5869f git log 4eb885a01e2c..e894e9c5869f --date=short --first-parent --format='%ad %ae %s' 2020-03-04 tvanderlippe@chromium.org Stop rewriting html entrypoints Created with: gclient setdep -r src/third_party/devtools-frontend/src@e894e9c5869f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1046596 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I906c4365a6f143b47be43af40bef0181a338d499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088253Reviewed-by:
-
Anna Malova authored
It expects ChangeCallback which is OnceCallback. Bug: 1007815 Change-Id: I1f6e9c183d70fdaf30c5b27905895b7276bafe8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087589 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#746927}
-
Jeff Yoon authored
This reverts commit d35923c2. Reason for revert: Breaking local test execution for developers. Original change's description: > Reland "generate_wrapper targets for iOS' non-EG/EG2 tests, EG, and EG2 tests" > > This is a reland of 4ed2234c > > TBR=sdefresne@chromium.org > TBR_REASON=Locally verified change build/config/ios/rules.gni no longer > breaks `gclient sync` when target_os_only = True > > Original change's description: > > generate_wrapper targets for iOS' non-EG/EG2 tests, EG, and EG2 tests > > > > The existing iOS recipe utilizes an isolate template, and an > > isolated.gen.json file to fill the template in per test with > > config-variables and path-variables. This isolate template contains > > the command arguments to invoke the iOS test runner. > > > > To support the iOS recipe migration to the Chromium recipe, I use GN to > > generate a script per test target instead of the isolate template. The > > script is pre-baked with arguments to the test runner (run.py). The > > given Swarming task is expected to execute the test by invoking the > > generated script. > > > > Invoking the generated script requires changes to gn_isolate_map.pyl > > for each iOS test target, and thus, these changes are only additive. > > > > * "ios_test_runner_wrapper" template wraps the generate_wrapper target. > > It bakes iOS specific arguments into the script, such that it can > > launch run.py with the given args. > > * ios_eg2_test, ios_eg_test, and test templates have > > been updated to utilize the ios_test_runner_wrapper for iOS targets. > > * mb.py to skip generated_directory check when writing isolates. > > View crbug/ in comments. > > > > Change-Id: I941d37dfdff0bd1ead1baff70907a197fee3fe64 > > Bug: 1055328,912681 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023748 > > Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> > > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > > Reviewed-by: John Budorick <jbudorick@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#745105} > > Bug: 1055328, 912681 > Change-Id: Ib6449bce4b07c8c50b0a59f58fe65caeaa48425f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083379 > Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746479} Change-Id: I2be3612b68c06f9e113f3777d9c339fd60fa410a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1055328, 912681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087416Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#746926}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/589b41e743db..fbc7ed0d7116 git log 589b41e743db..fbc7ed0d7116 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 02cf6c70..8d9e658d (746692:746798) 2020-03-04 ilnik@webrtc.org Enable quality scaler for simulcast and SVC if only one stream is active Created with: gclient setdep -r src/third_party/webrtc@fbc7ed0d7116 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibe2797c5d16a0801db6f0526ae6252b26db376ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088256Reviewed-by:
-
Nick Diego Yamane authored
This should help us to determine what exactly caused XWindow destruction during DelayedResize closure execution so that we can propose a proper fix to it. R=gab@chromium.org Bug: 1021490 Change-Id: Ie8e18d47b4c08d3c8aaf89d4f6dbf230f5c41b7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087664 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#746924}
-
Xiaohui Chen authored
This reverts commit 6a1b1ed5. Reason for revert: seems to cause podcast playback issues. Original change's description: > Reland "assistant: add audio ducking for internal media" > > This is a reland of f7860793 > Fix original build error and some additional refactoring. > > Original change's description: > > assistant: add audio ducking for internal media > > > > Bug: b/135064564 > > Test: locally build and run with multiple media playing > > Change-Id: I3814cfc3bc619077ca6781493fd369c27d50eb4e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899184 > > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > > Reviewed-by: Tao Wu <wutao@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#713200} > > Bug: b/135064564 > Change-Id: Ief51c008cb8dba3e6ae4757405c69fca01a94524 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903755 > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739453} TBR=xiaohuic@chromium.org,wutao@chromium.org Bug: b/135064564 Change-Id: I7a0c27554af154aa15d4ef3f368bc2a0b15ca7dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088220Reviewed-by:
-
Fredrik Söderquist authored
When StyleDidChange is called we're guaranteed to have a style object attached, so we can just use StyleRef() without checking. Also turn the ternary expression into a logical and for the similar check on the (potential) old style. Change-Id: Ic0ba51a265442e2c67cd4c718e98b42e90bb060a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087919 Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#746922}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ia56da988faa32212949b824876ba7f9f10295c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088214Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#746921}
-
Sigurdur Asgeirsson authored
Bug: 1056188 Change-Id: Idf49bdbff19b234cbd033b7fbb5265aa32c78194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083055 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
-
Eugene But authored
Use the following format: Switch [from Tab<id>] [to Tab<id> at 0] Old example: Activated Tab1 for user action Tab-1 at -1 New example of the same log: Switch to Tab1 at 0 #user-action Do not log events unless WebState activation was triggered by tab switch (the rest of activation reasons are covered by other WebStateListObserver callbacks). Bug: 1046231 Change-Id: I1c8657de6813bc62a719fed7add55211f9e6ffeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084151Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#746919}
-
Anna Malova authored
- Convert CreateDataCallback - Convert CreateUploadStreamCallback Bug: 1007815 Change-Id: If3b72b4ce85cf7bf7c808a38f8a54b4a496445ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088096 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Nick Diego Yamane authored
This is an attempt to fix or at least mitigate crash https://crbug.com/1021490. A base::WeakPtr is used in to bind XWindow::DelayedResize task to delayed_resize_task_, which is a CancelableCallback, which is not needed and potentially make it harder to understand the aforementioned crash. So use base::Unretained() instead of WeakPtr in that case. Additionally, dcheck Close() is called before XWindow's dtor. Bug: 1021490 Change-Id: Ibf8b2f185dc020258905f6bf5e26305c51e7a215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917079 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bbd4f3e6052c..16f581398d7d git log bbd4f3e6052c..16f581398d7d --date=short --first-parent --format='%ad %ae %s' 2020-03-04 chonggu@google.com [Telemetry] Change fuchsia_output_dir to fuchsia_ssh_config_dir for better clarity. Created with: gclient setdep -r src/third_party/catapult@16f581398d7d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1058255 Tbr: wenbinzhang@google.com Change-Id: If00db40ca541b33e90ad43c5210be7903b0ac0b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087949Reviewed-by:
-
Anastasia Helfinstein authored
Also removed a TODO, as the code no longer polls for the back button. Bug: None Change-Id: I167aca4a6e98ae7537bca431e33973a45dbf256d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071040 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#746915}
-
chrome://extensionsArchana Simha authored
Records Extensions.Checkup.TimeSpent when the ExtensionsCheckup feature is disabled so that we can compare the behavior of the experiment and control groups. Bug: 1034541 Change-Id: I58213193bc4d24ba1a2c832c69885fd62ed882e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083744Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Archana Simha <archanasimha@chromium.org> Cr-Commit-Position: refs/heads/master@{#746914}
-
Ahmed Mehfooz authored
There is currently no way to close notifications in tablet mode with chrome vox enabled. Bug: 1022595 Change-Id: Ia7fcfa5139bed04cfc465e2342b0938b6431c89f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072910 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
-
Ken Rockot authored
Missed this bot in r746454, which added the same tests to Windows and Chrome OS FYI bots. Bug: 1052045 Change-Id: I5096307255c6534b3e3f97158988c7ccc9144e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085842 Auto-Submit: Ken Rockot <rockot@google.com> Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#746912}
-
