- 27 Aug, 2018 40 commits
-
-
Armando Miraglia authored
Looking at the referenced bug (crbug/338503) it looks like this comment is outdated since the spec was already implemented. This CL removes the comment. BUG=338503 Change-Id: Id986c398ea59ea1d50c0835567a160b900769cd0 Reviewed-on: https://chromium-review.googlesource.com/1188566Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#586242}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/420696961c8c..e00fe30b8fe7 git log 420696961c8c..e00fe30b8fe7 --date=short --no-merges --format='%ad %ae %s' 2018-08-27 reed@google.com remove SkIPoint16 from documentation -- it is private Created with: gclient setdep -r src/third_party/skia@e00fe30b8fe7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I2dc3b8bdcd4944b435980ac6eb01e1ea2565337d Reviewed-on: https://chromium-review.googlesource.com/1190004Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586241}
-
Jinho Bang authored
The following pattern is wrong in browser tests: ResetEventWaiter(...); RetryPaymentRequest(...); WaitForObservedEvent(); The first line in the pattern is unmeaningful because the RetryPaymentRequest(...) helper method has already ResetEventWaiter() and WaitForObservedEvent() internally. So, this patch makes the helper method take DialogEvent and wait for the event internally. Bug: 861704 Change-Id: I94495cb0f0ed2369a08f49d1065571fa02251a00 Reviewed-on: https://chromium-review.googlesource.com/1189662Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#586240}
-
Alexander Hendrich authored
This CL adds handles the status code 417 from DMServer on an enrollment request, which occurs when the user has a packaged license and tries to enroll with a consumer account. The new error message hints the user to create an admin console. Bug: 871203 Change-Id: I9ddf696a252809f80104502b6df6744b1620e009 Reviewed-on: https://chromium-review.googlesource.com/1180961Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#586239}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ifb2bad243924f0260802a3b01cf6813b7dc23ae3 Reviewed-on: https://chromium-review.googlesource.com/1189344 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586238}
-
Eriko Kurimoto authored
This UI allows users to know the type of log (speech, event..) easily. Bug: 874349 Change-Id: Ia525731a02752fbc5fa9a29a6aeeeea55c66d2df Reviewed-on: https://chromium-review.googlesource.com/1179116 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Yuki Awano <yawano@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#586237}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c02e02c4. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23499 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I442cd02cdae8c7c0c525442d6820950976d1c7ef Reviewed-on: https://chromium-review.googlesource.com/1188498 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#586236}
-
Jan Wilken Doerrie authored
This CL modifies AddTypedEventHandler to post its tasks instead of running them immediately. This guarantees that events are received on the same thread an event handler was created on, and closer resembles production environments in tests. Bug: 821766 Change-Id: I7859a2566adf304c835b5a3982725bb4069007fc Reviewed-on: https://chromium-review.googlesource.com/1188904Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#586235}
-
Scott Wu authored
Note: In order to provide __crWeb.passwords, looks like the password_controller.js file needs to be included in js_compile targets as source file. Bug: 865114 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9a2447259247c58a86b36a354737fdd7ab1fa443 Reviewed-on: https://chromium-review.googlesource.com/1168959Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Scott Wu <scottwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#586234}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/13f46245..dcad91db Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I35ab516e8a672b3bf0adb85f4bc321f204c74ed8 Reviewed-on: https://chromium-review.googlesource.com/1188499Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586233}
-
Stephan Herhut authored
Changes the v8 binding to propagate the custom v8 deleter for array buffers into blinks internal DataHandle object. Also, always use deleters, regardless of reservation mode. As a follow-up, reservation mode and corresponding data can now be removed. Bug: v8:8073 Change-Id: I6db795d5a4f19ee0cea727a54d9085ff2ba5b5dc Reviewed-on: https://chromium-review.googlesource.com/1186333 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#586232}
-
Yoshifumi Inoue authored
This patch adds const modifier to member variables in |NGPhysicalFragment| for improving readability. Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I39f838aeb4f61ca4fe262056f22f0e772f1d86a2 Reviewed-on: https://chromium-review.googlesource.com/1186219Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#586231}
-
Hajime Hoshi authored
This is part of efforts to replace per-thread task runner usages with per-frame task runners. We tried to replace legacy IPC with Mojo first, but failed due to a message order issue (see https://chromium-review.googlesource.com/c/chromium/src/+/1174341/2/content/common/frame.mojom#65). Until this problem is solved, just replacing the task runner at the accepting side would work. Bug: 856568 Change-Id: I57f067cd34638eba6fd8bcce29e23e79c6ee7490 Reviewed-on: https://chromium-review.googlesource.com/1184739 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#586230}
-
Yoshifumi Inoue authored
This patch changes |ElementInnerTextCollector::ProcessNode()| to check object type before casting to |LayoutTableCell|. The issue is caused by |LayoutSVGRect|'s computed style of "display" property is "table-cell". This patch is follow-up of the patch[1] to fix the bug found by Cluster Fuzz. [1] http://crrev.com/c/1114673 Implement Element#innerText to conform the spec Bug: 877470 Change-Id: I8bf833c66770f1f0dbace7c45bc22f6a5c0cfa26 Reviewed-on: https://chromium-review.googlesource.com/1189262 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#586229}
-
Alan Cutter authored
This CL fixes color inconsistency between the title and the caption buttons on Windows 10 when theme colors are used in PWA windows. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=354609&signed_aid=XZviD7H5PrdO2M-73ui7Tw==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=354795&signed_aid=Av8_PIND8_gosBPPahgKFw==&inline=1 Bug: 872118 Change-Id: I7dcc27aa480ca43746ca65bb8a60561d99e47e99 Reviewed-on: https://chromium-review.googlesource.com/1186929Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#586228}
-
Elad Alon authored
TBR=grunell@chromium.org Bug: 775415 Change-Id: I272edfe82cdd3ae296251905f3e36b9611d63f44 Reviewed-on: https://chromium-review.googlesource.com/1162325 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Elad Alon <eladalon@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#586227}
-
Vasilii Sukhanov authored
Bug: 874029 Change-Id: I24d337bb04becf16f8f67d1f143129ccac8624cd Reviewed-on: https://chromium-review.googlesource.com/1186900 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#586226}
-
Tobias Sargeant authored
TBR: jinsukkim@chromium.org Bug: 877918 Change-Id: I73811d10e7c7e3af1ded812178424d69298d40f7 Reviewed-on: https://chromium-review.googlesource.com/1189863 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#586225}
-
Eriko Kurimoto authored
Change-Id: Ia527aeb71f894bfc0e4bac21abd9b951cd8fe568 Reviewed-on: https://chromium-review.googlesource.com/1184802 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Yuki Awano <yawano@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#586224}
-
Noel Gordon authored
Most tests herein are promise-based. Having a few tests in StepsRunner is not great. Let promises win in this file. Bug: 877557 Change-Id: Ia063d4218e4e1c27957beac2fa3f850532eb4f64 Reviewed-on: https://chromium-review.googlesource.com/1189586Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#586223}
-
Yoshifumi Inoue authored
This patch changes |ElementInnerTextCollector::IsAfterWhiteSpace()| to use |IsInlineTextBox()| instead of |InlineBox::IsText()| to detect |InlineTextBox| type properly. Note: |InlineBox::IsText()| is used for handling <br> in quirk mode, and list marker. This patch is follow-up of the patch[1] to fix the bug found by Cluster Fuzz. [1] http://crrev.com/c/1114673 Implement Element#innerText to conform the spec Bug: 877498 Change-Id: I484a93afba351b74a8b3cae0c6736e3ccdfde45d Reviewed-on: https://chromium-review.googlesource.com/1189242Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#586222}
-
Victor Costan authored
This is needed to fix cronet_unittests_android on the android_cronet_tester bot after https://crrev.com/c/1187783. TBR=mef Bug: 877868, 875486 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Change-Id: If59e993e3e6b19cb54f04c2259014c34d6ad4592 Reviewed-on: https://chromium-review.googlesource.com/1189712Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#586221}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/efbcb31cb67e..1946a3f0fe2c git log efbcb31cb67e..1946a3f0fe2c --date=short --no-merges --format='%ad %ae %s' 2018-08-26 ssilkin@webrtc.org Add frame rate parameter to SpatialLayer struct. 2018-08-24 peah@webrtc.org AEC3: Add state-specific suppressor behaviors 2018-08-24 benwright@webrtc.org Adds support for JSON config in video_replay. 2018-08-24 aleloi@webrtc.org Optionally disable digital adaptive AGC2. 2018-08-24 magjed@webrtc.org Fix a bug in barcode_decoder.py 2018-08-24 brandtr@webrtc.org Add VideoEncoder::Settings::numberOfSimulcastStreams. 2018-08-24 magjed@webrtc.org Reland "Update video_quality_analysis to align videos instead of using barcodes" 2018-08-24 magjed@webrtc.org Revert "Update video_quality_analysis to align videos instead of using barcodes" 2018-08-24 mbonadei@webrtc.org Remove unused include of <android/log.h>. 2018-08-24 ilnik@webrtc.org Enable video adaptation for all screenshare content 2018-08-24 gustaf@webrtc.org AEC3: Removing more dead code from the suppressor 2018-08-24 jonaso@webrtc.org Add support for enabling simulcast in "Plan B" using MediaConstraints. 2018-08-24 magjed@webrtc.org Update video_quality_analysis to align videos instead of using barcodes 2018-08-24 ilnik@webrtc.org Add unlimited retransmission experiment for screenshare 2018-08-24 phoglund@webrtc.org Remove client.webrtc.branches. 2018-08-24 kthelgason@webrtc.org Remove assumption that all video codecs are known. 2018-08-24 asapersson@webrtc.org Change some pointers to std::unique_ptr in rtp_rtcp tests. 2018-08-24 buildbot@webrtc.org Roll chromium_revision c86aa801..ca3a5e1c (585622:585726) 2018-08-24 gustaf@webrtc.org AEC3: Removing old suppressor logic 2018-08-24 peah@webrtc.org Adding quiet mode for audioproc_f 2018-08-24 zstein@webrtc.org Support domain name ICE candidates 2018-08-23 buildbot@webrtc.org Roll chromium_revision 607c2083..c86aa801 (585516:585622) 2018-08-23 ouj@fb.com The default logic for creating video bitrate allocator. 2018-08-23 mbonadei@webrtc.org Revert "Reland "Enable any address ports by default."" 2018-08-23 zstein@webrtc.org Ad-hoc rate limiting for UDPPort::SendTo failures. 2018-08-23 magjed@webrtc.org Android PeerConnectionFactory: Build without video codecs by default 2018-08-23 steveanton@webrtc.org Add steveanton to WATCHLISTS for api/ and pc/ 2018-08-23 buildbot@webrtc.org Roll chromium_revision bd84ccec..607c2083 (585399:585516) 2018-08-23 magjed@webrtc.org Add tool for aliging video files 2018-08-23 ssilkin@webrtc.org Write scalability structure in flexible mode. 2018-08-23 gustaf@webrtc.org Correct audioproc_f to support the new echo canceller activation III 2018-08-23 yinwa@webrtc.org Fix flaky test TestFlexfecRtpStatePreservation. 2018-08-23 gustaf@webrtc.org AEC3: Removing the coherence computation 2018-08-23 nisse@webrtc.org Delete unneeded includes of rtp_payload_registry.h 2018-08-23 magjed@webrtc.org Remove SequencedTaskChecker from Y4mFileReader 2018-08-23 titovartem@webrtc.org Remove temporary SetConfig method from NetworkSimulatioInterface. 2018-08-23 peah@webrtc.org AEC3: Adding the option for applying a fixed delay to the capture signal 2018-08-23 magjed@webrtc.org Add Y4mFileReader 2018-08-23 titovartem@webrtc.org Remove old sigslot.h header 2018-08-23 nisse@webrtc.org Delete almost all use of MediaConstraintsInterface in the PeerConnection API 2018-08-23 mbonadei@webrtc.org Add //test:fileutils_unittests to //test:test_support_unittests deps. 2018-08-23 gustaf@webrtc.org Correct audioproc_f to support the new echo canceller activation II 2018-08-23 buildbot@webrtc.org Roll chromium_revision 6f37604c..bd84ccec (585288:585399) 2018-08-23 buildbot@webrtc.org Roll chromium_revision 07be93b6..6f37604c (585077:585288) 2018-08-22 tkchin@webrtc.org Add didRemoveReceiver delegate callback. 2018-08-22 buildbot@webrtc.org Roll chromium_revision ab3ab1ba..07be93b6 (584945:585077) 2018-08-22 lizeb@chromium.org Fix VideoSendStreamImpl::OnPacketFeedbackError: operator precedence. 2018-08-22 nisse@webrtc.org Delete deprecated methods on AudioCodingModule 2018-08-22 nisse@webrtc.org Eliminate NackModule dependency on VCMPacket 2018-08-22 titovartem@webrtc.org Eliminate methods SetConfig() from DirectTransport and FakeNetworkPipe 2018-08-22 ilnik@webrtc.org Revert removal of simulcast screenshare experimental code (killswitch checks) 2018-08-22 srte@webrtc.org Adds start bitrate handling to task queue congestion controller. 2018-08-22 ilnik@webrtc.org Reland "Move FakeCodec to separate target and behave like real encoder." 2018-08-22 srte@webrtc.org Avoids posting tasks in congestion controller. 2018-08-22 mbonadei@webrtc.org Add Chromium default values for rtc_exclude_field_trial_default. 2018-08-22 nisse@webrtc.org Enable --rtc_event_log_name flag for more tests. 2018-08-22 mbonadei@webrtc.org Reland "Enable any address ports by default." 2018-08-22 nisse@webrtc.org Fix NACK logic for empty packets 2018-08-22 emircan@webrtc.org Disable flaky TestFlexfecRtpStatePreservation 2018-08-22 koloskova@webrtc.org Network & bitrate controllers are added for PCC. 2018-08-22 kwiberg@webrtc.org Audio encoder tests: Create audio encoders the new way 2018-08-22 qingsi@webrtc.org Revert "Reland "Enable any address ports by default."" Created with: gclient setdep -r src/third_party/webrtc@1946a3f0fe2c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:690537,chromium:877279,chromium:none,chromium:None,chromium:None,chromium:856088,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:690537,chromium:none,chromium:None,chromium:875391 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I201d39e11331d6b91c327b49d7be7589947b5a65 Reviewed-on: https://chromium-review.googlesource.com/1188496Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586220}
-
Max Morin authored
We're having some awkwardness with working around the issue with stuff like std::atomic<int64_t> and conversions back and forth. It would be preferable to use std::atomic<TimeDelta> directly. Removes the workaround added for bug 635974, since that was a bug in vs 2015 and we use clang now. Also fixes a couple of lint issues in time.h. Bug: 635974, 851959, 761570 Change-Id: I4683f960b0c348748c5f0aaf222da4dda40256ec Reviewed-on: https://chromium-review.googlesource.com/1184781 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#586219}
-
Koji Ishii authored
1. Padding for atomic inline isn't used. Removed computing it. 2. Both converting to NGBoxStrut and then to NGLineBoxStrut should use the same writing-mode. Added ng_length_utils functions for the two conversions to occur at the same place. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I3deace37ae5334af0f919d4c557effe067328da9 Reviewed-on: https://chromium-review.googlesource.com/1181004 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#586218}
-
Kunihiko Sakamoto authored
Bug: 803774 Change-Id: If049ec90db90587d3e7ed0fb5060ef43888a1ee8 Reviewed-on: https://chromium-review.googlesource.com/1188733Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#586217}
-
Eriko Kurimoto authored
logs in LogStore is taken always, so adding log process must be fast. In this patch, a ring buffr is implemented. It takes O(1) time to add a log while Javascript shift() takes O(n) time. As a benchmark: 1550ms in average for writeLog 10e+7 times in prior patch. 700 ms in average for writeLog 10e+7 times in this patch. Bug: 874349 Change-Id: I49455787ecbf92583b5f63e838d7970783dc776d Reviewed-on: https://chromium-review.googlesource.com/1179432 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#586216}
-
Alan Cutter authored
The position of the hosted app menu button was moved accidentally by https://chromium-review.googlesource.com/c/chromium/src/+/1183019. This CL fixes the incorrect y offset used for Windows 7. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=354844&signed_aid=ABFeIzothXglSH0Jji074A==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=354845&signed_aid=0q4hc-ELfn8qErN1FZ9KlQ==&inline=1 Bug: 877880 Change-Id: Ie90a49df72dea040c3d7224b9dfd1ee6aaabf8c4 Reviewed-on: https://chromium-review.googlesource.com/1189247Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#586215}
-
Kent Tamura authored
This CL reduces pre-processed size of event_path.h by 3.29MB. Bug: 242216 Change-Id: I96fbd9d53158529243ff6a1b2e807058fb05430e Reviewed-on: https://chromium-review.googlesource.com/1189517Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#586214}
-
Olivier Robin authored
This CLs allows to create objects with a lifetime linked to a WebFrame lifetime. Note that this lifetime is far shorter than the WebState lifetime (which persist on navigations). Bug: 851636 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1921ecb6cfbefc09f8608ca6bedd85f1733766e4 Reviewed-on: https://chromium-review.googlesource.com/1152734 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#586213}
-
Eriko Kurimoto authored
The way to store logs and filter output is general in this patch. Other log type can be easily implemented. In future, console.log output will be removed. Bug: 874349 Change-Id: I4c54869cb23a700cccf6e9f8426c168d7bcf334f Reviewed-on: https://chromium-review.googlesource.com/1177205Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#586212}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/51e736ca..13f46245 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I93d22d97bf1bab0f58c2a9b5483384eaa3b42ebb Reviewed-on: https://chromium-review.googlesource.com/1189553Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586211}
-
Trent Apted authored
r586060 added suppressions for Win7 but these flake on Mac as well. TBR=foolip@chromium.org Bug: 877104 Change-Id: Ic2f72440b1194ab493c165882d9bc50455eb53fc Reviewed-on: https://chromium-review.googlesource.com/1189509Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#586210}
-
Noel Gordon authored
Most tests herein are promise-based. Having a few tests in StepsRunner is not great. Let promises win in this file. Bug: 877557 Change-Id: I0f778870684d3e55f038c1a5317f5c86983e747c Reviewed-on: https://chromium-review.googlesource.com/1189269 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#586209}
-
Sam McNally authored
The file manager integration tests currently have no coverage for offline Drive. Add tests to ensure the file chooser dialog allows the selection of Drive files that are available offline while offline. These tests only run with DriveFS enabled due to the lack of controls available to set up the test scenarios with the existing Drive sync client. Bug: 876973 Change-Id: I81e39fba868a073fd82a457004700bb0ebb566ec Reviewed-on: https://chromium-review.googlesource.com/1189515 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#586208}
-
Gabriel Charette authored
R=grt@chromium.org https://chromium-review.googlesource.com/c/chromium/src/+/1178889 Bug: Shouldn't need an extra base OWNER for CLs like Change-Id: I3bfc9de274b7843a714b94b3b9e2dc74890fd88f Reviewed-on: https://chromium-review.googlesource.com/1188486Reviewed-by:Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#586207}
-
Trent Apted authored
Its comparator was rubbish and always has been. Array.prototype.sort() takes a function that should return {-1, 0, 1}, not bool. TBR=benwells@chromium.org Bug: 877890 Change-Id: I65162d2b261ad4ff91a028bf62c0cdcfb765df27 Reviewed-on: https://chromium-review.googlesource.com/1188736Reviewed-by:Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#586206}
-
Noel Gordon authored
Load only the file needed for the test (for speed and simplicity), use appId, document each test step. Bug: 877557 Change-Id: I70a82b5334047587c5b426639347bf42c33d391d Reviewed-on: https://chromium-review.googlesource.com/1188734Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#586205}
-
Yuichiro Hanada authored
This is a reland of a0f6eb42. It was reverted by Findit in crrev.com/c/1188826, but the revert didn't fix the broken tests and another change fixed them. Bug: 845079 TBR=yusukes@chromium.org,michaelpg@chromium.org Original change's description: > Allow to use ARC IMEs only in tablet mode. > > This CL also changes InputMethodManagerImpl and language settings api to > allow ArcInputMethodManagerService to restrict ARC IMEs. > > Bug: 845079 > Test: Ran on DUT and unit tests. > Change-Id: I61516b3c6a65775f42aae7e51583e933d55ab1b6 > Reviewed-on: https://chromium-review.googlesource.com/1179733 > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586121} Change-Id: I7f74b93c3a246f4c7379b1c3c1dd6eb349effc22 Reviewed-on: https://chromium-review.googlesource.com/1189268Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#586204}
-
Tatsuhisa Yamaguchi authored
Shows buttons when swipe control is opened by horizontal scroll of a notification box. The buttons triggers same action just like the existing control buttons inside MessageView for mouse. Test: ash_unittests --gtest_filter=MessageCenterViewTest.*:MessageListViewTest.* Test: manual Bug: 840497 Change-Id: I6ab456cda8dd1f2de5c885e9c28492bf00ac8cd3 Reviewed-on: https://chromium-review.googlesource.com/1188044 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#586203}
-