- 23 Jan, 2020 40 commits
-
-
Sigurdur Asgeirsson authored
Keeping track of the average write rate on the instrumented message pipe will allow reasoning on whether there's a spurt of messages coming through, or whether the unread quota protocol implementation is stalling somehow. Likewise the additional cumulative counts and the lifetime will shed some light on the usage of the abused interfaces. Bug: 1011441 Change-Id: I9e3d2b1fcfe2a264208108d2c7ff3cdc4dd11e22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013480 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#734528}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/10e83a92760c..b04d7c55bff1 git log 10e83a92760c..b04d7c55bff1 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 petermarshall@chromium.org Only call Debugger.setAsyncCallStackDepth while debugger is enabled 2020-01-23 aerotwist@chromium.org [Global] Update refs to Persistence.isolatedFileSystemManager 2020-01-23 tvanderlippe@chromium.org Migrate sdk/ to import cross-module 2020-01-23 aerotwist@chromium.org [Global] Update refs to UI.viewManager & UI.zoomManager 2020-01-23 tvanderlippe@chromium.org Migrate workspace/ to import cross-module Created with: gclient setdep -r src/third_party/devtools-frontend/src@b04d7c55bff1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1010534 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4969fe4faca21c6a8e788dd98b9dfbc0b1de9302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016286Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734527}
-
Saman Sami authored
Adds CheckOverlayCapabilitiesSync() that returns the result synchronously rather than running a callback. Add a base::Feature that determines whether to use the synchronous or asynchronous API. The synchronous API simply blocks on the DrmThread to run the test. We will monitor the metrics to see if this approach is sufficiently performant. Bug: 1034559 Change-Id: Ib90132e984d007064f8f6e91a462c0e227da172f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013465 Auto-Submit: Saman Sami <samans@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#734526}
-
Qingsi Wang authored
Bug: None Change-Id: I47cb1a453705043b7d273bb1f649447c1ac5e18f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015650Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Qingsi Wang <qingsi@chromium.org> Cr-Commit-Position: refs/heads/master@{#734525}
-
Egor Pasko authored
The usage of the flag was removed in crrev.com/719331. I planned to remove the declaration of the flag separately to make reverts smaller, but forgot to remove it in the end. Do it now. Bug: 1028600 Change-Id: Ia2cb8bd18389c25e440c2c95773b4c49ce120d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017405 Commit-Queue: Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Auto-Submit: Egor Pasko <pasko@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#734524}
-
Peter Wen authored
This a simple upgrade of an existing public Google library (http://errorprone.info/) from version 2.3.3 to version 2.3.4. It pulls in error prone's new maven dependencies and removes the ones that error prone has removed. Also fixes some of the new issues that were exposed by the new checks. Bug: 1030676 Change-Id: I2f76601befe4575bb19588a1c701c0bb73170c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953863Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#734523}
-
Jan Wilken Dörrie authored
This change moves PasswordAccessAuthenticator and ReauthPurpose from //chrome into //components, performs some code clean ups and improves the tests of PasswordAccessAuthenticator and PasswordsPrivateDelegateImpl. Bug: 1019174 Change-Id: I13d6ee5486169b9072536fb753c30efcdaa0f81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887812Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#734522}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-foundation/material-roboto-font-loader-ios/+log/4aa51e906e56..bc63eabbbd1e git log 4aa51e906e56..bc63eabbbd1e --date=short --first-parent --format='%ad %ae %s' 2019-04-10 rsmoore@google.com Revert "Remove unneeded fonts and unhint others. (#17)" (#19) 2019-04-10 rsmoore@google.com Revert "Remove extra `self = [super init]`. (#15)" (#18) 2019-04-10 dmaclach@gmail.com Remove unneeded fonts and unhint others. (#17) 2019-04-10 ccrazy88@users.noreply.github.com Remove extra `self = [super init]`. (#15) Created with: gclient setdep -r src/ios/third_party/material_roboto_font_loader_ios/src@bc63eabbbd1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/material-roboto-font-loader-ios-chromium Please CC bling-p10-rolls@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:ios-internal-mdc Bug: None Tbr: bling-p10-rolls@google.com Change-Id: I9c7c13f415582f3d204c8246703cf320f31ad44b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016866Reviewed-by:
-
Maksim Ivanov authored
This fix part 2/2 for the bug with the bad spinner being displayed after the end of the SAML login. This suppresses the ease-in/ease-out animations of the Gaia frame in case the SAML login was just performed. The animations are unwanted in this case, because they would lead to weird UI - two spinners displayed at the same time during the animation (one is the screen-gaia-signin's own spinner, and another is the Gaia's /programmatic_auth_chromeos one). Bug: 1024253 Change-Id: Ic4f7077c99d16d02324f22a3b15204e46e311643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000703Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#734520}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/00a30873c415..cdd73e095cd4 git log 00a30873c415..cdd73e095cd4 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 titovartem@google.com Migrate PC level tests on new video codec configuration API 2020-01-23 eshr@google.com Remove unused field trial WebRTC-InitialFramedrop Created with: gclient setdep -r src/third_party/webrtc@cdd73e095cd4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id2eac77ccdd71bce01a9da34ccd6feda1d029cf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017065Reviewed-by:
-
chrome://omniboxmanukh authored
We previously considered persisting all inputs, but decided to hold off because 1) it would make asking users to extract data more error prone, and 2) having options to 'reset inputs' and 'toggle persistence' would be too complicated. Since then, I've come into the habit of 1) open chrome://omnibox, 2) enable 'connect window to omnibox', 3) enable 'thin rows', and then 4) type my input. This becomes cumbersome when opening multiple chrome://omnibox tabs, e.g., to compare results. To satisfy both requirements, this CL persists display options only. Since query inputs aren't persisted, the extracted JSON won't be affected, and 'reset inputs' and 'toggle persistence' options won't be required. Change-Id: I8b2f4d17ce840f6b4d1cec4df8b446122b7e28eb NOTRY=true To skip android-binary-size bot due to a bug (crbug.com/1045024). Other try-bots have passed. Change-Id: I8b2f4d17ce840f6b4d1cec4df8b446122b7e28eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002983 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#734518}
-
sczs authored
- Updates the error state on editable cells for SaveCardTableVC whenever an invalid value has been entered. This is done whenever the TextField value is updated or it loses focus. - Changes TableViewTextEditItems so the error icon is displayed even if the cell is being edited. - Adds the correct Item Type to each of the TableViewTextEditItem, they were incorrectly all set to ItemTypeCardExpireYear. Bug: 1029067 Change-Id: Icc076695710ac0ddadab2f4d8949686e5287321e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007256Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#734517}
-
bttk authored
This check accidentally prevents package-private declarations of annotations. Change-Id: I7516f653d8b75ed82bb82c975586301f7fcb360a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014050Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#734516}
-
Tim Volodine authored
Currently committed safebrowsing interstitials are not supported in weblayer. This patch adds this support and tests. In this patch: - add support for committed interstitials for safebrowsing in weblayer (i.e. when kCommittedSBInterstitials is enabled). - add SafeBrowsingBlockingPage and SafeBrowsingNavigationThrottle - make SafeBrowsingBrowserTest work when kCommittedSBInterstitials feature is enabled. - parameterize tests to run both with committed interstitials and non-committed interstitials. BUG=1042662 TBR=vakh@chromium.org Change-Id: I5f732c1f0c2c6c09b2041ea0a7c8d41e81bce9d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003857 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#734515}
-
Anastasiia Nikolaienko authored
If child user has secondary accounts, the IsChild profile property will be set to false after removal of any account. Fix this by checking if the removed account is a primary account in OnExtendedAccountInfoRemoved method. Bug: 1043108 Change-Id: Ia9038932bb3baff8ae69a46675b5a995e3294826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015161Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#734514}
-
Shimi Zhang authored
Currently DeleteSelectionCommand accept a VisibleSelection as the parameter, which is not necessary in many places. This CL converts the VisibleSelection |selection_to_delete_| to SelectionForUndoStep. So we could avoid canonicalization. This enables us to avoiding to use VisibleSelection::CreateWithoutValidationDeprecated() later. Bug: 1024738 Change-Id: I4b32507afca4e77338e9f6a83c01b3a30ea3b188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013905Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#734513}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/68125d909621..ef832e92773a git log 68125d909621..ef832e92773a --date=short --first-parent --format='%ad %ae %s' 2020-01-23 fancl@chromium.org Simplify some part of the E-Divisive Created with: gclient setdep -r src/third_party/catapult@ef832e92773a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nuskos@google.com Change-Id: I053584685427e7cd9f696df2495124348fadc221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016877Reviewed-by:
-
Olga Sharonova authored
TBR=miu@chromium.org Bug: 1043812 Change-Id: I33211652636fd47c034e516aca438ee46240c99d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015057Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#734511}
-
Maksim Ivanov authored
Provide test coverage for the scenario where a new user authenticates via SAML using a smart card (or, generally speaking, using a security token via an extension using the chrome.certificateProvider API). This also provides some test coverage for the <security-token-pin> Polymer element used on the Login Screen. Bug: 1033936 Change-Id: I5ded32e0570eb7227c77b954c33d12c1a8a62914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968989Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#734510}
-
sczs authored
https://crrev.com/c/1996167 introduced a refactoring to infobar_translate_vc that broke this functionality, this CL fixes that by making the call to the right object. Bug: 1043094 Change-Id: I4ba6f804f91697c24264fec09584acd1c7a32a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015801 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
Nico Weber authored
Bug: 1015315 Change-Id: Ia34164d1bee32f7b217300b7afdf0dfb00682352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016843 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#734508}
-
Oriol Brufau authored
r732549 added a NoneContentData for representing 'content: none'. But due to a typo, instances of that class were considered to equal any ContentData instance. That caused problems when changing 'content' dynamically. This patch fixes the problem. BUG=1044869 TEST=external/wpt/css/css-content/element-replacement-dynamic.html Change-Id: If7532d1f859dcaa11b360c02709693b766286fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014910Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#734507}
-
Maya Lekova authored
This is a partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/2010843. Since V8ConcurrentInlining is enabled in the Future variants, we want it disabled by default to be able to tell the difference with the enabled variant. Bug: chromium:1031988, chromium:1044485 Change-Id: I8a353a565ec743e8577eebe9d4475469b0138abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014934 Auto-Submit: Maya Lekova <mslekova@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#734506}
-
Colin Blundell authored
This CL changes WebLayer Shell to retain the Fragment instance in order to more accurately model the behavior of WebLayer consumers. As part of this change, WebLayer Shell no longer handles rotation/resize internally in its manifest and loads the startup url on weblayer creation only if there is not already a navigation entry in the current Tab. Note that to test rotation in an emulator it is necessary to turn on autorotation, which is off by default in crow. Change-Id: I8a575e477d1242486f9fbbe72151392b597b86b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007413Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#734505}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5f411e4e022c..15d104be0c75 git log 5f411e4e022c..15d104be0c75 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 dburger@chromium.org PUpr uprev, fix uprev_ebuild_from_pin. 2020-01-23 lamontjones@chromium.org toolchain: prepare_build support. 2020-01-23 lamontjones@chromium.org Disable HW tests on drallion, puff release builders 2020-01-22 gbiv@google.com artifact_stages: Fix LLVM SHA parsing 2020-01-22 mmortensen@google.com Log warning instead of exception for missing goma stats/counterz files. 2020-01-22 cjmcdonald@chromium.org Update proto definitions Created with: gclient setdep -r src/third_party/chromite@15d104be0c75 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Ia3892778a12569a2f7c621bc06b9f2e971de7e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016873Reviewed-by:
-
sandromaggi authored
Bug: none Change-Id: I1b8e0bbb52e0240075ee00e65020ee871e07118e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015169 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#734503}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e4ddb8a7cddc..87211cd0bad8 git log e4ddb8a7cddc..87211cd0bad8 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 michaelludwig@google.com Add GM for crbug:10141204 Created with: gclient setdep -r src/third_party/skia@87211cd0bad8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC benjaminwagner@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:10141204 Tbr: benjaminwagner@google.com Change-Id: Ic8334974f53e3d3f2eb2a6464a29e9a90716e94b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016875Reviewed-by:
-
Benoît Lizé authored
Using the app zygote is a tradeoff with: - Pros: - Decreased incremental renderer cost - Faster incremental renderer startup - Cons: - 2 copies of relocations (renderers, and everything else) vs 1 - Increased fixed cost (memory from the zygote) - Increased cold startup latency From the attached bug, the added memory cost for a single renderer is ~4MB (excluding page tables, which are expected to be .5-1MB). As a consequence, disable the app zygote on low-end devices. Bug: 1044579 Change-Id: I453ce87060f84d616fef7d0796a3f6b794989693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016645Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c2e16963a9cc..a5a6e4f5bbda git log c2e16963a9cc..a5a6e4f5bbda --date=short --first-parent --format='%ad %ae %s' 2020-01-23 cwallez@chromium.org Roll third_party/glfw/ 2de2589f9..d973acc12 (366 commits) Created with: gclient setdep -r src/third_party/dawn@a5a6e4f5bbda If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I76fbf4655e17990ecb1fd661e899ddc10d28f1e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016876Reviewed-by:
-
Colin Blundell authored
Follows the componentization of the production code. TBR=jochen@chromium.org Bug: 1030692 Change-Id: I82a8a9bae9e97783569265ac57f7bed61f627fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012965 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#734499}
-
Dominik Röttsches authored
Skia issue skia:9747 has a fix landed, hence we can remove the workaround to conditionally branch to makeFromStream(). Bug: 1044966 Change-Id: I16c4401fb5463fa0deb8816e30a8480daec5a9f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016647 Auto-Submit: Dominik Röttsches <drott@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#734498}
-
Sylvain Defresne authored
Move ChromeBrowserState to the global namespace and add "using" to also make it accessible through the "ios" namespace. Change the forward declaration in chrome_browser_state_forward.h to also use the same pattern. Bug: 1042208 Change-Id: I721e2e6976bce5110724f66b0dfa3edd8acdfd37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014913 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#734497}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/35101480671e..d4101efae107 Created with: gclient setdep -r src-internal@d4101efae107 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I28d3e45d2e26b8021c34b0fb8660d49f38517900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016874Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734496}
-
Xiaocheng Hu authored
Length unit 'ch' should be recalculated after loading a web font. This patch is a followup of crrev.com/c/1972815 to ensure that it's also recalculated in pseudo elements. Bug: 441925 Change-Id: Ie62dba854aa9d1beb6b9a734f31760abf1acd040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016198Reviewed-by:
-
Nicolás Peña Moreno authored
This CL replaces assert_unreached for assert_precondition for the API existence checks in the ElementTiming and LargestContentfulPaint WPTs. Change-Id: Icd2ff3e045835cf4c46a370a384455143a717308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013863Reviewed-by:
Tom McKee <tommckee@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#734494}
-
Guido Urdaneta authored
This CL causes getUserMedia() to fail if requesting video formats exceeds a timeout. This is suspect of causing getUserMedia() hangs in some environments such as virtual machines. Drive-by: Add some comments, a thread check, and some extra WebRTC logging. Bug: 1044974 Change-Id: I87f7687c491b4a502f4dba57d2c57bc53cb81390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015249Reviewed-by:
Armando Miraglia <armax@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#734493}
-
Nikita Podguzov authored
Bug: 992889 Change-Id: If20a1b395e6ab25affe26ebd44175f1536a9b041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014962Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#734492}
-
Jeremy Roman authored
Any such tag name would need to also set noTypeHelpers: true and provide its own specializations that check something besides the tag name, since such an element could still end up in a document where it is disabled through node adoption. Bug: 1040627 Change-Id: Ib53554f673e2a7b375e82abde1b8e29c380c39c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994520Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#734491}
-
ckitagawa authored
This change migrates paint previews to use UnguessableToken rather than int64 or long. This change together with the addition of embedding tokens should have no impact on the behavior of paint previews. However, the data will use embedding tokens for subframes and a new token for the main frame main rather than old-style routing id + process id. This helps avoid creating a dependency in blink on content/ and routing ids. See: https://chromium-review.googlesource.com/c/chromium/src/+/1949121 for Embedding Token addition. Bug: 1035107 Change-Id: I50716b8b6c1b03aaf580fd282638b11b8b80c86b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972775 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#734490}
-
Isabella Scalzi authored
Add a test checking that Quick View opens from the context menu when in single selection mode. Test: browser_tests --gtest_filter="*openQuickViewViaContextMenuSingleSelection" Bug: 1038799 Change-Id: I569cea5e0ade7f1c9d4a614cfad3bc17d8b88a81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015903 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#734489}
-
