- 29 Jan, 2020 40 commits
-
-
tby authored
This is a reland of 2fe77415 Original change's description: > [Structured metrics] Add metric collection and upload logic. > > This is the final CL for the core of the structured metrics system. It > ties together the KeyData class (for managing keys and computing hashes) > with the metrics provider, and implements logic to: > > 1. Hash and store incoming structured metrics events. > 2. Provide stored metrics events for upload. > > It also adds integration tests for the system, checking that an event > created through the public API is correctly prepared for upload. > > Other misc changes: > > - Some minor refactoring of event_base.{h,cc} and equivalent changes > to events_template.py, to fix some bad style. > - Added a missing RemoveObserver call to the metrics provider dtor. > > Bug: 1016655 > Change-Id: I3daae2ba7927742d26db8d5750538584bf13b94f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975386 > Commit-Queue: Tony Yeoman <tby@chromium.org> > Reviewed-by: Andrew Moylan <amoylan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735748} Bug: 1016655 Change-Id: I83e69de7a9b865d35036b714f068cfda3c423b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026913Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#736590}
-
Darwin Huang authored
sqlite 3.31.1 upgrade changes: https://sqlite.org/releaselog/3_31_1.html Bug: 1046597 Change-Id: Iccfe05026e65d8563b8a8cef31f02a048d9afff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026759Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#736589}
-
Matt Mueller authored
Change-Id: I058cb3934c96b38ff4bddea0192c8b36297b4abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028754 Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: Matt Mueller <mattm@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#736588}
-
Matthew Mourgos authored
In this change, the following metrics will have their expiry extended: Apps.AppListFolderOpened Apps.AppListFolderNameLength.* Bug: 1043741, 1043740 Change-Id: I167ec665a98aa6f0e616ab00398b546a98bdd4d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024695Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#736587}
-
Theodore Dubois authored
RE2 was printing an error whenever a ruleset with no regex rules was initialized. It wasn't causing any problems, but it was bugging me. Fix it by skipping the initialization of an empty RegexRulesMatcher, because it wasn't actually doing anything anyway (other than print an error). R=karandeepb@chromium.org Bug: 974391 Change-Id: Ia381bca2b9d60ac2407fd9121657fccc4b05e81c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026592 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#736586}
-
Darwin Huang authored
Bug: 1046597 Change-Id: I0a9548d7fe0997c2cf606cff6fac13dc66465bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026377Reviewed-by:
-
Donn Denman authored
Pipes a boolean through Contextual Search to a server request parameter to determine whether to make the Resolve an "exact resolve" request that cannot expand the selection. Uses TemplateUrl to add the parameter to the Resolve request. This additional parameter is needed for the Long-press triggering experiment. Also includes cleanup of initializers in C++ ContextualSearchContext. BUG=956277 Change-Id: Iaa0e1988035ed49d13e7a9e77e20c0c2ef04b4d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995842 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#736584}
-
Darwin Huang authored
Bug: 1046597 Change-Id: I27a0520fbdb6b50f12c4530c508c4c0125f913e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026415Reviewed-by:
-
Connie Wan authored
- Tabs will read out their group membership. - Group headers will read out their tab contents. Tiny side bonus: Focusing on group headers will no longer show the wrong hovercard. Bug: 1045844 Change-Id: I5fc98231a5c5a0372aa75e31a5c3a6e321ce24b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025698 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#736582}
-
Maksym Onufriienko authored
Depend on cl http://crrev/c/1954209 that will change `shard size` logic, since this cl it will be number of swarming tasks, not number of test classes per swarming task. Bug: 1033656 Change-Id: I4490690cafb290997b3b243d2423a78a113763f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965733Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#736581}
-
rbpotter authored
Add missing imports of assert.html for elements that are using assert but not importing it currently. Also add to deps for closure compiler for settings_idle_load. This is in preparation for autogenerating Polymer 3 versions of these files. Bug: 1026426 Change-Id: I22eacc796d159ff24813c1cccd5c5c9e386e7cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028658 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#736580}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5e883773e98e..38fc743463bb Created with: gclient setdep -r src-internal@38fc743463bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1028270 Tbr: jbudorick@google.com Change-Id: I0b907160076cde4a14c28803706d98584d42acb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028849Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736579}
-
kylechar authored
When using SkiaRenderer on Windows use the Skia readback APIs instead of GLRendererCopier by default. The Skia readback API doesn't support RGBA_TEXTURE readback format. This is only used on Chrome OS in production but some cc_unittests exercise it. Don't run those tests on Windows with SkiaRenderer. We still exercise the same test with RGBA_BITMAP which is supported. Bug: 1042646, 1046788 Change-Id: Ida4a1a921c838ee7a2d628da4535d9367140ff04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019466 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#736578}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/37e7b36a3dc2..8a46f7664675 git log 37e7b36a3dc2..8a46f7664675 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 kjlubick@google.com [canvaskit] Add demo for RT shader 2020-01-29 csmartdalton@google.com Add a "kSimpleInnerPolygons" mode to GrTessellator 2020-01-29 fmalita@chromium.org [skottie] Cleanup: convert shape stroke/fill to new adapter pattern 2020-01-29 bsalomon@google.com Check for valid stencil buffer in GrGLGpu::clearStencilClip Created with: gclient setdep -r src/third_party/skia@8a46f7664675 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:984747 Tbr: reed@google.com Change-Id: I2fdadd8f2fe2725433a19e262355f54a537ff6b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028655Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736577}
-
Garrett Beaty authored
Change-Id: Id7abe4dc8ba4f14fd09dfd0bdf7048fa07ab79d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028176 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#736576}
-
Oriol Brufau authored
The ::marker pseudo-element is being implemented behind a flag, so it shouldn't be exposed in devtools unless this flag is enabled. That was already happening for ::markers that already existed before opening the devtools tree. However, if a ::marker was created afterwards (e.g. by setting 'display: list-item' to some element), then the ::marker was shown even if the flag was disabled. This patch fixes the issue so that ::marker is only shown when the flag is enabled. BUG=457718 Change-Id: Ie2261c15a1211599355ca687b38cc525be8e2bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027909 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#736575}
-
Xianzhu Wang authored
CompositeAfterPaint no longer produces different result. Remove the extra baseline, and the test passes. TBR=wangxianzhu@chromium.org Bug: 979369 Change-Id: I8da553bfcc71a4a08e7f4cb8a758fcf37f5107d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028736Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736574}
-
Eric Karl authored
Change-Id: Ic12f69ef4d4ba6c9fe02217ad6912175550cd8a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028631 Auto-Submit: Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#736573}
-
Geoff Lang authored
The validating command decoder exposes GL_ANGLE_texture_usage unconditionally but the passthrough decoder did not because it had to be requested first (for WebGL contexts). Request the extension at command buffer initialization time. BUG=1030835 Change-Id: I001f35650bd947eddf18878c56ac566c7dfd5588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023293Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#736572}
-
Chris Lu authored
This is an intermediate step to scoping FullscreenController to a Browser. In order to accomplish this, the code needs to be able to switch between associating it to both a BrowserState, which it current is, and a Browser. FullscreenController will have two new static getter methods FromBrowser() and FromBrowserState() to provide such abilities. A new FullscreenControllerContainer class that will be associated to either a BrowserState or Browser will own and manage the FullscreenControllerImpl instance. Since it is not used after this change, FullscreenControllerFactory is removed. Bug: 790886 Change-Id: I9a1e4e9832911d045b389b892538c00327c83127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006111 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#736571}
-
Josh Simmons authored
Bug: 1040661 Change-Id: I9fbb5af6e50f11926afce57efbf2348bc69c1b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028210Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Josh Simmons <jds@google.com> Cr-Commit-Position: refs/heads/master@{#736570}
-
Will Harris authored
This CL sets the shutdown parameters of child processes regardless of whether the build is Google Chrome or Chromium. This fixes the issue where sad tabs might briefly appear during logoff/shutdown on Chromium builds. BUG=1043938 TEST=load tabs in Chromium, log off user, check no sad tabs appear. Change-Id: I488f3d276a4ea93892527c39561d15a64e247127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025771Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#736569}
-
Kent Tamura authored
This CL adds "-internal-empty-line-height" CSS property, which is available only in UA stylesheets. The property takes "none" or "fabricated" as a value, and affects LayoutBlock:HasLineIfEmpty(). The property would help to decrease the number of LayoutBlock subclasses, and it would makes LayoutNG migration easier. Bug: 485982, 1040828 Change-Id: I9cb33c7c676bb7606018bc7a360bd4cbc2b2e52d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026327 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#736568}
-
Adam Langley authored
When caBLE v2 is enabled, use an updated transport selection dialog that indicates active discoveries with spinner entries. This communicates that either a USB or caBLE authenticator may be used, while still allowing the user to select other options. BUG=1002262 Change-Id: I8bd38500911025d5441975980e3ab9a63517410a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025577Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#736567}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/09d51a575493..053929aca61b git log 09d51a575493..053929aca61b --date=short --first-parent --format='%ad %ae %s' 2020-01-29 spang@chromium.org Fuchsia: Enable perFrameWindowSizeQuery by default 2020-01-29 sugoi@google.com Enable GL_OES_depth_texture_cube_map with Vulkan backend Created with: gclient setdep -r src/third_party/angle@053929aca61b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: I4d0631ffa2b2a3fb19de001c3d7812dfb3e8fe5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028025Reviewed-by:
-
Jarryd authored
Remove the third line in the clear data dialog warning about clearing data for installed apps, and instead warn about that in the main label on the dialog. This also changes the main label to only dynamically warn about installed apps data, depending on whether or not there is an associated installed app, and whether a SiteGroup has more than one installed app. Bug: 997258 Change-Id: Ibc31b233283ced6caecd9b51878e70ff1abdb877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003082Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#736565}
-
Yi Gu authored
Similar to crbug.com/1046653, this test is also flaky: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVylAELEgVGbGFrZSKIAWNocm9taXVtQGNocm9tZV9wdWJsaWNfdGVzdF9hcGtAb3JnLmNocm9taXVtLmNocm9tZS5icm93c2VyLmJvb2ttYXJrcy5Cb29rbWFya1BlcnNvbmFsaXplZFNpZ25pblByb21vVGVzdCN0ZXN0U2lnbmluQnV0dG9uRGVmYXVsdEFjY291bnQM TBR=mdjones@chromium.org Bug: 1046652 Change-Id: I8b80d4d48f68310b7d70a41a50fa452dcaf7972c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028763Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736564}
-
Eric Karl authored
These were moved to CodecBufferWaitCoordinator, <obsolete>ing the old versions. Bug: 960049, 960035 Change-Id: I519b343b1300ac59e198d2d58fe0602010eeac0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021184 Auto-Submit: Eric Karl <ericrk@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#736563}
-
Alex Moshchuk authored
HasSecurityState() was a temporary solution to deal with security checks on processes that have been destroyed, but which still have messages in flight. ChildProcessSecurityPolicy security checks on those messages should still be able to reference the old security state. Previously, HasSecurityState() was used to detect that the process was gone and just fail open. Now, we have a better solution in place in the form of ChildProcessSecurityPolicyImpl::Handle, which extends the lifetime of a process's security state even after the RenderProcessHost has gone away. Switch AppCache to use this approach instead, keeping the security state around while the corresponding AppCacheHost is alive. Bug: 943887 Change-Id: I7ebe7e127dec1c301ed61d811f0298c38778fd31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026314Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
-
Andrew Grieve authored
There was an assumption that a single prebuilt would not have more than 64k methods, but the assumption was wrong. Bug: None Change-Id: I4a94c383fa47ffd7f6034e094e495e98afe70c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027893 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#736561}
-
Michael Spang authored
The ScopedWrite needs to go out of scope before we submit the frame, or else the write semaphore won't be updated in time: [0124/175716.432747:FATAL:vulkan_swap_chain.cc(67)] Check failed: end_write_semaphore_ != VK_NULL_HANDLE. #0 0x7f62ba27c8f9 base::debug::CollectStackTrace() #1 0x7f62ba1584f3 base::debug::StackTrace::StackTrace() #2 0x7f62ba17af34 logging::LogMessage::~LogMessage() #3 0x7f62b9673e70 gpu::VulkanSwapChain::PresentBuffer() #4 0x55bb17a7c04a ui::VulkanRenderer::RenderFrame() #5 0x55bb17a731b4 base::internal::Invoker<>::RunOnce() #6 0x7f62ba1e8e42 base::TaskAnnotator::RunTask() #7 0x7f62ba206614 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() #8 0x7f62ba2062ee base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoSomeWork() #9 0x7f62ba2b7c94 base::MessagePumpLibevent::Run() #10 0x7f62ba207027 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #11 0x7f62ba1c21f7 base::RunLoop::Run() #12 0x55bb17a735a9 main #13 0x7f62b8e1352b __libc_start_main #14 0x55bb17a71a6a _start Change-Id: I4976010be79696826dd47eeff5cd2bb812ef9a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020619Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#736560}
-
Garrett Beaty authored
Change-Id: Icce42767b820205c3e38ce83f97906b0dd7f600c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025833Reviewed-by:
-
Shimi Zhang authored
We are going to expose the internal Rule class and some common rules sub-classes inside of ProxyBypassRules, so we could build different rule set based on different business logic. Bug: 1030092 Change-Id: I054e05bf1302506bee77e5c1a8e30ee8f973daea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008012 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
-
Yi Gu authored
This test is flaky: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyhAELEgVGbGFrZSJ5Y2hyb21pdW1AY2hyb21lX3B1YmxpY190ZXN0X2Fwa0BvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIuYm9va21hcmtzLkJvb2ttYXJrUmVvcmRlclRlc3QjdGVzdE1vdmVCdXR0b25zR29uZUluU2VhcmNoTW9kZQw TBR=mdjones@chromium.org Bug: 1046653 Change-Id: Ifd06085ea0abc14408b6012b05b4bdb7f8d98b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028761Reviewed-by:
-
David Jean authored
The badge tab helper's delegate needs to be set on initialization, otherwise it the mediator won't be informed of badge updates until after the active WebState is reset. Change-Id: Ie2774f2d0dc1929e9489c12a7e8cac6cca007794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026729Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
Vasiliy Telezhnikov authored
In some cases when we transit from one HardwareRenderer to another two of them can be alive simultaneously. This is incompatible with holding reference to CompositorFrameSinkSupport as only one can exist for specific FrameSinkId. This CL moves the logic of frame submission for viz from HardwareRendererViz::OnViz to RootFrameSink to avoid problems as there is always one RootFrameSink. Bug: 805739 Change-Id: Ibe45227bf0e72ee4a39932345087ded448e3c506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028732 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736555}
-
Yi Gu authored
testTopToolbar_WithGTS_WithBottomToolbar_Home_Search_Tab_Switcher is flaky on kitkat: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyqQELEgVGbGFrZSKdAWNocm9taXVtQGNocm9tZV9wdWJsaWNfdGVzdF9hcGtAb3JnLmNocm9taXVtLmNocm9tZS5icm93c2VyLnRvb2xiYXIudG9wLkFkYXB0aXZlVG9vbGJhclRlc3QjdGVzdFRvcFRvb2xiYXJfV2l0aEdUU19XaXRoQm90dG9tVG9vbGJhcl9Ib21lX1NlYXJjaF9UYWJfU3dpdGNoZXIM TBR=lazzzis@google.com Bug: 1046748 Change-Id: I769ec9e7908877a8bfa56bd562794d373235606f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028757Reviewed-by:
-
Yi Gu authored
This is another flaky test that may timeout similar to the rest. See bug for details. TBR=yangguo@chromium.org Bug: 1046784 Change-Id: Ic0cb69981a299021eb80405976287b43460c4698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028851Reviewed-by:
-
Vasiliy Telezhnikov authored
Reference to RootFrameSink is hold from RootFrameSinkProxy and HardwareRendererViz::OnViz. As they can be destroyed in arbitrary order the assumption that RootFrameSinkProxy always live longer than RootFrameSink is invalid. This CL fixes the issues about this assumption. Bug: 805739 Change-Id: Idec2864de31d271651e52687e2821763efbd5fa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028657Reviewed-by:
-
Yi Gu authored
This test is quite flaky recently: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyQQsSBUZsYWtlIjZjaHJvbWl1bUB1bml0X3Rlc3RzQEtleXN0b25lR2x1ZVRlc3QuQmFzaWNHbG9iYWxDcmVhdGUM TBR=mark@chromium.org Bug: 1041813 Change-Id: Ie6695e5da5d68b4d003032db94cc80b50c569c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028854Reviewed-by:
-
