- 06 Dec, 2011 32 commits
-
-
stevet@chromium.org authored
BUG=105110 TEST=Ensure that when Chrome on Windows creates a desktop icon for a new Profile, the icon image has the user avatar in it. Ensure that changing the Avatar changes the image in the icon. TBR=rsesek Review URL: http://codereview.chromium.org/8785006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113104 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
BUG=102714 TEST=none Review URL: http://codereview.chromium.org/8786006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113103 0039d316-1c4b-4281-b951-d872f2087c98
-
mmenke@chromium.org authored
Move CapturingNetLog out of net project, as it's no longer used except in tests. Review URL: http://codereview.chromium.org/8567011 TBR=mmenke@chromium.org Review URL: http://codereview.chromium.org/8822002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113100 0039d316-1c4b-4281-b951-d872f2087c98
-
abarth@chromium.org authored
TBR=pfeldman Review URL: http://codereview.chromium.org/8801036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113098 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
Also moves a bunch of mask images off the theme provider alltogether, which are now shared across profiles via gfx::Image. BUG=106060 TEST=none Review URL: http://codereview.chromium.org/8786003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113097 0039d316-1c4b-4281-b951-d872f2087c98
-
mball@chromium.org authored
Update pepper_16 to rev 1396 and pepper_17 to rev 112997 BUG=None TEST=None Review URL: http://codereview.chromium.org/8806024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113096 0039d316-1c4b-4281-b951-d872f2087c98
-
yusukes@chromium.org authored
ui::InputMethod: - An interface similar to views::InputMethod, but does not have Has neither Views nor Aura dependencies. ui::InputMethodIBus - Port of views::InputMethodIBus. Has neither Views nor Aura dependencies. Original review: http://codereview.chromium.org/8576005/ (PatchSet #1-8, Comment #1-24) BUG=97261 TEST=see part 3 of 3. Review URL: http://codereview.chromium.org/8659033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113095 0039d316-1c4b-4281-b951-d872f2087c98
-
sail@chromium.org authored
BUG=91241 TEST= Review URL: http://codereview.chromium.org/8742008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113094 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
BUG=105129 TEST=PanelTest.PanelOpenLarge should no longer run on Aura + chromeos Review URL: http://codereview.chromium.org/8632013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113093 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
BUG=104396 TEST=more tests passes in interactive_ui_tests passes on aura Review URL: http://codereview.chromium.org/8808001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113092 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
xinput1_3.dll is a Microsoft DirectX redist file. Unfortunately it's shipped without /NXCOMPAT and /DYNAMICBASE. This DLL is only be loaded when the user interacts with a gamepad. BUG=79050 Review URL: http://codereview.chromium.org/8806020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113091 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
Add abstract GetGroupsToChange() method to ModelChangingSyncerCommand. Use that to figure out which worker threads to post work on (instead of posting on all of them). Implement GetGroupsToChange() for each ModelChangingSyncerCommand. Add GetEnabledGroups() and GetEnabledGroupsWithConflicts() functions to SyncSession. Key unapplied updates index by type for ApplyUpdatesCommand. Make the abstract methods of ModelChangingSyncerCommand protected. Add HasCustomGroupsToChange() method to ModelChangingSyncerCommand and have all commands default to returning false to track down the perf regression introduced by the last couple of times this was landed (112178, 112815). BUG=97832 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112178 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112743 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112815 Review URL: http://codereview.chromium.org/8637006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113090 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113089 0039d316-1c4b-4281-b951-d872f2087c98
-
kkania@chromium.org authored
1) Wait for extension popup to load 2) Wait for extensions hosts to load in WaitForAllViews 3) Allow more than one browser action to be visible in views. 4) Add explicit IsPageActionVisible method BUG=93571 TEST=none Review URL: http://codereview.chromium.org/8804011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113088 0039d316-1c4b-4281-b951-d872f2087c98
-
sail@chromium.org authored
BUG=106229 TEST=Ran without my change and saw that the avatar icon would not change. Applied my fix and verified that the avatar icon changed. Review URL: http://codereview.chromium.org/8796003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113087 0039d316-1c4b-4281-b951-d872f2087c98
-
tommi@chromium.org authored
- Refactoring and bug fixes - Remove global variables of class type. NOTE: I'm landing this for Ronghua since he's on leave. The change has already been reviewed here: http://codereview.chromium.org/8790011/ but I had to create a new issue in order to resolve merge conflicts. TBR=sergeyu Review URL: http://codereview.chromium.org/8802019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113086 0039d316-1c4b-4281-b951-d872f2087c98
-
mmenke@chromium.org authored
used except in tests. Review URL: http://codereview.chromium.org/8567011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113085 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
BUG=101214 Review URL: http://codereview.chromium.org/8697006 TBR=rdsmith@chromium.org Review URL: http://codereview.chromium.org/8817005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113084 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
Revert 113075 (requested by asvitkine) (requested by asvitkine) (requested by asvitkine) (requested by asvitkine) (requested by asvitkine) (requested by asvitkine) (requested by asvitkine) (requested by asvitkine) (requested by asvitkine) - Improve RenderTextWin font fallback. Don't use SCRIPT_UNDEFINED in the case of font fallback, unless font fallback actually fails to return a script that can display the characters. This fixes the problem of some scripts not being properly displayed. This actually makes RenderTextWin properly validate whether a text position accepts a cursor, which caused several tests to fail and revealed some additional issues in RenderTextWin. The CL includes some modifications to address this. Some tests are disabled under XP, see: http://crbug.com/106450 Also, fixes some lint warnings. BUG=90426 TEST=Run chrome.exe --use-pure-views and paste some Bengali text into the omnibox. It should show up properly. Review URL: http://codereview.chromium.org/8575020 TBR=asvitkine@chromium.org Review URL: http://codereview.chromium.org/8819001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113083 0039d316-1c4b-4281-b951-d872f2087c98
-
mcgrathr@chromium.org authored
r113078 was done with "drover --revert 113074". It failed to restore one of the removed files. TBR=mpcomplete@chromium.org BUG= none TEST= none Review URL: http://codereview.chromium.org/8803030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113081 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113079 0039d316-1c4b-4281-b951-d872f2087c98
-
mcgrathr@chromium.org authored
These sources have been moved over to the native_client repository. Remove them from chromium/src altogether and just make the gyp files refer to the native_client stuff. BUG= none TEST= linux still builds R=sehr@google.com,noelallen@chromium.org Review URL: http://codereview.chromium.org/8799016 TBR=mcgrathr@chromium.org Review URL: http://codereview.chromium.org/8811002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113078 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113077 0039d316-1c4b-4281-b951-d872f2087c98
-
alokp@chromium.org authored
Review URL: http://codereview.chromium.org/8733008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113076 0039d316-1c4b-4281-b951-d872f2087c98
-
asvitkine@chromium.org authored
Don't use SCRIPT_UNDEFINED in the case of font fallback, unless font fallback actually fails to return a script that can display the characters. This fixes the problem of some scripts not being properly displayed. This actually makes RenderTextWin properly validate whether a text position accepts a cursor, which caused several tests to fail and revealed some additional issues in RenderTextWin. The CL includes some modifications to address this. Some tests are disabled under XP, see: http://crbug.com/106450 Also, fixes some lint warnings. BUG=90426 TEST=Run chrome.exe --use-pure-views and paste some Bengali text into the omnibox. It should show up properly. Review URL: http://codereview.chromium.org/8575020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113075 0039d316-1c4b-4281-b951-d872f2087c98
-
mcgrathr@chromium.org authored
These sources have been moved over to the native_client repository. Remove them from chromium/src altogether and just make the gyp files refer to the native_client stuff. BUG= none TEST= linux still builds R=sehr@google.com,noelallen@chromium.org Review URL: http://codereview.chromium.org/8799016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113074 0039d316-1c4b-4281-b951-d872f2087c98
-
adamk@chromium.org authored
Re-landing r113010 with clang style fixes. R=tony@chromium.org Review URL: http://codereview.chromium.org/8805027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113073 0039d316-1c4b-4281-b951-d872f2087c98
-
jennyz@chromium.org authored
BUG=102144 TEST=NONE Review URL: http://codereview.chromium.org/8763007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113072 0039d316-1c4b-4281-b951-d872f2087c98
-
yoz@chromium.org authored
It broke ExtensionManagementApiBrowserTest.LaunchApp. Make ExtensionSet iterate like a set instead of a map. BUG=104091 TEST=existing tests Review URL: http://codereview.chromium.org/8733004 TBR=yoz@chromium.org Review URL: http://codereview.chromium.org/8789018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113071 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
BUG=105028 TEST=none Review URL: http://codereview.chromium.org/8801012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113070 0039d316-1c4b-4281-b951-d872f2087c98
-
miket@chromium.org authored
Changed some API names. Wrapped existing UDPClientSocket. Added one unit test for controller. The socket API itself isn't tested for two reasons: (1) this is an interim checkin, where Part 2 will add UDP receiving, and that will likely involve some API changes, so I didn't bother constructing a whole extension built on a temporary API; and (2) the wrapper itself is so thin around the existing UDPClientSocket API that a unit test of the wrapper wouldn't accomplish much. BUG=none TEST=see above. Review URL: http://codereview.chromium.org/8743017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113069 0039d316-1c4b-4281-b951-d872f2087c98
-
battre@chromium.org authored
If an extension A tries to redirect a request to http://foo and an extension B tries to redirect a request to data://..., we consider the redirect of extension B as an attempt to cancel the request. As cancelling a request is considered to take precedence over redirects, this does not generate a conflict message any more. BUG=106431 TEST=no Review URL: http://codereview.chromium.org/8802017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113068 0039d316-1c4b-4281-b951-d872f2087c98
-
- 05 Dec, 2011 8 commits
-
-
davemoore@chromium.org authored
BUG=106481 TEST=Manual Review URL: http://codereview.chromium.org/8801033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113067 0039d316-1c4b-4281-b951-d872f2087c98
-
rginda@chromium.org authored
Some of this code is based on Cory Maccarrone's html terminal, developed internally in Google as part of a different project. Thanks to Cory for allowing us to repurpose it here! This gets us to a point where we have the core classes largely fleshed out. The code passes 45 tests, mostly related to correct handling of vt100 escape sequences. Still to come: network connectivity, keyboard input, and text attributes! BUG=chromium-os:23271 TEST=test_harness.html:45/45 tests passed. Review URL: http://codereview.chromium.org/8680034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113066 0039d316-1c4b-4281-b951-d872f2087c98
-
dcheng@chromium.org authored
Also fixes a leak that was accidentally introduced in http://src.chromium.org/viewvc/chrome?view=rev&revision=113018. BUG=31037,106472 TEST=manual testing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113040 Review URL: http://codereview.chromium.org/8802004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113064 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=none TEST=none NOTRY=true Review URL: http://codereview.chromium.org/8812001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113063 0039d316-1c4b-4281-b951-d872f2087c98
-
yzshen@chromium.org authored
Don't move the cursor back to the center of the view unless it approaches the border. BUG=106054 TEST=None Review URL: http://codereview.chromium.org/8791001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113061 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
(and other disposition modifiers) BUG=7678 TEST=trybots Review URL: http://codereview.chromium.org/8662051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113059 0039d316-1c4b-4281-b951-d872f2087c98
-
munjal@chromium.org authored
- Remove the CWS service and token generation for that. - Remove StartFetchingMissingTokens method - Remove unit test for removed code. Review URL: http://codereview.chromium.org/8769053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113058 0039d316-1c4b-4281-b951-d872f2087c98
-
dubroy@chromium.org authored
Also clean up some unnecessary complexity in history HTML, and move history-specific CSS from old_webui.css to history.css. BUG=None. TEST=Manual test of functionality on history and downloads pages. Review URL: http://codereview.chromium.org/8772046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113056 0039d316-1c4b-4281-b951-d872f2087c98
-