- 10 Jul, 2014 40 commits
-
-
rdevlin.cronin@chromium.org authored
UserScriptList from UserScriptMaster. This leads to problems: - What if master goes away? - What if the UserScriptList is modified, as in UserScriptMaster::OnExtensionLoaded? Fix this by making the script loading process in UserScriptMaster much simpler: UserScriptMaster calls LoadScriptsOnFile thread, and uses the result, using a weak pointer. Added bonus: Two fewer ref-counted objects! 50 fewer lines of code! Less script loading! BUG=383973 Review URL: https://codereview.chromium.org/362343006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282361 0039d316-1c4b-4281-b951-d872f2087c98
-
gbillock@chromium.org authored
BUG=352380,382556 Review URL: https://codereview.chromium.org/360773003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282360 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
> Add chrome/browser/ui to the GN build. > > This moves the intermediate grit files: > ui/ui_resources -> ui/resources > ui/ui_strings -> ui/strings > in the GYP build to put it in line with the GN one (and also what one would expect). > > R=ajwong@chromium.org > > Review URL: https://codereview.chromium.org/381463002 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/387573003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282359 0039d316-1c4b-4281-b951-d872f2087c98
-
dnicoara@chromium.org authored
display_unittests were fixed for Ozone in https://codereview.chromium.org/383463002/ BUG=none NOTRY=true Review URL: https://codereview.chromium.org/388483003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282358 0039d316-1c4b-4281-b951-d872f2087c98
-
henrika@chromium.org authored
This CL (https://codereview.chromium.org/344583002) has modified the data structure in shared memory and the original CL did not take the input side of Pepper Flash into account. Pepper Flash recording was therefore broken. This CL ensures that Pepper knows about the new audio structure and accounts for it using by mapping shared memory to an audio bus and then interleaves the data into a plain byte vector before sending it to the Pepper callback. Adding vrk@ as TBR for the added dependency in media. R=piman@chromium.org, xians@chromium.org TBR=vrk BUG=387303 TEST=www.youtube.com/my_webcam Review URL: https://codereview.chromium.org/371273004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282357 0039d316-1c4b-4281-b951-d872f2087c98
-
engedy@chromium.org authored
BUG=375333 # Depends on recently landed CL, ran try bots with manually specified base revison. NOTRY=True Review URL: https://codereview.chromium.org/369323003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282356 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
This moves the intermediate grit files: ui/ui_resources -> ui/resources ui/ui_strings -> ui/strings in the GYP build to put it in line with the GN one (and also what one would expect). R=ajwong@chromium.org Review URL: https://codereview.chromium.org/381463002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282355 0039d316-1c4b-4281-b951-d872f2087c98
-
ajuma@chromium.org authored
This removes "#if WEB_SCROLL_OFFSET_ANIMATION_CURVE_IS_DEFINED" lines added in http://crrev.com/112933005. These are no longer needed since http://crrev.com/365903004 (which #defines WEB_SCROLL_OFFSET_ANIMATION_CURVE_IS_DEFINED) has landed. BUG=243871 Review URL: https://codereview.chromium.org/383503003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282354 0039d316-1c4b-4281-b951-d872f2087c98
-
mathp@chromium.org authored
Adding this meta tag allows the page to have proper scaling. BUG=None TEST=Manual R=huangs@chromium.org Review URL: https://codereview.chromium.org/381913003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282353 0039d316-1c4b-4281-b951-d872f2087c98
-
joaodasilva@chromium.org authored
This change upstreams the downstream fixes to this test, so that this file doesn't need to be forked for iOS anymore. BUG=None Review URL: https://codereview.chromium.org/376253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282352 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282351 0039d316-1c4b-4281-b951-d872f2087c98
-
tnagel@chromium.org authored
TBR=dzhioev TBR=grt BUG=none Review URL: https://codereview.chromium.org/380233002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282350 0039d316-1c4b-4281-b951-d872f2087c98
-
vadimsh@chromium.org authored
$ git log f37f51218..c8437bfa4 --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//' 2014-07-09 vadimsh Add --task-summary-json parameter to swarming.py collect. 2014-07-09 vadimsh Fix tuple unpack exception. R=maruel@chromium.org BUG= Review URL: https://codereview.chromium.org/379193005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282349 0039d316-1c4b-4281-b951-d872f2087c98
-
mvanouwerkerk@chromium.org authored
BUG=350377 Review URL: https://codereview.chromium.org/366323002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282348 0039d316-1c4b-4281-b951-d872f2087c98
-
atwilson@chromium.org authored
We shouldn't ever get ICU errors when checking for enterprise domains, but apparently they do happen out in the field. Instead of crashing, we instead gracefully handle errors by treating domains in that case as potential enterprise domains (skipping the optimization). BUG=365351 Review URL: https://codereview.chromium.org/386573002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282347 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282346 0039d316-1c4b-4281-b951-d872f2087c98
-
mnaganov@chromium.org authored
Every invocation of Java method via an interface JS wrapper injected by Java bridge is preceded by a call to GetNamedProperty. As method presence can't change during Java object's lifetime, we should cache it on the renderer side, as every IPC call to the browser side is super-expensive. This optimization improves Cordova's "exec" benchmark speed by astonishing 60%, as we shave off half of the IPC calls. BUG=355644 Review URL: https://codereview.chromium.org/381683002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282345 0039d316-1c4b-4281-b951-d872f2087c98
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia/+log/da03653f347e38a27e79b1dfb8c731bf9a184909..996861db81bec78480b83e7a77f18fd5a786320e CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel TBR=jcgregorio@google.com BUG= Review URL: https://codereview.chromium.org/384633003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282344 0039d316-1c4b-4281-b951-d872f2087c98
-
joaodasilva@chromium.org authored
This policy is now supported and removing this attribute makes sure that it is included in the generated documentation. BUG=368801 Review URL: https://codereview.chromium.org/380183002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282343 0039d316-1c4b-4281-b951-d872f2087c98
-
nkostylev@chromium.org authored
BUG=387614 TBR=brettw,danakj Review URL: https://codereview.chromium.org/376193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282342 0039d316-1c4b-4281-b951-d872f2087c98
-
mef@chromium.org authored
BUG=390267 Review URL: https://codereview.chromium.org/360403002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282341 0039d316-1c4b-4281-b951-d872f2087c98
-
vasilii@chromium.org authored
BUG=354210 Review URL: https://codereview.chromium.org/377223003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282340 0039d316-1c4b-4281-b951-d872f2087c98
-
evy@chromium.org authored
To allow the user to return to TouchExplorationMode with mouse moves passed through, there is a one line change in the .cc file (386). Manual cursor_client changes have been added to the unit tests. A browser test has been added to more accurately test the cursor state. TEST= TouchExplorationTest.SplitTap (ui_unittest) TouchExplorationTest.SplitTapExplore (browser_test) BUG=389584 Review URL: https://codereview.chromium.org/359453003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282339 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
This reverts https://codereview.chromium.org/387513002/ which was wrong, and applies something like https://codereview.chromium.org/376403002/ to the 64bit rpm expectations. BUG=360311 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/382773005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282338 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282337 0039d316-1c4b-4281-b951-d872f2087c98
-
machenbach@chromium.org authored
Please reply to the V8 sheriff dslomov@chromium.org in case of problems. TBR=dslomov@chromium.org Review URL: https://codereview.chromium.org/384603002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282336 0039d316-1c4b-4281-b951-d872f2087c98
-
kcarattini@chromium.org authored
Adds a current page indicator to the launcher when the experimental app launcher is enabled. BUG=391642 Review URL: https://codereview.chromium.org/380613002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282335 0039d316-1c4b-4281-b951-d872f2087c98
-
sanjoy.pal@samsung.com authored
BUG=None Review URL: https://codereview.chromium.org/376133004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282334 0039d316-1c4b-4281-b951-d872f2087c98
-
teravest@chromium.org authored
An earlier change to narrow the whitelisting behavior for the Compositor and VideoDecode APIs enforced whitelisting, but removed the channel version check which permits use of these API on dev and canary builds of Chrome. https://codereview.chromium.org/346263006 This fixes that regression (and highlights the need for better testing for API permissions). BUG= Review URL: https://codereview.chromium.org/378353002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282333 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
Two recent flakes: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/32469 http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/32479 (One before the clang switch, one after, so it's unrelated to that.) BUG=367701 TBR=yutak@chromium.org Review URL: https://codereview.chromium.org/384783002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282332 0039d316-1c4b-4281-b951-d872f2087c98
-
kaliamoorthi@chromium.org authored
> Map WebSocket URL schemes to HTTP URL schemes for auth purposes. > > This permits WebSocket connections to inherit credentials from HTTP pages, and > matches the behaviour of other browsers. > > Design doc: https://docs.google.com/a/chromium.org/document/d/129rLtf5x3hvhP5rayLiSxnEjOXS8Z7EnLJgBL4CdwjI/edit > > Also consider any 401 or 407 results that reach the WebSocketStream > URLRequest::Delegate to be unrecoverable errors. > > Also ensure that the response headers are reported back to the renderer > when the developer tools are open and a 401 error happens. > > BUG=123862 > > Review URL: https://codereview.chromium.org/336263005 Seems to cause WebSocket1 failure in WinXP TBR=ricea@chromium.org Review URL: https://codereview.chromium.org/388493002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282331 0039d316-1c4b-4281-b951-d872f2087c98
-
vasilii@chromium.org authored
The patch made the bubble unresponsive on Win (see crbug/392734). > Password bubble: Don't focus by default. > > BUG=383821 > > Review URL: https://codereview.chromium.org/373043003 TBR=mkwst@chromium.org Review URL: https://codereview.chromium.org/381913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282325 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
Follow-up to https://codereview.chromium.org/376403002/ , looks like the 64bit bot just hadn't cycled yet. BUG=360311 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/387513002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282324 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282323 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=177812:177816&mode=html TBR=yutak@chromium.org,junov@chromium.org BUG= Review URL: https://codereview.chromium.org/382633007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282322 0039d316-1c4b-4281-b951-d872f2087c98
-
kouhei@chromium.org authored
Yak shaving to land https://codereview.chromium.org/380533003/ Before the patch, |MemoryObserver| called |GetMemoryUsageKB()| without any check, which is only valid after webkit is initialized. GetMemoryUsageKB queries |v8::Isolate::GetCurrent()| internally, but the query fails on DCHECK on debug builds. This patch moves the |MemoryObserver| instantiation inside |RenderThreadImpl::EnsureWebKitInitialized|. BUG=None Review URL: https://codereview.chromium.org/380603002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282321 0039d316-1c4b-4281-b951-d872f2087c98
-
mef@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/378823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282319 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
Review URL: https://codereview.chromium.org/380123002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282318 0039d316-1c4b-4281-b951-d872f2087c98
-
hyunki.baik@samsung.com authored
When vertical_density is 1, the value of horizontal_density from do_clustering() should be equal to 1. Thus, it skips the horizontal sort process in this case. When I checked logs in google.com and www.naver.com, this condition (vertical_density equals to 1) is met for more than 70% of cases. BUG=312861 Review URL: https://codereview.chromium.org/379823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282317 0039d316-1c4b-4281-b951-d872f2087c98
-
https://codereview.chromium.org/356613002vitalybuka@chromium.org authored
> Add function queryForNewLocalDevices to send query for new local devices, > implement it for mDNS (WiFi devices forthcoming) > > BUG=383167 > > Review URL: https://codereview.chromium.org/356613002 TBR=noamsml@chromium.org Review URL: https://codereview.chromium.org/387453002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282315 0039d316-1c4b-4281-b951-d872f2087c98
-