- 23 Oct, 2020 40 commits
-
-
Rakina Zata Amni authored
navigation_token is only needed for browser-initiated same-document navigations, which is handled in DidFinishSameDocumentNavigation. See discussion: https://groups.google.com/a/chromium.org/g/navigation-dev/c/N_QfNAB3x44/m/ABGSPq6OAgAJ Bug: 1131832 Change-Id: I9c5ae4eb76bc361473b4ea833eee0ed6fb1d0887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478744Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#820228}
-
Fredrik Söderqvist authored
Change-Id: I4187fdbbb265aab9d679781130c923936a4ad9b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494884 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#820227}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/6a2b3e4007e7..007c109b4594 2020-10-23 bungeman@google.com * src/sfnt/pngshim.c (Load_SBit_Png): Fix memory leak (#59322). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: Ic9be7c23a5208802888f7d10295f6f5d1ed3197e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493738Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#820226}
-
Mark Yacoub authored
BUG=1082882 TEST=N/A Change-Id: I167483e76cbc216ef1d5c9654f2b8a2e8bd85671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492968 Auto-Submit: Mark Yacoub <markyacoub@google.com> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#820225}
-
Konstantin Ganenko authored
Calling StartWorkerInternal() can end up in OnStartSend() which deletes `this` in case of error. This code path became real after the service worker context thread became the UI thread. R=falken@chromium.org Bug: 1141413 Change-Id: Iec9172567aab3dcc62323f358bab9fc751551d5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490113 Commit-Queue: Konstantin Ganenko <ganenkokb@yandex-team.ru> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#820224}
-
Rohit Agarwal authored
This CL uses adaptive colors for the incognito filled icon in the incognito interstitial. It uses modern_grey_300 for dark mode and modern_grey_800 for light mode. Screenshot: crbug.com/1137339#c4 Bug: 1137339 Change-Id: I659faac43841c27007b54e85e194e816e1648826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468116Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Lijin Shen <lazzzis@google.com> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#820223}
-
Jan Krcal authored
This CL splits the ShowSyncConfirmation() function of the dice turn on sync helper delegate into one that shows the normal sync confirmation and one that shows a error message that sync is disabled by the admin. Since both the dialogs are implemented by the same webUI page, there is not much behavioral change. The only change is for the delegate for the signed-in profile creation flow which opens a new browser window and shows the dialog in this window instead of showing it in the creation flow window. In follow-up CLs, the variant of the UI will be passed as a param to the WebUI page replacing the logic to decide which variant to show. Bug: 1126913 Change-Id: Ibac9a339c4fb071f960f15864482c818247f5719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487100 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#820222}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I186c23729a0cb00abe31c2425bf9f17b3d702aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495260Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820221}
-
Sreeja Kamishetty authored
Previously, the lifecycle state was updated to LifecycleState::kRunningUnloadHandlers/LifecycleState::kReadyToBeDeleted based on RFH having unload handlers or not during deletion when the RFH is in BackForwardCache. This CL removes this transition of LifecycleState and retains it to kInBackForwardCache during deletion. BUG=1109742 Change-Id: Ieef3635f80707be569dabb0ab37e38438084638e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351455 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#820220}
-
Nektarios Paisios authored
In a previous patch, we introduced AXNode::GetTextFieldAncestor for finding the root of an editable region. However, we didn't replace all the existing code that had equivalent functionality. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: Id3a9adfc7b9823fcd8899675d0e2cff5da1633d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490517 Auto-Submit: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#820219}
-
Abigail Klein authored
the MediaDialogView. The MediaDialogView paints to layer in order to ensure that corners are rounded (introduced due to crbug.com/992869). The Live Caption toggle label paints to a transparent background, which caused a bug due to subpixel rendering not occurring. This CL takes two approaches: 1. The new EnableMDRounedCornersOnDialogs flag enables rounded corners without needing to paint to layer. When that flag is enabled, we stop painting to layer. 2. When the flag is not enabled, set the background of the Live Caption toggle container to the native theme background so that the background color is opaque rather than transparent. Bug: 1055150, 1139395 Change-Id: Iaf9675e50671b3464c213412698aea3616534643 AX-Relnotes: N/A (Feature not launched yet) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490225Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#820218}
-
Bret Sepulveda authored
TBR=mmenke@chromium.org Bug: 1128033 Change-Id: I26c0756586cc484c50e6ec1cb886ac2c4b8acb8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494865Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#820217}
-
Robbie Gibson authored
The tests now pass after https://chromium-review.googlesource.com/c/chromium/src/+/2446782. See below for a hypothesis on the root causes. The root cause of the issue is a unclear, but seems to be as follows: The overscroll state is supposed to change twice, once to STARTED_PULLING after the |-scrollViewDidScroll| call, and once to ACTION_READY after the contentOffset is updated. This happens on simulator, but on device, the first change actually causes the overscroll state to change to NO_PULL_STARTED. This seems to be because on device, the initial contentOffset is 0, while on simulator, it is ~ -2.46E-314, which compares less than 0 in |OverscrollActionsController scrollViewDidScroll|. To fix this, I changed the content offset in the test manually to a small number less than 0. Bug: 944599 Change-Id: I0d062e6ab9d20aca0b85810375b0081186fef48a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390381 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#820216}
-
Bret Sepulveda authored
This test was reported flaky on Mac as well, so it is now disabled on all platforms. TBR=skobes@chromium.org Bug: 1135527 Change-Id: I8960866c3d7ebdf2199c839de28671510d7d9dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495141Reviewed-by:
-
Bret Sepulveda authored
Disable flaky SitePerProcessBrowserTestWithSadFrameTabReload.DoNotReloadHiddenTabWithHiddenCrashedSubframe All versions of this test are flaky on all platforms, so it is disabled. TBR=alexmos@chromium.org Bug: 1135595 Change-Id: I58843182f9a917c48cee813591a7859a173906bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494807Reviewed-by:
-
chrome://discardsKen Rockot authored
Bug: 1004256 Change-Id: I48acd4d46ee341f3cb399427b10e467f43537ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472484 Auto-Submit: Ken Rockot <rockot@google.com> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#820213}
-
Bret Sepulveda authored
This reverts commit 27c54e91. Reason for revert: Sorry, looks like VideoCaptureImplTest.BufferReceived_GpuMemoryBufferHandle on Linux MSan Tests is still failing, see latest build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/25945 Original change's description: > [VideoCapture] Handle GPU context lost for the zero-copy path > > When the render thread encounters GPU context lost, we need to re-create > the SharedImage resources to recover the video capture stream. > > This is a reland of crrev.com/c/2455328 with a fix to address the MSAN > test failure > > Bug: 1131998, b:169429427 > Test: Manually with chrome://gpuclean on soraka > > TBR=jcliang@chromium.org,ccameron@chromium.org,kbr@chromium.org,dcastagna@chromium.org,guidou@chromium.org,ccameron@google.com > > Change-Id: I3d00abaea04ccf95a795e116f5fc7ff5c7d7f43a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494406 > Reviewed-by: Ricky Liang <jcliang@chromium.org> > Commit-Queue: Ricky Liang <jcliang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820175} TBR=jcliang@chromium.org,ccameron@chromium.org,kbr@chromium.org,dcastagna@chromium.org,guidou@chromium.org,ccameron@google.com Change-Id: I5b13e249552304881763302cef3fd2334e998452 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1131998 Bug: b:169429427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494934Reviewed-by:
-
sauski authored
A previous change added the site_data.js search filter to the url query parameters. This resulted in the page sending two requests to the CookiesViewHandler for each filter change. The CookiesViewHandler has a strong requirement that only one request be in flight at any time. This CL adds logic to prevent sending a request on route change if a filter query parameters is present. Bug: 141785 Change-Id: I9ba6431b14e06fbd2211c9edb17c812cdbd1726f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494805Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#820211}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d3f2d5be. With Chromium commits locally applied on WPT: 4a9339fb "Fix NGLineBreaker::RewindOverflow crash" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Ic945ecfbc4b004f912094c35d606062428f66277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494423Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820210}
-
Jit Yao Yap authored
Sync server-side changes from cl/333594358 and cl/338193271. Change-Id: Iea6abbbf69040ba84146186a787c26006e940701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489300Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#820209}
-
Ramin Halavati authored
This test has been disabled for 5 years. Cleaning up a bit and giving it a try before expanding to cover ephemeral Guest profiles. Bug: 471953, 1125474 Change-Id: Ia97497052141aed270b70fd1452c25e23ca7a78b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489884 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#820208}
-
arthursonzogni authored
Replicate the logic from about MHTML document from: DocumentLoader::CalculateSandboxFlags() into: NavigationRequest::ComputeSandboxFlags() This allow the removal of an exception in RenderFrameHostImpl::CheckSandboxFlags. Bug: 1082118 Change-Id: I1c7492c56c7c9f01f86aaf39d860ada4c2f9b4cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452475 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#820207}
-
Alex Rudenko authored
HTMLPreloadScanner and HTMLImageElement were using slightly different logic to determine if an image type is supported. In particular, HTMLImageElement considered an empty image type as supported and HTMLPreloadScanner did not. In the following case, it'd result in HTMLPreloadScanner trying to preload a resource (.png) that will not be used by HTMLImageElement (it will use .avif): ``` <picture> <source srcset="images/test.avif" type=""> <img src="images/test.png"> </picture> ``` This CL adds a static method HTMLImageElement::SupportedImageType that is used by HTMLPreloadScanner to check if an image type is supported. Also, redundant checks for type emptiness are removed from HTMLImageElement. Fixed: 1141776 Change-Id: I89ed95c18bbbc86613f6b362ba935f428e1d05b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494720 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#820206}
-
Nicholas Verne authored
Instead of "Linux (Beta)", now shows as "Developers" Bug: 1140370 Change-Id: Id4e076b5d918e41e22e5c59d65958da9e75a3f55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486528 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Auto-Submit: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#820205}
-
Bret Sepulveda authored
This reverts commit 830b5b3a. Reason for revert: Causing crashes in several mathml tests on the MSAN bot. First failing build: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/8001 Original change's description: > [mathml] Implement special drawing of largeop operator in displaystyle > > This implements special drawing of largeop <mo> element in display style > as described in step 3. of [1]. A new algorithm is introduced for that > purpose and in particular only used for <mo> elements that are made of > a single glyph. Existing painting logic for stretchy radical symbol is > reused and adapted to work with largeop operators. > > [1] https://mathml-refresh.github.io/mathml-core/#layout-of-operators > > Bug: 6606 > Change-Id: Icca70f4bf464417809970fecc101e5aa7f149621 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414298 > Commit-Queue: Rob Buis <rbuis@igalia.com> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Reviewed-by: Frédéric Wang <fwang@igalia.com> > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819855} TBR=wangxianzhu@chromium.org,kojii@chromium.org,ikilpatrick@google.com,ikilpatrick@chromium.org,fwang@igalia.com,mstensho@chromium.org,rbuis@igalia.com Change-Id: I97a8a0708d5acd3d43fd67a2deff3fed5967fc5e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 6606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495061Reviewed-by:
-
Benoit Lize authored
On Linux, EINTR can be returned from mprotect(), but we don't handle it. Add HANDLE_EINTR() in relevant places in the codebase. For context, see https://bugs.chromium.org/p/chromium/issues/detail?id=1124675#c6. Bug: 1124675 Change-Id: I1cb35e637297593ae7e922cd90cef2163f397584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478946Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#820203}
-
Hoch Hochkeppel authored
Adding tests for the FakeIAsyncOperation test class. This includes pulling the templated test value logic out of the PostAsyncResultsTests to a shared location and leveraging it in these new tests. Bug: 1140544 Change-Id: I01b6918cf3694cf309301b2e56f39ef1d4670bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485621Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#820202}
-
Kinuko Yasuda authored
Change-Id: Icee91e5c9131e62afc4eca0faad2c1e18ee20556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492380 Auto-Submit: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#820201}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9a16bdb16349..53ee505d93e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC bsep@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1138523 Tbr: bsep@google.com Change-Id: I7ed511867d827852a945af8d61461c398883f06f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494903Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820200}
-
Kushagra Sinha authored
Fix use-after-move in chromeos::AccountManager::GetAccountEmailInternal callback. Change-Id: I463165fe2e642ffed07c5c11c26984d99daf5815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495060Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#820199}
-
Marc Treib authored
Notably, visitors were missing for the custom_nudge_delays field, which meant that this field wouldn't show up in the traffic log in sync-internals. Bug: 1141792 Change-Id: I60ea80be9b026ae2d6a386837f707c2180b17cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494862 Commit-Queue: Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#820198}
-
Tanmoy Mollik authored
Test two different sign-out flows in AccountManagerFragment. When the user is signed in without sync consent, sign out dialog should not be shown and data on device should not be wiped. When the user is signed in with sync consent, sign out dialog should be shown giving the user the choice to wipe device data. Bug: 1138935 Change-Id: Ie31d14b8fac938614dda927076e81344d52d5774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478980Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#820197}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e369f4fe6ec4..4c63602bdb60 2020-10-23 alcastano@google.com Typecheck elements/ElementStatePaneWidget.js with TypeScript 2020-10-23 wolfi@chromium.org Display frame ID in FrameDetailsView for debugging 2020-10-23 patrick.brosset@microsoft.com Refactor the ColorSwatch to use TypeScript and LitHTML web component If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1137438,chromium:1140481 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4b9fdd1aaa72d4075ff0919ae447813b99390da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494901Reviewed-by:
-
Rushan Suleymanov authored
Moved classes: * FakeSyncChangeProcessor * ModelTypeStoreTestUtil * SyncChangeProcessorWrapperForTest * SyncErrorFactoryMock Bug: 948661 Change-Id: Ic2476778322af7b0bf64d071e10d0991dc8c07b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489980Reviewed-by:
Travis Skare <skare@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#820195}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d9ccb94f..cdd7e6fa Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1affd489b188618d14707633ac118e271eb485ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494425Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820194}
-
Bret Sepulveda authored
TBR=jdeblasio@chromium.org Bug: 1139955 Change-Id: Ib622080583b8ebf3764b75513346d179e1be43f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494762Reviewed-by:
-
Marc Treib authored
It was always called directly from ModelAssociationManager::Associate(). The only non-trivial thing Associate() did was make sure it gets called only once per datatype and ModelAssociationManager::Initialize(). DataTypeManagerImpl now takes care of that itself, by storing a map of ConfigurationStats instead of a vector. One small behavior difference is that the ordering of those ConfigurationStats is not the same anymore. AFAICT, nothing depends on the ordering, and anyway each ConfigurationStats entry contains ordering information in the form of "types_configured_before", so this should not matter. Bug: 1102837 Change-Id: I95d71e8fa98b8b382bc182dc11e1fcbd6e58c4f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490109Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#820192}
-
Rushan Suleymanov authored
Without this patch in several cases when the commit request fails (e.g. the server returns any other than 200 HTTP error code), the model type processor doesn't reset transient state for entities. These entities won't be retried on the next sync cycle. In case when there are no new unsynced entities, those entities in the transient state won't be committed. If there is any new unsynced entity, it will be committed and eventually the transient state for all (even previous) entities will be reset. It means that in the most cases the issue is barely noticeable. This CL clears transient state of all entities on any commit failure. In this case the next commit request will collect all data again and commit it. For the integration test the fake server has been slightly changed. It stores the latest commit and get updates requests even on http error and stores the request and empty response to logs for debug print. Bug: 1137817 Change-Id: I50125dcbec9244f10227383a7081320be91b57db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485941 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7dee50774b30..7874beb5c5a1 2020-10-23 landrey@webrtc.org Roll out upload completion token for all requests from specified group If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1114061 Tbr: oysteine@google.com Change-Id: I19df667d17d18ebc8a2bff944682326967f0a2b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493739Reviewed-by:
-
Hiroki Nakagawa authored
This is a follow-up CL for: https://chromium-review.googlesource.com/c/chromium/src/+/2409473/54/content/browser/browser_interface_binders.cc#756 It should be less error-prone to put the binder for Prerender2 in the same BinderMap variant as the binder for NoStatePrefetch. These are enabled in a mutually exclusive way. Bug: 1132746 Change-Id: I441c748c9dc1429550fd9de54cc2e387fbaaf71b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494286Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
