- 13 May, 2019 40 commits
-
-
Evan Stade authored
This splits out the kiosk related mojos from the login controller interface, and removes kiosk_app_info.mojom. It also removes a couple methods from mojom::LoginScreenClient, replacing them with a single callback passed to the KioskAppMenu. TBR=tsepez@chromium.org Bug: 958206, 958204 Change-Id: I59d38c83fc91397d1d0890c87f5b18fe23fac7d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604333Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#659100}
-
Johannes Henkel authored
This depends on the following patch in V8: https://chromium-review.googlesource.com/c/v8/v8/+/1598254 Change-Id: Ic286f68b4cd4cd8be316ffe9ab9af0f6f24e413c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604463Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#659099}
-
Caleb Rouleau authored
This depends on the return code being -1 if nothing is run, which is implemented in https://chromium-review.googlesource.com/c/catapult/+/1605791 This change is safe to commit before https://chromium-review.googlesource.com/c/catapult/+/1605791 since it only does things if the return code is -1. Bug: 944909 Change-Id: I9619b2455c2cfe6e69d91c1d0c8f5a1d9c998e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604339Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#659098}
-
Dana Fried authored
Currently, we pass values into Layer::SetRoundedCornerRadius() as a vector, which means that the values are just an ordered list with implicit correspondence between order and what value they represent. Consider the following code: layer->SetRoundedCornerRadius({3, 4, 5, 6}); Which corner is getting a radius of 3? We have to look at the documentation for the function to find out that the corners are in clockwise order starting from the upper left - but it's not obvious. Passing values with specific semantic meaning in lists and vectors is generally considered an anti-pattern as it is very easy to mix up the order, and even sophisticated editors can't prompt you for the meaning of each value as you enter them. This CL introduces a new class: gfx::RoundedCornersF, which emulates the rounded corners portion of a gfx::RRectF (and indeed, we've added a version of the RRectF constructor that takes a RoundedCornersF). RoundedCornersF provides an explicit way to pass corner parameters (using named fields), and convenient constructors (with named parameters) to create sets of rounded corners with: - all the same radius - four distinct corner radii with equal x and y radii (See issue 961756 for discussion of extending this to distinct x and y radii once certain technical limitations disappear.) One consideration is that the new object is, internally, a list of four float values, while the old API took a vector of four ints. However, internally it was already being converted to an RRectF, which has eight floats. And even better, since there is a four-float constructor for RoundedCornersF, existing code that used a list initializer in calls to Layer::SetRoundedCornerRadius() still compiles (with the values representing the same corners as before, since we've preserved the order). Change-Id: I36d0037f8986468c146adf6fd5eea5c4d5dce9cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600965 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#659097}
-
Ovidio Henriquez authored
Adds a FakeBluetoothChooserClient associated interface that will be used by FakeBluetoothChooser to send FakeBluetoothChooserEvents to the client as they happen. Since this feature completes the Fake Bluetooth scanning API, this change also converts a test to use the new API. BUG=719827 Change-Id: I2770b3642ae93339e16b594591e4b4075e8246c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/961719 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#659096}
-
Mason Freed authored
This is a reland of ceacea9f Original change's description: > Fix backdrop_filter_bounds location for clipped layers > > Previous to this CL, the location of the backdrop filter bounds > rect was incorrect when the containing layer was clipped by the > viewport. In that case, the offset added to the backdrop filter > bounds transform did not account for the clip. It now does, which > should fix at least four bugs. > > Bug: 618913, 927097, 932160, 940917 > Change-Id: I0dc1e4c3dde61210d8f7aa78b2e20f13fc8a2471 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602812 > Commit-Queue: Mason Freed <masonfreed@chromium.org> > Reviewed-by: enne <enne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658920} Bug: 618913, 927097, 932160, 940917 Change-Id: Ibc92ac25d1c2642287220b4e7feef2196bd7e060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608921Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#659095}
-
Oriol Brufau authored
This test includes checks for bug 961407, they can be useful for other browsers like WebKit. I have refactored the test a bit to avoid checking the grids twice after each change, this was superfluous work. BUG=767015 Change-Id: I46c50b4bedcd4852fcc71fe4e37c63bbd37cb8a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607061 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#659094}
-
Tony de Luna authored
This CL fixes a bug where closing the error screen sends network screen exit message to network screen handler. Luckly this does not cause any user visible bugs, but this is not the expected behavior. Now closing the error screen just hides the screen. The default hide callback will make the parent screen visible in the JS side without modifying WizardController's current_screen_. This CL also adds tests that verify the bug fix and that the basic flow of connecting to a network in the error screen works. Bug: 959340 Change-Id: I760b92bd1e1cdbe96059c7941a854f0664f93298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606572 Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#659093}
-
Kush Sinha authored
Adding SAML federated GSuite accounts in Chrome OS Account Manager requires loading non-GAIA URLs inside the Account Manager account additon dialog. Loading these pages triggers a 'resize' event from |authenticator.js|, which in turn causes the opening of a Chrome browser window behind the account addition dialog. |authenticator.js| accepts a parameter: |dontResizeNonEmbeddedPages| to disable this behaviour. Use that on Chrome OS. Bug: 962484 Test: Manually Change-Id: I3014c8bc827f63a52847ebd7ce2e6a76950f7791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609832Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#659092}
-
Antonio Gomes authored
Some users of PostCrossThreadTask end up posting a task to the same thread, which is not the purpose of this Blink primitive. This CL fixes it. No new behavior is expected. BUG=None Change-Id: Idf3157749308f023174375172b204fff667d45b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610317 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#659091}
-
Sebastien Marchand authored
ps1 is a simple file move and rename. ps2 updates the content of the file (to rename the class etc). ps3-4: Rename the file once more (to disk_site_data_store) and update the name of the functions to use Store instead of Database. ps6: The name is not site_data_store. Bug: 961336 Change-Id: I9d94973e980f7a27fcb508237f8905fb7300cf72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602599 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#659090}
-
Jacques Newman authored
* Introduces the concept of "in the tree" vs "ignored" in Blink without changing the actual behavior. No ignored nodes are sent to the browser accessibility tree. * Adds new function IsIgnoredPassThrough, for use when an object is ignored, but should be passed through to the browser-side anyways. This will be used to allow different types of ignored nodes to pass through, instead of all at once. * Refactors browser-side code to walk only the unignored tree. Bug:651614 Change-Id: Idbd85949a8505f8a03a08e3e002bb893619d6757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535171 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#659089}
-
Xiyuan Xia authored
Bug: 958212 Change-Id: Ia09c8202887642a7eed6aa4d253ab77fee29f4f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606680 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#659088}
-
Ben Kelly authored
The LegacyCacheStorageCache must be kept alive as long as there are any outstanding disk_cache Entry objects associated with it. This is for two reasons: 1) If a partial write has occurred, then removing the cache will cause any outstanding runnables to be discarded destroying the ScopedEntryPtr. The ScopedEntryPtr will cleanly close the entry causing it to remain in a truncated state. 2) A second LegacyCacheStorageCache object could be created immedately after and open a new backend that stomps on our existing Entry objects. This CL solves the problem by making LegacyCacheStorageCache hold a handle reference to itself whenever its performing a public operation. This will in turn cause the owning LegacyCacheStorage to keep the cache object alive. Bug: 961752 Change-Id: Icf333341d51c4acd0688626977690d73408c43ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606200 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#659087}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/dab21c6a91a6..2ebf5239782b git log dab21c6a91a6..2ebf5239782b --date=short --no-merges --format='%ad %ae %s' 2019-05-13 ilnik@webrtc.org Reland "Copy video frames metadata between encoded and plain frames in one place" Created with: gclient setdep -r src/third_party/webrtc@2ebf5239782b The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3199cef668c550feaa557c827dc1452dd0d7330a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610250Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659086}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ac5a8cf07ac9..02f2aec13451 Created with: gclient setdep -r src-internal@02f2aec13451 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:891734 TBR=anthonyvd@google.com,alph@google.com,battre@google.com Change-Id: Ib15a4b88b5fdf01622bae598d5bcfac5afa5580a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610248Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659085}
-
Katie D authored
This keeps users from accidentally disabling automatic clicks and therefore locking themselves out of their device by making it so that they need a physical click to re-enable the feature. Dialog is shown when disabling from the accessibility menu in the tray and from the settings WebUI page. Bug: 960526 Change-Id: I681c8bfc1b668e6b290b33d889355b2a6f43500a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601468Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#659084}
-
Zentaro Kavanagh authored
- Forward declare where possible - Remove unused includes - Reorder includes BUG=None TEST=Compiles Change-Id: If353aa7666ffe85255a69102e0ecbcbc6793ffb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606635Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#659083}
-
rajendrant authored
It requires some delay for the XHR request to be populated in PLM. The total pagesize can also be 3-4 KB since favicon.ico could get included after the delay, so GreaterEqual 3KB was used. Bug: 961967 Change-Id: Ic23f93e6d276288a8be71684200b705b982e7c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607621Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#659082}
-
Julien Isorce authored
Useful to specify the color space of the captured data when passing it to the VideoCaptureDevice client. Previsouly it was assuming sRGB for RGB-like formats which resulted in wrong colors rendering. Bug: 945468, 959901, 959919, 959962, 959953, 945468, 959988, 959992 Change-Id: Ic5ef4f0050618dfe3d2d35fac880d710fa122c69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590619 Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#659081}
-
Edin Kadric authored
Screenshot attached in bug. Bug: 962332 Change-Id: I3fb769d29f5749137409364a429b4e5607dd57a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608803Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Edin Kadric <edinkadric@google.com> Cr-Commit-Position: refs/heads/master@{#659080}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b3f6654a5402..9b86955c65aa git log b3f6654a5402..9b86955c65aa --date=short --no-merges --format='%ad %ae %s' 2019-05-13 herb@google.com Add thread safety annotations for SkMutex 2019-05-13 robertphillips@google.com Alter createTestingOnlyBackendTexture methods 2019-05-13 csmartdalton@google.com ccpr: Clip path octo bounds by the scissor 2019-05-13 bsalomon@google.com Add color space and type conversion support to asyncReadPixels Created with: gclient setdep -r src/third_party/skia@9b86955c65aa The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: I8e26af88b17e4ebb119beae96804450b3d689853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610290Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659079}
-
Michael Thiessen authored
We need all Activities running in NoTouch mode to use the UI coordinator to support dialog actions, etc. So this moves ownership of the TouchlessUiCoordinator into ChromeActivity, and restricts the touchless URL bar and tooltips to NoTouchActivity. #issue 962059, presubmit is broken. NOPRESUBMIT=true Bug: 961734 Change-Id: Ib8fb701c4bb981726428a7f81a55fc9fc15bccf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606570Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#659078}
-
David Dorwin authored
https://crrev.com/c/1387151 added a test to webvr/ that checks for "xr". The WebVR API is obsolete, and only "vr" was used with it. This CL copies the test for "xr" to the webxr/ tests and changes the webvr/ test to check for "vr". Change-Id: I0481afc1ad0c1445bf744c1b99307e482f2315af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600152Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#659077}
-
Takuto Ikuta authored
This CL reduced total include for ip_address_space.mojom-blink-forward.h from 0.72MB to 0.22MB. Bug: 862064 Change-Id: I2371e1513a194ecd0275590522522f30983c0527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609737 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#659076}
-
Takuto Ikuta authored
This CL reduced total include for ip_address_space.mojom-blink-forward.h from 0.72MB to 0.66MB. Bug: 862064 Change-Id: I2f7278db9f06158d63a1345cf503d6cf5819f484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609617 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#659075}
-
Toni Barzic authored
The test updates shutdown policy, and waits for the login shelf UI to get updated from the state before the policy was changed. It then verifies that the shutdown/restart button visibility has been updated. This is racy if login shelf state can change for any reason different than shutdown policy value - which started happening since the test was updated to properly set-up enrollment, OOBE complete state. The login UI lands on login screen with GAIA dialog, instead of welcome screen, and GAIA UI is trying to update guest login button visibility. This fixes the test to wait for the shutdown button visibility to change. It observes login shelf UI updates until it detects that the shutdown button has the desired visibility state. Does the smae for lock test, even though that one does not seem flaky for now. Change-Id: I4b61c17c2ef750b9850bbbe68ea406b15197ec81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608525Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#659074}
-
Yeol Park authored
In order to better convey property object ownership, changed CreateSecondaryUiButton() to return std::unique_ptr. Bug: 948287 Change-Id: I4a496050e03705ccfee063b852ef35f5c61761e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598902Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Yeol Park <peary2@gmail.com> Cr-Commit-Position: refs/heads/master@{#659073}
-
Toni Barzic authored
GetDisplayNearestWindow returns a temp object, so we should not use a reference to it's return value. Change-Id: Ia81b1d1a74e7e3513bf29504d8e824e28f2b116b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608523 Auto-Submit: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#659072}
-
Brian White authored
b/131237867 Change-Id: Iaeb41b0256ae366243f2ab0ab653ef6bb6566bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585939 Auto-Submit: Brian White <bcwhite@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#659071}
-
Dominic Mazzoni authored
The Get Image Descriptions from Google feature provides a computer-generated description for unlabeled images on the web. Importantly, when there's an unlabeled link that contains a single image, it's supposed to apply the same automatic description to the link, too - because some screen readers only pay attention to the accessible name of the link. There was a bug when the image was absolute-positioned - that caused the link to have zero width and height, which made it ineligible for annotation. The fix is to only consider the size of the image when deciding whether a node is eligible for annotation, rather than the size of the link. Bug: 962370 Change-Id: I1a8d845666d2a508e17466da75bce0c88cd1d3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608922 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#659070}
-
Tarun Bansal authored
Record WiFi signal strength as an UMA metric. The next CL will do the plumbing to use it for adjusting the network quality. Skipping presubmit because of crbug 962059. NOPRESUBMIT=true Change-Id: I439cc6561fd2f368537cd567dcf7d3551449073d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551953 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#659069}
-
Oleg Davydov authored
Changed it to IDS_POLICY_SOURCE_DEVICE_LOCAL_ACCOUNT_OVERRIDE as overrides exist both in public sessions and kiosk modes. This is a follow up of CL 1602727, where we've changed corresponding option of PolicySource enum. Change-Id: I7ea0d422025fd182a8497b62dc7df13588cdbd6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604271 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#659068}
-
Kuo Jen Wei authored
Bug: 956858 Change-Id: Id0b36488deeede4b6114f1e2cbe3df49a5fd6b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605385Reviewed-by:
Sheng-hao Tsao <shenghao@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#659067}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a19080a956b5..a7a375565cdb git log a19080a956b5..a7a375565cdb --date=short --no-merges --format='%ad %ae %s' 2019-05-13 chrisforbes@google.com Wire up NoPerspective to interpolation Created with: gclient setdep -r src/third_party/swiftshader@a7a375565cdb The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: I3ca828e2d79d3ee9864a2aa45a1e89d98bf8e5b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610282Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659066}
-
Dan Harrington authored
And prevent it from being downloaded later. Note that I manually tested that this does work. Change-Id: I3b445f1a5fe8fa675ac9c7addc96b29eb8da12ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536606 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#659065}
-
Xiyuan Xia authored
- Get sign-in screen and user PrefService from SessionControllerClient instead of mojom::PrefConnector. - Add a TestPrefServiceProvider to create and own various PrefServices to outlive TestSessionControllerClient; - Move Shell:: RegisterSignin/UserProfilePrefs to ash_prefs.h in public/cpp and call them from browser prefs to register as part of the browser; - Remove RegisterForeignPref for user prefs in ash/* code since they are now part of the browser user prefs; Bug: 958212 Change-Id: Ic4d9f951e5fd2f255c5274906115fc4aeb2dcc41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603325 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#659064}
-
Robbie Gibson authored
After talking to the designers, they want this image on the leading edge of the popup instead of the trailing edge. Bug: 962436 Change-Id: Ib9a041360c4c7ffc1637700aa7cb471a8c8084cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609777 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#659063}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0379d8cfeac1..dab21c6a91a6 git log 0379d8cfeac1..dab21c6a91a6 --date=short --no-merges --format='%ad %ae %s' 2019-05-13 srte@webrtc.org Fix for crash in frame matcher on short runs. 2019-05-13 peah@webrtc.org AEC3: Remove unused code Created with: gclient setdep -r src/third_party/webrtc@dab21c6a91a6 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1ce03aaa95c714323cc33e619586c3180d59b076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610284Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659062}
-
smut authored
To ensure it gets the right number of cores when migrated to builderless. A no-op now, since builder:android-marshmallow-arm64-rel currently implies cores:16. Bug: 956776 Change-Id: I785938a91a7cf493ece0b0579cc9d8f106f673ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606637 Auto-Submit: smut <smut@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#659061}
-