- 05 Aug, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/93ee550c1fe8..8c1079cc71d7 git log 93ee550c1fe8..8c1079cc71d7 --date=short --no-merges --format='%ad %ae %s' 2019-08-05 taylori@google.com Update systrace to use traceconv Created with: gclient setdep -r src/third_party/catapult@8c1079cc71d7 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: None Change-Id: Ic9663d9d7645e4017f21fd4089eb62dda590a5a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734758Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683966}
-
Matthew Cary authored
This change upgrades RTCVideoEncoder output_buffers_ from base::SharedMemory to the new API base::UnsafeSharedMemoryRegion. The only functional difference is that the region is mapped for each BitstreamBufferReady() rather than only once when the shared memory is allocated. Bug: 849207 Change-Id: I6404b395d3b676f677ff9e9d6ccab3ff206e4099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697642 Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#683965}
-
Peter Marshall authored
Ongoing effort to deprecate this API Bug: chromium:913887 Change-Id: I01f1390d0006d8a8ffc5271f722c5d12dd39931a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736352Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#683964}
-
Stephane Zermatten authored
on_terminate_prompt_ is left over from a previous refactoring. It was checked but never actually set. This change removes it completely. Bug: 981363 Change-Id: I8ca8142b6bfe66f0e36d186b8559a31fcbf92313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735151Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#683963}
-
Daniel Vogelheim authored
Currently, Trusted Types are enforced also in extensions' worlds, which is unintentional. Bug: 986209 Co-Authored-By:
koto <koto@google.com> Change-Id: I5c4bbb03b715d1d0d3c3bfbcd7dbdb05caa88d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712683 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#683962}
-
Eldar Rello authored
Bug: webrtc:3098 Change-Id: I58b1b22d13259102294a00914e05b42b2b41b36e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731931 Commit-Queue: Eldar Rello <elrello@microsoft.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#683961}
-
Rune Lillesveen authored
We started not marking Document with ChildNeedsReattach() in [1], hence the common ancestor for LayoutTreeRebuildRoot would be null instead of Document when marking documentElement(). That caused an issue with documentElement() not becoming a common root. The plan is to always use documentElement() instead of Document as the top-most root node for all traversal roots and simplify this again. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1727290 Bug: 989659 Change-Id: Id6f71d98f130e3f9d84930e28e90f14175f44718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733527Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#683960}
-
Juan Antonio Navarro Perez authored
We need some test coverage for benchmarks still using the legacy Telemetry value system. Bug: 990036 Change-Id: I597a1c0149031adf6ec65353634beab6ca5ae48f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731840Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#683959}
-
Marc Treib authored
Bug: 983940 Change-Id: I5a64cdec49eec883d2ac1d9933c101d05ee8a47d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724513Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#683958}
-
Himanshu Jaju authored
Bug: 982229 Change-Id: I2000e18b7e5bfe3a9ec7d9b8906251bec68d2937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735450 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#683957}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=braveyao@chromium.org, wez@chromium.org Bug: 968047 Change-Id: I5223612c9d4bf031e86a570bec68bd75c68dbcd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729163 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#683956}
-
Dominic Farolino authored
This CL introduces the PrefetchRedirectError flag. When enabled, prefetch requests get a redirect mode of kError, instead of the default kFollow. Consequently, prefetches that redirect are "cancelled", however the corresponding redirect responses are not evicted from cache, and can be matched later, which is our goal. The current proposal mentions that redirect mode should be manual, with the goal being: - To not follow redirects - Store redirect responses in the HTTP cache In Chromium, to satisfy the above conditions with kManual redirect mode, we'd have to implement extra behavior to treat kManual requests differently. We can satisfy the above conditions with kError in Chromium, and avoid the extra special-handling work. This is sufficient for initial experimentation. This CL also includes prefetch browsertests ensuring this behavior is both correct, and tied to the flag. R=kinuko@chromium.org, yhirano@chromium.org Bug: 988956 Change-Id: I449be39a02b3806d3ab14c45a6cb491fcab9bb66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725554 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#683955}
-
Lowell Manners authored
This CL updates the logic when a page is restored from the back-forward cache to more closely resemble a normal navigation. The over-arching goal here is to share as much logic with normal navigations as is feasible, to limit the maintenance cost of back-forward cache navigations. This code should only be run when the back-forward cache experimental option is enabled, and should not have any effect on Chrome's behavior by default (back-forward cache is disabled by default). Change-Id: I9c800e707a1cfd0289572404428f64d1fb6605e3 Bug: 976697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667452Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#683954}
-
Arthur Hemery authored
The current behavior is to have the NavigationSimulator handle only the navigation itself and leave the loading to unit tests. In practice a lot of code works by "accident", never stopping load between different navigations, etc. To make the overall approach about loading more manageable, we switch the paradigm to finish loads by default. This CL is mostly about maintaining tests that rely on the load being ongoing after a navigation. For these, we introduce explicit parameters in the NavigationSimulator. Bug: 979200 Change-Id: I50bf458c487023843d01f753bc5a5c309dc094b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709582Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#683953}
-
Arthur Hemery authored
This CL removes all of the references to PlzNavigate in the comments of components/. Change-Id: I5ab774c0c1f5c5ed4d803f64c08b8611404e8073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729084Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#683952}
-
Xiang Ji authored
Change-Id: I1b5d4a9abe48084a919febc3398849b2be2b1042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728179 Auto-Submit: Xiang Ji <jxiang@google.com> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#683951}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dc2c5c5a419e..73ec5b06ff9e git log dc2c5c5a419e..73ec5b06ff9e --date=short --no-merges --format='%ad %ae %s' 2019-08-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 0b70972a29c7..4f14b4c8cc25 (1 commits) Created with: gclient setdep -r src/third_party/angle@73ec5b06ff9e The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Bug: chromium:None Change-Id: I5ad084d04fd556c7cb2c908970f11c0ab61eb156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735895Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683950}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I43d33469da6f95e9a997f154433a84d0b3aefc0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700849Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#683949}
-
Himanshu Jaju authored
Bug: 982229 Change-Id: Ibb2303765ebcffca2d572d89b0a9508ec87e34e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731896 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#683948}
-
Jazz Xu authored
Bug: 986231 Change-Id: I621b1309ad0920f57ca338ee607a518f2843263e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731924Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#683947}
-
Pavol Marko authored
In the context of https://crbug.com/939344, it will be possible to specify that some policy-provided certificats only apply in some scopes. Passing a list of certificates to PolicyCertificateProvider::Observer implementations is not very meaningful then anymore. Instead, Observer implementations should retrieve the list of certificates they need from PolicyCertificateProvider explicitly. Also, many of the observer implementations already don't care about the passed list. Bug: 939344 Test: browser_tests and unit_tests still pass Change-Id: Icce961c8688fa05ed78cd4d2bad5fe43fc2549b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729263Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#683946}
-
Sylvain Defresne authored
Inject dependencies into AdvancedProtectionStateManager instead of passing a Profile* and letting the class access to its dependencies internally (this allow for easier injection in tests). Change AdvancedProtectionStatusManagerFactory to return the same instance for off-the-record Profiles as for regular Profile (thus eliminate static methods on AdvancedProtectionStateManager) and fix the getter to take a Profile* as parameter. Add unit test for AdvancedProtectionStatusManagerFactory to ensure the correct instance is returned for off-the-record Profiles (and remove uses of TestingProfile in AdvancedProtectionStatusManagerTest). Change RequestsAdvancedProtectionVerdicts() method to not be static (as the code to get the correct Profile is now in the factory) and remove IsUnderAdvancedProtection() static method as the getter can be used instead. Since the AdvancedProtectionStateManager instances are only created by the factory in production code, there is no need to check if the profile is off-the-record or not (the factory does the check) and it is possible to use a SequenceChecker instead of checking for the UI thread (since the factory will create the instance on the UI thread/sequence anyway). Fix client code to uses the factory to call the method that were previously static methods. Bug: 984487 Change-Id: I8f6a57afeee438419b6e4db59147164d5471fb9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707353 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#683945}
-
Edvard Thörnros authored
This is the second commit in the series of updating all the old svg animation tests. The usage of testharness has replaced the older SVGAnimationTest.js for all where it's suitable. No functionality should have changed and the tests should cover almost the same. In all of the animations where there is a sampling at T=0, where it was assumed that no animations had started. Which didn't work flawlessly when moved to the new system, it has thus been removed. Bug: 985335 Change-Id: If5d6d879be3ccd3b14467eebaa4c9a2c03128f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733589 Commit-Queue: Edvard Thörnros <edvardt@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#683944}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a02d5ef7..f69a6724 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I59acbf31e23e417a8c571240c405a9bbf6b5751f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735239Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683943}
-
Christopher Gunadi authored
When policy is set on server, background and foreground of FilesApp will listen to changes in pref and hide/show the "Install with Linux (Beta)" context menu option Follow up CL to http://crosreview.com/1712667 Bug: 983997, 983998, 988375 Test: compile Change-Id: I666cb79e48e876cb222a0dead3e6cf96a5a0a28a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730907Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Christopher Gunadi <chrisgunadi@google.com> Cr-Commit-Position: refs/heads/master@{#683942}
-
Alexandre Courbot authored
We have a lot of chromium-style errors happening when enabling V4L2 for a non-Chrome OS build, e.g: ../../media/gpu/v4l2/v4l2_decode_surface.h:139:7: error: [chromium-style] Classes that are ref-counted should have explicit destructors that are declared protected or private. class V4L2RequestDecodeSurface : public V4L2DecodeSurface { and ../../media/gpu/v4l2/v4l2_slice_video_decoder.h:97:5: error: [chromium-style] Complex constructor has an inlined body. DecodeRequest(scoped_refptr<DecoderBuffer> buf, DecodeCB cb, int32_t id) This CL fixes these errors. Bug: 990690 Test: VDA unittest passes on Kukui. Change-Id: I3485c855f8affefb7ac99732e11fa78466081d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736346Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#683941}
-
Alice Boxhall authored
Fixing issue found by FindIt https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzQ0NzBkNDFkYjA3NDIwOTBlOWYxYjQ5NmZhOTA2MDBmNDdjNTMyYTgM ... revealed by test added in https://crrev.com/c/1731634 Change-Id: Ic2f2c381a4aa714172ff3487e05dca10744213e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736206 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#683940}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b976207c9e04..5a81193b1377 Created with: gclient setdep -r src-internal@5a81193b1377 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I655ed715cb9e148d14c18c7585b6872661e64946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736401Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683939}
-
Adam Rice authored
Split out code from DOMWebSocket that will be shared with WebSocketStream into a new class, WebSocketCommon. The major methods that have been moved are Connect() and CloseInternal(). Connect() in particular has some security-critical checks that should not be duplicated. Some members of DOMWebSocket have been moved to WebSocketCommon because they need to be modified by WebSocketCommon methods. The most important of these is |status_|. This is part of the implementation work for WebSocketStream. The design doc for the work as a whole is at https://docs.google.com/document/d/1XuxEshh5VYBYm1qRVKordTamCOsR-uGQBCYFcHXP4L0/edit BUG=983030 Change-Id: Idba0d5181b2a6946f65d10083f9e15a0fe5e7ec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731010Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#683938}
-
Tomasz Moniuszko authored
The directive breaks jumbo build with "error : using namespace directive in global context in header". It's also against Google C++ Style Guide rules. Change-Id: I4b2bb154fca3b59bc0561727b1b4e12ca23ec103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731939Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Cr-Commit-Position: refs/heads/master@{#683937}
-
Alex Danilo authored
Logic for deleting a summary panel was checking the total number of panels active, rather than the number of 'progress' panels. Use the count of progress panels as the criteria for removal of the summary panel display. Bug: 987931 Change-Id: I0ac1aa47fbcd297b916a1047b945c6682ee9884f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732589Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#683936}
-
Matt Giuca authored
This reverts commit 7a5df8d5. Reason for revert: Suspect it introduces timeout https://crbug.com/990692 DevToolsSanityTest.TestDeviceEmulation is reliably timing out with "[FAILED] Timeout exceeded: 20 sec". Original change's description: > Don't use NOTIFICATION_BROWSER_CLOSE_CANCELLED in tests > > Bug: 268984 > Change-Id: Ie41cb913d29ad690b9364d9c478c7a3c4771f607 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730591 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683662} TBR=avi@chromium.org,estade@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 268984, 990692 Change-Id: Ia1213f589b2cf3b966381886f2d60ff646ae7103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734735Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#683935}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a56838e0ef52..594583382d4e git log a56838e0ef52..594583382d4e --date=short --no-merges --format='%ad %ae %s' 2019-08-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 369f9e5df60b..dc2c5c5a419e (12 commits) 2019-08-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 01452feb..d67ae722 (443 commits) Created with: gclient setdep -r src/third_party/skia@594583382d4e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@google.com Bug: chromium:None,chromium:None Change-Id: I02cd44793512b0769b2a4d7d4991e8cf66748579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736392Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683934}
-
David Staessens authored
This CL increases the timeout used when waiting for events in the video_decode_accelerator_perf_tests. The MeasureCappedPerformance test decodes the video in real-time, so we should make sure the timeout is at least as large as the video's duration. The timeout is also increased when writing video frames to disk in the video_decode_accelerator_tests, as this can take a lot of time. TEST=./video_decode_accelerator_tests on eve BUG=None Change-Id: Iaf92d32cae755e6d0afe50571a87bb44a87c561c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731641 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#683933}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I481162f7297b7bfd1b3322ecba110155f2b45e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736227Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683932}
-
Hiroki Nakagawa authored
In WebSharedWorkerImpl::TerminateWorkerThread(), following if-conditions (1) if (shadow_page_ && !shadow_page_->WasInitialized()) (2) if (worker_thread_) are mutually exclusive, so we don't have to check the both conditions. Bug: 987850 Change-Id: Ibfac267d4ed684966853c606a09ab2fd8bb31e05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734733Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#683931}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/75502974..a02d5ef7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I12e833bd76ce4de9293335c74f2da18b4b3b3e10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734831Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683930}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/747e495a62fa..b976207c9e04 Created with: gclient setdep -r src-internal@b976207c9e04 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Iba6a8046c067f436af5731af0b3e6b57857aa65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736263Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683929}
-
Matt Falkenhagen authored
This fixes a race in the fast path taken by ServiceWorkerNavigationLoaderInterceptor when there is no in-scope registration for the navigation. In this path, the interceptor would elect to not handle the request, while posting a task to the IO thread to initialize the provider host. The navigation could commit before the provider host initialized. Before this CL ============== 1. The interceptor on the UI thread creates the inner interceptor and posts a task to the IO thread to start it. If there are no registrations, it also runs the callback with null, indicating it will not handle the request, so navigation continues. 2. The IO thread task creates the provider host and info. It sets the host in ServiceWorkerNavigationHandleCore and posts a task to pass info to the UI thread. 3. The UI thread task sets the info in ServiceWorkerNavigationHandle. 4. On navigation commit on the UI thread, the info from the navigation handle is sent to the renderer. The problem here is 3 and 4 can race, if the callback was run with null in step 1. After this CL ============= 1. The interceptor on the UI thread sets the info in ServiceWorkerNavigationHandle. As before, it creates the inner interceptor, and passes the other endpoints of the info to it, and as before, runs the callback with null if appropriate. 2. As before, the IO thread task creates the provider host, now binding it to the endpoints for info passed from the IO thread. It sets the host in ServiceWorkerNavigationHandleCore. 3. On navigation commit on the UI thread, the info from the navigation handle is sent to the renderer. Bug: 989863 Change-Id: I4c359827b28160fdb849621b1fdf547101b915ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734173 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#683928}
-
Tetsui Ohkubo authored
As ExoRawGamepadInfo is enabled by default since M77, we can now remove old code of ARC gamepad support. TEST=arc.Gamepad TEST=GamepadEventConverterEvdevTest BUG=b:138767224 Change-Id: I95649e34830c15b8a648a97702404de89e62c6d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728211 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Mitsuru Oshima (OOO 8/5,6) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#683927}
-