- 14 Feb, 2019 40 commits
-
-
Nico Weber authored
This CL was uploaded by git cl split. R=japhet@chromium.org Bug: 926235 Change-Id: I46f54cabb463e6322effde6316335e8d5e04abb8 Reviewed-on: https://chromium-review.googlesource.com/c/1464130 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#632369}
-
Daniel Bratell authored
There are two namespaces in extensions named GetRefererrChain and in jumbo builds the identically named namespace aliases create for them clashed. This just uses the full namespace name instead of using aliases so that it's always clear (to compiler and humans) which one is used. Bug: 914411 Change-Id: I43336e962a82756bf4be7db74417c6a1fc78e889 Reviewed-on: https://chromium-review.googlesource.com/c/1472571Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#632368}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6fe9b9821a1a..1541c8ba7a7e git log 6fe9b9821a1a..1541c8ba7a7e --date=short --no-merges --format='%ad %ae %s' 2019-02-14 enga@chromium.org Remove |start| and |size| from buffer mapping 2019-02-14 enga@chromium.org Split wire tests into multiple test files 2019-02-14 cwallez@chromium.org QueueSumit: Validate commands != nullptr before checking they are valid Created with: gclient setdep -r src/third_party/dawn@1541c8ba7a7e The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:931880 TBR=cwallez@chromium.org Change-Id: If917d0170c30ee1d2cbb1bf8b9e621edc9e1aadd Reviewed-on: https://chromium-review.googlesource.com/c/1473879Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632367}
-
Yuri Wiitala authored
This moves TabCapturePerformanceTest and CastV2PerformanceTest into browser_tests. By default, they have been changed to run in a quick- check mode. When run for performance testing on the perf bots, the additional --full-performance-run command line switch will be required. The performance_browser_tests isolate config has been changed to run browser_tests with the --full-performance-run switch, gtest filters, and timeout overrides. Also, the old performance_browser_tests GN test target has been turned into a simple group target that groups the necessary data dependencies for running on the perf bots. This change also includes some changes to allow the tests to complete in the absence of tracing data when in quick-check mode. While most bots do collect a reasonable amount of tracing data in a few short seconds, one or two don't always do so. Unfortunately, we can't justify making the CQ run longer to force data collection in all cases. Bug: 804191 Change-Id: I2de6c0b94453981fb0d9015f6b3f0e42f57cc2a6 Reviewed-on: https://chromium-review.googlesource.com/c/1428399 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#632366}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/126ac6365c3c..10f3c40674e4 git log 126ac6365c3c..10f3c40674e4 --date=short --no-merges --format='%ad %ae %s' 2019-02-14 bungeman@google.com Don't respect FontConfig matrix for bitmap fonts. 2019-02-14 fmalita@chromium.org [SVGCanvas] Clean up public factories 2019-02-14 bungeman@google.com Defer loading particle effect to load time. 2019-02-14 robertphillips@google.com Baulk at creating wait semaphores if we can't always delete them 2019-02-14 michaelludwig@google.com Add blendmode to GrRTC::drawTexture 2019-02-14 egdaniel@google.com Use kRGB_888x_SkColorType when importing R8G8B8X8 AHB. 2019-02-14 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 1f0e830f..b698b62f (516 commits) 2019-02-14 halcanary@google.com resources: add text for testing shaper 2019-02-14 egdaniel@google.com Add kRGB_888X_GrPixelConfig Created with: gclient setdep -r src/third_party/skia@10f3c40674e4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I06dfd4e1a0a633f695e0a4008d02f7f77ed5f377 Reviewed-on: https://chromium-review.googlesource.com/c/1473874Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632365}
-
Alexandros Frantzis authored
It's likely that at some point in the past Exo didn't properly emit release events for buffers that were still attached to a surface when that surface was destroyed. Add this test to check that Exo now provides the expected behavior and ensure we don't regress in the future Change-Id: Ic73a49aebd9693b701c77580645d49e32dd96aca Reviewed-on: https://chromium-review.googlesource.com/c/1458258Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#632364}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ffa447f419e1..0444f9acb88d git log ffa447f419e1..0444f9acb88d --date=short --no-merges --format='%ad %ae %s' 2019-02-14 manojgupta@google.com chromeos_config: Make {arm64-generic|kevin64}-paladin important. 2019-02-14 cjmcdonald@chromium.org chromeos_config: Enable internal manifest for goma-full builder 2019-02-14 dgarrett@google.com default PreCQ: Remove betty-arcnext-pre-cq 2019-02-14 evanhernandez@chromium.org cros branch: Validate version after syncing. 2019-02-14 evanhernandez@chromium.org cros branch: --force overrides version check. 2019-02-14 evanhernandez@chromium.org cros branch: Final cleanup. 2019-02-14 evanhernandez@chromium.org cros branch: Users confirms generated branch name. Created with: gclient setdep -r src/third_party/chromite@0444f9acb88d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ia2c7e5d2d9ef7a8dba0808aaad32e0c8e6aa6b8d Reviewed-on: https://chromium-review.googlesource.com/c/1473873Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632363}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0167a20b0af8..1b0047f21017 git log 0167a20b0af8..1b0047f21017 --date=short --no-merges --format='%ad %ae %s' 2019-02-14 stevenperron@google.com Add pass to remove dead members. (#2379) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@1b0047f21017 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idef7a1d3aa1d0201af32934afa3275925caa16f6 Reviewed-on: https://chromium-review.googlesource.com/c/1473871Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632362}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/52047de4d41f..77874e2ca341 git log 52047de4d41f..77874e2ca341 --date=short --no-merges --format='%ad %ae %s' 2019-02-14 timvp@google.com Vulkan: Reduce Default Descriptor Pool Max Sets Created with: gclient setdep -r src/third_party/angle@77874e2ca341 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I12682e011aa292292d5f04bf459dac8e9bf3b541 Reviewed-on: https://chromium-review.googlesource.com/c/1473872Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632361}
-
Eugene But authored
Previously this class was used for SadTab presentation. Bug: 616244 Change-Id: I8f8fcf722e79a723dd279c0be5f4348e3876069e Reviewed-on: https://chromium-review.googlesource.com/c/1467983Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#632360}
-
Will Harris authored
BUG=931436,767906 Change-Id: Ic1a6eb88edcf3dbd06845d0d83230b1d8858f8f0 Reviewed-on: https://chromium-review.googlesource.com/c/1471255 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#632359}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/81bd0ea1ec21..4976b9f5f855 git log 81bd0ea1ec21..4976b9f5f855 --date=short --no-merges --format='%ad %ae %s' 2019-02-14 treehugger-gerrit@google.com Merge "Break up BookkeepingThread::HandleBookkeepingRecord." Created with: gclient setdep -r src/third_party/perfetto@4976b9f5f855 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I27461becba7ecb3e9f3f4ad35bdbead5b225e56e Reviewed-on: https://chromium-review.googlesource.com/c/1473876Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632358}
-
Lily Chen authored
This CL changes the expires field of a NEL policy from base::TimeTicks to base::Time. This will make it easier to serialize and deserialize policies for persistent storage and, per the comment in //base/time/time.h, a base::Time is more appropriate for tracking expiration times. Bug: None Change-Id: Ib4530a97c178441228f42c46ac5195e04e9ba7df Reviewed-on: https://chromium-review.googlesource.com/c/1461327 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#632357}
-
proberge authored
Change-Id: I7ac0ec999afead7d39012b3a22b5b77e1670def0 Reviewed-on: https://chromium-review.googlesource.com/c/1468401Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@google.com> Commit-Queue: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#632356}
-
Sam Goto authored
We mocked out the android implementation in our early implementation, which we address here. The AndroidIdleDetector makes bridge between the C++ idle detection system and Android's Java Broadcast receivers. Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/OuwzBmH02M4 Design doc: https://docs.google.com/document/d/1_XlwY3NuG2HwWEYVrR-MNvw_i4hj5ZNj3gKvxWqO0FU/edit Bug: 878979 Change-Id: I2a6c288c750574f1d777115d9e574c66a3dcbbdb Reviewed-on: https://chromium-review.googlesource.com/c/1415296Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Sam Goto <goto@chromium.org> Auto-Submit: Sam Goto <goto@chromium.org> Cr-Commit-Position: refs/heads/master@{#632355}
-
Joey Arhar authored
I forgot to add a null check as Dmitry suggested here: https://chromium-review.googlesource.com/c/chromium/src/+/1357666/4#message-bc921121ce2c839de5e6a614a51ae48952d1a53a Bug: 908592 Change-Id: I32d46fd2feef20b7c129ea5bf7075fd386befcb9 Reviewed-on: https://chromium-review.googlesource.com/c/1471220 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#632354}
-
Peter Collingbourne authored
This is required for the test to pass on Android P. Bug: 931480 Change-Id: I65dc175ed754a4201204bfdaf1cacd70d5f7e0df Reviewed-on: https://chromium-review.googlesource.com/c/1471462Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#632353}
-
Rohit Rao authored
For EG2 tests, we'd like to use ios/web/public/test/http_server from the test process, but without pulling in all of //ios/web. Moving this utility function allows http_server to depend only on //base, //net, and //url. BUG=930859 Change-Id: Ia1e35b04089a3bd2cf00ee0e7a663783ac2762a7 Reviewed-on: https://chromium-review.googlesource.com/c/1473616Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#632352}
-
Carlos Caballero authored
As discussed in https://crrev.com/c/1449653 add a trace to make it easier to spot priority inversions happeingin due to this wait. Bug: 927548 Change-Id: I7f96079c5b290eabadc4b127ee15ece52f57f356 Reviewed-on: https://chromium-review.googlesource.com/c/1454919 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#632351}
-
Koji Ishii authored
Some fonts have kerning between some characters and the space character, which is unsafe if the line wraps there and the space becomes a trailing space to be removed. This patch avoids such reshaping unless the width of the text is visible. This patch improves: ArabicLineLayout by 40% chapter-reflow-once-random by 40% loading.desktop FCP:layout by 1-4% Bug: 636993 Change-Id: Ifc190ccbce164b1ba498e922f98ffaa9b1c181f4 Reviewed-on: https://chromium-review.googlesource.com/c/1469846 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#632350}
-
Lukasz Anforowicz authored
Extension developers have kindly tested that their extensions are not affected by CORB or have fixed their extensions to avoid making cross-origin requests from content scripts. Such extensions can be removed from the CORB allowlist. Bug: 846346 Change-Id: Ice60ef3181c32546862942652fad0791bdccd0b3 Reviewed-on: https://chromium-review.googlesource.com/c/1473821Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#632349}
-
Pavel Feldman authored
Bug: 929862 Change-Id: I6ff598a1157715cef02527bd8a5630f1e54d8500 Reviewed-on: https://chromium-review.googlesource.com/c/1473841Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#632348}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8d6b229a. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" af3b056c "[WPT] [wasm] Add JS-API tests for wasm threads" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." 6cf9dcc6 "Use testdriver Action API in WPT pointerevent touch tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-method-basic-card NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I6c0f82cd233a140ce097d165a18fb728fabcbbeb Reviewed-on: https://chromium-review.googlesource.com/c/1473544Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632347}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e6fcdfa5bb6e..db71c92c63fd git log e6fcdfa5bb6e..db71c92c63fd --date=short --no-merges --format='%ad %ae %s' 2019-02-14 thestig@chromium.org Add an ASSERT() in CPDF_DIBBase::ContinueLoadDIBBase(). Created with: gclient setdep -r src/third_party/pdfium@db71c92c63fd The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia38dfadc6173f5db44cb57f0ef271e9f28c7ab59 Reviewed-on: https://chromium-review.googlesource.com/c/1473870Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632346}
-
Vladimir Levin authored
This patch fixes one spot that navigates up the ancestor chain to first check whether the document has any locked display locks. R=chrishtr@chromium.org Bug: 882663 Change-Id: I461d01e339ecd82ff14e3732dfa1cec79c054c9c Reviewed-on: https://chromium-review.googlesource.com/c/1473812Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#632345}
-
Stephen McGruer authored
The 'middle' concept for steps was never standardized or shipped in any other browser. As far as I can tell we never actually shipped it either: i. On the CSS side we marked it as a valid parse but didn't allow the value; you ended up with the default timing (so e.g. getComputedStyle would return 'ease'. ii. On the JS side we allowed it for animate() only if you had specified the WebAnimationsAPI flag, i.e. it never shipped default-enabled. Given this, the UseCounter is expectedly basically zero (https://www.chromestatus.com/metrics/feature/timeline/popularity/2024) and so I don't believe an intent to deprecate and remove is necessary. Bug: 646265 Change-Id: I986f0098f2d6af47d320162c15a461c57335eb96 Reviewed-on: https://chromium-review.googlesource.com/c/1470395Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#632344}
-
Yann Dago authored
Bug: 925931 Change-Id: Ie1b4f24d019d39743f1cb76241988d2b52d4920c Reviewed-on: https://chromium-review.googlesource.com/c/1440223Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#632343}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bfcb02bd9f4d..dbffda048f2d Created with: gclient setdep -r src-internal@dbffda048f2d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0a26e90e2de1142657ec255bbedd2b9f8aa5f5f6 Reviewed-on: https://chromium-review.googlesource.com/c/1473810Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632342}
-
Ryan Sturm authored
This removes the entry from fieldtrial_testing_config.json (all finch experiments are already turned down). Bug: 909916 Change-Id: I8f3e695d3d5a3f3ddad0ebca830f34ddd3cbed67 Reviewed-on: https://chromium-review.googlesource.com/c/1471309Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#632341}
-
Antoine Labour authored
Only GLES2CommandBufferStub really needs it. It's still an implementation detail on RasterCommandBufferStub, but will be removed in a follow-up. Some media code needs access to the ContextGroup, it takes it now from the DecoderContext, noting that this only works for GLES2 decoders (the only use case). We make sure to check its existence early. Bug: None Change-Id: I7b66149e23ecce678afc9fafa3337e4081e32cb1 Reviewed-on: https://chromium-review.googlesource.com/c/1471454 Commit-Queue: Antoine Labour <piman@chromium.org> Auto-Submit: Antoine Labour <piman@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#632340}
-
Ryan Sturm authored
This turns on PreviewsDisallowedOnReloads for tests. Change-Id: I3d9a65d0caf71da133d2dd78eb3d6a1b173a3a33 Reviewed-on: https://chromium-review.googlesource.com/c/1471308Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#632339}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f0c366b461ed..d036c6582e13 git log f0c366b461ed..d036c6582e13 --date=short --no-merges --format='%ad %ae %s' 2019-02-14 hofbauer@webrtc.org Clarify and unify outgoing and incoming packet loss rate plots. 2019-02-14 nisse@webrtc.org Update test code to use EncodedImage::Allocate 2019-02-14 perkj@webrtc.org Always offer transport sequence number header extension for audio 2019-02-14 nisse@webrtc.org Revert "Update VP9EncoderImpl to use EncodedImage::Allocate" 2019-02-14 kron@webrtc.org Make recv_deltas optional in TransportFeedback packets 2019-02-14 hta@webrtc.org Allow DtlsTransport::Information() to be called off-thread 2019-02-14 terelius@webrtc.org Break out parameters from EventLogAnalyzer to AnalyzerConfig struct. Created with: gclient setdep -r src/third_party/webrtc@d036c6582e13 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:none,chromium:931692,chromium:907849 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibf144fa896480427b032454ff966d3f60c412642 Reviewed-on: https://chromium-review.googlesource.com/c/1473554Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632338}
-
Robert Flack authored
cc::UpdateTickingType::FORCE is only used in two circumstances: 1. From ElementAnimations::InitAffectedElementTypes. 2. From ElementAnimations::ElementRegistered. Since InitAffectedElementTypes is only called when constructing a new ElementAnimations, the call can be moved to the constructor such that we can guarantee the keyframe_effects_list_ is empty and thus remove the call to UpdateKeyframeEffectsTickingState(FORCE). When called from ElementRegistered, we are about to set has_element_in_active_list or has_element_in_pending_list which will result in the keyframe effect having an element in a list giving the same behavior that force was being used to provide. The other possible side effects of force seem unintentional. Change-Id: I6128793e953ad2e59fbc7657033995292c204f48 Reviewed-on: https://chromium-review.googlesource.com/c/1469070 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#632337}
-
Ryan Sturm authored
This CL intends to allow integration tests (for HTTPS server previews) to test end-to-end behavior of reporting to the right end point. Instead of waiting a minute for the test to finish, having a faster delay is preferable. Bug: 931411 Change-Id: I828d51f1b2faecbbd8dc38fd75d6f39e8fa9655f Reviewed-on: https://chromium-review.googlesource.com/c/1471214Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#632336}
-
Orin Jaworski authored
The in-suggestion side-button Pedals were experimentally considered along with dedicated suggestions, but dedicated suggestions were found to be preferred, so this CL simplifies the Pedals code. The #omnibox-pedal-suggestions flag is reduced from enum to bool, and related code is changed or removed so that dedicated Pedal suggestions are the only kind. Bug: 893183 Change-Id: I67864c4b9686372023aa9623b68d1fb1b985fc51 Reviewed-on: https://chromium-review.googlesource.com/c/1471251Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#632335}
-
Caleb Rouleau authored
TBR=bpastene@chromium.org Bug: 932036 Change-Id: Icb9ebd2b17560a843595d49cbee034f471ed8fa3 Reviewed-on: https://chromium-review.googlesource.com/c/1473831Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#632334}
-
Caleb Rouleau authored
Relanding https://chromium-review.googlesource.com/c/1449151 with fixes. Patchset 1 is https://chromium-review.googlesource.com/c/1449151 Patchset 2 is https://chromium-review.googlesource.com/c/1464228 Patchset 3 is the new fix. When you run a telemetry benchmark as a reference, you are supposed to do `run_benchmark benchmark_name --browser=reference` but I thought that you were supposed to do `run_benchmark benchmark_name.reference --browser=reference` because I read the earlier code wrong. I also added a end to end test for this behavior, which also covers sharding code as well. Patchset 5 is a unittest for https://chromium-review.googlesource.com/c/1464228 Bug: 930879, 928928, 927507, 923628, 920002, 744736 Change-Id: If73d929b8e1b32c33d2bed7d2298b64d205658c1 Reviewed-on: https://chromium-review.googlesource.com/c/1467907Reviewed-by:
Emily Hanley <eyaich@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#632333}
-
Jeffrey Cohen authored
Bug: 932141 Change-Id: I35665b81a01076297256a1631e6434433797061f Reviewed-on: https://chromium-review.googlesource.com/c/1473331Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#632332}
-
Zhongyi Shi authored
Add histogram to collect number of connection migrations exercised before receiving a public reset from the peer. Bug: 929478 Change-Id: I0f72794bacadf8585cd498196153c670f6c13a41 Reviewed-on: https://chromium-review.googlesource.com/c/1471392Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#632331}
-
Scott Violet authored
The code was static_cast'ing a WindowTreeHost to a WindowTreeHostMus. This static_cast is not valid if the window is contained in another WindowTreeHost subclass. Normally that shouldn't happen, but does if a Window created with aura::Env::Mode::MUS is in the same hierarchy as those of aura::Env::Mode::LOCAL. There are DCHECKs that prevent that from happening, but sadly they aren't run on this bot. This fixes the crash, but the real fix is to not mix the two types in the same hierarchy. BUG=930975 TEST=none Change-Id: I89b13f719d773aa8521e1e1fff0b225f6d65f3ad Reviewed-on: https://chromium-review.googlesource.com/c/1473813 Commit-Queue: Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#632330}
-