- 05 Oct, 2020 40 commits
-
-
Sebastien Lalancette authored
Splitting the "bookmarks" target further than it previously was. This will allow the reuse of various components and creation of another target which will enable an edit-only flow, with reduced dependencies. Bug: 1133294 Change-Id: I62469eee5deb06279dc16d6a7a02d56fe48e76a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440310 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#813743}
-
Owen Min authored
It should be "unlisted" instead of "private only". Change-Id: I20922745236070fcdea0dac74c6d835029b59777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448685 Commit-Queue: Owen Min <zmin@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Auto-Submit: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#813742}
-
Alessio Bazzica authored
ConfigAutomaticGainControl now supports two additional AGC2 params that are needed for experimentation. Tested: checked feature activation via AECdump using appr.tc $ out/Default/Chromium.app/Contents/MacOS/Chromium \ --enable-features=WebrtcHybridAgc Bug: webrtc:7494 Change-Id: I81225ebc05a66ca18e5c4b2edc350cd42f19c31a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446052 Commit-Queue: Ale Bzk <alessiob@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#813741}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: If858a8ff19c757b7fbae59e86005608f5dfa687c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445870Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813740}
-
Matthias Körber authored
Test causing deterministic failures. TBR=sophiechang@chromium.org Bug: 1135134 Change-Id: I6bdfc88a2a2e2bd7e1721101e94e545b9d7b11b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449949Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#813739}
-
Maksim Moskvitin authored
This CL plumbs PendingSharedURLLoaderFactory to TrustedVaultConnectionImpl, and address noisy NOTIMPLEMENTED in TrustedVaultConnectionImpl. Bug: 1113598 Change-Id: I3287ed4ac1bb4599d1227e9cb90563ce0d650d86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435227 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#813738}
-
Sebastien Lalancette authored
Created the BookmarkPageCommand which takes a title and URL parameter in order to create (or trigger edit for) a bookmark. Added it to a new BookmarksCommands protocol - allowing it to not be required by BrowserCommands (BVC). Bug: 1133294 Change-Id: If73503350d7d63fd467c45941113bcbafe06ad2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441910 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#813737}
-
Alessio Bazzica authored
ConfigAutomaticGainControl now supports more AGC2 params that are needed for experimentation. The CL includes a refactoring to avoid base::Optional boilerplate and it improves the docstring for `ConfigAutomaticGainControl()`. Tested: checked feature activation via AECdump using appr.tc $ out/Default/Chromium.app/Contents/MacOS/Chromium \ --enable-features=WebrtcHybridAgc Bug: webrtc:7494 Change-Id: I0d226b9e7e6f17acb8408af8ded80d80db7cabe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446149 Commit-Queue: Ale Bzk <alessiob@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#813736}
-
Andrei-Laurențiu Olteanu authored
Add function to dispatch an event from callback. Add browser test for each lid event. Bug: b:162051831 Change-Id: I09412b2be19c702a7fd47b5c069efab9c061b73e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448490 Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#813735}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/895556e19c08..c401923f3ee3 2020-10-05 yunz@fb.com Take max bitrate into account for target bitrate decision when min bitrate is empty 2020-10-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0de57436..ac83b0e7 (813540:813657) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Icaf3585c34ade91bc60388c90592be059b9e74d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449640Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813734}
-
Scott Violet authored
When the BrowserFragment is destroyed cleanup of the Tab in the client library wasn't happening. This is because in this case onTabRemoved is not called on the client, which was where cleanup was being done. This patch makes this work by handling the case in onTabDestroyed. BUG=1134085 TEST=covered by tests Change-Id: Ia36f5eeec75192b989114e329156c9cec558670c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446780Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#813733}
-
Saurabh Nijhara authored
Extension install events are converted from proto to base::Value using ConvertEventsToValue(...) before being uploaded. This CL adds tests for to check that different kinds of events are correctly parsed into base::Value and included into the final uploaded extension install report. Bug: b:162501511 Change-Id: I821441ac81211f9a9dbc073e70546187bb22ded1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431520Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Swapnil Gupta <swapnilgupta@google.com> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#813732}
-
Solomon Kinard authored
$ chrome --allow-future-manifest-version Bug: None Change-Id: I99a4d23386b99f707e21ab221b62b6d51b7f6658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434904 Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#813731}
-
Prashant Nevase authored
There is regression caused by creating dark mode filter in GraphicsContext ctor. This patch creates dark mode filter once it is accessed first time. Bug: 1134430, 1134476, 1082339 Change-Id: I97521749167fcd1fb7ddfeb1b2fe7e8a7de8846f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449829Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#813730}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/388b07889beb..745402dd650a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC koerber@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: koerber@google.com Change-Id: Ia815f8e343d296006e85c487adda135e9c8f6dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449641Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813729}
-
Olivier Robin authored
Some base i18n functions requires the icu data. E.g.: GetPluralStringFUTF16 Change-Id: I80b2bc0f6a7b26f5da0a4daaee7fac66217396ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449472Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#813728}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601877511-28b93e09fa0b9618306e073ac2e467bbc2486723.profdata to chrome-linux-master-1601899131-feda22e3411bdb75c005a38c5197b1e76964f668.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5860dbb15678ca96ae7bdebdc892488602c3c5aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449644Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813727}
-
Yifan Luo authored
Bug: 1116418 Change-Id: I0aedefbba5eb452d6bbcaa934d909b1dbb65c4d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416590 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#813726}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/10850e1e5ba9..74f8dbb95782 2020-10-05 jleconte@google.com Fix empty alert list issue when triaging. 2020-10-05 jleconte@google.com Fix pop up statement when triaging with an existing bug. 2020-10-05 jleconte@google.com Bisect on a chart with empty Bug ID fails. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1134978 Tbr: oysteine@google.com Change-Id: I36c1cfe10376ea7ea7f985cf703838dad4793a61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449638Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813725}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e56466d4848c..ef897a9c3ec2 2020-10-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 375fee944c76 to b3c1e71eb1cb (2 revisions) 2020-10-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from d91afd8de27a to f15133788010 (3 revisions) 2020-10-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from e1ba543c6789 to 94ff600cc862 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: If1a34d4f5e19a1a9280908a1f0f4d77b0546f3cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449635Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813724}
-
Chris Sharp authored
This reverts commit c64eed06. Reason for revert: Broke virtual/eye-dropper/color-picker-show-eye-dropper.html on WebKit Linux MSAN Original change's description: > Add security mitigations for eye dropper IPC. > > As discussed on the security review this CL adds the following mitigations: > - require a transient user activation on the browser side, and consume > it when showing the eye dropper for the renderer (this will prevent a > compromised renderer to repeatedly ask for a color) > - require the eye dropper UI to be visible for a minimum amount of time > before color selection is allowed in order to ensure the user has a > chance to see the UI. > > There is also a fix for the popup not correctly updating the user > activation state. This happens because it is using a > EmptyLocalFrameClient and its frame is not related to the > owner element's frame. > > Bug: 992297 > Change-Id: Ia5d2aead0be153ce4b49048552062de3a6c72e63 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442132 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Mason Freed <masonfreed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812847} TBR=avi@chromium.org,danakj@chromium.org,tkent@chromium.org,masonfreed@chromium.org,iopopesc@microsoft.com NOTRY=true Bug: 992297 Change-Id: If16db478fb59c4caa6f4fd90190adb72ce38e68a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448054 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#813723}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e51078b0b92b..fbcd4c1d714d 2020-10-05 jacktfranklin@chromium.org Migrate media/PlayerMessagesView to TS 2020-10-05 szuend@chromium.org [ts] Type-check network/NetworkItemView.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0f1b9d460cb3a3d5a20562f2cc0b5d22f45f8757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449636Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813722}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ia6051b73d2a757045775eb89a131354200f3fa3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448661Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#813721}
-
Chris Sharp authored
TBR=schenney@chromium.org NOTRY=true Bug: 626703 Change-Id: I2c309e1f37776358b8058e3d94b0452b87870374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449929Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#813720}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: Id57a75e0a359be08f4a14a11d8d71419705220b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446050 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#813719}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: Ia503bd748f633f2526feafc81c823f6b78132710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446051Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813718}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/43865d38f022..97440de4b947 2020-10-05 kjlubick@google.com [canvaskit] Add docs/types for Canvas. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: I37227862783a51f737efa62280b9c6d3f0f3d927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449634Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813717}
-
Mikel Astiz authored
This is a follow-up to crrev.com/c/2329751 to support notifying observers, along with an API to resolve the recoverability errors. The actual TrustedVaultClient implementations are left unimplemented, except for StandaloneTrustedVaultClient where minimal logic is introduced to support semi-realistic integration tests. Change-Id: I63acc6196fee59d24edbd1d3816f19ef8e15930a Bug: 1081649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448491 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#813716}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/af6c5c622733..7cdc44f903d3 2020-10-05 hjd@google.com Merge "ui: Stitch small TraceHttpStream chunks" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I53725d1e1165b39ca45468811fba435beee5a4fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449633Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813715}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/64b018448b3e..388b07889beb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC koerber@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: koerber@google.com Change-Id: I886d6b1d98426eb3d08b62cb091d76c4a928cafe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449128Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813714}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2fc8a89c..497b7a37 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I32a0d5dec093a720b50757c097af33635f427312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448533Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813713}
-
Anna Malova authored
This is a reland of bd3b0ee6 Original change's description: > [aw] Allow to set Network in AwPacProcessor. > > Bug: 1085115 > Change-Id: I8846261a0f21ecb48692b70ab778f68996843760 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414173 > Reviewed-by: Richard Coles <torne@chromium.org> > Commit-Queue: Anna Malova <amalova@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812494} Bug: 1085115 Change-Id: I8fc91488e417534238d916907d4d2a7c64963c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445489Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#813712}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ed3a93f690de..df909306835a 2020-10-05 cwallez@chromium.org wire::client: Make Buffer::MapAsync surface server-side errors. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I8746fc6fddb4eaeba750ff4d295fda7121b2f74d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449630Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813711}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I8f6218da609139d1edb24b56f782bbd0eb12d1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445413Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813710}
-
Ossama Mahmoud authored
Previously, during the post login steps the Apps button stays visible, and starting an app crashes the recently started user session. This is fixed by hiding the Apps button in all post login dialogs. Hide Apps button after a user session has started Bug: 1124319 Change-Id: Ie1c1f72c4dd473b928c3f93dc5fbeaf8f03cb30e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407312 Commit-Queue: Ossama Mahmoud <osamafathy@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#813709}
-
Kyle Williams authored
Convert the antiquated use of InterfaceRequest/InterfacePtr to its updated equivalent to comply with the current standards as well as to continue passing presubmits and other checks put in place. BUG=b:169582064 TEST=`autoninja -C out/Default chromeos:chromeos_unittests && ./out/Default/chromeos_unittests --dbus-stub --single-process-tests --gtest_filter=CfmServiceConnectionTest.*` Change-Id: Iafb58b5713964a7c6d6d5afab71c8d384000eb25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436990Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Kyle Williams <kdgwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#813708}
-
Ilya Nikolaevskiy authored
Bug: webrtc:11485 Change-Id: I843b0babbcc5ac1169ab09ea957d5df02bc52f29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449333 Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#813707}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If20b5506cfc26722eab609ca0df9d126929bbb34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449127Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813706}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ae5e8ebda79e..895556e19c08 2020-10-05 eshr@google.com Avoid converting frames to I420 in VideoStreamEncoder If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibc2a46cc30a95f20a49d2b2ba055e9f531319b71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449629Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813705}
-
Richard Knoll authored
This converts the unchecked observer lists to a checked ones to catch potential use-after-free issues earlier. Bug: None Change-Id: I291a34c4f6115c32449b99725a6da57a2702e862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437372Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#813704}
-