GitLab

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=171141:171225&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/232453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262942 0039d316-1c4b-4281-b951-d872f2087c98

The Info URL is used to send the user to a landing page when they see a
welcome notification for a synced sending service.

TBR=petewil@chromium.org
BUG=338864

Review URL: https://codereview.chromium.org/228753006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262940 0039d316-1c4b-4281-b951-d872f2087c98

Both base and protocol directories had util.cc files, which confuses
the linker when compiling them into a single static .a lib.

BUG=276739

Review URL: https://codereview.chromium.org/231943005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262938 0039d316-1c4b-4281-b951-d872f2087c98

BUG=93286
Test=No visible change. Ran the aforementioned test from content_unittests.

Review URL: https://codereview.chromium.org/232253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262937 0039d316-1c4b-4281-b951-d872f2087c98

Instead of ad-hoc DCHECKs of internal state throughout the job's
callbacks, introduce a phase system and add DCHECKs to internal state
getters/setters in terms of it.

BUG=349337

Review URL: https://codereview.chromium.org/229403004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262936 0039d316-1c4b-4281-b951-d872f2087c98

If seek happens while requesting data for the inactive chunk, the ack for the data request will call OnDecodeCompleted().
However, the decoder job is waiting for the OnDecodeCompleted() from the active chunk.
Tests:We already have seveal tests covering requesting inactive chunk during seek. This CL should fix the flakiness in there.

BUG=361541

Review URL: https://codereview.chromium.org/227523005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262934 0039d316-1c4b-4281-b951-d872f2087c98

In r262636 I deleted the Shutdown() methods from SWRegistration and
SWVersion, but it caused a leak in RepeatedlyObserveStatusChanges.

In the previous code the status change callback (ObserveStatusChanges)
holds a ref to ServiceWorkerVersion, which was ok when we had Shutdown()
(as we could explicitly clear the status change callback there), but
now we don't, so we have cyclic reference there.

I just changed make_scoped_refptr(version) to base::Unretained(version)
when we pass the version to the callback, so that the callback no longer
holds a ref to the Version.

BUG=361504
TEST=ServiceWorkerVersionTest.RepeatedlyObserveStatusChanges with asan/lsan

Review URL: https://codereview.chromium.org/230373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262933 0039d316-1c4b-4281-b951-d872f2087c98

R=zea@chromium.org

BUG=341513

Review URL: https://codereview.chromium.org/228553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262932 0039d316-1c4b-4281-b951-d872f2087c98

This fixes some build errors for the "chromeos=1 use_ozone=1" build. The
touch factory class & ui::CopyAreaToCanvas function are currently only
supported under X11.

BUG=361341
TEST=chrome --ozone-platform=test

Review URL: https://codereview.chromium.org/232313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262931 0039d316-1c4b-4281-b951-d872f2087c98

This fixes some build errors for the "chromeos=1 use_ozone=1" build. The
touch factory class is currently only supported under X11.

BUG=361341
TEST=chrome --ozone-platform=test

Review URL: https://codereview.chromium.org/232173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262930 0039d316-1c4b-4281-b951-d872f2087c98

Turns out that https://chromiumcodereview.appspot.com/11788005 made it
such that blocking for JavaScript doesn't require ContentViewClient,
just a ContentViewCore. Many places in tests still get the ContentView
in order to create a TestCallbackHelperContainer in order to wait for
JavaScript to execute...

Instead for clients that don't care about waiting themselves for JS to
execute, just do it inside JavaScriptUtils.

BUG=360644

Review URL: https://codereview.chromium.org/231693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262929 0039d316-1c4b-4281-b951-d872f2087c98

I found this while trying to build a target that depends on net.

BUG=None
TEST=ninja -C out/Debug_gn
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/231883005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262928 0039d316-1c4b-4281-b951-d872f2087c98

This event code is all currently X11-specific. Remove it from the
ChromeOS-on-Ozone build.

BUG=361341
TEST=chrome --ozone-platform=test

Review URL: https://codereview.chromium.org/226413008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262927 0039d316-1c4b-4281-b951-d872f2087c98

* Limits the maximum size of the button, truncating text if it can't fit
  (yay for testing with languages that I didn't have translations for
  initially).

* Stops an NPE that can trigger if the user uses the banner to install an
  app, uninstalls the app in the background, then returns to Chrome to
  open the app from the banner itself.

BUG=359208,359199

Review URL: https://codereview.chromium.org/231273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262926 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338888

Review URL: https://codereview.chromium.org/201673006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262925 0039d316-1c4b-4281-b951-d872f2087c98

This version is a little bit different from the last; main differences:

 - I saw that the "CalculateBounds" was returning the minimum and maximum of the means of the input list, so I thought it would be easier to understand if this was done by mapping CalculateMean and then directly making a tuple with min/max.
 - Since CalculateTruncatedMean(xs, 0) is just the mean, and this is used in several place, I extracted out a convenience function CalculateMean.
 - CalculateConfidence doesn't refer to self, so I thought it was reasonable to move it up to be a top-level function with the other stats functions.

BUG=

Review URL: https://codereview.chromium.org/220113012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262924 0039d316-1c4b-4281-b951-d872f2087c98

This fixes some build errors for the "chromeos=1 use_ozone=1" build. The
code under ash/accelerators is currently only supported under X11.

BUG=361341
TEST=chrome --ozone-platform=test

Review URL: https://codereview.chromium.org/232133005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262923 0039d316-1c4b-4281-b951-d872f2087c98

It is really tough to use some 4K monitor from ChromeOS because
the resolution is too high in comparison with the physical size.

Better to use 2X mode in such case.

BUG=348279
R=oshima@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/227593011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262922 0039d316-1c4b-4281-b951-d872f2087c98

This can happen after the account_chooser_model has been changed to the new data
source but before all the suggestions have been updated.  In this small amount
of time we snapshot SECTION_CC_BILLING while the account chooser doesn't have
wallet selected.

R=estade@chromium.org
BUG=361321

Review URL: https://codereview.chromium.org/229593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262921 0039d316-1c4b-4281-b951-d872f2087c98

I stumbled across this while trying to pass int16's into javascript. This
looks like a simple omission.

R=viettrungluu@chromium.org
BUG=

Review URL: https://codereview.chromium.org/231743004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262920 0039d316-1c4b-4281-b951-d872f2087c98

This fixes two compilation errors found while building with gcc 4.8.2:

1- unused variable 'orig_bak_files' [-Werror=unused-variable]
2- comparison between signed and unsigned integer expressions
[-Werror=sign-compare]

BUG=361857
TEST=ninja -C out/Debug_gn
TBR=brettw@chromium.org,dgrogan@chromium.org

Review URL: https://codereview.chromium.org/226413009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262919 0039d316-1c4b-4281-b951-d872f2087c98

Oops, I inverted the condition.

R=sky@chromium.org
TBR=sky@chromium.org
BUG=360081

Review URL: https://codereview.chromium.org/225863008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262918 0039d316-1c4b-4281-b951-d872f2087c98

This is a refactoring of the code in pdf.js, moving the code into a PDFViewer object. This
will make it more testable and usable by other classes that will be added later.

BUG=303491

Review URL: https://codereview.chromium.org/223363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262917 0039d316-1c4b-4281-b951-d872f2087c98

BUG=361569
TBR=dgozman

Review URL: https://codereview.chromium.org/232283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262916 0039d316-1c4b-4281-b951-d872f2087c98

This CL causes conflicts with my pending CL
(https://codereview.chromium.org/224903022) that needs to be merged into
M35. The safest way forward is to revert this, commit my CL, then
re-land this, dealing with the merge conflicts.

BUG=357049

> Remove title and icon from chrome apps native style title bars.
>
> These windows aren't meant to have titles or icons, but still need to
> get a proper title as far as the OS is concerned. This means using a
> custom but glass frame, similarly to how unthemed browser windows look.
>
> BUG=339558
> TEST=Try out frame:chrome app windows windows on Windows 7, 8 and XP.
> Use the windows in various states (maximised, fullscreen, normal).
> Make sure they work after switching in and out of aero mode.
>
> Review URL: https://codereview.chromium.org/213743017

Review URL: https://codereview.chromium.org/229343004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262915 0039d316-1c4b-4281-b951-d872f2087c98

Makes the naming consistent with AudioBuffer, which is helpful now that DecoderStream<T> enforces API consistency.

TBR=dmichael

Review URL: https://codereview.chromium.org/229453004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262914 0039d316-1c4b-4281-b951-d872f2087c98

Use the root view's height vs. the visible display frame instead of the screen
height.  This is because the window might not be the full size of the screen.

BUG=251343

Review URL: https://codereview.chromium.org/229903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262913 0039d316-1c4b-4281-b951-d872f2087c98

Previous patch was reverted because of flakiness.
The main reason of the flakiness is a race like followings:

1. After renaming, Files.app commit the new file name previsionally.
2. Test regards as the rename was done and starts the next rename.
3. Previous rename was actually done in a file system and the file list
   is updated. It cancels the second rename.

This patches add a marker for previsionally commitment, and let the test wait
until the marker is removed.

Previously reverted CL: crrev.com/221673002

BUG=345062
TEST=run the test.

Review URL: https://codereview.chromium.org/230073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262912 0039d316-1c4b-4281-b951-d872f2087c98

This will break the behavior with the older version of the hotword,
but actually that is fine because anyways the app-launcher hasn't
worked well with the older version for other reasons.

BUG=356873
R=xiyuan@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/229323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262911 0039d316-1c4b-4281-b951-d872f2087c98

Currently, searches using the app launcher search box use the RLZ access
point for the omnibox. With this change, the app launcher RLZ access
point is used to construct url parameters for searches from the app
launcher.

BUG=332996

Review URL: https://codereview.chromium.org/228013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262910 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347247
TEST=unit_tests
R=guohui@chromium.org, rogerta@chromium.org

Review URL: https://codereview.chromium.org/217883004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262909 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262906 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Compile errors on chromiumos builder [multiple cycles] due to 

https://src.chromium.org/viewvc/blink?revision=171165&view=revision

/third_party/WebKit/Source/core/dom/CharacterData.cpp:146:36:
error: 'realCount' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
chromeos-chrome-36.0.1933.0_alpha-r1:      newStr.remove(offset, realCount);

link: http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/20955

Original issue's description:
> Blink roll 171141:171171
> 
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=171141:171171&mode=html
> TBR=
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262863

TBR=yurys@chromium.org,jianli@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/232443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262905 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262903 0039d316-1c4b-4281-b951-d872f2087c98

When a GPU switch is detected, poison all browser-side GL contexts,
which will cause them to be recreated.

Make CompositorSwapBuffers destroy and recreate the GL context
if it has been poisoned. Ensure that the CALayer for the old content
remain in place until the new layer is in place and correctly sized,
to avoid flickering.

BUG=361493

Review URL: https://codereview.chromium.org/231863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262901 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262900 0039d316-1c4b-4281-b951-d872f2087c98

Pulls in change: https://gerrit.chromium.org/gerrit/#/c/69477/

BUG=354405,346626

Review URL: https://codereview.chromium.org/231283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262899 0039d316-1c4b-4281-b951-d872f2087c98

Removes AtomicRefCount checks from SincResampler and AudioOutputController
which never caught any issues.

BUG=295278, 349651
TEST=none

Review URL: https://codereview.chromium.org/231623005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262897 0039d316-1c4b-4281-b951-d872f2087c98

BUG=361127

Review URL: https://codereview.chromium.org/231173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262896 0039d316-1c4b-4281-b951-d872f2087c98

mod3 is the short name for ISO Level 5 shift, which is used by CA multilingual and German Neo2 keyboard layouts to allow support for a 4th shift state in addition to normal, shift, and AltGr.

BUG=335368

Review URL: https://codereview.chromium.org/227893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262895 0039d316-1c4b-4281-b951-d872f2087c98