- 28 May, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fd40163541b4..0499a4436c35 Created with: gclient setdep -r src-internal@0499a4436c35 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: Idc5b3a5eebec4fb56b6bdda957d6793716c85b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632971Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663970}
-
Mounir Lamouri authored
We would like to skip M76 as we may need to revisit the design based on new features coming into the Picture-in-Picture API. Bug: 940404 Change-Id: Iec0912a249fd0fbbed16103548aaa64fb0842921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632119Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#663969}
-
David Bienvenu authored
This matches the behaviour of ClipboardAuraX11, which allows OmniboxViewViewsClipboardTest to use the test clipboard. Bug: 963112 Change-Id: I59cdc24bb7ecd2bd904505e38df133b31ed48104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630012Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#663968}
-
Eric Roman authored
Change-Id: I787964b93b8f96200172d01b52f8865de2679c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629014Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#663967}
-
Brandon Wylie authored
* Adding abstract methods to ContentCaptureController for data clearing. * Adding observer for content capture. * Hooking up the observer to the HistoryDeletionBridge. Bug: 954404 Change-Id: I80ef890d619914d3b4f9f7fe50fc192ac5f9a10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623529 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#663966}
-
Zhenyao Mo authored
It looks like nouveau driver changed their GL_RENDERER string and avoided being blacklisted by Chrome. BUG=959766 TEST=bots R=piman@chromium.org Change-Id: I118f3796f101ed26517c9e360370a7176d55de21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625817Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#663965}
-
Jeremy Roman authored
Bug: 967095 Change-Id: I85ffd419c43f4715ce6fcf9857b08d340d605554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629287Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#663964}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a53cda46. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" be76d09e "[ServiceWorker] Reject update() from within installing workers" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure igrigorik@chromium.org, yoavweiss@chromium.org: external/wpt/preload nzolghadr@chromium.org, mustaq@chromium.org: external/wpt/pointerevents NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Iab9504d8b33771061ba767abddd54f5388227939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632869Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663963}
-
Nicolas Ouellet-Payeur authored
The policy is not completely implemented yet, so it should have been marked 'future'. Bug: 958659 Change-Id: I814d39f998de5d55466e95fbeaf2d70a11dcfc5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630975 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#663962}
-
Adam Ettenberger authored
I wasn't able to reproduce the failure, but according to the error logs they suggested that for some reason, word-wrapping was likely different from public Chromium and closed Chrome. This could be something subtle like differences in fonts, scroll bars, or potentially DPI differences in the test environment. Updating the test to avoid these types of differences. Adjusted the text so that line breaks will be more predictable, leaving ample room for and scrollbar differences. The error was : --- error: Expected equality of these values: L"G H I J K L " provider_content Which is: L"G H I J K L M " --- Bug: 966344 Change-Id: If978ce1fe03984c64151241e6241cdfc29d900c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627927Reviewed-by:Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Cr-Commit-Position: refs/heads/master@{#663961}
-
Paul Jensen authored
This was an accidental bug introduced in r659155 that only happens in the weird cases where NetworkChangeNotifierWin fails to watch for address changes. Bug: 967297 Change-Id: Ic4a575599be4ae4e150f19f672cf07aa82376e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632449 Auto-Submit: Paul Jensen <pauljensen@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#663960}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3971b19ba242..90cb260644cd git log 3971b19ba242..90cb260644cd --date=short --no-merges --format='%ad %ae %s' 2019-05-28 bclayton@google.com Reactor: Fix all memory leaks with rr::DebugInfo. Created with: gclient setdep -r src/third_party/swiftshader@90cb260644cd The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/133399620 TBR=swiftshader-team+autoroll@google.com Change-Id: I6e3b9720aa4e962e36613ae14ff1806d57f194b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632807Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663959}
-
Peter Kotwicz authored
This CL changes the test WebAPK APK to handle file sharing BUG=967792 Change-Id: Id184bd063f5a43d2d10d11d9e19494a0bdbf073a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632793Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#663958}
-
Vladislav Kaznacheev authored
There is no way to add an icon to a menu item provided by a platform app via chrome.contextMenus API. This CL detects that this particular item is being added (by checking the app id and the menu item label) and adds an appropriate icon to it. This method can be applied to other apps if necessary, which will require hard-coding app id, label and icon for each new case. Bug: 943319 Test: manual Change-Id: I9536e8dc7ab2d8623fca8b4d68cfb776e5053a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632909 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#663957}
-
Andrew Xu authored
A recent CL allows to focus on the notification. As a result, when notification gets the focus from AppList, AppList will be dismissed because of losing the focus. This CL fixes the issue. Bug: 948344 Change-Id: I0fd7d150548afc8e74d1ab406407fe3c1d7b2334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627701 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#663956}
-
Azeem Arshad authored
This CL adds a base-page element and skeleton ui for all steps of the cellular setup flow. Texts and page body for all page contain placeholder texts. Actual implementation and styling for theses pages will be added in a follow-up CL. See go/cros-cellular-activation-ui-design for UI design. Bug: 962702 Change-Id: Id4999fe6cb0f53838ce9d5b6fce9d99c5a85eca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616449Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#663955}
-
Elly Fong-Jones authored
Bug: 406227 Change-Id: I01b4eda623ff850daa5954fc55b617cd15931441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632390 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#663954}
-
Vlad Tsyrklevich authored
Long-lived allocations can consume all of GWP-ASan's memory early, resulting in uneven sampling over the process' lifetime. Report how many total allocations (e.g. taking into account the the sampling frequency) it took before OOM. Break these reports out by allocator and process since behavior varies significantly based on these factors. This metric will help measure whether we are frequently running out of allocations early for a given allocator/process and will help track future memory improvements. Bug: 963711 Change-Id: Ifef2d61ee3fb589a4b55fcf2b93f7f64096e43f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628288 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#663953}
-
Haiyang Pan authored
Add shard maps and disable failing tests for pixel2 devices This involves updating the shard number in bot_platforms.py and perf_data_generator.py, and running the following commands to update the json files: ./tools/perf/generate_perf_sharding update \ --builders android-pixel2-perf \ --builders android-pixel2_webview-perf ./tools/perf/generate_perf_data The tag "Pixel2_Webview" in expectations.config will be added in this review: crrev.com/c/1628818 Bug: 867592 Change-Id: I332a5ae8cff1598729775889418f28a67230a82e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628172 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#663952}
-
Sébastien Séguin-Gagnon authored
Filter out devices with the same name as the local device from the list of target devices. This is because there can be different device_info objects for the local device that have different cache guids. Bug: 957716 Change-Id: Idf279a9cb2298657c6d6cfa03f0dde62b0587473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625904 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Auto-Submit: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#663951}
-
Will Harris authored
This is Neilsen//NetRatings NetSight DLL and is causing hangs and crashes. Tested with NeilsenOnline v8.3.0.14084. BUG=712548 Change-Id: I5b9e960a4027a772a34eb7243363871075155fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625932Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#663950}
-
Fabio Rocha authored
DevTools: Fix small bug where Console shortcuts were only displayed if Console had been previously launched The Console shortcuts were only displayed in the shortcuts panel (in Settings) if the Console had been loaded previously, otherwise the Console shortcuts section would be empty. The reason was that the Console's descriptors weren't registered in the same place as all the other shortcut descriptors. The fix was a small refactor to extract descriptors into ShortcutScreen.js. Also did some cleanup in there to improve consistency. Change-Id: Ifee95da25208c6eace4a5be9775432bfb1880138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625926Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Fabio Rocha <fabio.rocha@microsoft.com> Cr-Commit-Position: refs/heads/master@{#663949}
-
Ben Pastene authored
Bug: 966656 Change-Id: Ia50f38ee1b39ed9239f0f45192f29f758a677a18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629697Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#663948}
-
Robert Ogden authored
The stale timestamp histogram is not logged with the new UI unless the page info dialog is opened which can't be done in a ChromeDriver test. Bug: 966667 Change-Id: I7ea17209352a1e18b0b4012da4c396c96125a51e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632116 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#663947}
-
arthursonzogni authored
When a frame is unloading in one process, it must not be visible from the other processes at some point. Previously, it was done when the frame completed the unload, now it will be done when it starts unloading. To achieve that, the RenderFrameProxyHost are removed when the frame starts unloading. Moreover, no new RenderFrameProxyHosts are created in a frame with an unloading current document. + 2 tests added, originally made by lukasza@chromium.org (Thanks!) Addition in the reland: ======================= + 1 regression test. A subframe is focused and unloaded, then another document commit. To prevent the previous regression, the focused frame is reset when unloading starts, instead of when it ends. Bug: 960006, 950625 Change-Id: I225118ee6385b3f843107adefe05d605d27703cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626412 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#663946}
-
danakj authored
RegisterInProcessThreads() is called to set up using single process with child processes running in threads. It must be called for: - Chrome unit tests - Android Content browser tests - Android Chrome browser tests Currently it is called in ContentBrowserTestSuite and ChromeUnitTestSuite which excludes the 3rd case. This adds a call in ChromeTestSuiteRunner, which is used to run Chrome browser tests. Bug: 961849 Change-Id: I371eb8777ba1fbe8b1dd7f4426dc15144392cad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610717Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Peter Kasting authored
* Convert some to range-based for * Convert some to STL algorithms * int -> size_t for object counts in a few places * Other misc. cleanup, e.g. removing unnecessary {} Bug: 940126 Change-Id: I9c50e1d40cef2f09d1e8dee9b051ab34cf0c59b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629712 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: -
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d04aaa3a841a..0cb2fdefc219 git log d04aaa3a841a..0cb2fdefc219 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 michaelludwig@google.com Use color analysis opts only if XP keeps the color FPs 2019-05-28 fmalita@chromium.org [skottie] Support multiple text fragments Created with: gclient setdep -r src/third_party/skia@0cb2fdefc219 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Change-Id: I1743119f19cc00c20ecfe63f691acef6fb881bfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632802Reviewed-by:
-
Luum Habtemariam authored
Added delegate provides the service with necessary Chrome printing stack dependencies, i.e. hooks to the CupsPrintersManager/PrinterConfigurer. Also adds a helpful fake for unit testing. Bug: chromium:945409 Test: none Change-Id: I6bb02592993fd6bb22b33240b2ae8d6e332304cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621326 Commit-Queue: Luum Habtemariam <luum@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#663942}
-
Will Harris authored
BUG=961831 Change-Id: I87ad2a4cf333ddfac7170f8309b34fcd7f71c338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628006Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
-
Caroline Rising authored
Tab renderer data's visible url will show the domain of the page the user is navigating to before there is a title. So at times the title would be for the page the user is navigating from while the url was for the page the user was navigating to. Using the last committed url will prevent this title and domain from being out of sync. Bug: 910739 Change-Id: I19f88d3a96ec950d37476f3287381ec2409ec17b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632593 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#663940}
-
David Bokan authored
In https://crrev.com/53f9afcdecf35a8, we changed the Force Enable Zoom setting to also force reset the initial scale factor so that pages that specify an initial-scale in the viewport meta tag load fully zoomed out. Unfortunately, this caused the bug in 960518 since we always reset the initial scale factor to -1 when calling SetIgnoreViewportTagLimits. On AndroidTV devices the initial scale is overridden using SetInitialPageScaleOverride. This override would be clobbered when SetIgnoreViewportTagLimits was called (with false, to ensure the override is off). This CL fixes the issue by storing the user agent constraints when we override them, and resetting them to the original values when turning off the override. Bug: 960518,929709 Change-Id: I9d7236ec0991025067504c867fe0d06c9d12c455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631710 Commit-Queue: David Bokan <bokan@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by:
-
Ian Kilpatrick authored
This was consuming an additional 160-bytes of stack. Also makes NGBlockNode::RunLegacyLayout private. Bug: 962034, 964926 Change-Id: I1e9f4b97d85b49d6262c07ae789bb984a66cc673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631126 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#663938}
-
Mike Wasserman authored
Move wallpaper.mojom to a virtual c++ interface. Update impl and clients, make some methods sync. Combine mojo and non-mojo observer types. Add a static WallpaperController::Get(), cleanup. Bug: 958227 Test: No Chrome OS wallpaper regressions. Change-Id: I23de39efd3721f40ec423eed651f1cb8fed7edd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626011 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
-
Lan Wei authored
Instead of adding a variable to check if the test is finished, we can create a promise object and finish the test at its last callback. Bug: 606367 Change-Id: Iabf281a1fffca85630683e79436a8b442057b824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618002 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#663936}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6c8f0250717b..162eba28f207 git log 6c8f0250717b..162eba28f207 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@162eba28f207 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I673d0adf0d6c38beef43b87c1c6430d7c335f61f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632804Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/caa10d3db92b..21362a5cf0dc git log caa10d3db92b..21362a5cf0dc --date=short --no-merges --format='%ad %ae %s' 2019-05-28 treehugger-gerrit@google.com Merge "processor: Support arguments for nestable slices" Created with: gclient setdep -r src/third_party/perfetto@21362a5cf0dc The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I16e23fcb7d57b722c0d5621042590834683f8d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632801Reviewed-by:
-
Sebastien Lalancette authored
This reverts commit e61604f9. Reason for revert: Tests started failing again. Original change's description: > Re-enabled system_health.memory_mobile benchmarks > > These should be working again after > https://chromium-review.googlesource.com/c/chromium/src/+/1626991 > > TBR=perezju@chromium.org > > Bug: 964804 > Change-Id: Iddbffc36717e86db4da46cfc733821f169cf6f38 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628317 > Reviewed-by: oysteine <oysteine@chromium.org> > Commit-Queue: oysteine <oysteine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#663183} TBR=oysteine@chromium.org,perezju@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 964804 Change-Id: I23caa9852a521316ec7b61369584daa45e146ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630225Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#663933}
-
yilkal authored
Bug: 948955 Change-Id: I5c98964e81984ff2fca76a0500dd297f5189f5b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623535Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#663932}
-
Tao Bai authored
Change-Id: I5d5a979cb8360341c910288141394e84ebf4e2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616389Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
-
