GitLab

Revert of Fix crash when we don't have a plane to display (patchset #2 id:20001 of https://codereview.chromium.org/779173007/)

Reason for revert:
Broke Linux ChromiumOS Ozone.
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/8423

GetPrimaryPlane was changed to return a pointer, but a callsite was
not modified.

Original issue's description:
> Fix crash when we don't have a plane to display
>
> BUG=434115,438835
>
> Committed: https://crrev.com/208e6bf151685abc68ac836db5afb3543d8a1e92
> Cr-Commit-Position: refs/heads/master@{#308105}

TBR=dnicoara@chromium.org,achaulk@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=434115,438835

Review URL: https://codereview.chromium.org/800053002

Cr-Commit-Position: refs/heads/master@{#308118}

BUG=440405

Review URL: https://codereview.chromium.org/789853002

Cr-Commit-Position: refs/heads/master@{#308117}

This class is a wrapper around net::URLFetcherDelegate that is designed
specifically to fetch images. It will transcode WebP encoded images.

BUG=436897, 441327

Review URL: https://codereview.chromium.org/787903003

Cr-Commit-Position: refs/heads/master@{#308116}

See https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-dev/AppLaunchParams/chromium-dev/uPckpeYSlNA/bwfwZAtbEEkJ
for a discussion of what I'm trying to do, and https://codereview.chromium.org/771003002 for more context of how I'm going to use
this to achieve it.

Review URL: https://codereview.chromium.org/757433004

Cr-Commit-Position: refs/heads/master@{#308115}

Review URL: https://codereview.chromium.org/792443004

Cr-Commit-Position: refs/heads/master@{#308114}

SelectFile() is getting called more than once for the same window
and causing NOTREACHED() failure on linux, since it tries to re-add
the observer.

To fix the failure, this patch adds a check that does an early-return
if the select file dialog is currently being shown to the specified
window.

BUG=432783

Review URL: https://codereview.chromium.org/772983002

Cr-Commit-Position: refs/heads/master@{#308113}

ManagePasswordBubbleView wants to monitor events on a specific window,
currently using aura specific code that won't work for MacViews.
views::EventMonitor is enhanced to support monitoring events on a window,
with both Mac and Aura implementations.

Also includes minor compile fixes in ZoomBubbleView and StatusBubbleView.

Originally reviewed in https://crrev.com/730833006/

BUG=425229

Review URL: https://codereview.chromium.org/793003004

Cr-Commit-Position: refs/heads/master@{#308112}

We always confirm, so we may as well remove the roundtrip together.

BUG=432527

Review URL: https://codereview.chromium.org/803523002

Cr-Commit-Position: refs/heads/master@{#308111}

BUG=437577

Review URL: https://codereview.chromium.org/749183004

Cr-Commit-Position: refs/heads/master@{#308110}

This change was needed for Chromecast, while avoiding adding yet another
preprocessor condition.

BUG=438331

Review URL: https://codereview.chromium.org/790903003

Cr-Commit-Position: refs/heads/master@{#308109}

Prior instrumentations showed that most of jank (13.3) comes from URLRequestJob::Read.

BUG=423948

Review URL: https://codereview.chromium.org/790723004

Cr-Commit-Position: refs/heads/master@{#308108}

BUG=435064

Review URL: https://codereview.chromium.org/743123002

Cr-Commit-Position: refs/heads/master@{#308107}

The kInstantProcess flag was used to check if the current frame belongs to instant and should be whitelisted. This would cause layering troubles once ContentSettingsObserver is componentised.

Instead, this CL moves the check back to the construction of the observer, in ChromeContentRendererClient, and only records the Boolean flag for whitelisting in the observer.

BUG=384874

Review URL: https://codereview.chromium.org/797993002

Cr-Commit-Position: refs/heads/master@{#308106}

BUG=434115,438835

Review URL: https://codereview.chromium.org/779173007

Cr-Commit-Position: refs/heads/master@{#308105}

Revert of suppress svg test until next blink roll (patchset #1 id:1 of https://codereview.chromium.org/801853002/)

Reason for revert:
blink roll has landed, so this is unneeded

Original issue's description:
> suppress svg test until next blink roll
>
> BUG=
> NOTRY=True
>
> Committed: https://crrev.com/85f7f361478f35bad79e180b69711e6923f886bd
> Cr-Commit-Position: refs/heads/master@{#308093}

TBR=fmalita@chromium.org,bungeman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/798873003

Cr-Commit-Position: refs/heads/master@{#308104}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8e6fc6d..f405722d

TBR=lushnikov@chromium.org,vsevik@chromium.org,dglazkov@chromium.org

Review URL: https://codereview.chromium.org/795353007

Cr-Commit-Position: refs/heads/master@{#308103}

Extensions that ship with plugins may use them. Since the viewer is a
builtin plugin, it doesn't get whitelisted by the usual mechanism.
Explicitly whiltelist it.

BUG=409813
R=bauerb@chromium.org

Review URL: https://codereview.chromium.org/794903005

Cr-Commit-Position: refs/heads/master@{#308102}

BUG=441785
TBR=jbauman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/800923003

Cr-Commit-Position: refs/heads/master@{#308101}

Refactoring of ProtectedMediaIdentifierPermissionContext to derive from
PermissionContextBase class to conform with other APIs like geolocation
and midi. This has the advantage of less code and a consistent path for
all permissions. Also it makes it easier to implement PermissionService
because some functionality like HasPermission() can be implemented at
the level of PermissionContextBase.

Also add the corresponding UMA bits in histograms.xml and
permission_context_uma_util.cc.

BUG=

Review URL: https://codereview.chromium.org/769103002

Cr-Commit-Position: refs/heads/master@{#308100}

Check that all symbolized methods in the output orderfile are in their own linker section in the original object files.

BUG=440018

Review URL: https://codereview.chromium.org/796423003

Cr-Commit-Position: refs/heads/master@{#308099}

BUG=

Review URL: https://codereview.chromium.org/801803002

Cr-Commit-Position: refs/heads/master@{#308098}

Prior instrumentations showed:
StartSomeQueuedResolutions: 9 jph
ProfileIOData::Init: 4.4

BUG=436671

Review URL: https://codereview.chromium.org/796213002

Cr-Commit-Position: refs/heads/master@{#308097}

Instrumenting IOComplete internals to find jank.

From prior instrumentations, the jank turned to be in
QuicStreamFactory::Job::OnIOComplete - 26 jps
and
TransportConnectJobHelper::OnIOComplete - 7 jph

Instrumentation of the callback of QuicStreamFactory::Job::OnIOComplete is covered by CL https://codereview.chromium.org/789483004/.

This CL instruments the rest.

BUG=436634

Review URL: https://codereview.chromium.org/792233002

Cr-Commit-Position: refs/heads/master@{#308096}

* Remove unused methods.
* Move SkColor constants into BookmarkBarView (solo user).

BUG=None
R=sky@chromium.org

Review URL: https://codereview.chromium.org/795353003

Cr-Commit-Position: refs/heads/master@{#308095}

This CL moves the ZoomController code for WebView out of
ChromeWebViewGuestDelegate and into GuestViewBase and WebViewGuest. This
will allow non-chrome builds to access the WebView zoom api.

BUG=none

Review URL: https://codereview.chromium.org/787813004

Cr-Commit-Position: refs/heads/master@{#308094}

BUG=
NOTRY=True

Review URL: https://codereview.chromium.org/801853002

Cr-Commit-Position: refs/heads/master@{#308093}

third_party/libc++/trunk/src/support/solaris/xlocale.c from the license checker.

BUG=329819
R=phajdan@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/764113004

Cr-Commit-Position: refs/heads/master@{#308092}

This pulls in the following Native Client changes:

r14179: (kschimpf) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r14180: (ncbray) GN: fix layering of library dependencies.
r14181: (shyamsundarr) enable all nonspecial avx1 instructions.
r14183: (dschuff) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r14184: (dschuff) Use an architecture-specific newlib build for nacl-clang
r14185: (dschuff) Make libc.a a linker script for nacl-clang
r14186: (jvoung) Don't use pnacl raw toolchain in llvm nightly and libcxx tests.
r14187: (hamaji) Non-SFI Mode: Build PIE nonsfi_loader
r14188: (dschuff) Update revision for PNaCl r14173->r14185
r14189: (dschuff) PNaCl: Update Clang revision in pnacl/COMPONENT_REVISIONS
r14190: (jvoung) Remove a few locale-related "known failures" from libcxx list.
r14191: (dyen) NaCl Core SDK libs for both x86-32/x86-64 x86 newlib/glibc toolchains.
r14192: (sbc) Update glibc version in tools/REVISIONS (f78e18e->1106743)
r14193: (dyen) Fixed package_version reusing work dirs between revision packages.
r14194: (ncbray) Roll GCC toolchains.
r14195: (hidehiko) Non-SFI mode: Override NACL_BUILD_ARCH and _SUBARCH in build_nexe.py.
r14196: (dschuff) Remove cygwin support from buildbot_pnacl_toolchain.py
r14197: (jvoung) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r14198: (sbc) ncval_new: on success don't produce any output by default.
r14200: (ncbray) GN: do not assemble toolchain in output directory.
r14201: (grt) Stop closing thread handles owned by the Win32 debugging API.

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk

Review URL: https://codereview.chromium.org/793383003

Cr-Commit-Position: refs/heads/master@{#308091}

Changing in the intialization order of WeakPtrFactory such that all
member variables should appear before the WeakPtrFactory to ensure
that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818

Review URL: https://codereview.chromium.org/791743006

Cr-Commit-Position: refs/heads/master@{#308090}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/796413003

Cr-Commit-Position: refs/heads/master@{#308089}

I've been playing around with a build of Chrome that asserts all bitmaps
recorded into pictures are immutable.  Most are, but this one popped out
on sites that use native widgets (checkboxes, text fields, etc.).

While we're here, we can just call SkCanvas::setMatrix() instead of
concating the matrix with its inverse.  That works fine with SkPicture now.

BUG=

Review URL: https://codereview.chromium.org/801553002

Cr-Commit-Position: refs/heads/master@{#308088}

BUG=441258

Review URL: https://codereview.chromium.org/790233003

Cr-Commit-Position: refs/heads/master@{#308087}

BUG=NONE
TEST=
Note: this test step depends on xkb extension update first. It should be soon available in canary channel.
1. In chrome://settings/languages page, add "Dutch"
2. Check if you see two IMES available for this language(netherland and belgian)
3. enable the two imes and switch to them (assume netherland first)
4. verify the default virtual keyboard is a compact qwerty keyboard and can
switch to us-intl full layout
4. switch to belgian keyboard, verify it is azerty full keyboard and no compact
layout for it

Review URL: https://codereview.chromium.org/794453002

Cr-Commit-Position: refs/heads/master@{#308086}

The test sometimes fails on windows, because entry file is not yet
closed when the test tries to write into it.

Review URL: https://codereview.chromium.org/783473002

Cr-Commit-Position: refs/heads/master@{#308085}

BUG=440120

Review URL: https://codereview.chromium.org/790723003

Cr-Commit-Position: refs/heads/master@{#308084}

BUG=438230

Review URL: https://codereview.chromium.org/769423005

Cr-Commit-Position: refs/heads/master@{#308083}

This logic can also be used for keyboards, mice, touchpads, and tablets.

TEST=chrome on link_freon & rush_ryu
BUG=437539

Review URL: https://codereview.chromium.org/791743004

Cr-Commit-Position: refs/heads/master@{#308082}

BUG=

Review URL: https://codereview.chromium.org/799893003

Cr-Commit-Position: refs/heads/master@{#308081}

This patch removes all uses of ShowDesktopNotificationHostMsgParams and replaces
it with a more directed PlatformNotificationData. The PlatformNotificationData
structure has the same content as the WebNotificationData structure in the Blink
API, and included are canonical conversion functions between the two.

The reason for this change is two-folded:
  (1) The content/ layer now has the ability to initialize Web Notification
      objects, whereas this previously could only be done by Blink. This means
      that we have to carry all associated data around.

      The primary user for this are Persistent Notifications, which can outlive
      the page they were created by (and thereby the JavaScript objects).

  (2) The Web Notification specification is being updated with new features, a
      number of which will eventually have to be known to the browser process.
      This makes future plumbing significantly clearer.

Also, the *Desktop*Notification.. name is outdated.

BUG=432527

Review URL: https://codereview.chromium.org/794633002

Cr-Commit-Position: refs/heads/master@{#308080}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/799753002

Cr-Commit-Position: refs/heads/master@{#308079}