- 28 Aug, 2014 40 commits
-
-
perezju authored
Changed implementation to make a single shell call, rather than pushing files and executing several shell calls. When running telemetry unittests on android, reduces total execution time about 12%. BUG=379378 Review URL: https://codereview.chromium.org/514123005 Cr-Commit-Position: refs/heads/master@{#292405}
-
dcheng authored
BUG=110610 Review URL: https://codereview.chromium.org/512153002 Cr-Commit-Position: refs/heads/master@{#292404}
-
dcheng authored
BUG=110610 Review URL: https://codereview.chromium.org/512063003 Cr-Commit-Position: refs/heads/master@{#292403}
-
dmazzoni authored
This is a workaround for an Android accessibility bug - when the object with accessibility focus moves, Android doesn't update the bounds of accessibility focus on the screen, even if we send a WINDOW_CONTENT_CHANGED event. With this change, we keep track of the bounding rect of the node with accessibility focus, and if it changes, we move focus to the document and then back to this node, which works around the issue. No visual flicker was observed when testing on multiple devices. Refreshable braille displays flicker briefly. BUG=407871 Review URL: https://codereview.chromium.org/505423002 Cr-Commit-Position: refs/heads/master@{#292402}
-
skia-deps-roller authored
https://skia.googlesource.com/skia/+log/b2f7fce9e034c3b6749e75a129e7836df3529706..dc53701216c0e9f98eacf6c0cda769ebbd200b59 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel TBR=djsollen@google.com Review URL: https://codereview.chromium.org/517643002 Cr-Commit-Position: refs/heads/master@{#292401}
-
dcheng authored
BUG=110610 Review URL: https://codereview.chromium.org/515093002 Cr-Commit-Position: refs/heads/master@{#292400}
-
gavinp authored
Adds a regression test for bug 317138. This test is interesting because it generates exactly the same stacks that we're seeing in crash reports on that bug. This is a good regression test, so I suggest we land it, as well as look at it for more confidence that our fix to bug 317138 is the right fix. R=ttuttle@chromium.org,jkarlin@chromium.org BUG=317138 Review URL: https://codereview.chromium.org/509973002 Cr-Commit-Position: refs/heads/master@{#292399}
-
timvolodine authored
Adds UMA logging to track how many batteries are reported by the system at the start of Battery Status API. BUG= Review URL: https://codereview.chromium.org/480113003 Cr-Commit-Position: refs/heads/master@{#292398}
-
chrome-tpm authored
Cr-Commit-Position: refs/heads/master@{#292397}
-
fgorski authored
Extracting GCMConnectionObserver from GCMAppHandler * Updating consuming code: GCMInvalidationBridge * Updating GCMAppHandler overrides * Updating tests for GCMDriverDesktop BUG=407841 R=jianli@chromium.org Review URL: https://codereview.chromium.org/515763002 Cr-Commit-Position: refs/heads/master@{#292396}
-
qinmin authored
Most hardware OEMs provides codecs to support H264 main/high profile. The current way of declaring them as unsupported is too restrictive. BUG=407741 Review URL: https://codereview.chromium.org/506283002 Cr-Commit-Position: refs/heads/master@{#292395}
-
aurimas authored
BUG=163393 Review URL: https://codereview.chromium.org/509753002 Cr-Commit-Position: refs/heads/master@{#292394}
-
fsamuel authored
BUG=none TBR=fsamuel@chromium.org Review URL: https://codereview.chromium.org/517593002 Cr-Commit-Position: refs/heads/master@{#292393}
-
Scott Violet authored
I changed analyzer such that if a gyp file (or an included gypi file) changes all targets in the gyp file are marked as changed. This means I should no longer have to special case gyp files. I'm leaving the exception in place for any gyp files in build as any change to those really needs to recompile the world. BUG=109173 TEST=none R=thakis@chromium.org Review URL: https://codereview.chromium.org/512693004 Cr-Commit-Position: refs/heads/master@{#292392}
-
yiyaoliu authored
BUG=293702 Review URL: https://codereview.chromium.org/469653002 Cr-Commit-Position: refs/heads/master@{#292391}
-
mlamouri authored
Revert of DevTools: use explicit IPC messages for enabling/disabling tracing instead of intercepting protocol… (patchset #3 of https://codereview.chromium.org/511873002/) Reason for revert: Creates timeout failures on a lot of inspector/ tests in Blink: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28deps%29/builds/33453/steps/webkit_tests/logs/stdio Original issue's description: > DevTools: use explicit IPC messages for enabling/disabling tracing instead of intercepting protocol events > > Added IPC plumbing that allows InspectorTracingAgent to enable/disable browser-wide tracing. It was implemented by intercepting Tracing.started/Tracing.stopped events in the browser. Tracing.stopped event in the DevTools protocol was used by the renderer to notify the browser that it should stop trace event recording and it didn't make much sense for the client as there is already Tracing.tracingComplete event in the protocol. > > BUG=398787 > > Committed: https://chromium.googlesource.com/chromium/src/+/a449adae35631e4791547bd0b14403d1766f9ddf TBR=dcheng@chromium.org,caseq@chromium.org,loislo@chromium.org,vsevik@chromium.org,yurys@chromium.org NOTREECHECKS=true NOTRY=true BUG=398787 Review URL: https://codereview.chromium.org/516963003 Cr-Commit-Position: refs/heads/master@{#292390}
-
acolwell authored
Changing WebMediaPlayerImpl and related media code to use task runners instead of MessageLoopProxy to avoid presubmit errors when moving this code to media/blink. There is no functional change here. Just making the tools happy. :) BUG=408338 Review URL: https://codereview.chromium.org/508293003 Cr-Commit-Position: refs/heads/master@{#292389}
-
Nico Weber authored
brings in https://codereview.chromium.org/515263002 TBR=rnk@chromium.org Review URL: https://codereview.chromium.org/513973004 Cr-Commit-Position: refs/heads/master@{#292388}
-
vsevik authored
BUG=404355 R=yurys, pfeldman-OOO, horo Review URL: https://codereview.chromium.org/479673004 Cr-Commit-Position: refs/heads/master@{#292387}
-
dmazzoni authored
Consolidate the code to set accessibility focus to one place. Fix it so we never set accessibility focus to the same id twice in a row, as that puts things in a weird state (because we then get a "clear" accessibility focus action on the current focused view). In a couple of places where we want to explicitly update the focus, set focus away and then back again so Android can't ignore it. BUG=407871 Review URL: https://codereview.chromium.org/513483002 Cr-Commit-Position: refs/heads/master@{#292386}
-
eroman authored
BUG=407718 Review URL: https://codereview.chromium.org/510583002 Cr-Commit-Position: refs/heads/master@{#292385}
-
felt authored
When tab focus is placed on the security warning primary button, Chrome should outline the button. However, the outline is not shown during button activation to prevent it from making the button border an odd white-gray-blue. BUG=387163 R=bauerb@chromium.org Review URL: https://codereview.chromium.org/511073002 Cr-Commit-Position: refs/heads/master@{#292384}
-
mseaborn authored
This pulls in the following Native Client changes: r13667: (yyanagisawa) Re-enable use of Goma on Windows, except when using the PNaCl toolchain r13668: (noelallen) Force rebuild on cmd change. BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build TBR=bradnelson@chromium.org Review URL: https://codereview.chromium.org/513933003 Cr-Commit-Position: refs/heads/master@{#292383}
-
sky authored
. Make HistoryService::Cleanup() private. Making this public can leave HistoryService in a bad state. . HistoryServiceFactory would leak a HistoryService if HistoryService::Init() failed. BUG=none TEST=none R=brettw@chromium.org Review URL: https://codereview.chromium.org/510033004 Cr-Commit-Position: refs/heads/master@{#292382}
-
vasilii authored
BUG=394287 Review URL: https://codereview.chromium.org/512683003 Cr-Commit-Position: refs/heads/master@{#292381}
-
benm authored
BUG=408525 Review URL: https://codereview.chromium.org/513173002 Cr-Commit-Position: refs/heads/master@{#292380}
-
yurys authored
DevTools: use explicit IPC messages for enabling/disabling tracing instead of intercepting protocol events Added IPC plumbing that allows InspectorTracingAgent to enable/disable browser-wide tracing. It was implemented by intercepting Tracing.started/Tracing.stopped events in the browser. Tracing.stopped event in the DevTools protocol was used by the renderer to notify the browser that it should stop trace event recording and it didn't make much sense for the client as there is already Tracing.tracingComplete event in the protocol. BUG=398787 Review URL: https://codereview.chromium.org/511873002 Cr-Commit-Position: refs/heads/master@{#292379}
-
hanxi authored
Move ExtensionWarningService and ExtensionsWarningSet, which are used by webrequest api, to extensions. This cl resolve the dependencies of ExtensionsWarningSet of chrome strings: - move the declarations of IDS_EXTENSION_WARNINGS_XXX to extensions_strings.grd; - replace the usage of "IDS_PRODUCT_NAME" by creating GetProductName() function in ExtensionsClient and its subclasses. BUG=352293 Review URL: https://codereview.chromium.org/503033002 Cr-Commit-Position: refs/heads/master@{#292378}
-
joaodasilva authored
BUG=None Review URL: https://codereview.chromium.org/512223002 Cr-Commit-Position: refs/heads/master@{#292377}
-
philipj authored
It was moved in https://crrev.com/55b8563 Found by git grep 'components.*breakpad' BUG=406410 R=rsesek@chromium.org TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/511223002 Cr-Commit-Position: refs/heads/master@{#292376}
-
Paweł Hajdan, Jr authored
BUG=408285 R=glider@chromium.org Review URL: https://codereview.chromium.org/510913004 Cr-Commit-Position: refs/heads/master@{#292375}
-
dgozman authored
BUG=none Review URL: https://codereview.chromium.org/501153006 Cr-Commit-Position: refs/heads/master@{#292374}
-
thiago.santos authored
This removes an ash dependency from the system.display API in order to move it to extensions/. As a side effect, we got rid of #ifdefs on system_info_api.cc BUG=392842 Review URL: https://codereview.chromium.org/507783003 Cr-Commit-Position: refs/heads/master@{#292373}
-
qsr authored
Instead add a run_mojo_python_bindings_tests.py that will be run from the bots. This also refactor run_mojo_python_tests.py to factorize the common code. BUG=407818 Review URL: https://codereview.chromium.org/509863002 Cr-Commit-Position: refs/heads/master@{#292372}
-
earthdok authored
BUG=405951 TBR=lally@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/515193002 Cr-Commit-Position: refs/heads/master@{#292371}
-
mithro authored
These functions where invaluable when trying to debug and fix the cc::OrderedTestRunner as they let me easily inspect the tasks without having to fire up GDB. They should also be useful in development / testing of other task runners. Added a very simple test for ShouldRunBefore which shows this stuff working. If that test fails, the output looks like the following; ------------------------------------------------------------------------------- ../../base/test/test_pending_task_unittest.cc:49: Failure Value of: task_after.ShouldRunBefore(task_first) Actual: false Expected: true TestPendingTask( {"delay":2000,"nestability":"NESTABLE","post_time":0, "posting_function":"Unknown@Unknown:-1","run_at":2000} ).ShouldRunBefore(TestPendingTask( {"delay":1000,"nestability":"NESTABLE","post_time":0, "posting_function":"Unknown@Unknown:-1","run_at":1000}) ) ------------------------------------------------------------------------------- BUG=380889 Review URL: https://codereview.chromium.org/491743002 Cr-Commit-Position: refs/heads/master@{#292370}
-
rtenneti authored
flight. Merge internal change: 74165077 Renabled flaky LargePostZeroRTTFailure to see if this CL fixes issue 407756 on chromeos valgrind. R=rch@chromium.org, rjshade@chromium.org BUG=407756 Review URL: https://codereview.chromium.org/511003002 Cr-Commit-Position: refs/heads/master@{#292369}
-
rmcilroy authored
BUG=408179 NOTRY=true Review URL: https://codereview.chromium.org/509333002 Cr-Commit-Position: refs/heads/master@{#292368}
-
mlamouri authored
Revert of Modify test case to support streaming operation in sandbox file system. (patchset #6 of https://codereview.chromium.org/491813002/) Reason for revert: This is breaking fast/filesystem/op-copy.html in Blink: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=fast/filesystem/op-copy.html Original issue's description: > Modify test case to support streaming operation in sandbox file system. > > BUG=360088 > TEST=content_unittests passed > > Committed: https://chromium.googlesource.com/chromium/src/+/2332db94ec6c42aaa3d66f5226a4c17b85c1553e TBR=tzik@chromium.org,iseki@chromium.org NOTREECHECKS=true NOTRY=true BUG=360088 Review URL: https://codereview.chromium.org/510323003 Cr-Commit-Position: refs/heads/master@{#292367}
-
bartfab authored
This pulls in the following changes: * dbus: Add method for cryptohomed GetKeyDataEx * Remove deprecated shill::kPaymentURLProperty * Add a constant for the 'org.freedesktop.DBus' interface. * dbus/service_constants.h: Remove "Cellular.ActivateOverNonCellularNetwork" * Add portal detection failed phase and status to service property BUG=367847 TEST=Everything still compiles Review URL: https://codereview.chromium.org/507973003 Cr-Commit-Position: refs/heads/master@{#292366}
-