- 12 Oct, 2020 40 commits
-
-
Willie Koomson authored
This change adds a check in ArcVmClientAdapter::StopArcInstance() to see if a VM is running (current_cid_ is set). If not, skip calling ConciergeClient::StopVm() and notify observers that ARCVM is stopped right away. BUG=b:169893632 TEST=arc.AuthPerf.unmanaged_vm Change-Id: Ic927f122cacea0e89cacffbbcd67a217772dba43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462573 Commit-Queue: Willie Koomson <wvk@google.com> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#816221}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ia1fb6ddabd8c6b0a8fea720662d2f4b4b703374c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462046Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#816220}
-
David Tseng authored
Change-Id: I86274af81a2d60223813cdfb91253abca97a766b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465383Reviewed-by:
Adam Ettenberger <Adam.Ettenberger@microsoft.com> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#816219}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2067d1a93e6e..69d0c1acc28a 2020-10-12 rverschelde@gmail.com Remove executable bits from code/data files (#2420) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com Change-Id: I956c21d527d9508e49c0e021f00f62762dd87bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466317Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816218}
-
rbpotter authored
Last portion of a rebase of: https://chromium-review.googlesource.com/c/chromium/src/+/2443211 by dpapad@ onto the addition of a new resource_path grit property. This CL updates Print Preview to use the new manifest generation option in optimize_webui, combined with the resource_path grit property and generate_grd changes, to autogenerate the grd file in optimized builds. Bug: 1132403 Change-Id: I8f03064bbacd0ce993f59cf008ee27112d1934cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458878 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#816217}
-
Finnur Thorarinsson authored
Bug: 1135551 Change-Id: If6eb558fd23c74b16479a4f23b4327b522a828e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442691Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#816216}
-
Zach Trudo authored
Bug: chromium:1078512 Change-Id: I959ed70590b80770eef0edd44fd88ea940e1020e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459706Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#816215}
-
Idries Hamadi authored
Adds RectUtil class for computing coverage of multiple rects Add an OnPreDraw Listener to AwContents Provides a means for the Java side of AwContents to determine whether the WebView is displaying Open Web Content. Tracking is behind an experiment flag Bug: 1122091 Bug: 1122060 Bug: 1122203 Bug: 1122087 Change-Id: Ie8587525310c4b856bf08d9c2edd2af74ec376e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327050 Commit-Queue: Idries Hamadi <idries@google.com> Auto-Submit: Idries Hamadi <idries@google.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#816214}
-
Zach Trudo authored
CloudPolicyClient will be expanded to make use of a new server endpoint. This change prepares DeviceManagementService for that eventuality. Bug: chromium:1135951 Change-Id: I8b23d8dc112a8f583ddc249f01572cae9522d99b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454278Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/46d4522b161b..0f55e3e5d266 2020-10-12 lexa.knyazev@gmail.com Reland "Remove redundant BlendStateArray tracking" 2020-10-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 51b03d58fb17 to e72c6099f946 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1085996,chromium:1086582,chromium:1086585,chromium:1086586 Tbr: ynovikov@chromium.org Change-Id: Ibe5cf5d42a910067ee3f3282bf57815ddd07b120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465208Reviewed-by:
-
Hidehiko Abe authored
This reverts commit 2133e7d7. Reason for revert: The original revert was speculative. Relanding. Original change's description: > Revert "Fix ifdef guard for OS_CHROMEOS." > > This reverts commit fcffa1cc. > > Reason for revert: Reverting due to failure on Linux ASAN LSAN bot > See link below for failure details: > https://ci.chromium.org/p/chromium/builders/ci/Linux%20ASan%20LSan%20Tests%20%281%29/82545 > > Original change's description: > > Fix ifdef guard for OS_CHROMEOS. > > > > There's on going work to unset OS_LINUX on Chrome OS build, > > however, it is not yet completed, so it is still defined. > > > > This CL adds the explicit !defined(OS_CHROMEOS) to fix > > the behavior. > > > > Bug: 1110266 > > Test: Built locally. > > Change-Id: I60731672aabb6bb6025e29a0b641988e68ecade5 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460826 > > Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> > > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#815116} > > TBR=hidehiko@chromium.org,guidou@chromium.org > > Change-Id: I59d4a9dfe96d45199c87fcf42a65d9e05e7b76d1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1110266 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462015 > Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org> > Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815138} TBR=hidehiko@chromium.org,guidou@chromium.org,tluk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1110266 Change-Id: I086c838a52603f647d5dbc948e577e930d80ecd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466008Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#816211}
-
Egor Pasko authored
Disable CrossPlatformAccessibilityBrowserTestWithImplicitRootScrolling.ImplicitRootScroller on Android It fails since 2020-10-01 on test-o-phone. Tbr: dmazzoni@chromium.org Bug: 1137425 Change-Id: I6457626f3da9e021b888d0b92506262206105730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466239Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#816210}
-
Claude van der Merwe authored
Wifi Sync is enabled from a Chrome OS device if the multidevice setup is complete and the Wifi Sync flag is enabled on the Chrome OS device. This CL adds a pending state kEnableOnVerify that gets set when the Multidevice setup is complete on a Chrome OS device with the Wifi Sync flag enabled. The kEnableOnVerify state listens for the host to become verified and enables Wifi Sync if it is not already enabled. The kEnableOnVerify state gets cleared if the host device is removed. Bug: 1117619 Change-Id: I34070149b963629aa0ff0dc2da8c3022c2fcef5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457047 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#816209}
-
Moe Ahmadi authored
This reverts commit 174d9faa. Reason for revert: Breaking https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-cfi-thin-lto-rel See: https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-cfi-thin-lto-rel/24710 Original change's description: > build: In LTO links, run just one link at once, but give it all cores > > Normally, we allow running several links in parallel if there's enough > memory, since links tend to be memory- and io-bound, not compute bound. > However, in LTO builds the linker does codegen for every linked > translation unit, which needs a lot of CPU. > > Previously, we used to hardcode 8 threads per link for thinlto builds, > which makes builds needlessly slow on machines with many cores. > > Instead, automatically use all cores for a thinlto link, but only run > one link in parallel at once. > > chromeos-chrome-9999.ebuild in the Chrome OS build and link_jobs_32 in > mb_config.pyl currently manually set the number of threads per lto link > to the number of cores. Once this change here is in, we should stop > explicitly setting the arg there and then we can turn this from a gn arg > to a regular variable that's not settable in args.gn > > Bug: 1132930 > Change-Id: If2fda3e38b2b1827beb2da844f024f52211210db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464782 > Reviewed-by: Hans Wennborg <hans@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816129} TBR=thakis@chromium.org,hans@chromium.org Change-Id: Ic1d381681e00dbebd576ec44119d426518f4b778 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1132930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466261Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#816208}
-
Xianzhu Wang authored
Bug: 1136764 Change-Id: Id909f6ef11c914ca8ff4c468c669a60d0f04dd31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464015Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816207}
-
Xiaohui Chen authored
Bug: b:170509871 Test: unittests and manually on nocturne Change-Id: Ib59a1c9e00056a5fdd13e5ee94cac51c365cf9b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462025Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#816206}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/109c355900d1..7c7b98f06001 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0adf5ba77c2c555b89df7d4232747c824ad5addf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466316Reviewed-by:
-
Mohamed Amir Yosef authored
Before this CL, each part of the badged icon was a views, however, this wasn't necessary since they were never placed using layout manager and users were never supposed to interact with them. This CL should introduce only minor visual difference. It however uses ImageSkiaOperations which: 1- Eliminates the need for 2 custom views. 2- Allows to use a more standard way for creating badged images by using gfx::ImageSkiaOperations::CreateIconWithBadge(). Bug: 1100814 Change-Id: Iaf84b61c4bae1d7130ae58513c9b287ba8eb55d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466276 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#816204}
-
Eric Willigers authored
Remove #include from source files that do not use ScopedFeatureList. Bug: 1137231 Change-Id: I2513187d4585930e0ac2a82a45cd15f0ffe2645a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463021 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#816203}
-
Moe Ahmadi authored
Fixed: 1136654 Change-Id: I55f7cb4ca34332a33d81421a9a21475279e6fa08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463335Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#816202}
-
Victor Hugo Vianna Silva authored
Following crrev.com/c/2465744, the last usage of this class (in DataTypeController::GetStatusCounters() and similar methods) is unused in production code, so this CL removes the class. As for the methods, some are removed, while others are converted into *ForTest methods that don't make use of the class, in case they are still used in test expectations and there's no other good way of verifying those. The CL also removes the unimplemented method DataTypeDebugInfoEmitter::EmitStatusCountersUpdate(), so that there's no reference to the concept of StatusCounters in the sync codebase anymore. Bug: 1102849 Change-Id: I47dc92b6ce6f1631cc3762834770c54e3d47ea12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463611 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#816201}
-
Antonio Gomes authored
This is step 1.2 on the design document [1]. [1] https://docs.google.com/document/d/1xHwcHrAiEaWuA4usGEqKZ9zm1H8SGk3WkS-Jf2Q_los/edit BUG=1113900 R=jamescook@chromium.org, sky@chromium.org Change-Id: Ic625b887b00538d758260a3f35426c346bcdbabf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458768 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#816200}
-
Kurt Catti-Schmidt (SCHMIDT) authored
This is a speculative fix, as I haven't been able to reproduce this overflow. There also is not a unit test, because I haven't been able to reproduce this overflow by tweaking the unit test from https://chromium-review.googlesource.com/c/chromium/src/+/2426490 However, this is still causing crashes, even after the CL 2426490 has gone in. And all of the overflows that I've seen after that CL loop forever in the kMoveRight scenario, so I am confident that this change will provide the complete mitigation. Bug: 1124394 Change-Id: Ife9293f2fa26a34c17d1aace03b38b3592f387d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464003Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#816199}
-
Rushan Suleymanov authored
This is the first patch in chain which starts removing one of mocking classes: RecordingModelTypeChangeProcessor. This class will be replaced by MockModelTypeChangeProcessor. This CL introduces the mock_processor in typed url sync bridge tests and changes first two tests to use only mock_processor. Bug: 791939 Change-Id: I162e56587e9f2765b8d2ebcc8f021a140d99ae9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466099 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
-
Avi Drissman authored
Users might not like the URL display on the touchbar in fullscreen. This CL makes the fullscreen touchbar customizable. Right now, that means that the user can add or remove the single item in it (the URL display) but that should help for the case in the bug. Fixed: 1135102 Change-Id: I99e3ca0d4d9d6575a0ec79ab3329e54613475e7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464080 Commit-Queue: Leonard Grey <lgrey@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#816197}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fb0f797b07aa..d185008d04b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC gab@google.com,amraboelkher@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: gab@google.com,amraboelkher@google.com Change-Id: Ibcd0140d4bda02e4478ff5d552c21f8c0abf355e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465770Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816196}
-
Alexander Dunaev authored
Historically, there were a few discrepancies in behaviour of file drag and drop on different platforms. With introduction of Ozone and implementation of X11 platform it became so complicated that a few tests had been disabled. The core difference between Linux and non-Linux was in how string and URI contents are handled together. Various Linux file managers pass both string and URI together, for which there was a workaround in the X11 implementation but not in Wayland one. Another difference was that drags started in the renderer did not take files (due to security reasons) but the non-backed data provider used in ChromeOS and Wayland didn't recognise this scenario. This CL unifies the behaviour on Linux platforms and makes the non-backed data provider aware of drags originated from renderer, and enables the tests that validate this behaviour. Bug: 1121928, 1070483 Change-Id: If64857c60df295b37f1f5d4abe11338912134f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461372Reviewed-by:
-
David Tseng authored
R=dmazzoni@chromium.org Test: run through all Tts Debug tests; manually using Eve/Hana; word callbacks; continuous read on large blocks; trigger lots of interruptions; start/end callback testing. Change-Id: I7ebc43620adbd5adc9de23ead8af12bde9f4bf14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465564Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 87-4265.0-1601890590-benchmark-87.0.4280.15-r1 to 87-4265.0-1601890590-benchmark-87.0.4280.16-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I8f3f3c00ae6b359a4edc2555b39e49221bfdb7e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465649Reviewed-by:
-
Paula Vidas authored
Since |committer_id| is a bit ambiguous, it's renamed to |committer_invalidator_client_id|. Change-Id: I3403b9eba366c51af328df16b859d53b5582759f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462265 Commit-Queue: Paula Vidas <paulavidas@google.com> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/07055b5e25a2..ceb6214a556a 2020-10-12 ethannicholas@google.com moved SkSL InlineMarker and UnresolvedFunction data into IRNode 2020-10-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 952149303d06 to e72c6099f946 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: I01428e4b6fdb4e6978849d1031ebeb89714ab24f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465772Reviewed-by:
-
Dan McArdle authored
This CL contains a tentative fix for a crash that was uncovered when we enabled the control domain wildcard [1] for the INTEGRITY experiment. Currently, all INTEGRITY responses get the error OK, regardless of their contents. This OK error can overpower the actual errors of A or AAAA responses in HostCache::Entry::MergeEntries. As a result, the TransportConnectJob assumes that the address results are nonempty, and unconditionally dereferences the front of the |AddressList::endpoints_| vector [2]. [1]: See net::features::kDnsHttpssvcControlDomainWildcard [2]: See net::TransportConnectJob::DoTransportConnect() Bug: 1136661 Change-Id: I5d7534c3244cddcf7029c38577d649870ed92bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463598 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#816190}
-
Alexander Surkov authored
Bug: 1133330 Change-Id: I3669a7aa774a2b58ccd05142b7f874e14c3ae451 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461235Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#816189}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/84bd221ed748..4fe1d403a22d 2020-10-12 chrome-bot@chromium.org Update config settings by config-updater. 2020-10-10 yueherngl@google.com volteer: add firmware-volteer-13521.B branch builder 2020-10-09 chrome-bot@chromium.org Update config settings by config-updater. 2020-10-09 saklein@chromium.org deploy: Refactor SplitCPV to parse. 2020-10-09 saklein@chromium.org portage_testables: Refactor SplitCPV to parse. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ic1f9dfa0cf653d9757b324b8b73335de7629aac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465206Reviewed-by:
Keigo Oka <oka@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816188}
-
David Tseng authored
This event gets fired by ARC++, so it's likely been a no-op in automation ever since the event generator changes, since ARC++ doesn't set any of the *scroll* int attributes. chrome/browser/chromeos/arc/accessibility/arc_accessibility_util.cc It does get fired by Blink as well at the moment third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc so this patch changes those event sites to generic events. Finally, re-introducing this event seems to have triggered Error: Error in event handler for scrollPositionChanged during phase 1: TypeError: Cannot read property 'start' of null at Output.range_ (chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromevox/chromeVoxChromeBackgroundScript.js:1246:77) at Output.render_ (chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromevox/chromeVoxChromeBackgroundScript.js:1183:83) at Output.withLocation (chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromevox/chromeVoxChromeBackgroundScript.js:1148:107) at DesktopAutomationHandler.onScrollPositionChanged (chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromevox/chromeVoxChromeBackgroundScript.js:2232:140) at DesktopAutomationHandler.<anonymous> (chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromevox/chromeVoxChromeBackgroundScript.js:1824:1) which we can check for explicitly. What looks to be happening is the target of the scroll position changed is detached. R=dmazzoni@chromium.org, hirokisato@chromium.org Change-Id: If3008218d8e0565428bd18cf8642eb106d83fdec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451974Reviewed-by: -
Polina Bondarenko authored
Add an auto-login to Managed Guest Session / public account to start ARC snapshot creation. Block auto-login flow even if specified by policy. Wait for ArcDataSnapshotdManager successfully generates a key pair and auto-login to MGS once it is ready. BUG=b:161221001 TEST=components_unittests TEST=browser_tests Change-Id: Ib7895f49f9295b3959226cde3e304c9c78614e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440872Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
David Maunder authored
Where appropriate and available we display the price of an offer on a shopping website in the card in the tab grid switcher. The backend is not ready yet but the integration is in place and unit tested. The feature is behind a flag and will be able to be turned on via the flag UI when the backend is ready. Bug: 1129203 Change-Id: I7c1cad74d769e2c3286f209dc20509e80ad045f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419632 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#816185}
-
Nektarios Paisios authored
This is a speculative fix which I wasn't able to test, but which will hopefully resolved the attached bug. Retrieving the document markers for an AXInlineTextBox requires access to the flattened representation of the DOM tree. To get this representation, all slots in related shadow DOM subtrees need to be filled in, A.K.A. Document::UpdateDistributionForFlatTreeTraversal() needs to be called. In fact, if accessibility doesn't call this method, it is automatically called by the DOM Position class when accessibility requests for a DOM Position to be converted to the equivalent position in flat tree. To prevent a potential infinite loop, we return early when slots in the shadow DOM are dirty. An infinite loop might occur because updating the distribution for the flat tree could in turn update the accessibility tree which could in turn call GetDocumentMarkers again. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 1124683 Change-Id: I5f373459f2a4879df4b9754f64c465e7f2b6536d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464910 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#816184}
-
Maksim Moskvitin authored
Verifier profile is a bad way to specify tests expectations and its usages should be avoided. This CL replaces all usages in dictionary tests with actual checks of dictionary state. Side change: AddDifferentToEach test is removed, because it was a subset of Sanity test. Bug: 1033848 Change-Id: Icd6a3aa25bafd7bd375c0c7daa45cf3cb413fbef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465906 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Bailey Berro authored
This change introduces the SystemRoutineController class that connects to the cros_healthd DiagnosticsService. Subsequent CLs will declare and implement a SystemRoutineController mojo interface. Bug: 1128204 Change-Id: Ic510e1f90efedbbcba42827ca843323f04803e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457807Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#816182}
-
