GitLab

CL:1045256 calculates |uv_rect| of the primary plane in wrong way. It causes
drmModeAtomicAddProperty failure. This CL fixes it.

BUG=896945

Change-Id: I6e914707cb961e8294e8ddd160b75e48ae5a2b64
Reviewed-on: https://chromium-review.googlesource.com/c/1291590
Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Kristian H. Kristensen <hoegsberg@chromium.org>
Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com>
Cr-Commit-Position: refs/heads/master@{#601392}

This reverts commit 4c097c39.

Reason for revert: I found a bug in internal keyboard detection. I will reland with fix to be able to merge to M-71.

Original change's description:
> Hide option to remap internal search when no internal KB is connected
> 
> To avoid confusion when there is no internal keyboard connected:
> - We should not show the option to remap the internal "Search"
> key since that key doesn't exist.
> - We should also avoid labeling the options to remap the external
> meta keys as "External Meta" or "External Command", and just say
> "Meta" or "Command" as "External" here is redundant.
> 
> BUG=890522, 890950
> TEST=Expanded existing tests.
> 
> Change-Id: If979b80217298a5f6bb18be478aa2c457859a351
> Reviewed-on: https://chromium-review.googlesource.com/c/1253022
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599409}

TBR=stevenjb@chromium.org,afakhry@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 890522, 890950
Change-Id: I9cd4273a61c51751a20d8bbffbf7fffbb252246c
Reviewed-on: https://chromium-review.googlesource.com/c/1292816Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601391}

This reverts commit 8e3e6c83.

Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=896603

Original change's description:
> Network Service: Convert port_forwarding_controller.cc to mojo host resolver
>
> Bug: 874651
> Change-Id: I4762526cc8fc4dbf18512b8ab7fbeeda8434336d
> Reviewed-on: https://chromium-review.googlesource.com/1184306
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Commit-Queue: Jun Cai <juncai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#585658}

TBR=caseq@chromium.org,mmenke@chromium.org,juncai@chromium.org,ericorth@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 874651, 896603
Change-Id: Iaeede103359aeb369589620ec10085dcf20311ee
Reviewed-on: https://chromium-review.googlesource.com/c/1292824
Commit-Queue: Jun Cai <juncai@chromium.org>
Reviewed-by: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601390}

https://webrtc.googlesource.com/src.git/+log/51cc30c12411..648d28ad6257


git log 51cc30c12411..648d28ad6257 --date=short --no-merges --format='%ad %ae %s'
2018-10-19 thaloun@google.com Media engine and channel support for per-channel dscp values, specified by RtpParameter


Created with:
  gclient setdep -r src/third_party/webrtc@648d28ad6257

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I27cdd34c150d2be9e783f26da58977e3e7c0ff53
Reviewed-on: https://chromium-review.googlesource.com/c/1292793Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601389}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/bd5d55eea5c0..9b771ac49bd2


git log bd5d55eea5c0..9b771ac49bd2 --date=short --no-merges --format='%ad %ae %s'
2018-10-20 derat@chromium.org Revert "chromeos_config: Reenable Tast on VM paladin builders."


Created with:
  gclient setdep -r src/third_party/chromite@9b771ac49bd2

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I29869cd7fe4e250854738c290c9337dc859c67b3
Reviewed-on: https://chromium-review.googlesource.com/c/1292794Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601388}

This removes a footgun, since InkDropHostView's View overrides provided a lot of
functionality that any InkDropHost implementation would want.

Also does various other cleanups:
* IWYU fixes
* Remove unnecessary qualifiers
* Reorder InkDropHostView declarations and definitions to match each other and
  be in a more logical order
* Initialize InkDropHostView members in declaration

Bug: none
Change-Id: Iaf067fbb6361324fbf2da1a82f6658a4b564775e
Reviewed-on: https://chromium-review.googlesource.com/c/1282216
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601387}

Currently, we sometimes pause videos when they are hidden, as an
optimization. This causes videos flung to cast devices to pause as well,
since the pause command sent to the FlingingRenderer is forwarded to the
cast device.

This CL fixes adds a new flag to track whether or not we are currently
flinging a video, and disables ShouldPauseVideoWhenHidden() when we are.

Bug: 790766
Change-Id: I7729ab2c8187ffd1c77ebb6c48301165dea1d90f
Reviewed-on: https://chromium-review.googlesource.com/c/1292820Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601386}

This patch implements the ability to load skia vector animation files
via the resource bundle. Each file is only loaded once and cached for
future use. ResourceBundle expects the animation file to be gzipped.

UMA metrics are also recorded to note the time to uncompress and parse
each animation file.

Bug: 890512
Change-Id: Ie0e17dbee9198b12a886f3739a034ad366bf9478
Component: ResourceBundle, skia vector animations
Reviewed-on: https://chromium-review.googlesource.com/c/1272800Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601385}

Currently MSVC_SUPPRESS_WARNING is used in a place.
Let me use os-specific static_cast instead.

Change-Id: Ief273eaf2cc3a6b5e99948b618f9dc9c005898b2
Reviewed-on: https://chromium-review.googlesource.com/c/1290574
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601384}

Throttle begin-frames to clients until gpu is done processing the
earlier swaps. This helps with reducing work when the gpu has a high
load, by not sending begin-frames to clients.

The clients always keep receiving the compositor-frame-ack messages
when a surface becomes activated (or replaces an older pending frame),
even if the gpu is busy doing work from earlier frames. So this change
introduces the back pressure by way of withholding begin-frames so
clients have to do less work.

BUG=877906

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: If34eb5c5af03961e17932c8f57caf352d0362bab
Reviewed-on: https://chromium-review.googlesource.com/c/1282219Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601383}

A shell surface widget needs be created when the surface has a content,
(https://cs.chromium.org/chromium/src/components/exo/shell_surface.cc?rcl=63840f211efada36274cae7ade3003a2dc88c74b&l=475)
but it can be created without content if a client requested maximize/fullscreen/minimize state upon creation.

This is necessary since xdg (or gtk3 wayland client) seems to have an issue if we configure before the content
is created, and it stops updating frames, even if we sends new configure events later.

Bug: 892291
Test: Covered by unit tests. Also tested manually. See bug for repro step.
Change-Id: I115ec6540a0ec2fc5258c020bd05c4be623f85da
Reviewed-on: https://chromium-review.googlesource.com/c/1278986
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601382}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/549b4ca0fa63..90b15ebffc98


Created with:
  gclient setdep -r src-internal@90b15ebffc98

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ib5525440069d08a8e32bc70db58c91fe0bf740c0
Reviewed-on: https://chromium-review.googlesource.com/c/1292286Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601381}

This reverts commit 310c6fa1.

Reason for revert: flaky previews test

Original change's description:
> Switching Previews triggering from the IO thread to the UI thread
> 
> This CL moves previews triggering from the IO thread
> (ChromeResourceDispatcherHostDelegate) to the UI thread
> (ChromeContentBrowserClient). The new call sites occur in
> NavigationRequest and update the previews_state in
> CommonNavigationParams held by the NavigationRequest directly. This
> means PreviewsDeciderImpl is being moved to the UI thread.
> 
> Significant changes:
> - PreviewsDeciderImpl is now owned by the PreviewsUIService instead of
> profile IO data.
> - PreviewsUserData is now entirely a UI thread notion. For now, we use
> PreviewsUITabHelper to manage its lifetime, but it could move to
> NavigationHandle (if NavigationHandle already supported UserData,
> that solution would be ideal).
> - ChromeNavigationData is update to remove PreviewsUserData and
> PreviewsState (the latter has moved into PreviewsUserData and there is a
> notion of Allowed PreviewsState and committed PreviewsState)
> - Offline Previews committed checks use the OfflinePreviewsTabHelper
> instead of PreviewsUserData now that we are on the same thread.
> - Cleanup on ResourceRequestInfo to remove PreviewsState setter as well
> as cleanup to remove PreviewsState from being passed back out of the
> loader code into NavigationRequest.
> - There is a TODO to re-evaluate PreviewsState during redirects, which
> will *not* be plumbed into the network service, so DataReductionProxy
> Previews will not be updated.
> 
> Bug: 842233
> Change-Id: I80a3044a4c84734b877f8ebcbe5a4bb2c2900dbb
> Reviewed-on: https://chromium-review.googlesource.com/c/1266196
> Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Camille Lamy <clamy@chromium.org>
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: Jian Li <jianli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#601298}

TBR=clamy@chromium.org,jianli@chromium.org,mmenke@chromium.org,tbansal@chromium.org,robertogden@chromium.org,ryansturm@chromium.org,jochen@chromium.org

Change-Id: I176df103620910300297ce0fb9bc6d233b4ebb2f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 842233
Reviewed-on: https://chromium-review.googlesource.com/c/1292836Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601380}

Bug: 895547
Change-Id: I2d05a172f353938555e8ac1c9d7f0527fa69329d
Reviewed-on: https://chromium-review.googlesource.com/c/1281914Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601379}

https://chromium.googlesource.com/angle/angle.git/+log/32643cea2319..b8eec4a4ab53


git log 32643cea2319..b8eec4a4ab53 --date=short --no-merges --format='%ad %ae %s'
2018-10-19 jmadill@chromium.org Use angle::Result in front-end (Part 7)
2018-10-19 jmadill@chromium.org Use angle::Result in front-end (Part 6)
2018-10-19 jmadill@chromium.org Use angle::Result in front-end (Part 5)
2018-10-19 jmadill@chromium.org Use angle::Result in front-end (Part 4)
2018-10-19 jmadill@chromium.org Use angle::Result in front-end (Part 3)


Created with:
  gclient setdep -r src/third_party/angle@b8eec4a4ab53

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I38e7beec0c56a6283c108fe66c1820f30bbcd07c
Reviewed-on: https://chromium-review.googlesource.com/c/1292790Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601378}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/93277a7fc8ef..98f1e59b41c6


git log 93277a7fc8ef..98f1e59b41c6 --date=short --no-merges --format='%ad %ae %s'
2018-10-19 iannucci@chromium.org [git] Stop using git-retry wrapper on LUCI.


Created with:
  gclient setdep -r src/third_party/depot_tools@98f1e59b41c6

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Id3e109f3e431c49ad9e50e6ce2963180ccd56ee4
Reviewed-on: https://chromium-review.googlesource.com/c/1292285Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601377}

This reverts commit b011ab56.

Reason for revert: caused test failures -- see crbug/897352

Original change's description:
> Upgrade image file management for Win 10 native notification
> 
> This CL makes the following changes:
> 1) Change to run image folder cleanup after Chrome startup using a background
>    task, rather than running it at Chrome shutdown using a high priority task.
> 2) Retain the image folder to avoid deleting and creating it repeatedly.
> 3) Remove <subdir> from the full path for the temp file, which is unnecessary.
> 4) Delete the temp files in batch.
> 
> These changes have the following benefits:
> 1) Fix the issue of Chrome shutdown being blocked by image file IO for some users
>    as in the current implementation.
> 2) Save some disk IO related to the sub-directories in the image folder and the
>    image folder itself.
> 3) Avoid creating a deletion task for each file, otherwise the overhead can be
>    large when there is a steady stream of notifications coming rapidly.
> 
> Bug: 888276
> Change-Id: I214680aa00bd7f19e84e207e82ada553583a094b
> Reviewed-on: https://chromium-review.googlesource.com/c/1260498
> Commit-Queue: Xi Cheng <chengx@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Reviewed-by: Greg Thompson <grt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#601227}

TBR=isherman@chromium.org,finnur@chromium.org,grt@chromium.org,chengx@chromium.org

Change-Id: Ie79e62373c0076346499e450e48c2d16b55c6dc4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 888276, 897352
Reviewed-on: https://chromium-review.googlesource.com/c/1292834Reviewed-by: Xi Cheng <chengx@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601376}

Bug: 896480
Change-Id: I9a0b2b041991a1dbcc63f3190df4dec650f4c25a
Reviewed-on: https://chromium-review.googlesource.com/c/1286826
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601375}

https://skia.googlesource.com/skia.git/+log/41ba826ad7b4..773e141a83e3


git log 41ba826ad7b4..773e141a83e3 --date=short --no-merges --format='%ad %ae %s'
2018-10-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader d55d997310c2..17dfe1b679af (1 commits)
2018-10-19 herb@google.com Remove unused methods from SkTDArray
2018-10-19 mtklein@google.com any idea why SkReadBuffer has a vtable?
2018-10-19 bsalomon@google.com Use preallocated space for default vertex and index buffer sizes
2018-10-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9e4d040cb93c..d55d997310c2 (1 commits)
2018-10-19 egdaniel@google.com Add drawDrawable support to GrRenderTargetContext.
2018-10-19 brianosman@google.com Remove texColorSpace output param from various producer APIs


Created with:
  gclient setdep -r src/third_party/skia@773e141a83e3

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=egdaniel@chromium.org

Change-Id: I6693036561c1ade1710d8972b3472821d18bb954
Reviewed-on: https://chromium-review.googlesource.com/c/1292789Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601374}

This change should instruct the code coverage testers to include the
raw profile data in the isolated output.

R=jbudorick

Change-Id: Iac30af93faa67179a2b61ef12ec52d65e18a1e08
Reviewed-on: https://chromium-review.googlesource.com/c/1272080
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601373}

Previously we hid Assistant on widget deactivation. Then we removed
that logic to instead use an event handler that dismissed Assistant on
press.

We actually need both since Assistant widget can be deactivated w/o a
press event, such as happens when opening feedback via Alt+Shift+i.

Bug: b:117990949
Change-Id: I75338ef112f5cef3445bf88903adaef2ccd56c48
Reviewed-on: https://chromium-review.googlesource.com/c/1292604Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#601372}

R=kariah@chromium.org

Change-Id: Ic132d8e5e9d2848862285e95dab69ad24040f424
Reviewed-on: https://chromium-review.googlesource.com/c/1292818Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601371}

Updates the OfflineContentOnDinoPage experiment group name and param
value to comply with the upcoming Finch experiment configuration change.

Bug: 852872
Change-Id: If110b3d215e9e6fd3184eaff6c33c9f3c5ac5ff7
Reviewed-on: https://chromium-review.googlesource.com/c/1292523Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601370}

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286016

This CL was uploaded by git cl split.

R=imcheng@chromium.org

Bug: 753973
Change-Id: I37354ffed6f228bb85ac3d05a19bdf6bf606b6f3
Reviewed-on: https://chromium-review.googlesource.com/c/1288154Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601369}

Previously, the http_service_tests suite was not using the TestLauncher
facilities, which caused it to fail on the waterfall.

Bug: 896884
Change-Id: I9ce03cf45f0bd75944dce62bed5e16e2df6a4191
Tested: Locally
Reviewed-on: https://chromium-review.googlesource.com/c/1292591
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601368}

We already started removing cancelled and non-resumable download from history
DB. And we should do the same for download DB.
This CL moves all the logic of clearing those download into DownloadManagerImpl.
Here is the work flow:
1. when in-progress download manager is loaded, clear all the non-resumable
downloads.
2. When DownloadHistory loads all the history items, a nullptr will be
returned if the history item should be cleaned, and history DB will remove
the item.
3. After DownloadHistory finished loading, in-progress download manager will
remove all the non-resumable downloads, so that we are guaranteed that changes
in Download DB are propagated to DownloadHistory

This CL also fixes issues that cancelled download in Download DB are not
propagated to history DB.

BUG=851650

Change-Id: Ieeec319cd429ecca7a327e463e2a869dd00a7f4e
Reviewed-on: https://chromium-review.googlesource.com/c/1285318Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601367}

https://webrtc.googlesource.com/src.git/+log/cb21ffe8996b..51cc30c12411


git log cb21ffe8996b..51cc30c12411 --date=short --no-merges --format='%ad %ae %s'
2018-10-19 qingsi@google.com Fix a null reference bug in NetworkMonitorAutoDetect.getNetworkState.


Created with:
  gclient setdep -r src/third_party/webrtc@51cc30c12411

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I19446610dbcd4927d5e92c3e2054c4b6069c5452
Reviewed-on: https://chromium-review.googlesource.com/c/1292284Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601366}

This CL checks if the user has SD card. Don't show download location
dialog if user don't have SD card.

Bug: 896873
Change-Id: I157b8958669c0692247f7cf3798f32867675b11c
Reviewed-on: https://chromium-review.googlesource.com/c/1290509Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601365}

This fixes Clang's newly enhanced -Wshadow warning which now covers enums (see
bug), and also makes the code nicer.

TBR=jochen

Bug: 895475
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ia8c8fff99b93efcd2c8278cd0b2ac739c4e0c917
Reviewed-on: https://chromium-review.googlesource.com/c/1289471
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601364}

PageAutoFetcher isn't yet used, but it is fully functional. It schedules
requests and cancels scheduled requests, and uses a new client policy.

Note PageAutoFetcher isn't yet called anywhere.

Bug: 883486
Change-Id: If1f9ed401e30466d6c55f7598477150feb983f27
Reviewed-on: https://chromium-review.googlesource.com/c/1234358Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Dan H <harringtond@google.com>
Cr-Commit-Position: refs/heads/master@{#601363}

This was revealed by
https://chromium-review.googlesource.com/c/chromium/src/+/1145692
which makes subtle changes to Mojo message dispatch timing and can
thus expose incorrect assumptions in various bits of code.

In this case, there is a race between AbandonAudioFocus and
receiving a reply from a previous call to RequestAudioFocus on
the audio_focus_ptr_. The callback which handles the latter reply
DCHECKs that request_client_ptr_ is bound, but it's possible for
AbandonAudioFocus to have been called before that reply is
dispatched.

The above Mojo CL in question causes some unit tests to flake by
hitting this DCHECK occasionally.

This CL corrects the issue by also resetting audio_focus_ptr_ in
AbandonAudioFocus, which ensures that any pending replies on that
interface will *not* be dispatched.

This also fixes a bug in AudioFocusManagerMetricsHelper (also
revealed by this CL) where it was retaining a *reference* to an
unowned std::string that could be deleted before the helper. This
is because the string was ultimately owned by a binding endpooint,
but the helper is owned by a StackRow which can outlive any given
binding endpoint. Because the name is effectively only useful at
helper construction time, this simply changes the helper to retain
a copy instead of a reference.

TBR=mlamouri@chromium.org

Bug: 895693
Change-Id: I958b783d005cb85dc9dc9f7371df100883d774cb
Reviewed-on: https://chromium-review.googlesource.com/c/1286202
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601362}

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=mef@chromium.org

Bug: 681136
Change-Id: I55220b203c6798614bd7978710aa6fe3669c70dc
Reviewed-on: https://chromium-review.googlesource.com/c/1288348Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601361}

For Assistant, we use a horizontal BoxLayout which relies on
GetHeightForWidth to determine chip size. By removing this method
override we will no longer respect kPreferredHeightDip.

Screenshot in the bug.

Bug: b:117991892
Change-Id: Ic6b889a477b262290285ad5e61c3922ee43ceb6f
Reviewed-on: https://chromium-review.googlesource.com/c/1292608
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601360}

This was initially added to ensure that the typefaces embedded in a blob
were stored in a sidelist on the blob, in order to enable serialization
of typefaces for OOP raster. This is no longer required and the wrapping
is just unnecessary overhead.

R=drott@chromium.org,enne@chromium.org

Bug: 816445,894200
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I76f106d13ce1aa04a50aadb0d4faa98dafe7a688
Reviewed-on: https://chromium-review.googlesource.com/c/1289571
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601359}

Bug: b/117937718
Test: locally build and see logs on device.
Change-Id: Iea6b72b328c57d3c37e58692e2146f0b71c3218c
Reviewed-on: https://chromium-review.googlesource.com/c/1292549Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601358}

Fix CrossProcessMouseEnterAndLeaveTest by waiting for initial
mouse event to be dispatched because the event is asynchronously
dispatched in mash.

Bug: 884360
Change-Id: I4f40accfb9077e6bb8ccab5128b42c66493e84ed
Reviewed-on: https://chromium-review.googlesource.com/c/1292398Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601357}

When using EXT_multisampled_render_to_texture, glReadPixels fails in
recent Qualcomm Adreno drivers. glCopyTexImage2D still works, so the
workaround is to create a temporary texture, glCopyTexImage2D, and then
glReadPixels from the temporary texture.

WebGL conformance test updates for this bug are here:
https://github.com/KhronosGroup/WebGL/pull/2729

This workaround will be revisited in the passthrough command decoder
and ANGLE when the switch is made to use those for WebGL on Android.

dEQP test is here:
https://android-review.googlesource.com/c/platform/external/deqp/+/796566

Bug: 890002
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I6254242258411997fcfbb3f0145801b398073778
Reviewed-on: https://chromium-review.googlesource.com/c/1279354
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601356}

This CL disables window functions, which were introduced in SQLite 3.25
[1], and PostgreSQL-style UPSERT, which was introduced in SQLite 3.24
[2]. This reduces the binary size by 57,376 bytes on a Linux official
build.

The sqlite3.c diff was entirely generated by re-running the updated
generated_amalgamation.sh script.

[1] https://www.sqlite.org/windowfunctions.html#history
[2] https://www.sqlite.org/lang_UPSERT.html

Bug: 896685, 892852
Change-Id: Ia501d35993c382445e6a70348dd1643037969245
Reviewed-on: https://chromium-review.googlesource.com/c/1290510Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601355}

https://android.googlesource.com/platform/external/perfetto.git/+log/3bcd7ab930ad..6c448e3f5b2f


git log 3bcd7ab930ad..6c448e3f5b2f --date=short --no-merges --format='%ad %ae %s'
2018-10-19 oysteine@google.com Merge "Add an Message::AppendScatteredBytes function"


Created with:
  gclient setdep -r src/third_party/perfetto@6c448e3f5b2f

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: If04c93bf1547f31c541024cf01e334b9c98a78f2
Reviewed-on: https://chromium-review.googlesource.com/c/1292283Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601354}

Bug: 895871
Change-Id: Idb6d382891affa99a4976e3e8b83efd1b437e5b6
Reviewed-on: https://chromium-review.googlesource.com/c/1292396Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601353}