- 13 Jan, 2021 40 commits
-
-
Richard Chui authored
Extend the expiry date of the Tabs.ScrubDuration histogram to a year later. Fixed: 1165198 Change-Id: I3073b92cf3b778c57c5a2ad8901a2537405e9a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625155Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Richard Chui <richui@chromium.org> Cr-Commit-Position: refs/heads/master@{#843217}
-
David Black authored
It is possible to open a context menu via two finger gesture tap. We previously didn't handle this gesture so selection state was empty. Bug: 1166274 Change-Id: I259082d7c41391a23ccabd99573343e77c68bc78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627440Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#843216}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610549866-1e248feef781fb0cfb48b77513413e45541eeb72.profdata to chrome-win64-master-1610560659-e96e8917fec116ef2a139db8416bd66f9188db27.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I51ad308ffbeb0501d1e4cd80dd8fb0b08d4e6d00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627906Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843215}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fdd89469d681..4e0ef215f6da 2021-01-13 ddoman@chromium.org [resultdb] move the cipd pin of infra/tools/rdb in depot_tools If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1141153,chromium:1155298 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ieebe70ae1c149993a906f6d4dc35ff80d252076e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626106Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843214}
-
David Black authored
Previously in RTL the ink drop was drawn outside of view bounds. Bug: 1166271 Change-Id: I454871125239d40b65ee2b2606ae0953562e51c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627438Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#843213}
-
Josiah K authored
Don't include focus following result "Magnifier follows keyboard focus" in Chrome OS Settings search results when screen magnifier is disabled. Before: https://screenshot.googleplex.com/7k4npcGDnBznceP After: https://screenshot.googleplex.com/5Gmmstz22u7Dcfi AX-Relnotes: N/A. Fixed: 1165652 Change-Id: Ibb7dd1c7b7e301c0322d09615765484205958d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623429 Commit-Queue: Josiah Krutz <josiahk@google.com> Auto-Submit: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#843212}
-
minch authored
See demo at the crbug. Bug: 1158583 Change-Id: I7ee3ff75c2126543a2fe215817281c11540d080a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604683Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#843211}
-
Morten Stenshorne authored
The block-size of the column fragment in the initial column balancing pass isn't used for anything (at least currently), but setting it to kIndefiniteSize is pretty bogus. Don't do that. https://chromium-review.googlesource.com/c/chromium/src/+/2611570 is about to introduce DCHECKs for such situations. Change-Id: Ib6c7342ecc2f29a9d4d29c64bbaee8e2bde1243f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626431Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#843210}
-
Joel Riley authored
For consistency with autoclick panel, feedback from UX review. Bug: 1140216 Change-Id: I324ce723bc9e5c69be8f3fe39a7aba4ce2ed27db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626924Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Joel Riley <joelriley@google.com> Cr-Commit-Position: refs/heads/master@{#843209}
-
Nicholas Hollingum authored
Previously we manually calculated the rootfs/kernel path using the mount point of the DLC. This is actually done by concierge now, and we should use it instead of re-doing the work ourselves. Bug: b/177367054 Change-Id: Ic3137f9c0b5b3c186e84795ff64329e8b5e2a819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626607Reviewed-by:
Daniel Ng <danielng@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#843208}
-
Reilly Grant authored
This change enables the throbber and status message that are used for the Web Bluetooth device chooser prompt on all of the other APIs which use this UI. This improves the user experience for users on slower devices where it can take some time for the set of available options to be available. Bug: 1160147 Change-Id: I59a03c1a94f58fdb38bf7c8d2d713680cb21c5aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597903Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#843207}
-
Erik Chen authored
This CL adds stubs to finish flushing out the platform keys extension APIs. This CL has no intended behavior change on ash -- it just renames some files. Bug: 1164523 Change-Id: I2d201f7f648f86c26c97c5612280b52706b80a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625750Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#843206}
-
Edman Anjos authored
Inform arc-keymasterd of Chaps keys that will be installed in ARC. Needed so arc-keymasterd can associate placeholders to the original Chaps keys appropriately. out_/Default/unit_tests --gtest_filter="ArcCertInstaller*" && \ out_/Default/browser_tests --gtest_filter="CertStoreServiceTest*" Bug: b:172907736 Test: autoninja -C out_/Default unit_tests browser_tests && \ Change-Id: I85b2d234c5f12706093428228bcf690de45ddd9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613965 Commit-Queue: Edman Anjos <edman@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#843205}
-
Jiawei Li authored
Those interfaces are used for organizing Cast native windows to work with an external window manager via the interface CastWindowEmbedder primarily through pre-defined events and requests. The unittest is not exhaustive and more test cases will be added in follow-up CLs. Bug: Internal b/173251340 Test: cast_content_window_embedded_unittest Change-Id: I9385cfb0bd2af64cc364f74f5c1b86b88d4432ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539668Reviewed-by:
Shawn Gallea <sagallea@google.com> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Jiawei Li <lijiawei@chromium.org> Cr-Commit-Position: refs/heads/master@{#843204}
-
Austin Sullivan authored
This fixes a leak in a obfuscated_file_util_unittest, allowing us to enable LSAN on this test. Bug: 961068 Change-Id: I798bc4e0e2c5b344d29d3588102eb9a598801381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627359 Auto-Submit: Austin Sullivan <asully@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#843203}
-
Jun Kokatsu authored
While there are many online resources about general CSP, it's hard to find similar resources for Trusted Types, especially on how to convert existing JS code. This change adds explanation of Trusted Types as well as tips for how to convert existing JS code to be compatible with Trusted Types mitigation on WebUI. Bug: 41905 Change-Id: Ia8382c8a7542bcd45be9a1b8434e23388a93b483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616966 Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#843202}
-
Austin Sullivan authored
In ObfuscatedFileUtil::InitOriginDatabase method Bug: N/A Change-Id: I630c0e40a56db336c12f80c7869fd48a6fe6f451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627136 Auto-Submit: Austin Sullivan <asully@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#843201}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8fccd82e4e02..704a1aa4c802 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I60e6cdbf43c4a3889a860a68e3ce6d3465ee1334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627968Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843200}
-
Clark DuVall authored
WebView compatibility is on by default, so this is no longer needed. Bug: 1051358 Change-Id: I88740862ad035d91271974417512bcd4da42c3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628231 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#843199}
-
Javier Ernesto Flores Robles authored
Expose APIs to replace the input view and input accessory view in web view. Bug: 1163967 Change-Id: I98c5dce1cc1f06bbebaf97c881a8520280567b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611903 Commit-Queue: Javier Flores <javierrobles@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#843198}
-
sczs authored
- If the Discover Feed is OFF then the non refactored version (which uses ContentSuggestionsVC as the main NTP VC) will be used, for this container VC is created on NTPCoordinator which is returned to BVC. The contained VC will change (between NTPVC and ContentSuggestionsVC) depending on the Feed being ON or OFF. - Adds an extra check on most IsRefactoredNTP calls, so the refactored NTP is only used when the Discover Feed is on. - Moves the NTPHomeMediator creation to NTPCoordinator. Bug: 1114792 Change-Id: I64b82462825da7bd66f1004e89f55c64313f1dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625508 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#843197}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 88.0.4324.89. R=rmhasan@google.com Bug: 1041619 Change-Id: I4960c11db72692f4bd1518311e8c3efac84f6dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626779 Commit-Queue: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#843196}
-
Clark DuVall authored
Bug: 1146438 Change-Id: I295bd5e8899b517540c310b4265781f787bac1aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628035Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#843195}
-
Scott Violet authored
LayoutBlock is the only places that enables non-visible-overflow. This means all the logic in ComputeOverflowClipAxes() after non-visible-overflow can be moved to LayoutBlock. BUG=none TEST=none Change-Id: If9c8783285cf0d2ad50dcc3167af3fded0026500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625977Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#843194}
-
Sinan Sahin authored
Bug: 989148 Change-Id: I043a617e6f2c9eb2f530a67e3fb3be731c34bae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627439Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#843193}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/215834139a79..47e9aed2af83 2021-01-13 jmadill@chromium.org Remove Sleep() from PrimitivesWrittenAndGenerated test. 2021-01-13 jmadill@chromium.org infra: Fixes for config. 2021-01-13 jwata@google.com Use CAS in scripts/trigger.py 2021-01-13 jmadill@chromium.org Add configuration for trace test bots. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1163817 Tbr: timvp@google.com Change-Id: I7f6682381a1110ea73c5e4e219695c247fe4c74a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627869Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843192}
-
Marc-André (MAD) Decoste authored
Bug: 1163668 Change-Id: If5d37113d20e44b719f0e0162ed079e25853b833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612932Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Marc-André Decoste <mad@chromium.org> Auto-Submit: Marc-André Decoste <mad@chromium.org> Cr-Commit-Position: refs/heads/master@{#843191}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d8d98e1b9627..4e3d4af7bd5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mpearson@google.com,fdoray@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1158794 Tbr: mpearson@google.com,fdoray@google.com Change-Id: I3d87ccda76d585b2cfa0e7b6c944c8d91fc3ea40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627975Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843190}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5f223d7f..a1598e58 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9295a90058f33095468103267cdeab57dbfa5a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627143Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843189}
-
François Doray authored
This reverts commit 21296da9. Reason for revert: crbug.com/1166333 Original change's description: > Record LSS search status metric in trusted frame per search. > > Bug: b/170162419 > Change-Id: I862f02fa7949d3c1e06b83c2389ddc63273f2188 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617406 > Commit-Queue: Callistus Tan <callistus@google.com> > Reviewed-by: dstockwell <dstockwell@google.com> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842864} TBR=xiyuan@chromium.org,dstockwell@google.com,bcwhite@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,callistus@google.com Change-Id: I402f5b44b91661032ef2d2c4eb163ed8d1eca84e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/170162419, 1166333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626000Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#843188}
-
Chris Lu authored
GetFieldTrial() is the correct API to call for finch config experiments. Bug: 1165875 Change-Id: Ic3a0657c1ee2c6e1bb815c91607ec12b0ed41afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626104Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#843187}
-
Garrett Beaty authored
This reverts commit 82cf2844. Reason for revert: Possible culrpit for increase in browser_tests runtime on linux-lacros-rel Original change's description: > Add testing config for per-profile Connectors > > A small change in ConnectorsService is required to make this test config > work. When checking analysis/reporting settings, 2 things are required > to obtain settings: a policy set to a valid value and a DM token (from > the browser or the profile). The previous implementation checked the DM > token first, meaning the blocking BrowserDMTokenStorage::RetrieveDMToken > call would trigger on multiple tests and crash them (see patchset 1 > failures for examples of this). > > The solution is to simply switch the > order of checks and read the policy first. This is also a valid > optimization of Connectors logic, as reading prefs is faster than > potentially reading the DM token from local storage. > > Change-Id: Ie1026b57cf7a4fd66663530ec2a77a72f21d6d81 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623812 > Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> > Reviewed-by: Marc-André Decoste <mad@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843115} TBR=mad@chromium.org,rkaplow@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,domfc@chromium.org Change-Id: I0e4c041b0dcc4372117ae5221335e101a3a8003d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628041Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#843186}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610538373-541aee2d8154a147aea334eed2074efc5a2f470f.profdata to chrome-linux-master-1610560809-8437f20a31feb534d6a6f0fc9839520be075bc3e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib85599f2de973a68633046ad1c69ab88e3799ced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625933Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843185}
-
François Doray authored
This reverts commit eacc052e. Reason for revert: crbug.com/1166280 Original change's description: > Add browser test for canceled image request > > When image request is cancelled the robots rules request should be > invalidated correctly. This CL adds a test. > > This CL also creates component for subresource_redirect and moves some > utility functions there. Subsequent CLs could move more independent code > out of chrome/renderer/subresource_redirect to the component. > > Bug: 1160424 > Change-Id: I29b20fe4f7057a1e8778995ea5e1114e36843da8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619421 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Commit-Queue: rajendrant <rajendrant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842806} TBR=sky@chromium.org,rajendrant@chromium.org,mcrouse@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I441aa96f8ce123398fa9ddaa5f364e36c9e4533c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1160424, 1166280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626518Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#843184}
-
Justin Cohen authored
Fixes chrome/builders/ci/cronet-ios-simulator-debug redness. Bug: 1165809 Change-Id: I57f6ed9471d27b53340986bd3bbb1fc32414c1d6 Fixed: 32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625889Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#843183}
-
François Doray authored
This reverts commit fd90951e. Reason for revert: crbug.com/1166280 Original change's description: > Move subresource_redirect proto to components > > Moves the robots_rules.proto from chrome/renderer to components/ > > Bug: 1160424 > Change-Id: I0b2af266e3a6de40872bf094195b7f0c21c42096 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623647 > Commit-Queue: rajendrant <rajendrant@chromium.org> > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842827} TBR=rajendrant@chromium.org,mcrouse@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I9da5764c078264a93aa1e50118c0296055e4a7c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1160424, 1166280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627872Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#843182}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610538373-c4c83fd08459537f19e890c14c2288baf23d3675.profdata to chrome-mac-master-1610560809-c13d1dc2d5ece813e7ca3ddf321bf7cfccbb8ffc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie31be2d2aac45ffe7792df6b81f92ba25cdbb954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627811Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843181}
-
Sophie Chang authored
disabled on desktop platforms Change-Id: I173ac1025760f908042e64c7c8839fb90e41fc78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626918Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#843180}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/be2a8614c5d6..d8e9436a78bf 2021-01-13 jsimmons@google.com Cache ICU break iterators in SkUnicode_icu 2021-01-13 ethannicholas@google.com Fixed error reporting on invalid SkSL assignments 2021-01-13 johnstiles@google.com Reland "Scrub memory released from a GrMemoryPool in debug mode." 2021-01-13 tdenniston@google.com [svg] Add plumbing for color-interpolation-filters property 2021-01-13 mtklein@google.com support 7 args in skvm::Program::eval() 2021-01-13 fmalita@chromium.org [svg] Initial mask plumbing 2021-01-13 ethannicholas@google.com SkSL DSL operator overloading 2021-01-13 johnstiles@google.com Add guard-rails to Constructor constant-value fetchers. 2021-01-13 johnstiles@google.com Simplify IRGenerator::coerce. 2021-01-13 bsalomon@google.com Revert "Reland "asyncRescaleAndRead supports unpremul results on GPU"" 2021-01-13 fmalita@chromium.org [svg] TextPath support 2021-01-13 reed@google.com Allow chrome to be nearest until it can rebaseline 2021-01-13 johnstiles@google.com Split apart SkRuntimeInvalid tests into multiple functions. 2021-01-13 bsalomon@google.com Reland "asyncRescaleAndRead supports unpremul results on GPU" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: ethannicholas@google.com Change-Id: If6cc2acc8038437a70013a1d70d70bb73a9efeb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628007Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843179}
-
Klaus Weidner authored
Change-Id: I89b964d1223683cf42a37eacbd40073e47e54631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627893 Auto-Submit: Klaus Weidner <klausw@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#843178}
-